RE: [PATCH v1 3/3] Bluetooth: btintel_pcie: Fix REVERSE_INULL issue reported by coverity

K, Kiran
2024-05-16T13:03:46Z

Please ignore v1 series. I have published v2 version with Fixes tag included.

Thanks,
Kiran

>-----Original Message-----
>From: K, Kiran <kiran.k@intel.com>
>Sent: Thursday, May 16, 2024 6:10 PM
>To: linux-bluetooth@vger.kernel.org
>Cc: Srivatsa, Ravishankar <ravishankar.srivatsa@intel.com>; Tumkur Narayan,
>Chethan <chethan.tumkur.narayan@intel.com>; Satija, Vijay
><vijay.satija@intel.com>; K, Kiran <kiran.k@intel.com>
>Subject: [PATCH v1 3/3] Bluetooth: btintel_pcie: Fix REVERSE_INULL issue
>reported by coverity
>
>From: Vijay Satija <vijay.satija@intel.com>
>
>check pdata return of skb_pull_data, instead of data.
>
>Signed-off-by: Vijay Satija <vijay.satija@intel.com>
>Signed-off-by: Kiran K <kiran.k@intel.com>
>---
> drivers/bluetooth/btintel_pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
>index d8f82e0f6435..58144c82b1cb 100644
>--- a/drivers/bluetooth/btintel_pcie.c
>+++ b/drivers/bluetooth/btintel_pcie.c
>@@ -382,7 +382,7 @@ static int btintel_pcie_recv_frame(struct
>btintel_pcie_data *data,
>
> /* The first 4 bytes indicates the Intel PCIe specific packet type */
> pdata = skb_pull_data(skb, BTINTEL_PCIE_HCI_TYPE_LEN);
>- if (!data) {
>+ if (!pdata) {
> bt_dev_err(hdev, "Corrupted packet received");
> ret = -EILSEQ;
> goto exit_error;
>--
>2.40.1