[PATCH BlueZ] profile: add NULL check to ext_remove_records()

[PATCH BlueZ] profile: add NULL check to ext_remove_records()

[Roman Smirnov]

Add a NULL check to prevent dereferencing a null pointer in
case the adapter is NULL
---
 src/profile.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/profile.c b/src/profile.c
index c62224af9..bb988e8cb 100644
--- a/src/profile.c
+++ b/src/profile.c
@@ -1507,7 +1507,8 @@ static void ext_remove_records(struct ext_profile *ext,
 
 		ext->records = g_slist_remove(ext->records, r);
 
-		adapter_service_remove(adapter, r->handle);
+		if (adapter)
+			adapter_service_remove(adapter, r->handle);
 		btd_adapter_unref(r->adapter);
 		g_free(r);
 	}
-- 
2.43.0

RE: [BlueZ] profile: add NULL check to ext_remove_records()

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=866066

---Test result---

Test Summary:
CheckPatch                    PASS      0.97 seconds
GitLint                       PASS      0.19 seconds
BuildEll                      PASS      25.09 seconds
BluezMake                     PASS      1786.27 seconds
MakeCheck                     PASS      13.52 seconds
MakeDistcheck                 PASS      184.71 seconds
CheckValgrind                 PASS      259.64 seconds
CheckSmatch                   PASS      362.96 seconds
bluezmakeextell               PASS      122.90 seconds
IncrementalBuild              PASS      1668.12 seconds
ScanBuild                     PASS      1065.72 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ] profile: add NULL check to ext_remove_records()

[Luiz Augusto von Dentz]

Hi Roman,

On Thu, Jun 27, 2024 at 5:17 AM Roman Smirnov <r.smirnov@omp.ru> wrote:
>
> Add a NULL check to prevent dereferencing a null pointer in
> case the adapter is NULL
> ---
>  src/profile.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/profile.c b/src/profile.c
> index c62224af9..bb988e8cb 100644
> --- a/src/profile.c
> +++ b/src/profile.c
> @@ -1507,7 +1507,8 @@ static void ext_remove_records(struct ext_profile *ext,
>
>                 ext->records = g_slist_remove(ext->records, r);
>
> -               adapter_service_remove(adapter, r->handle);
> +               if (adapter)
> +                       adapter_service_remove(adapter, r->handle);

I'd move this check inside adapter_service_remove to make it safe to
pass NULL pointers as adapter.

>                 btd_adapter_unref(r->adapter);
>                 g_free(r);
>         }
> --
> 2.43.0
>
>


-- 
Luiz Augusto von Dentz