[PATCH BlueZ] plugins/sixaxis: add NULL check in setup_device()

[PATCH BlueZ] plugins/sixaxis: add NULL check in setup_device()

[Roman Smirnov]

btd_adapter_get_device() may return NULL on the next call stack:

btd_adapter_get_device()
    adapter_create_device()
        device_create()
	    device_new()
                g_try_malloc0()

It is necessary to prevent this to avoid dereferencing a null
pointer further.
---
 plugins/sixaxis.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/plugins/sixaxis.c b/plugins/sixaxis.c
index 544ab399a..3e69f1dd2 100644
--- a/plugins/sixaxis.c
+++ b/plugins/sixaxis.c
@@ -346,6 +346,11 @@ static bool setup_device(int fd, const char *sysfs_path,
 
 	device = btd_adapter_get_device(adapter, &device_bdaddr, BDADDR_BREDR);
 
+	if (!device) {
+		error("sixaxis: unable to set up a new device");
+		return false;
+	}
+
 	info("sixaxis: setting up new device");
 
 	btd_device_device_set_name(device, cp->name);
-- 
2.43.0

RE: [BlueZ] plugins/sixaxis: add NULL check in setup_device()

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1519 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=866086

---Test result---

Test Summary:
CheckPatch                    PASS      0.38 seconds
GitLint                       FAIL      0.48 seconds
BuildEll                      PASS      24.64 seconds
BluezMake                     PASS      1721.32 seconds
MakeCheck                     PASS      13.36 seconds
MakeDistcheck                 PASS      177.71 seconds
CheckValgrind                 PASS      254.35 seconds
CheckSmatch                   PASS      356.74 seconds
bluezmakeextell               PASS      124.26 seconds
IncrementalBuild              PASS      1565.98 seconds
ScanBuild                     PASS      988.32 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ] plugins/sixaxis: add NULL check in setup_device()

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
8: B3 Line contains hard tab characters (\t): "	    device_new()"


---
Regards,
Linux Bluetooth