[PATCH BlueZ v1] core: add NULL check to adapter_service_remove()

[PATCH BlueZ v1] core: add NULL check to adapter_service_remove()

[Roman Smirnov]

Make adapter_service_remove() safe for passing NULL pointers.
---
 src/adapter.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/adapter.c b/src/adapter.c
index bdc5bf920..57e4dcd54 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -1349,6 +1349,10 @@ int adapter_service_add(struct btd_adapter *adapter, sdp_record_t *rec)
 void adapter_service_remove(struct btd_adapter *adapter, uint32_t handle)
 {
 	sdp_record_t *rec;
+
+	if (!adapter)
+		return;
+
 	/*
 	 * If the controller does not support BR/EDR operation,
 	 * there is no point in trying to remote SDP records.
-- 
2.43.0

RE: [BlueZ,v1] core: add NULL check to adapter_service_remove()

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=866524

---Test result---

Test Summary:
CheckPatch                    PASS      0.38 seconds
GitLint                       PASS      0.28 seconds
BuildEll                      PASS      25.08 seconds
BluezMake                     PASS      1699.29 seconds
MakeCheck                     PASS      13.10 seconds
MakeDistcheck                 PASS      178.40 seconds
CheckValgrind                 PASS      252.27 seconds
CheckSmatch                   PASS      355.14 seconds
bluezmakeextell               PASS      119.98 seconds
IncrementalBuild              PASS      1455.52 seconds
ScanBuild                     PASS      1015.46 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] core: add NULL check to adapter_service_remove()

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri, 28 Jun 2024 13:30:49 +0300 you wrote:
> Make adapter_service_remove() safe for passing NULL pointers.
> ---
>  src/adapter.c | 4 ++++
>  1 file changed, 4 insertions(+)

Here is the summary with links:
  - [BlueZ,v1] core: add NULL check to adapter_service_remove()
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=ee12a631caef

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

[PATCH BlueZ v1] core: add NULL check to adapter_service_remove()

[Roman Smirnov]

Make adapter_service_remove() safe for passing NULL pointers.
---
 src/adapter.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/adapter.c b/src/adapter.c
index bdc5bf920..57e4dcd54 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -1349,6 +1349,10 @@ int adapter_service_add(struct btd_adapter *adapter, sdp_record_t *rec)
 void adapter_service_remove(struct btd_adapter *adapter, uint32_t handle)
 {
 	sdp_record_t *rec;
+	
+	if (!adapter)
+		return;
+
 	/*
 	 * If the controller does not support BR/EDR operation,
 	 * there is no point in trying to remote SDP records.
-- 
2.43.0

RE: [BlueZ,v1] core: add NULL check to adapter_service_remove()

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1898 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=866445

---Test result---

Test Summary:
CheckPatch                    FAIL      0.79 seconds
GitLint                       PASS      0.98 seconds
BuildEll                      PASS      24.46 seconds
BluezMake                     PASS      1680.13 seconds
MakeCheck                     PASS      13.23 seconds
MakeDistcheck                 PASS      176.92 seconds
CheckValgrind                 PASS      253.74 seconds
CheckSmatch                   PASS      352.70 seconds
bluezmakeextell               PASS      119.37 seconds
IncrementalBuild              PASS      1459.73 seconds
ScanBuild                     PASS      997.31 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,v1] core: add NULL check to adapter_service_remove()
ERROR:TRAILING_WHITESPACE: trailing whitespace
#94: FILE: src/adapter.c:1352:
+^I$

/github/workspace/src/src/13715666.patch total: 1 errors, 0 warnings, 10 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

/github/workspace/src/src/13715666.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth