[PATCH BlueZ] tools/btmgmt: Fix --index option for non-interactive mode

[PATCH BlueZ] tools/btmgmt: Fix --index option for non-interactive mode

[Arjan Opmeer]

In non-interactive mode the --index option does not work because the
call to mgmt_set_index() is made after bt_shell_attach().
See also https://github.com/bluez/bluez/issues/893

---
 tools/btmgmt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/btmgmt.c b/tools/btmgmt.c
index 9b7f851bd..436c2bb21 100644
--- a/tools/btmgmt.c
+++ b/tools/btmgmt.c
@@ -51,8 +51,8 @@ int main(int argc, char *argv[])
 		return EXIT_FAILURE;
 	}
 
-	bt_shell_attach(fileno(stdin));
 	mgmt_set_index(index_option);
+	bt_shell_attach(fileno(stdin));
 	status = bt_shell_run();
 
 	mgmt_remove_submenu();
-- 
2.45.2

RE: [BlueZ] tools/btmgmt: Fix --index option for non-interactive mode

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=869637

---Test result---

Test Summary:
CheckPatch                    PASS      0.38 seconds
GitLint                       PASS      0.27 seconds
BuildEll                      PASS      24.65 seconds
BluezMake                     PASS      1645.25 seconds
MakeCheck                     PASS      13.60 seconds
MakeDistcheck                 PASS      178.83 seconds
CheckValgrind                 PASS      253.40 seconds
CheckSmatch                   PASS      356.17 seconds
bluezmakeextell               PASS      120.42 seconds
IncrementalBuild              PASS      1467.28 seconds
ScanBuild                     PASS      1001.55 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ] tools/btmgmt: Fix --index option for non-interactive mode

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue,  9 Jul 2024 13:55:41 +0200 you wrote:
> In non-interactive mode the --index option does not work because the
> call to mgmt_set_index() is made after bt_shell_attach().
> See also https://github.com/bluez/bluez/issues/893
> 
> ---
>  tools/btmgmt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ] tools/btmgmt: Fix --index option for non-interactive mode
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f00d5546c9e9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html