[PATCH BlueZ] gatt-client: allow AcquireNotify when characteristic has indicate flag

[PATCH BlueZ] gatt-client: allow AcquireNotify when characteristic has indicate flag

[Benedek Kupper]

[-- Attachment #1.1: Type: text/plain, Size: 1283 bytes --]



________________________________


Benedek Kupper
Embedded Software Developer

[cid:epitome-card-02_b006a446-bce6-44e1-9d92-f7393d79c71c.png]<https://epitome.inc>
[cid:linkedin_1f596618-4864-44d6-9b3e-e082e106b6c5.png]<https://www.linkedin.com/company/epitome-gmbh/mycompany>        [cid:facebook_b8860cf9-5522-4aa8-b473-0744d2dfb230.png] <https://www.facebook.com/profile.php?id=61556804053377>
        [cid:instagram_6d192f80-e153-45d1-91d4-fbdc5b86c5ec.png] <https://www.instagram.com/epitome.inc>
        [cid:web_c7097f79-83ac-4349-81ee-a4e57ed66b37.png] <https://epitome.inc>



________________________________


epitome GmbH | The ICON Vienna, Tower 17, 10th floor | Gertrude-Froehlich-Sandner-Strasse 2-4 | 1100 Vienna
benedek.kupper@epitome.inc | www.epitome.inc | office-AT: +43 676 8967 6100
UID-ATU73252623 | FN: FN489535f, Handelsgericht Wien



The content of this e-mail is for information purposes and is intended exclusively for the designated addressee. If you are not the intended recipient of this e-mail or its representative, please note that any form of disclosure, publication, reproduction or transmission of the contents of this e-mail is prohibited. In this case, please contact the sender of the e-mail. Thank you very much.


[-- Attachment #1.2.1: Type: text/html, Size: 4143 bytes --]

[-- Attachment #1.2.2: epitome-card-02_b006a446-bce6-44e1-9d92-f7393d79c71c.png --]
[-- Type: image/png, Size: 2713 bytes --]

[-- Attachment #1.2.3: linkedin_1f596618-4864-44d6-9b3e-e082e106b6c5.png --]
[-- Type: image/png, Size: 421 bytes --]

[-- Attachment #1.2.4: facebook_b8860cf9-5522-4aa8-b473-0744d2dfb230.png --]
[-- Type: image/png, Size: 407 bytes --]

[-- Attachment #1.2.5: instagram_6d192f80-e153-45d1-91d4-fbdc5b86c5ec.png --]
[-- Type: image/png, Size: 580 bytes --]

[-- Attachment #1.2.6: web_c7097f79-83ac-4349-81ee-a4e57ed66b37.png --]
[-- Type: image/png, Size: 644 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gatt-client-allow-AcquireNotify-when-characteristic-.patch --]
[-- Type: text/x-patch; name="0001-gatt-client-allow-AcquireNotify-when-characteristic-.patch", Size: 1504 bytes --]

From 412a8a7b3f5b3cc3ef160f49648648a184210c18 Mon Sep 17 00:00:00 2001
From: Benedek Kupper <benedek.kupper@epitome.inc>
Date: Thu, 22 Aug 2024 11:36:51 +0200
Subject: [PATCH] gatt-client: allow AcquireNotify when characteristic has
 indicate flag

StartNotify / StopNotify already correctly allows usage when the
characteristic indicate is present (simplify this check though),
apply the same to AcquireNotify.
---
 src/gatt-client.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/gatt-client.c b/src/gatt-client.c
index 8d83a9577..a67e04eee 100644
--- a/src/gatt-client.c
+++ b/src/gatt-client.c
@@ -1556,7 +1556,8 @@ static DBusMessage *characteristic_acquire_notify(DBusConnection *conn,
 	if (!queue_isempty(chrc->notify_clients))
 		return btd_error_in_progress(msg);
 
-	if (!(chrc->props & BT_GATT_CHRC_PROP_NOTIFY))
+	if (!(chrc->props & (BT_GATT_CHRC_PROP_NOTIFY |
+			BT_GATT_CHRC_PROP_INDICATE)))
 		return btd_error_not_supported(msg);
 
 	client = notify_client_create(chrc, sender);
@@ -1601,8 +1602,8 @@ static DBusMessage *characteristic_start_notify(DBusConnection *conn,
 	if (chrc->notify_io)
 		return btd_error_not_permitted(msg, "Notify acquired");
 
-	if (!(chrc->props & BT_GATT_CHRC_PROP_NOTIFY ||
-				chrc->props & BT_GATT_CHRC_PROP_INDICATE))
+	if (!(chrc->props & (BT_GATT_CHRC_PROP_NOTIFY |
+				BT_GATT_CHRC_PROP_INDICATE)))
 		return btd_error_not_supported(msg);
 
 	/* Each client can only have one active notify session. */
-- 
2.34.1

RE: [BlueZ] gatt-client: allow AcquireNotify when characteristic has indicate flag

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

----- Output -----


Please resolve the issue and submit the patches again.


---
Regards,
Linux Bluetooth

[PATCH BlueZ] gatt-client: allow AcquireNotify when characteristic has indicate flag

[Benedek Kupper]

From: Benedek Kupper <benedek.kupper@epitome.inc>

StartNotify / StopNotify already correctly allows usage when the
characteristic indicate is present (simplify this check though),
apply the same to AcquireNotify.
---
 src/gatt-client.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/gatt-client.c b/src/gatt-client.c
index 8d83a9577..a67e04eee 100644
--- a/src/gatt-client.c
+++ b/src/gatt-client.c
@@ -1556,7 +1556,8 @@ static DBusMessage *characteristic_acquire_notify(DBusConnection *conn,
 	if (!queue_isempty(chrc->notify_clients))
 		return btd_error_in_progress(msg);
 
-	if (!(chrc->props & BT_GATT_CHRC_PROP_NOTIFY))
+	if (!(chrc->props & (BT_GATT_CHRC_PROP_NOTIFY |
+			BT_GATT_CHRC_PROP_INDICATE)))
 		return btd_error_not_supported(msg);
 
 	client = notify_client_create(chrc, sender);
@@ -1601,8 +1602,8 @@ static DBusMessage *characteristic_start_notify(DBusConnection *conn,
 	if (chrc->notify_io)
 		return btd_error_not_permitted(msg, "Notify acquired");
 
-	if (!(chrc->props & BT_GATT_CHRC_PROP_NOTIFY ||
-				chrc->props & BT_GATT_CHRC_PROP_INDICATE))
+	if (!(chrc->props & (BT_GATT_CHRC_PROP_NOTIFY |
+				BT_GATT_CHRC_PROP_INDICATE)))
 		return btd_error_not_supported(msg);
 
 	/* Each client can only have one active notify session. */
-- 
2.34.1

RE: [BlueZ] gatt-client: allow AcquireNotify when characteristic has indicate flag

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2303 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=882131

---Test result---

Test Summary:
CheckPatch                    PASS      0.46 seconds
GitLint                       PASS      0.32 seconds
BuildEll                      PASS      24.50 seconds
BluezMake                     PASS      1685.40 seconds
MakeCheck                     FAIL      13.82 seconds
MakeDistcheck                 FAIL      159.20 seconds
CheckValgrind                 FAIL      251.10 seconds
CheckSmatch                   PASS      353.95 seconds
bluezmakeextell               PASS      119.71 seconds
IncrementalBuild              PASS      1440.61 seconds
ScanBuild                     PASS      1031.19 seconds

Details
##############################
Test: MakeCheck - FAIL
Desc: Run Bluez Make Check
Output:

make[3]: *** [Makefile:11766: test-suite.log] Error 1
make[2]: *** [Makefile:11874: check-TESTS] Error 2
make[1]: *** [Makefile:12303: check-am] Error 2
make: *** [Makefile:12305: check] Error 2
##############################
Test: MakeDistcheck - FAIL
Desc: Run Bluez Make Distcheck
Output:

Package cups was not found in the pkg-config search path.
Perhaps you should add the directory containing `cups.pc'
to the PKG_CONFIG_PATH environment variable
No package 'cups' found
make[4]: *** [Makefile:11766: test-suite.log] Error 1
make[3]: *** [Makefile:11874: check-TESTS] Error 2
make[2]: *** [Makefile:12303: check-am] Error 2
make[1]: *** [Makefile:12305: check] Error 2
make: *** [Makefile:12226: distcheck] Error 1
##############################
Test: CheckValgrind - FAIL
Desc: Run Bluez Make Check with Valgrind
Output:

tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12725:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12725 | int main(int argc, char *argv[])
      |     ^~~~
make[3]: *** [Makefile:11766: test-suite.log] Error 1
make[2]: *** [Makefile:11874: check-TESTS] Error 2
make[1]: *** [Makefile:12303: check-am] Error 2
make: *** [Makefile:12305: check] Error 2


---
Regards,
Linux Bluetooth