[PATCH BlueZ v1] test-uhid: Fix attempting to run when bt_uhid is NULL

[PATCH BlueZ v1] test-uhid: Fix attempting to run when bt_uhid is NULL

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

When running under root there is a possibility the bt_uhid_new_default
doesn't work (e.g. fakeroot) in which case the test shall be aborted
since it is likely a device specific test case which would require
proper permissions to run.
---
 unit/test-uhid.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/unit/test-uhid.c b/unit/test-uhid.c
index 2765feb72b06..6871c22eeaa1 100644
--- a/unit/test-uhid.c
+++ b/unit/test-uhid.c
@@ -201,6 +201,11 @@ static struct context *create_context(gconstpointer data)
 	 */
 	if (test_data->test_device && !uid) {
 		context->uhid = bt_uhid_new_default();
+		if (!context->uhid) {
+			tester_test_abort();
+			context_quit(context);
+			return NULL;
+		}
 		return context;
 	}
 
@@ -255,9 +260,13 @@ static const struct uhid_event ev_feature = {
 static void test_client(gconstpointer data)
 {
 	struct context *context = create_context(data);
-	struct test_device *device = context->data->test_device;
+	struct test_device *device;
 	int err;
 
+	if (!context)
+		return;
+
+	device = context->data->test_device;
 	if (device)
 		err = bt_uhid_create(context->uhid, device->name,
 					BDADDR_ANY, BDADDR_ANY,
-- 
2.46.0

RE: [BlueZ,v1] test-uhid: Fix attempting to run when bt_uhid is NULL

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=882708

---Test result---

Test Summary:
CheckPatch                    PASS      0.50 seconds
GitLint                       PASS      0.34 seconds
BuildEll                      PASS      25.18 seconds
BluezMake                     PASS      1727.35 seconds
MakeCheck                     PASS      13.79 seconds
MakeDistcheck                 PASS      182.82 seconds
CheckValgrind                 PASS      256.54 seconds
CheckSmatch                   PASS      357.55 seconds
bluezmakeextell               PASS      120.85 seconds
IncrementalBuild              PASS      1491.88 seconds
ScanBuild                     PASS      1051.32 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] test-uhid: Fix attempting to run when bt_uhid is NULL

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri, 23 Aug 2024 11:20:06 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> When running under root there is a possibility the bt_uhid_new_default
> doesn't work (e.g. fakeroot) in which case the test shall be aborted
> since it is likely a device specific test case which would require
> proper permissions to run.
> 
> [...]

Here is the summary with links:
  - [BlueZ,v1] test-uhid: Fix attempting to run when bt_uhid is NULL
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=4ed7060ca9df

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html