public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* Sharing functions that parse configs in src/main.c to the mesh module
@ 2024-08-27  7:19 Junho Lee
  0 siblings, 0 replies; only message in thread
From: Junho Lee @ 2024-08-27  7:19 UTC (permalink / raw)
  To: linux-bluetooth

Hi,
While reviewing the code to add new Mesh States to mesh/mesh-main.conf,
I noticed the following issues:

The parse_settings() function in mesh/mesh.c, the existing configs
parsing function, has many duplicate lines and is not well separated.
On the other hand, the parse-related functions in src/main.c are well
separated in the same structure. I think this code could be reused to
improve the mesh conf parsing function.
Rather than duplicate implementations of similar code, I would like to
ask for feedback on whether it would be better to isolate the reusable
lines in the src/shared/ directory and make them available in
mesh/mesh.c as well. It would not be necessary to move all the prefix
parse_ functions in src/main.c, just the prefix prase_config_ that
parses the data type. I would like to ask if this would break the bluez
semantics.

Regards,
Junho Lee

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-08-27  7:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-27  7:19 Sharing functions that parse configs in src/main.c to the mesh module Junho Lee

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox