From: bluez.test.bot@gmail.com
To: linux-bluetooth@vger.kernel.org, quic_chejiang@quicinc.com
Subject: RE: [v1] device: Remove device after all bearers are disconnected
Date: Wed, 25 Sep 2024 02:01:36 -0700 (PDT) [thread overview]
Message-ID: <66f3d170.050a0220.318d13.6f06@mx.google.com> (raw)
In-Reply-To: <20240925073204.1499240-1-quic_chejiang@quicinc.com>
[-- Attachment #1: Type: text/plain, Size: 2889 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=892676
---Test result---
Test Summary:
CheckPatch FAIL 0.71 seconds
GitLint PASS 0.32 seconds
BuildEll PASS 24.18 seconds
BluezMake PASS 1590.90 seconds
MakeCheck PASS 12.94 seconds
MakeDistcheck PASS 176.77 seconds
CheckValgrind PASS 249.60 seconds
CheckSmatch PASS 349.54 seconds
bluezmakeextell PASS 117.92 seconds
IncrementalBuild PASS 1470.89 seconds
ScanBuild PASS 1042.01 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[v1] device: Remove device after all bearers are disconnected
WARNING:TYPO_SPELLING: 'droped' may be misspelled - perhaps 'dropped'?
#94:
RemoveDevice should be handled after all bearers are droped,
^^^^^^
WARNING:LONG_LINE: line length of 82 exceeds 80 columns
#109: FILE: src/device.c:3495:
+ "RemoveDevice")) {
WARNING:LONG_LINE_COMMENT: line length of 84 exceeds 80 columns
#111: FILE: src/device.c:3497:
+ /* Don't handle the RemoveDevice msg if device is connected.
WARNING:LONG_LINE_COMMENT: line length of 87 exceeds 80 columns
#112: FILE: src/device.c:3498:
+ * For a dual mode remote, both BR/EDR and BLE may be connected,
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#112: FILE: src/device.c:3498:
+ /* Don't handle the RemoveDevice msg if device is connected.
+ * For a dual mode remote, both BR/EDR and BLE may be connected,
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#114: FILE: src/device.c:3500:
+ * disconnects. */
WARNING:LONG_LINE: line length of 88 exceeds 80 columns
#115: FILE: src/device.c:3501:
+ if (device->bredr_state.connected || device->le_state.connected)
/github/workspace/src/src/13811736.patch total: 0 errors, 7 warnings, 17 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13811736.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
prev parent reply other threads:[~2024-09-25 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 7:32 [PATCH v1] device: Remove device after all bearers are disconnected Cheng Jiang
2024-09-25 9:01 ` bluez.test.bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66f3d170.050a0220.318d13.6f06@mx.google.com \
--to=bluez.test.bot@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=quic_chejiang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox