[PATCH BlueZ v1] avdtp: Fix triggering disconnect_timeout while discovering capabilities

[PATCH BlueZ v1] avdtp: Fix triggering disconnect_timeout while discovering capabilities

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

If there are many endpoint registered it may delay the discovering of
the capabilities long enough to trigger diconnect_timeout which may
cause unexpected collisions/disconnections.

Fixes: https://github.com/bluez/bluez/issues/981
---
 profiles/audio/avdtp.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
index 289b40827d88..80fbe847e043 100644
--- a/profiles/audio/avdtp.c
+++ b/profiles/audio/avdtp.c
@@ -2037,6 +2037,14 @@ failed:
 static gboolean avdtp_parse_cmd(struct avdtp *session, uint8_t transaction,
 				uint8_t signal_id, void *buf, int size)
 {
+	/* Reset disconnect timer if command is received */
+	if (session->dc_timer) {
+		timeout_remove(session->dc_timer);
+		session->dc_timer = timeout_add_seconds(session->dc_timeout,
+						disconnect_timeout,
+						session, NULL);
+	}
+
 	switch (signal_id) {
 	case AVDTP_DISCOVER:
 		DBG("Received DISCOVER_CMD");
-- 
2.47.0

RE: [BlueZ,v1] avdtp: Fix triggering disconnect_timeout while discovering capabilities

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=899479

---Test result---

Test Summary:
CheckPatch                    PASS      0.44 seconds
GitLint                       FAIL      0.53 seconds
BuildEll                      PASS      27.53 seconds
BluezMake                     PASS      1671.68 seconds
MakeCheck                     PASS      12.96 seconds
MakeDistcheck                 PASS      182.32 seconds
CheckValgrind                 PASS      256.64 seconds
CheckSmatch                   PASS      360.94 seconds
bluezmakeextell               PASS      120.32 seconds
IncrementalBuild              PASS      1424.95 seconds
ScanBuild                     PASS      1010.25 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,v1] avdtp: Fix triggering disconnect_timeout while discovering capabilities

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (82>80): "[BlueZ,v1] avdtp: Fix triggering disconnect_timeout while discovering capabilities"


---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] avdtp: Fix triggering disconnect_timeout while discovering capabilities

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 15 Oct 2024 15:42:54 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> If there are many endpoint registered it may delay the discovering of
> the capabilities long enough to trigger diconnect_timeout which may
> cause unexpected collisions/disconnections.
> 
> Fixes: https://github.com/bluez/bluez/issues/981
> 
> [...]

Here is the summary with links:
  - [BlueZ,v1] avdtp: Fix triggering disconnect_timeout while discovering capabilities
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c1d01a378f23

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html