[PATCH BlueZ v1] shared/shell: Always set stdout to be line buffered

[PATCH BlueZ v1] shared/shell: Always set stdout to be line buffered

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This always set stdout to be line buffered to avoid cluttering the
output:

https://github.com/bluez/bluez/issues/747#issuecomment-2596840382
---
 src/shared/shell.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/shared/shell.c b/src/shared/shell.c
index aa6c16c8c430..37c747f8fa23 100644
--- a/src/shared/shell.c
+++ b/src/shared/shell.c
@@ -1268,7 +1268,6 @@ static void rl_init(void)
 	/* Allow conditional parsing of the ~/.inputrc file. */
 	rl_readline_name = data.name;
 
-	setlinebuf(stdout);
 	rl_attempted_completion_function = shell_completion;
 
 	rl_erase_empty_line = 1;
@@ -1405,6 +1404,8 @@ done:
 
 	mainloop_init();
 
+	/* Always set stdout as line buffered */
+	setlinebuf(stdout);
 	rl_init();
 
 	data.init = true;
-- 
2.47.1

RE: [BlueZ,v1] shared/shell: Always set stdout to be line buffered

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1621 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=926226

---Test result---

Test Summary:
CheckPatch                    PENDING   0.30 seconds
GitLint                       PENDING   0.27 seconds
BuildEll                      PASS      21.43 seconds
BluezMake                     PASS      1612.86 seconds
MakeCheck                     PASS      13.21 seconds
MakeDistcheck                 PASS      164.85 seconds
CheckValgrind                 PASS      226.76 seconds
CheckSmatch                   WARNING   287.83 seconds
bluezmakeextell               PASS      101.21 seconds
IncrementalBuild              PENDING   0.25 seconds
ScanBuild                     PASS      900.68 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] shared/shell: Always set stdout to be line buffered

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 16 Jan 2025 15:39:00 -0500 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This always set stdout to be line buffered to avoid cluttering the
> output:
> 
> https://github.com/bluez/bluez/issues/747#issuecomment-2596840382
> 
> [...]

Here is the summary with links:
  - [BlueZ,v1] shared/shell: Always set stdout to be line buffered
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=07c14fcfbd8b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html