[PATCH 1/4] test-runner: Increase amount of RAM available in VM

[PATCH 1/4] test-runner: Increase amount of RAM available in VM

[Arkadiusz Bokowy]

When using default kernel configuration from Ubuntu 24.04 patched with
the configuration from tester.config, the kernel image is too big to run
on 192M bytes of RAM. As a result the test-runner exits without any
message (because of the "quite" kernel command line option).
---
 tools/test-runner.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/test-runner.c b/tools/test-runner.c
index cd8b86d7a..77c89f3f9 100644
--- a/tools/test-runner.c
+++ b/tools/test-runner.c
@@ -211,7 +211,7 @@ static char *const qemu_argv[] = {
 	"-monitor", "none",
 	"-display", "none",
 	"-machine", "type=q35,accel=kvm:tcg",
-	"-m", "192M",
+	"-m", "256M",
 	"-nographic",
 	"-net", "none",
 	"-no-reboot",
-- 
2.43.0

[PATCH 2/4] test-runner: Remove the "-nographic" option passed to QEMU

[Arkadiusz Bokowy]

This option causes QEMU to redirect monitor and serial to the terminal,
but also it modifies the terminal settings and clears it before printing
anything. Such behavior might be annoying because it might clear some
warning messages printed before clearing the screen. Since test-runner
disables QEMU monitor and redirects serial to stdio in an explicit way,
the "-nographic" option can be dropped.
---
 tools/test-runner.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/test-runner.c b/tools/test-runner.c
index 77c89f3f9..13a5de465 100644
--- a/tools/test-runner.c
+++ b/tools/test-runner.c
@@ -212,7 +212,6 @@ static char *const qemu_argv[] = {
 	"-display", "none",
 	"-machine", "type=q35,accel=kvm:tcg",
 	"-m", "256M",
-	"-nographic",
 	"-net", "none",
 	"-no-reboot",
 	"-fsdev", "local,id=fsdev-root,path=/,readonly,security_model=none,"
-- 
2.43.0

[PATCH 3/4] test-runner: Do not use short-form of readonly option

[Arkadiusz Bokowy]

From: Arkadiusz Bokowy <arkadiusz.bokowy@bokowy.com>

qemu-system-x86_64: warning: short-form boolean option 'readonly' deprecated
Please use readonly=on instead
---
 tools/test-runner.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/test-runner.c b/tools/test-runner.c
index 13a5de465..1fc95d33f 100644
--- a/tools/test-runner.c
+++ b/tools/test-runner.c
@@ -214,7 +214,7 @@ static char *const qemu_argv[] = {
 	"-m", "256M",
 	"-net", "none",
 	"-no-reboot",
-	"-fsdev", "local,id=fsdev-root,path=/,readonly,security_model=none,"
+	"-fsdev", "local,id=fsdev-root,path=/,readonly=on,security_model=none,"
 	"multidevs=remap",
 	"-device", "virtio-9p-pci,fsdev=fsdev-root,mount_tag=/dev/root",
 	"-chardev", "stdio,id=con,mux=on",
-- 
2.43.0

[PATCH 4/4] test-runner: Use host CPU when starting VM

[Arkadiusz Bokowy]

When running test-runner on Ubuntu 24.04 with mainline kernel compiled
from Ubuntu default configuration with applied tester.config options,
the QEMU is not able to start the test-runner application due to illegal
instruction. Passing '-cpu host' fixes that issue.

> $ tools/test-runner -k linux/arch/x86/boot/bzImage -- tools/mgmt-tester
> Using QEMU binary /usr/bin/qemu-system-x86_64
> Using kernel image [...]/linux/arch/x86/boot/bzImage
> Found support for Virtual Machine eXtensions
> [...]
> [    0.000000] Linux version 6.14.0-rc2+ (gcc (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0 [...]
> [...]
> Running command tools/mgmt-tester
> New process 74 created
> Illegal instruction
> Process 74 exited with status 132
> [    0.881239] reboot: Restarting system
> [    0.881431] reboot: machine restart

Potential caveat:

In case when the KVM is not available on the host, the QEMU will not
start with the warning:
CPU model 'host' requires KVM or HVF
---
 tools/test-runner.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/test-runner.c b/tools/test-runner.c
index 1fc95d33f..48e114174 100644
--- a/tools/test-runner.c
+++ b/tools/test-runner.c
@@ -211,6 +211,7 @@ static char *const qemu_argv[] = {
 	"-monitor", "none",
 	"-display", "none",
 	"-machine", "type=q35,accel=kvm:tcg",
+	"-cpu", "host",
 	"-m", "256M",
 	"-net", "none",
 	"-no-reboot",
-- 
2.43.0

Re: [PATCH 2/4] test-runner: Remove the "-nographic" option passed to QEMU

[Luiz Augusto von Dentz]

Hi Arkadiusz,

On Wed, Feb 12, 2025 at 8:52 AM Arkadiusz Bokowy
<arkadiusz.bokowy@gmail.com> wrote:
>
> This option causes QEMU to redirect monitor and serial to the terminal,
> but also it modifies the terminal settings and clears it before printing
> anything. Such behavior might be annoying because it might clear some
> warning messages printed before clearing the screen. Since test-runner
> disables QEMU monitor and redirects serial to stdio in an explicit way,
> the "-nographic" option can be dropped.
> ---
>  tools/test-runner.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tools/test-runner.c b/tools/test-runner.c
> index 77c89f3f9..13a5de465 100644
> --- a/tools/test-runner.c
> +++ b/tools/test-runner.c
> @@ -212,7 +212,6 @@ static char *const qemu_argv[] = {
>         "-display", "none",
>         "-machine", "type=q35,accel=kvm:tcg",
>         "-m", "256M",
> -       "-nographic",
>         "-net", "none",
>         "-no-reboot",
>         "-fsdev", "local,id=fsdev-root,path=/,readonly,security_model=none,"

Are you sure this won't require changes to tester.config? It seems you
have the impression the test-runner kernel image shall be compiled
with distros .config on top of tester.config, that is not how the
likes of CI uses it though, usually all you have to do is:

https://github.com/bluez/bluez/blob/master/doc/test-runner.rst#kernel

So we need to confirm removing -nographic doesn't end up breaking when
build with only tester.config

> --
> 2.43.0
>
>


-- 
Luiz Augusto von Dentz

RE: [1/4] test-runner: Increase amount of RAM available in VM

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=933153

---Test result---

Test Summary:
CheckPatch                    PENDING   0.21 seconds
GitLint                       PENDING   0.20 seconds
BuildEll                      PASS      20.82 seconds
BluezMake                     PASS      1547.50 seconds
MakeCheck                     PASS      13.73 seconds
MakeDistcheck                 PASS      161.08 seconds
CheckValgrind                 PASS      217.41 seconds
CheckSmatch                   PASS      295.20 seconds
bluezmakeextell               PASS      97.85 seconds
IncrementalBuild              PENDING   0.32 seconds
ScanBuild                     PASS      862.48 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH 1/4] test-runner: Increase amount of RAM available in VM

[patchwork-bot+bluetooth]

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 12 Feb 2025 14:52:06 +0100 you wrote:
> When using default kernel configuration from Ubuntu 24.04 patched with
> the configuration from tester.config, the kernel image is too big to run
> on 192M bytes of RAM. As a result the test-runner exits without any
> message (because of the "quite" kernel command line option).
> ---
>  tools/test-runner.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [1/4] test-runner: Increase amount of RAM available in VM
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=571bc32fd9d0
  - [2/4] test-runner: Remove the "-nographic" option passed to QEMU
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8e76a4d0dc56
  - [3/4] test-runner: Do not use short-form of readonly option
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=54210e0210d4
  - [4/4] test-runner: Use host CPU when starting VM
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=4577f50e739f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html