[PATCH 1/2] Bluetooth: btnxpuart: Add VIN regulator support

[PATCH 1/2] Bluetooth: btnxpuart: Add VIN regulator support

[Loic Poulain]

As bluetooth controller is usually part of a WiFi/BT combo chip,
it is important that each driver references the common supply.
This prevents bluetooth to be powered down if WiFi driver is not
loaded or removed.

Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
---
 drivers/bluetooth/btnxpuart.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
index 4f2f429c9800..fc313559c2aa 100644
--- a/drivers/bluetooth/btnxpuart.c
+++ b/drivers/bluetooth/btnxpuart.c
@@ -17,6 +17,7 @@
 #include <linux/crc32.h>
 #include <linux/string_helpers.h>
 #include <linux/gpio/consumer.h>
+#include <linux/regulator/consumer.h>
 
 #include <net/bluetooth/bluetooth.h>
 #include <net/bluetooth/hci_core.h>
@@ -1522,6 +1523,11 @@ static int nxp_serdev_probe(struct serdev_device *serdev)
 {
 	struct hci_dev *hdev;
 	struct btnxpuart_dev *nxpdev;
+	int ret;
+
+	ret = devm_regulator_get_enable(&serdev->dev, "vin");
+	if (ret)
+		return dev_err_probe(&serdev->dev, ret, "Failed to enable VIN\n");
 
 	nxpdev = devm_kzalloc(&serdev->dev, sizeof(*nxpdev), GFP_KERNEL);
 	if (!nxpdev)
-- 
2.34.1

[PATCH 2/2] dt-bindings: net: bluetooth: nxp: Add vin-supply property

[Loic Poulain]

To specify the VIN supply for internal buck (1.8V). This supply is
usually referenced by both the bluetooth and WiFi nodes, as they
share the same combo chip input voltage.

Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
---
 .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml      | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
index 04f55fac42ce..275c1e5a6f72 100644
--- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
+++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
@@ -50,6 +50,9 @@ properties:
     description:
       The GPIO number of the NXP chipset used for BT_WAKE_OUT.
 
+  vin-supply:
+    description: Input supply phandle (1.8V)
+
 required:
   - compatible
 
-- 
2.34.1

[PATCH 2/2] dt-bindings: net: bluetooth: nxp: Add vin-supply property

[Neeraj Sanjay Kale]

Hi Loic,

Thank you for your patch.

There is a similar patch series from Catalin Popescu, which has been approved but pending merge:
https://patchwork.kernel.org/project/bluetooth/list/?series=895539&state=%2A&archive=both

++ Luiz, Catalin

Hi Catalin,
Can you please resend your patch series which implements power-up sequence? 

Thanks,
Neeraj

> 
> To specify the VIN supply for internal buck (1.8V). This supply is usually
> referenced by both the bluetooth and WiFi nodes, as they share the same
> combo chip input voltage.
> 
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> ---
>  .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml      | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
> bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
> bt.yaml
> index 04f55fac42ce..275c1e5a6f72 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
> bt.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
> bt.yam
> +++ l
> @@ -50,6 +50,9 @@ properties:
>      description:
>        The GPIO number of the NXP chipset used for BT_WAKE_OUT.
> 
> +  vin-supply:
> +    description: Input supply phandle (1.8V)
> +
>  required:
>    - compatible
> 
> --
> 2.34.1

Re: [PATCH 2/2] dt-bindings: net: bluetooth: nxp: Add vin-supply property

[POPESCU Catalin]

Hi Neeraj,

Thanks for the heads-up, I just sent a v2 patchset rebased on linux-next.

BR,
Catalin

On 26/02/2025 18:55, Neeraj Sanjay Kale wrote:
> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>
>
> Hi Loic,
>
> Thank you for your patch.
>
> There is a similar patch series from Catalin Popescu, which has been approved but pending merge:
> https://patchwork.kernel.org/project/bluetooth/list/?series=895539&state=%2A&archive=both
>
> ++ Luiz, Catalin
>
> Hi Catalin,
> Can you please resend your patch series which implements power-up sequence?
>
> Thanks,
> Neeraj
>
>> To specify the VIN supply for internal buck (1.8V). This supply is usually
>> referenced by both the bluetooth and WiFi nodes, as they share the same
>> combo chip input voltage.
>>
>> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
>> ---
>>   .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml      | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
>> bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
>> bt.yaml
>> index 04f55fac42ce..275c1e5a6f72 100644
>> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
>> bt.yaml
>> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
>> bt.yam
>> +++ l
>> @@ -50,6 +50,9 @@ properties:
>>       description:
>>         The GPIO number of the NXP chipset used for BT_WAKE_OUT.
>>
>> +  vin-supply:
>> +    description: Input supply phandle (1.8V)
>> +
>>   required:
>>     - compatible
>>
>> --
>> 2.34.1

RE: [1/2] Bluetooth: btnxpuart: Add VIN regulator support

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2601 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=938097

---Test result---

Test Summary:
CheckPatch                    PENDING   0.40 seconds
GitLint                       PENDING   0.29 seconds
SubjectPrefix                 FAIL      0.39 seconds
BuildKernel                   PASS      24.14 seconds
CheckAllWarning               PASS      26.55 seconds
CheckSparse                   PASS      29.95 seconds
BuildKernel32                 PASS      23.90 seconds
TestRunnerSetup               PASS      425.98 seconds
TestRunner_l2cap-tester       PASS      20.87 seconds
TestRunner_iso-tester         PASS      35.61 seconds
TestRunner_bnep-tester        PASS      4.81 seconds
TestRunner_mgmt-tester        FAIL      120.85 seconds
TestRunner_rfcomm-tester      PASS      7.88 seconds
TestRunner_sco-tester         PASS      9.53 seconds
TestRunner_ioctl-tester       PASS      8.21 seconds
TestRunner_mesh-tester        FAIL      6.23 seconds
TestRunner_smp-tester         PASS      7.15 seconds
TestRunner_userchan-tester    PASS      5.00 seconds
IncrementalBuild              PENDING   0.74 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 490, Passed: 484 (98.8%), Failed: 2, Not Run: 4

Failed Test Cases
LL Privacy - Set Flags 3 (2 Devices to RL)           Failed       0.182 seconds
LL Privacy - Start Discovery 1 (Disable RL)          Failed       0.161 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
BUG: KASAN: slab-use-after-free in run_timer_softirq+0x76f/0x7d0
WARNING: CPU: 0 PID: 67 at kernel/workqueue.c:2257 __queue_work+0x687/0xb40
Total: 10, Passed: 9 (90.0%), Failed: 1, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Failed       0.127 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth