[PATCH BlueZ v1] client/player: Fix changing preset SDU

[PATCH BlueZ v1] client/player: Fix changing preset SDU

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This fixes changing preset SDU when configuring multiple channels, the
SDU of the configuration is the one the needs to be adjusted not the
preset itself.
---
 client/player.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/client/player.c b/client/player.c
index 17817c45a921..9d38347d6b91 100644
--- a/client/player.c
+++ b/client/player.c
@@ -2296,8 +2296,12 @@ static DBusMessage *endpoint_select_properties_reply(struct endpoint *ep,
 		/* Adjust the SDU size based on the number of
 		 * locations/channels that is being requested.
 		 */
-		if (channels > 1)
-			qos->sdu *= channels;
+		if (channels > 1) {
+			if (ep->broadcast)
+				cfg->qos.bcast.io_qos.sdu *= channels;
+			else
+				cfg->qos.ucast.io_qos.sdu *= channels;
+		}
 	}
 
 	dbus_message_iter_init_append(reply, &iter);
-- 
2.48.1

RE: [BlueZ,v1] client/player: Fix changing preset SDU

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=941596

---Test result---

Test Summary:
CheckPatch                    PENDING   0.24 seconds
GitLint                       PENDING   0.22 seconds
BuildEll                      PASS      20.72 seconds
BluezMake                     PASS      1612.41 seconds
MakeCheck                     PASS      13.27 seconds
MakeDistcheck                 PASS      160.99 seconds
CheckValgrind                 PASS      215.93 seconds
CheckSmatch                   PASS      284.98 seconds
bluezmakeextell               PASS      98.79 seconds
IncrementalBuild              PENDING   0.28 seconds
ScanBuild                     PASS      882.16 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] client/player: Fix changing preset SDU

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri,  7 Mar 2025 11:34:35 -0500 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This fixes changing preset SDU when configuring multiple channels, the
> SDU of the configuration is the one the needs to be adjusted not the
> preset itself.
> ---
>  client/player.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Here is the summary with links:
  - [BlueZ,v1] client/player: Fix changing preset SDU
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=48c33d291d92

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html