[PATCH] Bluetooth: HCI: Add definition of hci_rp_remote_name_req_cancel

[PATCH] Bluetooth: HCI: Add definition of hci_rp_remote_name_req_cancel

[Wentao Guan]

Return Parameters is not only status, also bdaddr:

BLUETOOTH CORE SPECIFICATION Version 5.4 | Vol 4, Part E
page 1870:
BLUETOOTH CORE SPECIFICATION Version 5.0 | Vol 2, Part E
page 802:

Return parameters:
  Status:
  Size: 1 octet
  BD_ADDR:
  Size: 6 octets

Note that it also fixes the warning:
"Bluetooth: hci0: unexpected cc 0x041a length: 7 > 1"

Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
---
 include/net/bluetooth/hci.h | 5 +++++
 net/bluetooth/hci_event.c   | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
index 0d51970d809f..b9a95c2735e0 100644
--- a/include/net/bluetooth/hci.h
+++ b/include/net/bluetooth/hci.h
@@ -855,6 +855,11 @@ struct hci_cp_remote_name_req_cancel {
 	bdaddr_t bdaddr;
 } __packed;
 
+struct hci_rp_remote_name_req_cancel {
+	__u8     status;
+	bdaddr_t bdaddr;
+} __packed;
+
 #define HCI_OP_READ_REMOTE_FEATURES	0x041b
 struct hci_cp_read_remote_features {
 	__le16   handle;
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 2cc7a9306350..a7b0e36609d9 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -4005,8 +4005,8 @@ static const struct hci_cc {
 	HCI_CC_STATUS(HCI_OP_INQUIRY_CANCEL, hci_cc_inquiry_cancel),
 	HCI_CC_STATUS(HCI_OP_PERIODIC_INQ, hci_cc_periodic_inq),
 	HCI_CC_STATUS(HCI_OP_EXIT_PERIODIC_INQ, hci_cc_exit_periodic_inq),
-	HCI_CC_STATUS(HCI_OP_REMOTE_NAME_REQ_CANCEL,
-		      hci_cc_remote_name_req_cancel),
+	HCI_CC(HCI_OP_REMOTE_NAME_REQ_CANCEL,
+		      hci_cc_remote_name_req_cancel, sizeof(struct hci_rp_remote_name_req_cancel)),
 	HCI_CC(HCI_OP_ROLE_DISCOVERY, hci_cc_role_discovery,
 	       sizeof(struct hci_rp_role_discovery)),
 	HCI_CC(HCI_OP_READ_LINK_POLICY, hci_cc_read_link_policy,
-- 
2.20.1

RE: Bluetooth: HCI: Add definition of hci_rp_remote_name_req_cancel

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2636 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=944728

---Test result---

Test Summary:
CheckPatch                    PENDING   0.36 seconds
GitLint                       PENDING   0.23 seconds
SubjectPrefix                 PASS      0.07 seconds
BuildKernel                   PASS      25.25 seconds
CheckAllWarning               PASS      27.58 seconds
CheckSparse                   WARNING   30.98 seconds
BuildKernel32                 PASS      24.69 seconds
TestRunnerSetup               PASS      440.96 seconds
TestRunner_l2cap-tester       PASS      21.11 seconds
TestRunner_iso-tester         PASS      37.47 seconds
TestRunner_bnep-tester        PASS      4.98 seconds
TestRunner_mgmt-tester        FAIL      122.05 seconds
TestRunner_rfcomm-tester      PASS      7.91 seconds
TestRunner_sco-tester         PASS      12.39 seconds
TestRunner_ioctl-tester       PASS      8.20 seconds
TestRunner_mesh-tester        FAIL      6.30 seconds
TestRunner_smp-tester         PASS      7.19 seconds
TestRunner_userchan-tester    PASS      5.09 seconds
IncrementalBuild              PENDING   1.02 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: CheckSparse - WARNING
Desc: Run sparse tool with linux kernel
Output:
net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 490, Passed: 484 (98.8%), Failed: 2, Not Run: 4

Failed Test Cases
LL Privacy - Set Flags 3 (2 Devices to RL)           Failed       0.186 seconds
LL Privacy - Set Device Flag 1 (Device Privacy)      Failed       0.154 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
BUG: KASAN: slab-use-after-free in run_timer_softirq+0x76f/0x7d0
WARNING: CPU: 0 PID: 35 at kernel/workqueue.c:2257 __queue_work+0x687/0xb40
Total: 10, Passed: 9 (90.0%), Failed: 1, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Failed       0.112 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH] Bluetooth: HCI: Add definition of hci_rp_remote_name_req_cancel

[Luiz Augusto von Dentz]

Hi Wentao,

On Mon, Mar 17, 2025 at 11:53 AM Wentao Guan <guanwentao@uniontech.com> wrote:
>
> Return Parameters is not only status, also bdaddr:
>
> BLUETOOTH CORE SPECIFICATION Version 5.4 | Vol 4, Part E
> page 1870:
> BLUETOOTH CORE SPECIFICATION Version 5.0 | Vol 2, Part E
> page 802:
>
> Return parameters:
>   Status:
>   Size: 1 octet
>   BD_ADDR:
>   Size: 6 octets
>
> Note that it also fixes the warning:
> "Bluetooth: hci0: unexpected cc 0x041a length: 7 > 1"

Please add the Fixes tag pointing to the patch which introduced the
hci_rp_remote_name_req_cancel.

> Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
> ---
>  include/net/bluetooth/hci.h | 5 +++++
>  net/bluetooth/hci_event.c   | 4 ++--
>  2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index 0d51970d809f..b9a95c2735e0 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -855,6 +855,11 @@ struct hci_cp_remote_name_req_cancel {
>         bdaddr_t bdaddr;
>  } __packed;
>
> +struct hci_rp_remote_name_req_cancel {
> +       __u8     status;
> +       bdaddr_t bdaddr;
> +} __packed;
> +
>  #define HCI_OP_READ_REMOTE_FEATURES    0x041b
>  struct hci_cp_read_remote_features {
>         __le16   handle;
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 2cc7a9306350..a7b0e36609d9 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -4005,8 +4005,8 @@ static const struct hci_cc {
>         HCI_CC_STATUS(HCI_OP_INQUIRY_CANCEL, hci_cc_inquiry_cancel),
>         HCI_CC_STATUS(HCI_OP_PERIODIC_INQ, hci_cc_periodic_inq),
>         HCI_CC_STATUS(HCI_OP_EXIT_PERIODIC_INQ, hci_cc_exit_periodic_inq),
> -       HCI_CC_STATUS(HCI_OP_REMOTE_NAME_REQ_CANCEL,
> -                     hci_cc_remote_name_req_cancel),
> +       HCI_CC(HCI_OP_REMOTE_NAME_REQ_CANCEL,
> +                     hci_cc_remote_name_req_cancel, sizeof(struct hci_rp_remote_name_req_cancel)),
>         HCI_CC(HCI_OP_ROLE_DISCOVERY, hci_cc_role_discovery,
>                sizeof(struct hci_rp_role_discovery)),
>         HCI_CC(HCI_OP_READ_LINK_POLICY, hci_cc_read_link_policy,
> --
> 2.20.1
>
>


-- 
Luiz Augusto von Dentz

Re: [PATCH] Bluetooth: HCI: Add definition of hci_rp_remote_name_req_cancel

[Wentao Guan]

Hello,

c8992cffbe74 Bluetooth: hci_event: Use of a function table to handle Command Complete, is it ok?
a9de9248064b [Bluetooth] Switch from OGF+OCF to using only opcodes,is many years ago and it seems not wrong.

BRs
Wentao Guan