[PATCH BlueZ] profiles/avrcp: Fix AVRCP PDU parameters length don't match

[PATCH BlueZ] profiles/avrcp: Fix AVRCP PDU parameters length don't match

[Frédéric Danis]

This is required for passing PTS test case AVRCP/TG/VLH/BI-01-C
(To verify the behavior of the TG receiving an invalid SetAbsoluteVolume
command).
---
 profiles/audio/avrcp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
index 7e9a383b0..65f1adbdd 100644
--- a/profiles/audio/avrcp.c
+++ b/profiles/audio/avrcp.c
@@ -1963,7 +1963,8 @@ static size_t handle_vendordep_pdu(struct avctp *conn, uint8_t transaction,
 
 	if (be16_to_cpu(pdu->params_len) != operand_count) {
 		DBG("AVRCP PDU parameters length don't match");
-		pdu->params_len = cpu_to_be16(operand_count);
+		pdu->params[0] = AVRCP_STATUS_PARAM_NOT_FOUND;
+		goto err_metadata;
 	}
 
 	for (handler = session->control_handlers; handler->pdu_id; handler++) {
-- 
2.43.0

RE: [BlueZ] profiles/avrcp: Fix AVRCP PDU parameters length don't match

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=945567

---Test result---

Test Summary:
CheckPatch                    PENDING   0.32 seconds
GitLint                       PENDING   0.27 seconds
BuildEll                      PASS      20.55 seconds
BluezMake                     PASS      1505.41 seconds
MakeCheck                     PASS      13.47 seconds
MakeDistcheck                 PASS      157.51 seconds
CheckValgrind                 PASS      214.91 seconds
CheckSmatch                   PASS      286.33 seconds
bluezmakeextell               PASS      99.30 seconds
IncrementalBuild              PENDING   0.29 seconds
ScanBuild                     PASS      877.76 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ] profiles/avrcp: Fix AVRCP PDU parameters length don't match

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 19 Mar 2025 13:11:12 +0100 you wrote:
> This is required for passing PTS test case AVRCP/TG/VLH/BI-01-C
> (To verify the behavior of the TG receiving an invalid SetAbsoluteVolume
> command).
> ---
>  profiles/audio/avrcp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ] profiles/avrcp: Fix AVRCP PDU parameters length don't match
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=e88f914ea700

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html