[PATCH BlueZ bluez v2] bass: Set the service connection flag when BASS connected

[PATCH BlueZ bluez v2] bass: Set the service connection flag when BASS connected

[Yang Li via B4 Relay]

From: Yang Li <yang.li@amlogic.com>

When BASS serice connected, set the service states to
BTD_SERVICE_STATE_CONNECTED. Otherwise, the device will
timeout and be removed, triggering the automatic termination
 of BIG.

issue: https://github.com/bluez/bluez/issues/1144

Signed-off-by: Yang Li <yang.li@amlogic.com>
---
Changes in v2:
- Set the BASS service connection success flag in the connect_cb function.
- Link to v1: https://patch.msgid.link/20250402-bass-v1-1-3e753841faa5@amlogic.com
---
 profiles/audio/bass.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/profiles/audio/bass.c b/profiles/audio/bass.c
index c36f43277..c28d9d1ad 100644
--- a/profiles/audio/bass.c
+++ b/profiles/audio/bass.c
@@ -321,6 +321,8 @@ static void connect_cb(GIOChannel *io, GError *err, void *user_data)
 	if (bt_bap_stream_set_io(stream, fd)) {
 		g_io_channel_set_close_on_unref(io, FALSE);
 	}
+
+	btd_service_connecting_complete(setup->dg->service, 0);
 }
 
 static bool link_enabled(const void *data, const void *match_data)

---
base-commit: 0efa20cbf3fb5693c7c2f14ba8cf67053ca029e5
change-id: 20250402-bass-66200bb7eba1

Best regards,
-- 
Yang Li <yang.li@amlogic.com>

RE: [BlueZ,bluez,v2] bass: Set the service connection flag when BASS connected

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=949647

---Test result---

Test Summary:
CheckPatch                    PENDING   0.23 seconds
GitLint                       PENDING   0.34 seconds
BuildEll                      PASS      20.61 seconds
BluezMake                     PASS      1558.06 seconds
MakeCheck                     PASS      12.78 seconds
MakeDistcheck                 PASS      163.31 seconds
CheckValgrind                 PASS      219.19 seconds
CheckSmatch                   PASS      290.61 seconds
bluezmakeextell               PASS      100.96 seconds
IncrementalBuild              PENDING   0.28 seconds
ScanBuild                     PASS      898.04 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ bluez v2] bass: Set the service connection flag when BASS connected

[Luiz Augusto von Dentz]

Hi Yang,

On Wed, Apr 2, 2025 at 11:37 PM Yang Li via B4 Relay
<devnull+yang.li.amlogic.com@kernel.org> wrote:
>
> From: Yang Li <yang.li@amlogic.com>
>
> When BASS serice connected, set the service states to
> BTD_SERVICE_STATE_CONNECTED. Otherwise, the device will
> timeout and be removed, triggering the automatic termination
>  of BIG.
>
> issue: https://github.com/bluez/bluez/issues/1144
>
> Signed-off-by: Yang Li <yang.li@amlogic.com>
> ---
> Changes in v2:
> - Set the BASS service connection success flag in the connect_cb function.
> - Link to v1: https://patch.msgid.link/20250402-bass-v1-1-3e753841faa5@amlogic.com
> ---
>  profiles/audio/bass.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/profiles/audio/bass.c b/profiles/audio/bass.c
> index c36f43277..c28d9d1ad 100644
> --- a/profiles/audio/bass.c
> +++ b/profiles/audio/bass.c
> @@ -321,6 +321,8 @@ static void connect_cb(GIOChannel *io, GError *err, void *user_data)
>         if (bt_bap_stream_set_io(stream, fd)) {
>                 g_io_channel_set_close_on_unref(io, FALSE);
>         }
> +
> +       btd_service_connecting_complete(setup->dg->service, 0);

Ok, do we mark it as disconnected when the BIS is disconnected? In
case we are acting as assistante then there is probably no reason to
keep the device object around after it has been pushed to the remote
sink.

>  }
>
>  static bool link_enabled(const void *data, const void *match_data)
>
> ---
> base-commit: 0efa20cbf3fb5693c7c2f14ba8cf67053ca029e5
> change-id: 20250402-bass-66200bb7eba1
>
> Best regards,
> --
> Yang Li <yang.li@amlogic.com>
>
>
>


-- 
Luiz Augusto von Dentz

Re: [PATCH BlueZ bluez v2] bass: Set the service connection flag when BASS connected

[Yang Li]

Hi Luiz,


> [ EXTERNAL EMAIL ]
>
> Hi Yang,
>
> On Wed, Apr 2, 2025 at 11:37 PM Yang Li via B4 Relay
> <devnull+yang.li.amlogic.com@kernel.org> wrote:
>> From: Yang Li <yang.li@amlogic.com>
>>
>> When BASS serice connected, set the service states to
>> BTD_SERVICE_STATE_CONNECTED. Otherwise, the device will
>> timeout and be removed, triggering the automatic termination
>>   of BIG.
>>
>> issue: https://github.com/bluez/bluez/issues/1144
>>
>> Signed-off-by: Yang Li <yang.li@amlogic.com>
>> ---
>> Changes in v2:
>> - Set the BASS service connection success flag in the connect_cb function.
>> - Link to v1: https://patch.msgid.link/20250402-bass-v1-1-3e753841faa5@amlogic.com
>> ---
>>   profiles/audio/bass.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/profiles/audio/bass.c b/profiles/audio/bass.c
>> index c36f43277..c28d9d1ad 100644
>> --- a/profiles/audio/bass.c
>> +++ b/profiles/audio/bass.c
>> @@ -321,6 +321,8 @@ static void connect_cb(GIOChannel *io, GError *err, void *user_data)
>>          if (bt_bap_stream_set_io(stream, fd)) {
>>                  g_io_channel_set_close_on_unref(io, FALSE);
>>          }
>> +
>> +       btd_service_connecting_complete(setup->dg->service, 0);
> Ok, do we mark it as disconnected when the BIS is disconnected?

Yes, the service will be marked as disconnected after the BASS service 
is disconnected.

static int bass_disconnect(struct btd_service *service)
{
     ......
     btd_service_disconnecting_complete(service, 0);

     return 0;
}

> In
> case we are acting as assistante then there is probably no reason to
> keep the device object around after it has been pushed to the remote
> sink.
I don't think so. As an Assistant, the mobile phone needs to record the 
source information configured for the BIS sink. The record of the source 
device will only be cleared when the BIS source is removed.
>>   }
>>
>>   static bool link_enabled(const void *data, const void *match_data)
>>
>> ---
>> base-commit: 0efa20cbf3fb5693c7c2f14ba8cf67053ca029e5
>> change-id: 20250402-bass-66200bb7eba1
>>
>> Best regards,
>> --
>> Yang Li <yang.li@amlogic.com>
>>
>>
>>
>
> --
> Luiz Augusto von Dentz

RE: [BlueZ,bluez,v2] bass: Set the service connection flag when BASS connected

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=949647

---Test result---

Test Summary:
CheckPatch                    PENDING   0.25 seconds
GitLint                       PENDING   0.31 seconds
BuildEll                      PASS      21.06 seconds
BluezMake                     PASS      2790.87 seconds
MakeCheck                     PASS      20.59 seconds
MakeDistcheck                 PASS      200.68 seconds
CheckValgrind                 PASS      278.14 seconds
CheckSmatch                   PASS      303.24 seconds
bluezmakeextell               PASS      128.37 seconds
IncrementalBuild              PENDING   0.33 seconds
ScanBuild                     PASS      919.29 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ bluez v2] bass: Set the service connection flag when BASS connected

[Yang Li]

Hi Luiz,
A gentle ping, thanks.

> Hi Luiz,
>
>
>> [ EXTERNAL EMAIL ]
>>
>> Hi Yang,
>>
>> On Wed, Apr 2, 2025 at 11:37 PM Yang Li via B4 Relay
>> <devnull+yang.li.amlogic.com@kernel.org> wrote:
>>> From: Yang Li <yang.li@amlogic.com>
>>>
>>> When BASS serice connected, set the service states to
>>> BTD_SERVICE_STATE_CONNECTED. Otherwise, the device will
>>> timeout and be removed, triggering the automatic termination
>>>   of BIG.
>>>
>>> issue: https://github.com/bluez/bluez/issues/1144
>>>
>>> Signed-off-by: Yang Li <yang.li@amlogic.com>
>>> ---
>>> Changes in v2:
>>> - Set the BASS service connection success flag in the connect_cb 
>>> function.
>>> - Link to v1: 
>>> https://patch.msgid.link/20250402-bass-v1-1-3e753841faa5@amlogic.com
>>> ---
>>>   profiles/audio/bass.c | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/profiles/audio/bass.c b/profiles/audio/bass.c
>>> index c36f43277..c28d9d1ad 100644
>>> --- a/profiles/audio/bass.c
>>> +++ b/profiles/audio/bass.c
>>> @@ -321,6 +321,8 @@ static void connect_cb(GIOChannel *io, GError 
>>> *err, void *user_data)
>>>          if (bt_bap_stream_set_io(stream, fd)) {
>>>                  g_io_channel_set_close_on_unref(io, FALSE);
>>>          }
>>> +
>>> + btd_service_connecting_complete(setup->dg->service, 0);
>> Ok, do we mark it as disconnected when the BIS is disconnected?
>
> Yes, the service will be marked as disconnected after the BASS service 
> is disconnected.
>
> static int bass_disconnect(struct btd_service *service)
> {
>     ......
>     btd_service_disconnecting_complete(service, 0);
>
>     return 0;
> }
>
>> In
>> case we are acting as assistante then there is probably no reason to
>> keep the device object around after it has been pushed to the remote
>> sink.
> I don't think so. As an Assistant, the mobile phone needs to record 
> the source information configured for the BIS sink. The record of the 
> source device will only be cleared when the BIS source is removed.
>>>   }
>>>
>>>   static bool link_enabled(const void *data, const void *match_data)
>>>
>>> ---
>>> base-commit: 0efa20cbf3fb5693c7c2f14ba8cf67053ca029e5
>>> change-id: 20250402-bass-66200bb7eba1
>>>
>>> Best regards,
>>> -- 
>>> Yang Li <yang.li@amlogic.com>
>>>
>>>
>>>
>>
>> -- 
>> Luiz Augusto von Dentz