[PATCH BlueZ v1] input/device: Fix not sending virtual cable unplug

[PATCH BlueZ v1] input/device: Fix not sending virtual cable unplug

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

When using udev HIDP_CTRL_VIRTUAL_CABLE_UNPLUG must be sent directly
since it is not handled internally like when utilizing kernel hidp
module.

Fixes: https://github.com/bluez/bluez/issues/1173
---
 profiles/input/device.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/profiles/input/device.c b/profiles/input/device.c
index 3642cc3267be..f21a69f57529 100644
--- a/profiles/input/device.c
+++ b/profiles/input/device.c
@@ -1154,8 +1154,13 @@ static int connection_disconnect(struct input_device *idev, uint32_t flags)
 		shutdown(sock, SHUT_WR);
 	}
 
-	if (flags & (1 << HIDP_VIRTUAL_CABLE_UNPLUG))
+	if (flags & (1 << HIDP_VIRTUAL_CABLE_UNPLUG)) {
 		idev->virtual_cable_unplug = true;
+		if (idev->uhid)
+			hidp_send_ctrl_message(idev, HIDP_TRANS_HID_CONTROL |
+						HIDP_CTRL_VIRTUAL_CABLE_UNPLUG,
+						NULL, 0);
+	}
 
 	if (idev->uhid)
 		return uhid_disconnect(idev, false);
-- 
2.49.0

RE: [BlueZ,v1] input/device: Fix not sending virtual cable unplug

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=959160

---Test result---

Test Summary:
CheckPatch                    PENDING   0.22 seconds
GitLint                       PENDING   0.24 seconds
BuildEll                      PASS      20.74 seconds
BluezMake                     PASS      2637.67 seconds
MakeCheck                     PASS      19.90 seconds
MakeDistcheck                 PASS      196.58 seconds
CheckValgrind                 PASS      273.95 seconds
CheckSmatch                   PASS      301.48 seconds
bluezmakeextell               PASS      127.98 seconds
IncrementalBuild              PENDING   0.20 seconds
ScanBuild                     PASS      892.69 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] input/device: Fix not sending virtual cable unplug

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri,  2 May 2025 12:58:21 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> When using udev HIDP_CTRL_VIRTUAL_CABLE_UNPLUG must be sent directly
> since it is not handled internally like when utilizing kernel hidp
> module.
> 
> Fixes: https://github.com/bluez/bluez/issues/1173
> 
> [...]

Here is the summary with links:
  - [BlueZ,v1] input/device: Fix not sending virtual cable unplug
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=ab6ce0c8f3e0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html