* [PATCH 0/2] Bluetooth: Add support for RTK firmware version 3 and enhanced ACL-based download acceleration
@ 2025-05-29 12:48 Hilda Wu
2025-05-29 12:48 ` [PATCH 1/2] Bluetooth: btrtl: Firmware format v3 support Hilda Wu
2025-05-29 12:48 ` [PATCH 2/2] Bluetooth: btrtl: Add enhanced download support Hilda Wu
0 siblings, 2 replies; 7+ messages in thread
From: Hilda Wu @ 2025-05-29 12:48 UTC (permalink / raw)
To: marcel; +Cc: luiz.dentz, linux-bluetooth, linux-kernel, max.chou, alex_lu
Dear Maintainers,
I am submitting a patch for the Bluetooth that introduces support for RTK
firmware version 3 and implements an enhanced download mechanism through
ACL to improve firmware loading times.
Patch Overview:
1. Bluetooth: btrtl: Firmware format v3 support
- This addition ensures the latest RTK chipsets with firmware version 3
are fully supported. It includes necessary modifications to
accommodate new firmware structure changes.
2. Bluetooth: btrtl: Add enhanced download support
- By leveraging ACL links for firmware transmission, the download
process is significantly accelerated, reducing the overall time and
enhancing performance.
Testing and Validation:
- The implementation has been tested on various RTK chipsets under Linux
based distribution.
Impact and Benefits:
These enhancements are beneficial for future firmware v3 chips and
compatible with previous firmware versions. Users can expect shortened
initialization times.
Your feedback and suggestions are welcome to further refine these changes.
Thank you for considering these enhancements.
Best regards,
Hilda
Hilda Wu (2):
Bluetooth: btrtl: Firmware format v3 support
Bluetooth: btrtl: Add enhanced download support
drivers/bluetooth/btrtl.c | 871 +++++++++++++++++++++++++++++++++++++-
drivers/bluetooth/btrtl.h | 102 +++++
drivers/bluetooth/btusb.c | 3 +
3 files changed, 968 insertions(+), 8 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] Bluetooth: btrtl: Firmware format v3 support
2025-05-29 12:48 [PATCH 0/2] Bluetooth: Add support for RTK firmware version 3 and enhanced ACL-based download acceleration Hilda Wu
@ 2025-05-29 12:48 ` Hilda Wu
2025-05-29 13:26 ` Bluetooth: Add support for RTK firmware version 3 and enhanced ACL-based download acceleration bluez.test.bot
2025-05-29 23:49 ` [PATCH 1/2] Bluetooth: btrtl: Firmware format v3 support kernel test robot
2025-05-29 12:48 ` [PATCH 2/2] Bluetooth: btrtl: Add enhanced download support Hilda Wu
1 sibling, 2 replies; 7+ messages in thread
From: Hilda Wu @ 2025-05-29 12:48 UTC (permalink / raw)
To: marcel; +Cc: luiz.dentz, linux-bluetooth, linux-kernel, max.chou, alex_lu
Realtek changed the format of the firmware file as v3. The driver
should implement the patch to extract the firmware data from the
firmware file. The future chips must apply this patch for firmware loading.
This patch is compatible with the both previous format, v2 and v3 as well.
Signed-off-by: Alex Lu <alex_lu@realsil.com.cn>
Signed-off-by: Hilda Wu <hildawu@realtek.com>
---
drivers/bluetooth/btrtl.c | 670 +++++++++++++++++++++++++++++++++++++-
drivers/bluetooth/btrtl.h | 97 ++++++
drivers/bluetooth/btusb.c | 3 +
3 files changed, 762 insertions(+), 8 deletions(-)
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 7838c89e529e..0e6332a45ced 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -22,6 +22,12 @@
#define RTL_CHIP_8723CS_XX 5
#define RTL_EPATCH_SIGNATURE "Realtech"
#define RTL_EPATCH_SIGNATURE_V2 "RTBTCore"
+#define RTL_EPATCH_SIGNATURE_V3 "BTNIC003"
+#define RTL_PATCH_V3_1 0x01
+#define RTL_PATCH_V3_PATCH_IMAGE 0x02
+#define IMAGE_ID_F000 0xf000
+#define IMAGE_ID_F001 0xf001
+#define IMAGE_ID_F002 0xf002
#define RTL_ROM_LMP_8703B 0x8703
#define RTL_ROM_LMP_8723A 0x1200
#define RTL_ROM_LMP_8723B 0x8723
@@ -72,6 +78,7 @@ enum btrtl_chip_id {
CHIP_ID_8851B = 36,
CHIP_ID_8922A = 44,
CHIP_ID_8852BT = 47,
+ CHIP_ID_8922D = 55,
};
struct id_table {
@@ -98,8 +105,11 @@ struct btrtl_device_info {
int cfg_len;
bool drop_fw;
int project_id;
+ u32 opcode;
+ u8 fw_type;
u8 key_id;
struct list_head patch_subsecs;
+ struct list_head patch_images;
};
static const struct id_table ic_id_table[] = {
@@ -328,6 +338,15 @@ static const struct id_table ic_id_table[] = {
.fw_name = "rtl_bt/rtl8852btu_fw",
.cfg_name = "rtl_bt/rtl8852btu_config",
.hw_info = "rtl8852btu" },
+
+ /* 8922DU */
+ { IC_INFO(RTL_ROM_LMP_8922A, 0xd, 0xe, HCI_USB),
+ .config_needed = false,
+ .has_rom_version = true,
+ .has_msft_ext = true,
+ .fw_name = "rtl_bt/rtl8922du_fw",
+ .cfg_name = "rtl_bt/rtl8922du_config",
+ .hw_info = "rtl8922du" },
};
static const struct id_table *btrtl_match_ic(u16 lmp_subver, u16 hci_rev,
@@ -361,6 +380,33 @@ static const struct id_table *btrtl_match_ic(u16 lmp_subver, u16 hci_rev,
return &ic_id_table[i];
}
+static int btrtl_read_chip_id(struct hci_dev *hdev, u8 *chip_id)
+{
+ struct rtl_rp_read_chip_id *rp;
+ struct sk_buff *skb;
+
+ /* Read RTL chip id command */
+ skb = __hci_cmd_sync(hdev, 0xfc6f, 0, NULL, HCI_INIT_TIMEOUT);
+ if (IS_ERR(skb))
+ return PTR_ERR(skb);
+
+ if (skb->len != sizeof(*rp)) {
+ rtl_dev_err(hdev, "read chip id event length mismatch");
+ kfree_skb(skb);
+ return -EIO;
+ }
+
+ rp = (struct rtl_rp_read_chip_id *)skb->data;
+ rtl_dev_info(hdev, "chip_id status=0x%02x id=0x%02x",
+ rp->status, rp->chip_id);
+
+ if (chip_id)
+ *chip_id = rp->chip_id;
+
+ kfree_skb(skb);
+ return 0;
+}
+
static struct sk_buff *btrtl_read_local_version(struct hci_dev *hdev)
{
struct sk_buff *skb;
@@ -439,6 +485,26 @@ static int btrtl_vendor_read_reg16(struct hci_dev *hdev,
return 0;
}
+static int btrtl_vendor_write_mem(struct hci_dev *hdev, u32 addr, u32 val)
+{
+ struct rtl_vendor_write_cmd cp;
+ struct sk_buff *skb;
+ int err = 0;
+
+ cp.type = 0x21;
+ cp.addr = cpu_to_le32(addr);
+ cp.val = cpu_to_le32(val);
+ skb = __hci_cmd_sync(hdev, 0xfc62, sizeof(cp), &cp, HCI_INIT_TIMEOUT);
+ if (IS_ERR(skb)) {
+ err = PTR_ERR(skb);
+ bt_dev_err(hdev, "RTL: Write mem32 failed (%d)", err);
+ return err;
+ }
+
+ kfree_skb(skb);
+ return 0;
+}
+
static void *rtl_iov_pull_data(struct rtl_iovec *iov, u32 len)
{
void *data = iov->data;
@@ -452,6 +518,30 @@ static void *rtl_iov_pull_data(struct rtl_iovec *iov, u32 len)
return data;
}
+static void btrtl_insert_ordered_patch_image(struct rtl_section_patch_image *image,
+ struct btrtl_device_info *btrtl_dev)
+{
+ struct list_head *pos;
+ struct list_head *next;
+ struct rtl_section_patch_image *node;
+
+ list_for_each_safe(pos, next, &btrtl_dev->patch_images) {
+ node = list_entry(pos, struct rtl_section_patch_image, list);
+
+ if (node->image_id > image->image_id) {
+ __list_add(&image->list, pos->prev, pos);
+ return;
+ }
+
+ if (node->image_id == image->image_id &&
+ node->index > image->index) {
+ __list_add(&image->list, pos->prev, pos);
+ return;
+ }
+ }
+ __list_add(&image->list, pos->prev, pos);
+}
+
static void btrtl_insert_ordered_subsec(struct rtl_subsection *node,
struct btrtl_device_info *btrtl_dev)
{
@@ -629,6 +719,295 @@ static int rtlbt_parse_firmware_v2(struct hci_dev *hdev,
return -EPERM;
*_buf = ptr;
+ btrtl_dev->fw_type = FW_TYPE_V2;
+ return len;
+}
+
+static int rtlbt_parse_config(struct hci_dev *hdev,
+ struct rtl_section_patch_image *patch_image,
+ struct btrtl_device_info *btrtl_dev)
+{
+ const struct id_table *ic_info = NULL;
+ const struct firmware *fw;
+ char tmp_name[32];
+ char filename[64];
+ u8 *cfg_buf;
+ char *str;
+ char *p;
+ int len;
+ int ret;
+
+ if (btrtl_dev && btrtl_dev->ic_info)
+ ic_info = btrtl_dev->ic_info;
+
+ if (!ic_info)
+ return -EINVAL;
+
+ str = ic_info->cfg_name;
+ if (btrtl_dev->fw_type == FW_TYPE_V3_1) {
+ if (!patch_image->image_id && !patch_image->index) {
+ snprintf(filename, sizeof(filename), "%s.bin", str);
+ goto load_fw;
+ }
+ goto done;
+ }
+
+ len = strlen(str);
+ if (len > sizeof(tmp_name) - 1)
+ len = sizeof(tmp_name) - 1;
+ memcpy(tmp_name, str, len);
+ tmp_name[len] = '\0';
+
+ str = tmp_name;
+ p = strsep(&str, ".");
+
+ ret = snprintf(filename, sizeof(filename), "%s", p);
+ if (patch_image->config_rule && patch_image->need_config) {
+ switch (patch_image->image_id) {
+ case IMAGE_ID_F000:
+ case IMAGE_ID_F001:
+ case IMAGE_ID_F002:
+ ret += snprintf(filename + ret, sizeof(filename) - ret,
+ "_%04x", patch_image->image_id);
+ break;
+ default:
+ goto done;
+ }
+ } else {
+ goto done;
+ }
+
+ if (str)
+ snprintf(filename + ret, sizeof(filename) - ret, ".%s", str);
+ else
+ snprintf(filename + ret, sizeof(filename) - ret, ".bin");
+load_fw:
+ rtl_dev_info(hdev, "config file: %s", filename);
+ ret = request_firmware(&fw, filename, &hdev->dev);
+ if (ret < 0) {
+ rtl_dev_err(hdev, "request_firmware [%s] error", filename);
+ if (btrtl_dev->fw_type == FW_TYPE_V3_2) {
+ len = 4;
+ cfg_buf = kvmalloc(len, GFP_KERNEL);
+ if (!cfg_buf)
+ return -ENOMEM;
+
+ memset(cfg_buf, 0xff, len);
+ patch_image->cfg_buf = cfg_buf;
+ patch_image->cfg_len = len;
+ return 0;
+ }
+ goto err_req_fw;
+ }
+ cfg_buf = kvmalloc(fw->size, GFP_KERNEL);
+ if (!cfg_buf) {
+ ret = -ENOMEM;
+ goto err;
+ }
+ memcpy(cfg_buf, fw->data, fw->size);
+ len = fw->size;
+ release_firmware(fw);
+
+ patch_image->cfg_buf = cfg_buf;
+ patch_image->cfg_len = len;
+done:
+ return 0;
+err:
+ release_firmware(fw);
+err_req_fw:
+ return ret;
+}
+
+static int rtlbt_parse_section_v3(struct hci_dev *hdev,
+ struct btrtl_device_info *btrtl_dev,
+ u32 opcode, u8 *data, u32 len)
+{
+ struct rtl_section_patch_image *patch_image;
+ struct rtl_patch_image_hdr *hdr;
+ u16 image_id;
+ u16 chip_id;
+ u32 patch_image_len;
+ u8 *ptr;
+ int ret = 0;
+ u8 i;
+ struct rtl_iovec iov = {
+ .data = data,
+ .len = len,
+ };
+
+ hdr = rtl_iov_pull_data(&iov, sizeof(*hdr));
+ if (!hdr)
+ return -EINVAL;
+
+ if (btrtl_dev->opcode && btrtl_dev->opcode != opcode) {
+ rtl_dev_err(hdev, "invalid opcode 0x%02x", opcode);
+ return -EINVAL;
+ }
+
+ if (!btrtl_dev->opcode) {
+ btrtl_dev->opcode = opcode;
+ switch (btrtl_dev->opcode) {
+ case RTL_PATCH_V3_1:
+ btrtl_dev->fw_type = FW_TYPE_V3_1;
+ break;
+ case RTL_PATCH_V3_PATCH_IMAGE:
+ btrtl_dev->fw_type = FW_TYPE_V3_2;
+ break;
+ default:
+ return -EINVAL;
+ }
+ }
+
+ patch_image_len = (u32)le64_to_cpu(hdr->patch_image_len);
+ chip_id = le16_to_cpu(hdr->chip_id);
+ image_id = le16_to_cpu(hdr->image_id);
+ rtl_dev_info(hdev, "image (%04x:%02x), chip id %u, cut 0x%02x, len %08x"
+ , image_id, hdr->index, chip_id, hdr->ic_cut,
+ patch_image_len);
+
+ if (btrtl_dev->key_id && btrtl_dev->key_id != hdr->key_id) {
+ rtl_dev_err(hdev, "invalid key_id (%u, %u)", hdr->key_id,
+ btrtl_dev->key_id);
+ return -EINVAL;
+ }
+
+ if (hdr->ic_cut != btrtl_dev->rom_version + 1) {
+ rtl_dev_info(hdev, "unused ic_cut (%u, %u)", hdr->ic_cut,
+ btrtl_dev->rom_version + 1);
+ return -EINVAL;
+ }
+
+ if (btrtl_dev->fw_type == FW_TYPE_V3_1 && !btrtl_dev->project_id)
+ btrtl_dev->project_id = chip_id;
+
+ if (btrtl_dev->fw_type == FW_TYPE_V3_2 &&
+ chip_id != btrtl_dev->project_id) {
+ rtl_dev_err(hdev, "invalid chip_id (%u, %d)", chip_id,
+ btrtl_dev->project_id);
+ return -EINVAL;
+ }
+
+ ptr = rtl_iov_pull_data(&iov, patch_image_len);
+ if (!ptr)
+ return -ENODATA;
+
+ patch_image = kzalloc(sizeof(*patch_image), GFP_KERNEL);
+ if (!patch_image)
+ return -ENOMEM;
+ patch_image->index = hdr->index;
+ patch_image->image_id = image_id;
+ patch_image->config_rule = hdr->config_rule;
+ patch_image->need_config = hdr->need_config;
+
+ for (i = 0; i < DL_FIX_ADDR_MAX; i++) {
+ patch_image->fix[i].addr =
+ (u32)le64_to_cpu(hdr->addr_fix[i * 2]);
+ patch_image->fix[i].value =
+ (u32)le64_to_cpu(hdr->addr_fix[i * 2 + 1]);
+ }
+
+ patch_image->image_len = patch_image_len;
+ patch_image->image_data = kvmalloc(patch_image_len, GFP_KERNEL);
+ if (!patch_image->image_data) {
+ ret = -ENOMEM;
+ goto err;
+ }
+ memcpy(patch_image->image_data, ptr, patch_image_len);
+ patch_image->image_ver =
+ get_unaligned_le32(ptr + patch_image->image_len - 4);
+ rtl_dev_info(hdev, "image version: %08x", patch_image->image_ver);
+
+ rtlbt_parse_config(hdev, patch_image, btrtl_dev);
+
+ ret = patch_image->image_len;
+
+ btrtl_insert_ordered_patch_image(patch_image, btrtl_dev);
+
+ return ret;
+err:
+ kfree(patch_image);
+ return ret;
+}
+
+static int rtlbt_parse_firmware_v3(struct hci_dev *hdev,
+ struct btrtl_device_info *btrtl_dev)
+{
+ struct rtl_epatch_header_v3 *hdr;
+ int rc;
+ u32 num_sections;
+ struct rtl_section_v3 *section;
+ u32 section_len;
+ u32 opcode;
+ int len = 0;
+ int i;
+ u8 *ptr;
+ struct rtl_iovec iov = {
+ .data = btrtl_dev->fw_data,
+ .len = btrtl_dev->fw_len,
+ };
+ struct rtl_vendor_cmd cmd_data = { {0x10, 0xa4, 0xad, 0x00, 0xb0} };
+ u8 reg_val[2];
+
+ if (btrtl_dev->project_id >= CHIP_ID_8922D) {
+ /* A0010DA4 */
+ cmd_data.param[2] = 0x0d;
+ cmd_data.param[3] = 0x01;
+ cmd_data.param[4] = 0xa0;
+ }
+
+ rc = btrtl_vendor_read_reg16(hdev, &cmd_data, reg_val);
+ if (rc < 0)
+ return -EIO;
+
+ rtl_dev_info(hdev, "key id %u", reg_val[0]);
+
+ btrtl_dev->key_id = reg_val[0];
+
+ hdr = rtl_iov_pull_data(&iov, sizeof(*hdr));
+ if (!hdr)
+ return -EINVAL;
+ num_sections = le32_to_cpu(hdr->num_sections);
+
+ rtl_dev_dbg(hdev, "timpstamp %08x-%08x", *((u32 *)hdr->timestamp),
+ *((u32 *)(hdr->timestamp + 4)));
+
+ for (i = 0; i < num_sections; i++) {
+ section = rtl_iov_pull_data(&iov, sizeof(*section));
+ if (!section)
+ break;
+
+ section_len = (u32)le64_to_cpu(section->len);
+ opcode = le32_to_cpu(section->opcode);
+
+ rtl_dev_dbg(hdev, "opcode 0x%04x", section->opcode);
+
+ ptr = rtl_iov_pull_data(&iov, section_len);
+ if (!ptr)
+ break;
+
+ rc = 0;
+ switch (opcode) {
+ case RTL_PATCH_V3_1:
+ case RTL_PATCH_V3_PATCH_IMAGE:
+ rc = rtlbt_parse_section_v3(hdev, btrtl_dev, opcode,
+ ptr, section_len);
+ break;
+ default:
+ rtl_dev_warn(hdev, "Unknown opcode %08x", opcode);
+ break;
+ }
+ if (rc < 0) {
+ rtl_dev_err(hdev, "Parse section (%u) err (%d)",
+ opcode, rc);
+ continue;
+ }
+ len += rc;
+ }
+
+ rtl_dev_info(hdev, "image payload total len: 0x%08x", len);
+ if (!len)
+ return -ENODATA;
+
return len;
}
@@ -673,6 +1052,9 @@ static int rtlbt_parse_firmware(struct hci_dev *hdev,
if (btrtl_dev->fw_len <= 8)
return -EINVAL;
+ if (!memcmp(btrtl_dev->fw_data, RTL_EPATCH_SIGNATURE_V3, 8))
+ return rtlbt_parse_firmware_v3(hdev, btrtl_dev);
+
if (!memcmp(btrtl_dev->fw_data, RTL_EPATCH_SIGNATURE, 8))
min_size = sizeof(struct rtl_epatch_header) +
sizeof(extension_sig) + 3;
@@ -808,10 +1190,11 @@ static int rtlbt_parse_firmware(struct hci_dev *hdev,
memcpy(buf + patch_length - 4, &epatch_info->fw_version, 4);
*_buf = buf;
+ btrtl_dev->fw_type = FW_TYPE_V1;
return len;
}
-static int rtl_download_firmware(struct hci_dev *hdev,
+static int rtl_download_firmware(struct hci_dev *hdev, u8 fw_type,
const unsigned char *data, int fw_len)
{
struct rtl_download_cmd *dl_cmd;
@@ -822,6 +1205,13 @@ static int rtl_download_firmware(struct hci_dev *hdev,
int j = 0;
struct sk_buff *skb;
struct hci_rp_read_local_version *rp;
+ u8 dl_rp_len = sizeof(struct rtl_download_response);
+
+ if (is_v3_fw(fw_type)) {
+ j = 1;
+ if (fw_type == FW_TYPE_V3_2)
+ dl_rp_len++;
+ }
dl_cmd = kmalloc(sizeof(*dl_cmd), GFP_KERNEL);
if (!dl_cmd)
@@ -834,7 +1224,7 @@ static int rtl_download_firmware(struct hci_dev *hdev,
if (dl_cmd->index == 0x7f)
j = 1;
- if (i == (frag_num - 1)) {
+ if (i == (frag_num - 1) && !is_v3_fw(fw_type)) {
dl_cmd->index |= 0x80; /* data end */
frag_len = fw_len % RTL_FRAG_LEN;
}
@@ -852,7 +1242,7 @@ static int rtl_download_firmware(struct hci_dev *hdev,
goto out;
}
- if (skb->len != sizeof(struct rtl_download_response)) {
+ if (skb->len != dl_rp_len) {
rtl_dev_err(hdev, "download fw event length mismatch");
kfree_skb(skb);
ret = -EIO;
@@ -863,6 +1253,9 @@ static int rtl_download_firmware(struct hci_dev *hdev,
data += RTL_FRAG_LEN;
}
+ if (is_v3_fw(fw_type))
+ goto out;
+
skb = btrtl_read_local_version(hdev);
if (IS_ERR(skb)) {
ret = PTR_ERR(skb);
@@ -880,6 +1273,226 @@ static int rtl_download_firmware(struct hci_dev *hdev,
return ret;
}
+static int rtl_check_download_state(struct hci_dev *hdev,
+ struct btrtl_device_info *btrtl_dev)
+{
+ struct sk_buff *skb;
+ int ret = 0;
+ u8 state;
+
+ skb = __hci_cmd_sync(hdev, 0xfdcf, 0, NULL, HCI_CMD_TIMEOUT);
+ if (IS_ERR(skb)) {
+ rtl_dev_err(hdev, "write tb error %lu", PTR_ERR(skb));
+ return -EIO;
+ }
+
+ /* Other driver might be downloading the combined firmware. */
+ state = skb->data[0];
+ kfree_skb(skb);
+ if (state == 0x03) {
+ btrealtek_set_flag(hdev, REALTEK_DOWNLOADING);
+ ret = btrealtek_wait_on_flag_timeout(hdev, REALTEK_DOWNLOADING,
+ TASK_INTERRUPTIBLE,
+ msecs_to_jiffies(5000));
+ if (ret == -EINTR) {
+ bt_dev_err(hdev, "Firmware loading interrupted");
+ return ret;
+ }
+
+ if (ret) {
+ bt_dev_err(hdev, "Firmware loading timeout");
+ return -ETIMEDOUT;
+ }
+
+ ret = -EALREADY;
+ }
+
+ return 0;
+}
+
+static int rtl_finalize_download(struct hci_dev *hdev,
+ struct btrtl_device_info *btrtl_dev)
+{
+ struct hci_rp_read_local_version *rp_ver;
+ u8 params[2] = { 0x03, 0xb2 };
+ struct sk_buff *skb;
+ u16 opcode;
+ u32 len;
+ int ret;
+
+ opcode = 0xfc8e;
+ len = 2;
+ if (btrtl_dev->opcode == RTL_PATCH_V3_1) {
+ opcode = 0xfc20;
+ params[0] = 0x80;
+ len = 1;
+ }
+ skb = __hci_cmd_sync(hdev, opcode, len, params, HCI_CMD_TIMEOUT);
+ if (IS_ERR(skb)) {
+ rtl_dev_err(hdev, "Watchdog reset err (%ld)", PTR_ERR(skb));
+ return -EIO;
+ }
+ rtl_dev_info(hdev, "Watchdog reset status %02x", skb->data[0]);
+ kfree_skb(skb);
+
+ skb = btrtl_read_local_version(hdev);
+ if (IS_ERR(skb)) {
+ ret = PTR_ERR(skb);
+ rtl_dev_err(hdev, "read local version failed (%d)", ret);
+ return ret;
+ }
+
+ rp_ver = (struct hci_rp_read_local_version *)skb->data;
+ rtl_dev_info(hdev, "fw version 0x%04x%04x",
+ __le16_to_cpu(rp_ver->hci_rev),
+ __le16_to_cpu(rp_ver->lmp_subver));
+ kfree_skb(skb);
+
+ return 0;
+}
+
+static int rtl_security_check(struct hci_dev *hdev,
+ struct btrtl_device_info *btrtl_dev)
+{
+ struct rtl_section_patch_image *tmp = NULL;
+ struct rtl_section_patch_image *image = NULL;
+ u32 val;
+ int ret;
+
+ list_for_each_entry_reverse(tmp, &btrtl_dev->patch_images, list) {
+ /* Check security hdr */
+ if (!tmp->fix[DL_FIX_SEC_HDR_ADDR].value ||
+ !tmp->fix[DL_FIX_SEC_HDR_ADDR].addr ||
+ tmp->fix[DL_FIX_SEC_HDR_ADDR].addr == 0xffffffff)
+ continue;
+ rtl_dev_info(hdev, "addr 0x%08x, value 0x%08x",
+ tmp->fix[DL_FIX_SEC_HDR_ADDR].addr,
+ tmp->fix[DL_FIX_SEC_HDR_ADDR].value);
+ image = tmp;
+ break;
+ }
+
+ if (!image)
+ return 0;
+
+ rtl_dev_info(hdev, "sec image (%04x:%02x)", image->image_id,
+ image->index);
+ val = image->fix[DL_FIX_PATCH_ADDR].value + image->image_len -
+ image->fix[DL_FIX_SEC_HDR_ADDR].value;
+ ret = btrtl_vendor_write_mem(hdev, image->fix[DL_FIX_PATCH_ADDR].addr,
+ val);
+ if (ret) {
+ rtl_dev_err(hdev, "write sec reg failed (%d)", ret);
+ return ret;
+ }
+ return 0;
+}
+
+static int rtl_download_firmware_v3(struct hci_dev *hdev,
+ struct btrtl_device_info *btrtl_dev)
+{
+ struct rtl_section_patch_image *image, *tmp;
+ struct rtl_rp_dl_v3 *rp;
+ struct sk_buff *skb;
+ u8 *fw_data;
+ int fw_len;
+ int ret = 0;
+ u8 i;
+
+ if (btrtl_dev->fw_type == FW_TYPE_V3_2) {
+ ret = rtl_check_download_state(hdev, btrtl_dev);
+ if (ret) {
+ if (ret == -EALREADY)
+ return 0;
+ return ret;
+ }
+ }
+
+ list_for_each_entry_safe(image, tmp, &btrtl_dev->patch_images, list) {
+ rtl_dev_dbg(hdev, "image (%04x:%02x)", image->image_id,
+ image->index);
+
+ for (i = DL_FIX_CI_ID; i < DL_FIX_ADDR_MAX; i++) {
+ if (!image->fix[i].addr ||
+ image->fix[i].addr == 0xffffffff) {
+ rtl_dev_dbg(hdev, "no need to write addr %08x",
+ image->fix[i].addr);
+ continue;
+ }
+ rtl_dev_dbg(hdev, "write addr and val, 0x%08x, 0x%08x",
+ image->fix[i].addr, image->fix[i].value);
+ if (btrtl_vendor_write_mem(hdev, image->fix[i].addr,
+ image->fix[i].value)) {
+ rtl_dev_err(hdev, "write reg failed");
+ ret = -EIO;
+ goto done;
+ }
+ }
+
+ fw_len = image->image_len + image->cfg_len;
+ fw_data = kvmalloc(fw_len, GFP_KERNEL);
+ if (!fw_data) {
+ rtl_dev_err(hdev, "Couldn't alloc buf for image data");
+ ret = -ENOMEM;
+ goto done;
+ }
+ memcpy(fw_data, image->image_data, image->image_len);
+ if (image->cfg_len > 0)
+ memcpy(fw_data + image->image_len, image->cfg_buf,
+ image->cfg_len);
+
+ rtl_dev_dbg(hdev, "patch image (%04x:%02x). len: %d",
+ image->image_id, image->index, fw_len);
+ rtl_dev_dbg(hdev, "fw_data %p, image buf %p, len %u", fw_data,
+ image->image_data, image->image_len);
+
+ ret = rtl_download_firmware(hdev, btrtl_dev->fw_type, fw_data,
+ fw_len);
+ kvfree(fw_data);
+ if (ret < 0) {
+ rtl_dev_err(hdev, "download firmware failed (%d)", ret);
+ goto done;
+ }
+
+ if (image->list.next != &btrtl_dev->patch_images &&
+ image->image_id == tmp->image_id)
+ continue;
+
+ if (btrtl_dev->fw_type == FW_TYPE_V3_1)
+ continue;
+
+ i = 0x80;
+ skb = __hci_cmd_sync(hdev, 0xfc20, 1, &i, HCI_CMD_TIMEOUT);
+ if (IS_ERR(skb)) {
+ ret = -EIO;
+ rtl_dev_err(hdev, "Failed to issue last cmd fc20, %ld",
+ PTR_ERR(skb));
+ goto done;
+ }
+ rp = (void *)skb->data;
+ ret = rp->err;
+ kfree_skb(skb);
+ if (ret == 2) {
+ /* Verification failure */
+ ret = -EFAULT;
+ goto done;
+ }
+ }
+
+ if (btrtl_dev->fw_type == FW_TYPE_V3_1) {
+ ret = rtl_security_check(hdev, btrtl_dev);
+ if (ret) {
+ rtl_dev_err(hdev, "Security check failed (%d)", ret);
+ goto done;
+ }
+ }
+
+ ret = rtl_finalize_download(hdev, btrtl_dev);
+
+done:
+ return ret;
+}
+
static int rtl_load_file(struct hci_dev *hdev, const char *name, u8 **buff)
{
const struct firmware *fw;
@@ -913,7 +1526,7 @@ static int btrtl_setup_rtl8723a(struct hci_dev *hdev,
return -EINVAL;
}
- return rtl_download_firmware(hdev, btrtl_dev->fw_data,
+ return rtl_download_firmware(hdev, FW_TYPE_V0, btrtl_dev->fw_data,
btrtl_dev->fw_len);
}
@@ -928,7 +1541,7 @@ static int btrtl_setup_rtl8723b(struct hci_dev *hdev,
if (ret < 0)
goto out;
- if (btrtl_dev->cfg_len > 0) {
+ if (!is_v3_fw(btrtl_dev->fw_type) && btrtl_dev->cfg_len > 0) {
tbuff = kvzalloc(ret + btrtl_dev->cfg_len, GFP_KERNEL);
if (!tbuff) {
ret = -ENOMEM;
@@ -944,9 +1557,14 @@ static int btrtl_setup_rtl8723b(struct hci_dev *hdev,
fw_data = tbuff;
}
+ if (is_v3_fw(btrtl_dev->fw_type)) {
+ ret = rtl_download_firmware_v3(hdev, btrtl_dev);
+ goto out;
+ }
+
rtl_dev_info(hdev, "cfg_sz %d, total sz %d", btrtl_dev->cfg_len, ret);
- ret = rtl_download_firmware(hdev, fw_data, ret);
+ ret = rtl_download_firmware(hdev, btrtl_dev->fw_type, fw_data, ret);
out:
kvfree(fw_data);
@@ -1042,6 +1660,7 @@ static int rtl_read_chip_type(struct hci_dev *hdev, u8 *type)
void btrtl_free(struct btrtl_device_info *btrtl_dev)
{
struct rtl_subsection *entry, *tmp;
+ struct rtl_section_patch_image *image, *next;
kvfree(btrtl_dev->fw_data);
kvfree(btrtl_dev->cfg_data);
@@ -1051,6 +1670,15 @@ void btrtl_free(struct btrtl_device_info *btrtl_dev)
kfree(entry);
}
+ list_for_each_entry_safe(image, next, &btrtl_dev->patch_images, list) {
+ list_del(&image->list);
+ if (image->image_data)
+ kvfree(image->image_data);
+ if (image->cfg_buf)
+ kvfree(image->cfg_buf);
+ kfree(image);
+ }
+
kfree(btrtl_dev);
}
EXPORT_SYMBOL_GPL(btrtl_free);
@@ -1058,7 +1686,7 @@ EXPORT_SYMBOL_GPL(btrtl_free);
struct btrtl_device_info *btrtl_initialize(struct hci_dev *hdev,
const char *postfix)
{
- struct btrealtek_data *coredump_info = hci_get_priv(hdev);
+ struct btrealtek_data *btrtl_data = hci_get_priv(hdev);
struct btrtl_device_info *btrtl_dev;
struct sk_buff *skb;
struct hci_rp_read_local_version *resp;
@@ -1069,6 +1697,7 @@ struct btrtl_device_info *btrtl_initialize(struct hci_dev *hdev,
u8 hci_ver, lmp_ver, chip_type = 0;
int ret;
u8 reg_val[2];
+ u8 chip_id = 0;
btrtl_dev = kzalloc(sizeof(*btrtl_dev), GFP_KERNEL);
if (!btrtl_dev) {
@@ -1077,8 +1706,14 @@ struct btrtl_device_info *btrtl_initialize(struct hci_dev *hdev,
}
INIT_LIST_HEAD(&btrtl_dev->patch_subsecs);
+ INIT_LIST_HEAD(&btrtl_dev->patch_images);
check_version:
+ ret = btrtl_read_chip_id(hdev, &chip_id);
+ if (!ret && chip_id == CHIP_ID_8922D) {
+ btrtl_dev->project_id = chip_id;
+ goto read_local_ver;
+
ret = btrtl_vendor_read_reg16(hdev, RTL_CHIP_SUBVER, reg_val);
if (ret < 0)
goto err_free;
@@ -1101,6 +1736,7 @@ struct btrtl_device_info *btrtl_initialize(struct hci_dev *hdev,
}
}
+read_local_ver:
skb = btrtl_read_local_version(hdev);
if (IS_ERR(skb)) {
ret = PTR_ERR(skb);
@@ -1228,7 +1864,7 @@ struct btrtl_device_info *btrtl_initialize(struct hci_dev *hdev,
hci_set_msft_opcode(hdev, 0xFCF0);
if (btrtl_dev->ic_info)
- coredump_info->rtl_dump.controller = btrtl_dev->ic_info->hw_info;
+ btrtl_data->rtl_dump.controller = btrtl_dev->ic_info->hw_info;
return btrtl_dev;
@@ -1301,6 +1937,7 @@ void btrtl_set_quirks(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev)
case CHIP_ID_8851B:
case CHIP_ID_8922A:
case CHIP_ID_8852BT:
+ case CHIP_ID_8922D:
set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
/* RTL8852C needs to transmit mSBC data continuously without
@@ -1387,6 +2024,23 @@ int btrtl_shutdown_realtek(struct hci_dev *hdev)
}
EXPORT_SYMBOL_GPL(btrtl_shutdown_realtek);
+int btrtl_recv_event(struct hci_dev *hdev, struct sk_buff *skb)
+{
+ struct hci_event_hdr *hdr = (void *)skb->data;
+
+ if (skb->len > HCI_EVENT_HDR_SIZE && hdr->evt == 0xff &&
+ hdr->plen > 0) {
+ if (skb->data[2] == 0x77 &&
+ btrealtek_test_and_clear_flag(hdev, REALTEK_DOWNLOADING)) {
+ btrealtek_wake_up_flag(hdev, REALTEK_DOWNLOADING);
+ return 0;
+ }
+ }
+
+ return hci_recv_frame(hdev, skb);
+}
+EXPORT_SYMBOL_GPL(btrtl_recv_event);
+
static unsigned int btrtl_convert_baudrate(u32 device_baudrate)
{
switch (device_baudrate) {
diff --git a/drivers/bluetooth/btrtl.h b/drivers/bluetooth/btrtl.h
index a2d9d34f9fb0..ea3537b9d4fd 100644
--- a/drivers/bluetooth/btrtl.h
+++ b/drivers/bluetooth/btrtl.h
@@ -12,6 +12,19 @@
#define rtl_dev_info(dev, fmt, ...) bt_dev_info(dev, "RTL: " fmt, ##__VA_ARGS__)
#define rtl_dev_dbg(dev, fmt, ...) bt_dev_dbg(dev, "RTL: " fmt, ##__VA_ARGS__)
+#define FW_TYPE_V0 0
+#define FW_TYPE_V1 1
+#define FW_TYPE_V2 2
+#define FW_TYPE_V3_1 3
+#define FW_TYPE_V3_2 4
+#define is_v3_fw(type) (type == FW_TYPE_V3_1 || type == FW_TYPE_V3_2)
+
+#define DL_FIX_CI_ID 0
+#define DL_FIX_CI_ADDR 1
+#define DL_FIX_PATCH_ADDR 2
+#define DL_FIX_SEC_HDR_ADDR 3
+#define DL_FIX_ADDR_MAX 4
+
struct btrtl_device_info;
struct rtl_chip_type_evt {
@@ -103,8 +116,79 @@ struct rtl_vendor_cmd {
__u8 param[5];
} __packed;
+struct rtl_vendor_write_cmd {
+ u8 type;
+ __le32 addr;
+ __le32 val;
+} __packed;
+
+struct rtl_rp_read_chip_id {
+ __u8 status;
+ __u8 chip_id;
+} __packed;
+
+struct rtl_rp_dl_v3 {
+ __u8 status;
+ __u8 index;
+ __u8 err;
+} __packed;
+
+struct rtl_epatch_header_v3 {
+ __u8 signature[8];
+ __u8 timestamp[8];
+ __le32 ver_rsvd;
+ __le32 num_sections;
+} __packed;
+
+struct rtl_section_v3 {
+ __le32 opcode;
+ __le64 len;
+ u8 data[];
+} __packed;
+
+struct rtl_addr_fix {
+ u32 addr;
+ u32 value;
+};
+
+struct rtl_section_patch_image {
+ u16 image_id;
+ u8 index;
+ u8 config_rule;
+ u8 need_config;
+
+ struct rtl_addr_fix fix[DL_FIX_ADDR_MAX];
+
+ u32 image_len;
+ u8 *image_data;
+ u32 image_ver;
+
+ u8 *cfg_buf;
+ u16 cfg_len;
+
+ struct list_head list;
+};
+
+struct rtl_patch_image_hdr {
+ __le16 chip_id;
+ u8 ic_cut;
+ u8 key_id;
+ u8 enable_ota;
+ __le16 image_id;
+ u8 config_rule;
+ u8 need_config;
+ u8 rsv[950];
+
+ __le64 addr_fix[DL_FIX_ADDR_MAX * 2];
+ u8 index;
+
+ __le64 patch_image_len;
+ __u8 data[];
+} __packed;
+
enum {
REALTEK_ALT6_CONTINUOUS_TX_CHIP,
+ REALTEK_DOWNLOADING,
__REALTEK_NUM_FLAGS,
};
@@ -130,8 +214,20 @@ struct btrealtek_data {
#define btrealtek_get_flag(hdev) \
(((struct btrealtek_data *)hci_get_priv(hdev))->flags)
+#define btrealtek_wake_up_flag(hdev, nr) \
+ do { \
+ struct btrealtek_data *rtl = hci_get_priv((hdev)); \
+ wake_up_bit(rtl->flags, (nr)); \
+ } while (0)
+
#define btrealtek_test_flag(hdev, nr) test_bit((nr), btrealtek_get_flag(hdev))
+#define btrealtek_test_and_clear_flag(hdev, nr) \
+ test_and_clear_bit((nr), btrealtek_get_flag(hdev))
+
+#define btrealtek_wait_on_flag_timeout(hdev, nr, m, to) \
+ wait_on_bit_timeout(btrealtek_get_flag(hdev), (nr), m, to)
+
#if IS_ENABLED(CONFIG_BT_RTL)
struct btrtl_device_info *btrtl_initialize(struct hci_dev *hdev,
@@ -148,6 +244,7 @@ int btrtl_get_uart_settings(struct hci_dev *hdev,
unsigned int *controller_baudrate,
u32 *device_baudrate, bool *flow_control);
void btrtl_set_driver_name(struct hci_dev *hdev, const char *driver_name);
+int btrtl_recv_event(struct hci_dev *hdev, struct sk_buff *skb);
#else
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 3016ee9f2932..08ec38917850 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -2674,6 +2674,9 @@ static int btusb_recv_event_realtek(struct hci_dev *hdev, struct sk_buff *skb)
return 0;
}
+ if (skb->data[0] == HCI_VENDOR_PKT)
+ return btrtl_recv_event(hdev, skb);
+
return hci_recv_frame(hdev, skb);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] Bluetooth: btrtl: Add enhanced download support
2025-05-29 12:48 [PATCH 0/2] Bluetooth: Add support for RTK firmware version 3 and enhanced ACL-based download acceleration Hilda Wu
2025-05-29 12:48 ` [PATCH 1/2] Bluetooth: btrtl: Firmware format v3 support Hilda Wu
@ 2025-05-29 12:48 ` Hilda Wu
2025-05-30 11:49 ` kernel test robot
1 sibling, 1 reply; 7+ messages in thread
From: Hilda Wu @ 2025-05-29 12:48 UTC (permalink / raw)
To: marcel; +Cc: luiz.dentz, linux-bluetooth, linux-kernel, max.chou, alex_lu
Add an enhanced download mode for firmware format v3.
Use ACL to speed up firmware downloads.
Signed-off-by: Alex Lu <alex_lu@realsil.com.cn>
Signed-off-by: Hilda Wu <hildawu@realtek.com>
---
drivers/bluetooth/btrtl.c | 205 +++++++++++++++++++++++++++++++++++++-
drivers/bluetooth/btrtl.h | 5 +
2 files changed, 208 insertions(+), 2 deletions(-)
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 0e6332a45ced..2c6239091a68 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -108,6 +108,8 @@ struct btrtl_device_info {
u32 opcode;
u8 fw_type;
u8 key_id;
+ u16 handle;
+ u16 acldata_pkt_len;
struct list_head patch_subsecs;
struct list_head patch_images;
};
@@ -1310,6 +1312,178 @@ static int rtl_check_download_state(struct hci_dev *hdev,
return 0;
}
+struct hci_rp_enhanced_download_mode {
+ __u8 status;
+ __u8 reserved1;
+ __le16 handle;
+ __le16 acldata_pkt_len;
+ __u8 reserved2;
+} __packed;
+
+static int btrtl_enhanced_download_mode_enable(struct hci_dev *hdev,
+ struct btrtl_device_info *btrtl_dev)
+{
+ struct hci_rp_enhanced_download_mode *ev;
+ struct sk_buff *skb;
+ u16 opcode = 0xfc1f;
+ u8 val = 1;
+ int ret = -EINVAL;
+
+ skb = __hci_cmd_sync(hdev, opcode, 1, &val, HCI_CMD_TIMEOUT);
+ if (IS_ERR(skb)) {
+ bt_dev_err(hdev, "send %04x error (%lu)", opcode, PTR_ERR(skb));
+ return -EIO;
+ }
+ if (skb->len != sizeof(*ev)) {
+ bt_dev_err(hdev, "got invalid cmd complete, %u %lu", skb->len,
+ sizeof(*ev));
+ goto err;
+ }
+ ev = (struct hci_rp_enhanced_download_mode *)skb->data;
+ if (ev->status) {
+ bt_dev_err(hdev, "got invalid status 0x%02x", ev->status);
+ goto err;
+ }
+ btrtl_dev->handle = le16_to_cpu(ev->handle);
+ btrtl_dev->acldata_pkt_len = le16_to_cpu(ev->acldata_pkt_len);
+ kfree_skb(skb);
+
+ bt_dev_info(hdev, "enhanced download mode enabled, handle %04x, acl %u",
+ btrtl_dev->handle, btrtl_dev->acldata_pkt_len);
+
+ return 0;
+err:
+ kfree_skb(skb);
+ return ret;
+}
+
+struct rtl_acl_download_rp {
+ __u8 subevent;
+ __u8 index;
+ __le16 handle;
+ __le32 loaded_len;
+} __packed;
+
+static int rtl_acl_download_firmware(struct hci_dev *hdev,
+ struct btrtl_device_info *btrtl_dev,
+ const unsigned char *data, int fw_len)
+{
+ struct btrealtek_data *btrtl_data = hci_get_priv(hdev);
+ int frag_num = fw_len / RTL_FRAG_LEN + 1;
+ int frag_len = RTL_FRAG_LEN;
+ int ret = 0;
+ int i;
+ int j = 0;
+ struct sk_buff *skb;
+ struct rtl_acl_download_rp *rp;
+ u16 max_payload_len;
+ struct hci_acl_hdr *hdr;
+ u8 index;
+
+ if (is_v3_fw(btrtl_dev->fw_type))
+ j = 1;
+
+ btrtl_data->dlreq_status = 0;
+ btrtl_data->dlreq_result = 0;
+ btrtl_data->dlreq_rsp = NULL;
+ max_payload_len = (btrtl_dev->acldata_pkt_len - 1) & ~0x3;
+
+ for (i = 0; i < frag_num; i++) {
+ index = j++;
+ if (index == 0x7f)
+ j = 1;
+
+ if (i == (frag_num - 1) && !is_v3_fw(btrtl_dev->fw_type)) {
+ index |= 0x80; /* data end */
+ frag_len = fw_len % max_payload_len;
+ }
+ rtl_dev_dbg(hdev, "acl download fw (%d/%d). index = %d", i,
+ frag_num, index);
+
+ skb = bt_skb_alloc(sizeof(*hdr) + 1 + frag_len, GFP_KERNEL);
+ if (!skb)
+ return -ENOMEM;
+ hdr = (struct hci_acl_hdr *)skb_put(skb, sizeof(*hdr));
+ hdr->handle = cpu_to_le16(btrtl_dev->handle | 0x8000);
+ hdr->dlen = cpu_to_le16(1 + frag_len);
+ *(u8 *)skb_put(skb, 1) = index;
+ memcpy(skb_put(skb, frag_len), data, frag_len);
+
+ hci_skb_pkt_type(skb) = HCI_ACLDATA_PKT;
+
+ btrtl_data->dlreq_status = HCI_REQ_PEND;
+
+ ret = hdev->send(hdev, skb);
+ if (ret < 0) {
+ bt_dev_err(hdev, "sending frame failed (%d)", ret);
+ goto err;
+ }
+
+ ret = wait_event_interruptible_timeout(btrtl_data->dlreq_wait_q,
+ btrtl_data->dlreq_status != HCI_REQ_PEND,
+ HCI_INIT_TIMEOUT);
+ if (ret == -ERESTARTSYS)
+ goto out;
+
+ switch (btrtl_data->dlreq_status) {
+ case HCI_REQ_DONE:
+ ret = -bt_to_errno(btrtl_data->dlreq_result);
+ break;
+
+ case HCI_REQ_CANCELED:
+ ret = -btrtl_data->dlreq_result;
+ break;
+
+ default:
+ ret = -ETIMEDOUT;
+ break;
+ }
+
+ btrtl_data->dlreq_status = 0;
+ btrtl_data->dlreq_result = 0;
+ skb = btrtl_data->dlreq_rsp;
+ btrtl_data->dlreq_rsp = NULL;
+
+ bt_dev_dbg(hdev, "end: err %d", ret);
+
+ if (ret < 0) {
+ bt_dev_err(hdev, "wait on complete err (%d)", ret);
+ goto err;
+ }
+
+ if (!skb)
+ return -ENODATA;
+
+ if (skb->len != sizeof(*rp)) {
+ rtl_dev_err(hdev, "acl download fw event len mismatch");
+ ret = -EIO;
+ goto err;
+ }
+ rp = (struct rtl_acl_download_rp *)skb->data;
+ if ((btrtl_dev->handle & 0xfff) != le16_to_cpu(rp->handle)) {
+ rtl_dev_err(hdev, "handle mismatch (%04x %04x)",
+ btrtl_dev->handle & 0xfff,
+ le16_to_cpu(rp->handle));
+ ret = -EINVAL;
+ goto err;
+ }
+ if (index != rp->index) {
+ rtl_dev_err(hdev, "index mismatch (%u, %u)", index,
+ rp->index);
+ ret = -EINVAL;
+ goto err;
+ }
+
+ kfree_skb(skb);
+ data += frag_len;
+ }
+out:
+ return ret;
+err:
+ kfree_skb(skb);
+ return ret;
+}
+
static int rtl_finalize_download(struct hci_dev *hdev,
struct btrtl_device_info *btrtl_dev)
{
@@ -1394,6 +1568,7 @@ static int rtl_download_firmware_v3(struct hci_dev *hdev,
struct rtl_section_patch_image *image, *tmp;
struct rtl_rp_dl_v3 *rp;
struct sk_buff *skb;
+ u8 enh_dl = 0;
u8 *fw_data;
int fw_len;
int ret = 0;
@@ -1408,6 +1583,16 @@ static int rtl_download_firmware_v3(struct hci_dev *hdev,
}
}
+ switch (btrtl_dev->project_id) {
+ case CHIP_ID_8852C:
+ case CHIP_ID_8922D:
+ if (!btrtl_enhanced_download_mode_enable(hdev, btrtl_dev))
+ enh_dl = 1;
+ break;
+ default:
+ break;
+ }
+
list_for_each_entry_safe(image, tmp, &btrtl_dev->patch_images, list) {
rtl_dev_dbg(hdev, "image (%04x:%02x)", image->image_id,
image->index);
@@ -1446,8 +1631,13 @@ static int rtl_download_firmware_v3(struct hci_dev *hdev,
rtl_dev_dbg(hdev, "fw_data %p, image buf %p, len %u", fw_data,
image->image_data, image->image_len);
- ret = rtl_download_firmware(hdev, btrtl_dev->fw_type, fw_data,
- fw_len);
+ if (enh_dl)
+ ret = rtl_acl_download_firmware(hdev, btrtl_dev,
+ fw_data, fw_len);
+ else
+ ret = rtl_download_firmware(hdev, btrtl_dev->fw_type,
+ fw_data, fw_len);
+
kvfree(fw_data);
if (ret < 0) {
rtl_dev_err(hdev, "download firmware failed (%d)", ret);
@@ -1707,6 +1897,7 @@ struct btrtl_device_info *btrtl_initialize(struct hci_dev *hdev,
INIT_LIST_HEAD(&btrtl_dev->patch_subsecs);
INIT_LIST_HEAD(&btrtl_dev->patch_images);
+ init_waitqueue_head(&btrtl_data->dlreq_wait_q);
check_version:
ret = btrtl_read_chip_id(hdev, &chip_id);
@@ -2026,6 +2217,7 @@ EXPORT_SYMBOL_GPL(btrtl_shutdown_realtek);
int btrtl_recv_event(struct hci_dev *hdev, struct sk_buff *skb)
{
+ struct btrealtek_data *btrtl_data = hci_get_priv(hdev);
struct hci_event_hdr *hdr = (void *)skb->data;
if (skb->len > HCI_EVENT_HDR_SIZE && hdr->evt == 0xff &&
@@ -2034,6 +2226,15 @@ int btrtl_recv_event(struct hci_dev *hdev, struct sk_buff *skb)
btrealtek_test_and_clear_flag(hdev, REALTEK_DOWNLOADING)) {
btrealtek_wake_up_flag(hdev, REALTEK_DOWNLOADING);
return 0;
+ } else if (skb->data[2] == 0x2a) {
+ if (btrtl_data->dlreq_status == HCI_REQ_PEND) {
+ btrtl_data->dlreq_result = 0;
+ btrtl_data->dlreq_status = HCI_REQ_DONE;
+ skb_pull(skb, sizeof(*hdr));
+ btrtl_data->dlreq_rsp = skb;
+ wake_up_interruptible(&btrtl_data->dlreq_wait_q);
+ }
+ return 0;
}
}
diff --git a/drivers/bluetooth/btrtl.h b/drivers/bluetooth/btrtl.h
index ea3537b9d4fd..781ac845944e 100644
--- a/drivers/bluetooth/btrtl.h
+++ b/drivers/bluetooth/btrtl.h
@@ -203,6 +203,11 @@ struct btrealtek_data {
DECLARE_BITMAP(flags, __REALTEK_NUM_FLAGS);
struct rtl_dump_info rtl_dump;
+
+ wait_queue_head_t dlreq_wait_q;
+ __u32 dlreq_status;
+ __u32 dlreq_result;
+ struct sk_buff *dlreq_rsp;
};
#define btrealtek_set_flag(hdev, nr) \
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: Bluetooth: Add support for RTK firmware version 3 and enhanced ACL-based download acceleration
2025-05-29 12:48 ` [PATCH 1/2] Bluetooth: btrtl: Firmware format v3 support Hilda Wu
@ 2025-05-29 13:26 ` bluez.test.bot
2025-05-29 23:49 ` [PATCH 1/2] Bluetooth: btrtl: Firmware format v3 support kernel test robot
1 sibling, 0 replies; 7+ messages in thread
From: bluez.test.bot @ 2025-05-29 13:26 UTC (permalink / raw)
To: linux-bluetooth, hildawu
[-- Attachment #1: Type: text/plain, Size: 42621 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=967329
---Test result---
Test Summary:
CheckPatch PENDING 0.38 seconds
GitLint PENDING 0.32 seconds
SubjectPrefix PASS 0.12 seconds
BuildKernel FAIL 24.60 seconds
CheckAllWarning FAIL 26.66 seconds
CheckSparse FAIL 29.59 seconds
BuildKernel32 FAIL 24.22 seconds
TestRunnerSetup PASS 460.63 seconds
TestRunner_l2cap-tester PASS 25.07 seconds
TestRunner_iso-tester PASS 39.77 seconds
TestRunner_bnep-tester PASS 5.89 seconds
TestRunner_mgmt-tester FAIL 134.98 seconds
TestRunner_rfcomm-tester PASS 9.41 seconds
TestRunner_sco-tester PASS 14.54 seconds
TestRunner_ioctl-tester PASS 10.16 seconds
TestRunner_mesh-tester PASS 7.71 seconds
TestRunner_smp-tester PASS 8.44 seconds
TestRunner_userchan-tester PASS 6.00 seconds
IncrementalBuild PENDING 1.03 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: BuildKernel - FAIL
Desc: Build Kernel for Bluetooth
Output:
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c: In function ‘btrtl_initialize’:
drivers/bluetooth/btrtl.c:2110:19: error: non-static declaration of ‘btrtl_download_firmware’ follows static declaration
2110 | EXPORT_SYMBOL_GPL(btrtl_download_firmware);
| ^~~~~~~~~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2110:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2110 | EXPORT_SYMBOL_GPL(btrtl_download_firmware);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2069:5: note: previous definition of ‘btrtl_download_firmware’ was here
2069 | int btrtl_download_firmware(struct hci_dev *hdev,
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2169:19: error: non-static declaration of ‘btrtl_set_quirks’ follows static declaration
2169 | EXPORT_SYMBOL_GPL(btrtl_set_quirks);
| ^~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2169:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2169 | EXPORT_SYMBOL_GPL(btrtl_set_quirks);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2112:6: note: previous definition of ‘btrtl_set_quirks’ was here
2112 | void btrtl_set_quirks(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev)
| ^~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2196:19: error: non-static declaration of ‘btrtl_setup_realtek’ follows static declaration
2196 | EXPORT_SYMBOL_GPL(btrtl_setup_realtek);
| ^~~~~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2196:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2196 | EXPORT_SYMBOL_GPL(btrtl_setup_realtek);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2171:5: note: previous definition of ‘btrtl_setup_realtek’ was here
2171 | int btrtl_setup_realtek(struct hci_dev *hdev)
| ^~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2216:19: error: non-static declaration of ‘btrtl_shutdown_realtek’ follows static declaration
2216 | EXPORT_SYMBOL_GPL(btrtl_shutdown_realtek);
| ^~~~~~~~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2216:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2216 | EXPORT_SYMBOL_GPL(btrtl_shutdown_realtek);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2198:5: note: previous definition of ‘btrtl_shutdown_realtek’ was here
2198 | int btrtl_shutdown_realtek(struct hci_dev *hdev)
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2243:19: error: non-static declaration of ‘btrtl_recv_event’ follows static declaration
2243 | EXPORT_SYMBOL_GPL(btrtl_recv_event);
| ^~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2243:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2243 | EXPORT_SYMBOL_GPL(btrtl_recv_event);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2218:5: note: previous definition of ‘btrtl_recv_event’ was here
2218 | int btrtl_recv_event(struct hci_dev *hdev, struct sk_buff *skb)
| ^~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2245:21: error: invalid storage class for function ‘btrtl_convert_baudrate’
2245 | static unsigned int btrtl_convert_baudrate(u32 device_baudrate)
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2351:19: error: non-static declaration of ‘btrtl_get_uart_settings’ follows static declaration
2351 | EXPORT_SYMBOL_GPL(btrtl_get_uart_settings);
| ^~~~~~~~~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2351:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2351 | EXPORT_SYMBOL_GPL(btrtl_get_uart_settings);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2282:5: note: previous definition of ‘btrtl_get_uart_settings’ was here
2282 | int btrtl_get_uart_settings(struct hci_dev *hdev,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2404:1: error: expected declaration or statement at end of input
2404 | MODULE_FIRMWARE("rtl_bt/rtl8922au_config.bin");
| ^~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2404: error: control reaches end of non-void function [-Werror=return-type]
2404 | MODULE_FIRMWARE("rtl_bt/rtl8922au_config.bin");
|
cc1: some warnings being treated as errors
make[4]: *** [scripts/Makefile.build:203: drivers/bluetooth/btrtl.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:461: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:461: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:2003: .] Error 2
make: *** [Makefile:248: __sub-make] Error 2
##############################
Test: CheckAllWarning - FAIL
Desc: Run linux kernel with all warning enabled
Output:
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c: In function ‘btrtl_initialize’:
drivers/bluetooth/btrtl.c:2110:19: error: non-static declaration of ‘btrtl_download_firmware’ follows static declaration
2110 | EXPORT_SYMBOL_GPL(btrtl_download_firmware);
| ^~~~~~~~~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2110:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2110 | EXPORT_SYMBOL_GPL(btrtl_download_firmware);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2069:5: note: previous definition of ‘btrtl_download_firmware’ was here
2069 | int btrtl_download_firmware(struct hci_dev *hdev,
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2169:19: error: non-static declaration of ‘btrtl_set_quirks’ follows static declaration
2169 | EXPORT_SYMBOL_GPL(btrtl_set_quirks);
| ^~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2169:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2169 | EXPORT_SYMBOL_GPL(btrtl_set_quirks);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2112:6: note: previous definition of ‘btrtl_set_quirks’ was here
2112 | void btrtl_set_quirks(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev)
| ^~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2196:19: error: non-static declaration of ‘btrtl_setup_realtek’ follows static declaration
2196 | EXPORT_SYMBOL_GPL(btrtl_setup_realtek);
| ^~~~~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2196:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2196 | EXPORT_SYMBOL_GPL(btrtl_setup_realtek);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2171:5: note: previous definition of ‘btrtl_setup_realtek’ was here
2171 | int btrtl_setup_realtek(struct hci_dev *hdev)
| ^~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2216:19: error: non-static declaration of ‘btrtl_shutdown_realtek’ follows static declaration
2216 | EXPORT_SYMBOL_GPL(btrtl_shutdown_realtek);
| ^~~~~~~~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2216:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2216 | EXPORT_SYMBOL_GPL(btrtl_shutdown_realtek);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2198:5: note: previous definition of ‘btrtl_shutdown_realtek’ was here
2198 | int btrtl_shutdown_realtek(struct hci_dev *hdev)
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2243:19: error: non-static declaration of ‘btrtl_recv_event’ follows static declaration
2243 | EXPORT_SYMBOL_GPL(btrtl_recv_event);
| ^~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2243:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2243 | EXPORT_SYMBOL_GPL(btrtl_recv_event);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2218:5: note: previous definition of ‘btrtl_recv_event’ was here
2218 | int btrtl_recv_event(struct hci_dev *hdev, struct sk_buff *skb)
| ^~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2245:21: error: invalid storage class for function ‘btrtl_convert_baudrate’
2245 | static unsigned int btrtl_convert_baudrate(u32 device_baudrate)
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2351:19: error: non-static declaration of ‘btrtl_get_uart_settings’ follows static declaration
2351 | EXPORT_SYMBOL_GPL(btrtl_get_uart_settings);
| ^~~~~~~~~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2351:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2351 | EXPORT_SYMBOL_GPL(btrtl_get_uart_settings);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2282:5: note: previous definition of ‘btrtl_get_uart_settings’ was here
2282 | int btrtl_get_uart_settings(struct hci_dev *hdev,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2404:1: error: expected declaration or statement at end of input
2404 | MODULE_FIRMWARE("rtl_bt/rtl8922au_config.bin");
| ^~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2404: error: control reaches end of non-void function [-Werror=return-type]
2404 | MODULE_FIRMWARE("rtl_bt/rtl8922au_config.bin");
|
cc1: some warnings being treated as errors
make[4]: *** [scripts/Makefile.build:203: drivers/bluetooth/btrtl.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:461: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:461: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:2003: .] Error 2
make: *** [Makefile:248: __sub-make] Error 2
##############################
Test: CheckSparse - FAIL
Desc: Run sparse tool with linux kernel
Output:
net/bluetooth/af_bluetooth.c:248:25: warning: context imbalance in 'bt_accept_enqueue' - different lock contexts for basic block
net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):
./include/net/bluetooth/hci.h:2653:47: warning: array of flexible structures
./include/net/bluetooth/hci.h:2739:43: warning: array of flexible structures
drivers/bluetooth/hci_ag6xx.c:257:24: warning: restricted __le32 degrades to integer
drivers/bluetooth/hci_mrvl.c:170:23: warning: restricted __le16 degrades to integer
drivers/bluetooth/hci_mrvl.c:203:23: warning: restricted __le16 degrades to integer
net/bluetooth/hci_codec.c: note: in included file:
./include/net/bluetooth/hci_core.h:148:35: warning: array of flexible structures
net/bluetooth/sco.c: note: in included file:
./include/net/bluetooth/hci_core.h:148:35: warning: array of flexible structures
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c: In function ‘btrtl_initialize’:
drivers/bluetooth/btrtl.c:2110:19: error: non-static declaration of ‘btrtl_download_firmware’ follows static declaration
2110 | EXPORT_SYMBOL_GPL(btrtl_download_firmware);
| ^~~~~~~~~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2110:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2110 | EXPORT_SYMBOL_GPL(btrtl_download_firmware);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2069:5: note: previous definition of ‘btrtl_download_firmware’ was here
2069 | int btrtl_download_firmware(struct hci_dev *hdev,
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2169:19: error: non-static declaration of ‘btrtl_set_quirks’ follows static declaration
2169 | EXPORT_SYMBOL_GPL(btrtl_set_quirks);
| ^~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2169:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2169 | EXPORT_SYMBOL_GPL(btrtl_set_quirks);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2112:6: note: previous definition of ‘btrtl_set_quirks’ was here
2112 | void btrtl_set_quirks(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev)
| ^~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2196:19: error: non-static declaration of ‘btrtl_setup_realtek’ follows static declaration
2196 | EXPORT_SYMBOL_GPL(btrtl_setup_realtek);
| ^~~~~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2196:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2196 | EXPORT_SYMBOL_GPL(btrtl_setup_realtek);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2171:5: note: previous definition of ‘btrtl_setup_realtek’ was here
2171 | int btrtl_setup_realtek(struct hci_dev *hdev)
| ^~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2216:19: error: non-static declaration of ‘btrtl_shutdown_realtek’ follows static declaration
2216 | EXPORT_SYMBOL_GPL(btrtl_shutdown_realtek);
| ^~~~~~~~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2216:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2216 | EXPORT_SYMBOL_GPL(btrtl_shutdown_realtek);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2198:5: note: previous definition of ‘btrtl_shutdown_realtek’ was here
2198 | int btrtl_shutdown_realtek(struct hci_dev *hdev)
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2243:19: error: non-static declaration of ‘btrtl_recv_event’ follows static declaration
2243 | EXPORT_SYMBOL_GPL(btrtl_recv_event);
| ^~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2243:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2243 | EXPORT_SYMBOL_GPL(btrtl_recv_event);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2218:5: note: previous definition of ‘btrtl_recv_event’ was here
2218 | int btrtl_recv_event(struct hci_dev *hdev, struct sk_buff *skb)
| ^~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2245:21: error: invalid storage class for function ‘btrtl_convert_baudrate’
2245 | static unsigned int btrtl_convert_baudrate(u32 device_baudrate)
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2351:19: error: non-static declaration of ‘btrtl_get_uart_settings’ follows static declaration
2351 | EXPORT_SYMBOL_GPL(btrtl_get_uart_settings);
| ^~~~~~~~~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2351:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2351 | EXPORT_SYMBOL_GPL(btrtl_get_uart_settings);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2282:5: note: previous definition of ‘btrtl_get_uart_settings’ was here
2282 | int btrtl_get_uart_settings(struct hci_dev *hdev,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2404:1: error: expected declaration or statement at end of input
2404 | MODULE_FIRMWARE("rtl_bt/rtl8922au_config.bin");
| ^~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2404: error: control reaches end of non-void function [-Werror=return-type]
2404 | MODULE_FIRMWARE("rtl_bt/rtl8922au_config.bin");
|
cc1: some warnings being treated as errors
make[4]: *** [scripts/Makefile.build:203: drivers/bluetooth/btrtl.o] Error 1
make[3]: *** [scripts/Makefile.build:461: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:461: drivers] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/github/workspace/src/src/Makefile:2003: .] Error 2
make: *** [Makefile:248: __sub-make] Error 2
##############################
Test: BuildKernel32 - FAIL
Desc: Build 32bit Kernel for Bluetooth
Output:
In file included from drivers/bluetooth/btrtl.c:13:
drivers/bluetooth/btrtl.c: In function ‘btrtl_enhanced_download_mode_enable’:
./include/net/bluetooth/bluetooth.h:281:9: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘unsigned int’ [-Wformat=]
281 | BT_ERR("%s: " fmt, bt_dev_name(hdev), ##__VA_ARGS__)
| ^~~~~~
./include/net/bluetooth/bluetooth.h:266:33: note: in definition of macro ‘BT_ERR’
266 | #define BT_ERR(fmt, ...) bt_err(fmt "\n", ##__VA_ARGS__)
| ^~~
drivers/bluetooth/btrtl.c:1338:3: note: in expansion of macro ‘bt_dev_err’
1338 | bt_dev_err(hdev, "got invalid cmd complete, %u %lu", skb->len,
| ^~~~~~~~~~
drivers/bluetooth/btrtl.c:1338:52: note: format string is defined here
1338 | bt_dev_err(hdev, "got invalid cmd complete, %u %lu", skb->len,
| ~~^
| |
| long unsigned int
| %u
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c: In function ‘btrtl_initialize’:
drivers/bluetooth/btrtl.c:2110:19: error: non-static declaration of ‘btrtl_download_firmware’ follows static declaration
2110 | EXPORT_SYMBOL_GPL(btrtl_download_firmware);
| ^~~~~~~~~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2110:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2110 | EXPORT_SYMBOL_GPL(btrtl_download_firmware);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2069:5: note: previous definition of ‘btrtl_download_firmware’ was here
2069 | int btrtl_download_firmware(struct hci_dev *hdev,
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2169:19: error: non-static declaration of ‘btrtl_set_quirks’ follows static declaration
2169 | EXPORT_SYMBOL_GPL(btrtl_set_quirks);
| ^~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2169:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2169 | EXPORT_SYMBOL_GPL(btrtl_set_quirks);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2112:6: note: previous definition of ‘btrtl_set_quirks’ was here
2112 | void btrtl_set_quirks(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev)
| ^~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2196:19: error: non-static declaration of ‘btrtl_setup_realtek’ follows static declaration
2196 | EXPORT_SYMBOL_GPL(btrtl_setup_realtek);
| ^~~~~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2196:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2196 | EXPORT_SYMBOL_GPL(btrtl_setup_realtek);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2171:5: note: previous definition of ‘btrtl_setup_realtek’ was here
2171 | int btrtl_setup_realtek(struct hci_dev *hdev)
| ^~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2216:19: error: non-static declaration of ‘btrtl_shutdown_realtek’ follows static declaration
2216 | EXPORT_SYMBOL_GPL(btrtl_shutdown_realtek);
| ^~~~~~~~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2216:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2216 | EXPORT_SYMBOL_GPL(btrtl_shutdown_realtek);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2198:5: note: previous definition of ‘btrtl_shutdown_realtek’ was here
2198 | int btrtl_shutdown_realtek(struct hci_dev *hdev)
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2243:19: error: non-static declaration of ‘btrtl_recv_event’ follows static declaration
2243 | EXPORT_SYMBOL_GPL(btrtl_recv_event);
| ^~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2243:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2243 | EXPORT_SYMBOL_GPL(btrtl_recv_event);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2218:5: note: previous definition of ‘btrtl_recv_event’ was here
2218 | int btrtl_recv_event(struct hci_dev *hdev, struct sk_buff *skb)
| ^~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2245:21: error: invalid storage class for function ‘btrtl_convert_baudrate’
2245 | static unsigned int btrtl_convert_baudrate(u32 device_baudrate)
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/linkage.h:7,
from ./include/linux/printk.h:8,
from ./include/asm-generic/bug.h:22,
from ./arch/x86/include/asm/bug.h:103,
from ./arch/x86/include/asm/alternative.h:9,
from ./arch/x86/include/asm/barrier.h:5,
from ./include/linux/list.h:11,
from ./include/linux/module.h:12,
from drivers/bluetooth/btrtl.c:8:
drivers/bluetooth/btrtl.c:2351:19: error: non-static declaration of ‘btrtl_get_uart_settings’ follows static declaration
2351 | EXPORT_SYMBOL_GPL(btrtl_get_uart_settings);
| ^~~~~~~~~~~~~~~~~~~~~~~
./include/linux/export.h:70:21: note: in definition of macro ‘__EXPORT_SYMBOL’
70 | extern typeof(sym) sym; \
| ^~~
./include/linux/export.h:84:33: note: in expansion of macro ‘_EXPORT_SYMBOL’
84 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
| ^~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2351:1: note: in expansion of macro ‘EXPORT_SYMBOL_GPL’
2351 | EXPORT_SYMBOL_GPL(btrtl_get_uart_settings);
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2282:5: note: previous definition of ‘btrtl_get_uart_settings’ was here
2282 | int btrtl_get_uart_settings(struct hci_dev *hdev,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2404:1: error: expected declaration or statement at end of input
2404 | MODULE_FIRMWARE("rtl_bt/rtl8922au_config.bin");
| ^~~~~~~~~~~~~~~
drivers/bluetooth/btrtl.c:2404: error: control reaches end of non-void function [-Werror=return-type]
2404 | MODULE_FIRMWARE("rtl_bt/rtl8922au_config.bin");
|
cc1: some warnings being treated as errors
make[4]: *** [scripts/Makefile.build:203: drivers/bluetooth/btrtl.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:461: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:461: drivers] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/github/workspace/src/src/Makefile:2003: .] Error 2
make: *** [Makefile:248: __sub-make] Error 2
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 490, Passed: 484 (98.8%), Failed: 2, Not Run: 4
Failed Test Cases
LL Privacy - Add Device 2 (2 Devices to AL) Failed 0.202 seconds
LL Privacy - Set Flags 3 (2 Devices to RL) Failed 0.202 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] Bluetooth: btrtl: Firmware format v3 support
2025-05-29 12:48 ` [PATCH 1/2] Bluetooth: btrtl: Firmware format v3 support Hilda Wu
2025-05-29 13:26 ` Bluetooth: Add support for RTK firmware version 3 and enhanced ACL-based download acceleration bluez.test.bot
@ 2025-05-29 23:49 ` kernel test robot
1 sibling, 0 replies; 7+ messages in thread
From: kernel test robot @ 2025-05-29 23:49 UTC (permalink / raw)
To: Hilda Wu, marcel
Cc: llvm, oe-kbuild-all, luiz.dentz, linux-bluetooth, linux-kernel,
max.chou, alex_lu
Hi Hilda,
kernel test robot noticed the following build errors:
[auto build test ERROR on bluetooth/master]
[also build test ERROR on bluetooth-next/master linus/master v6.15 next-20250529]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Hilda-Wu/Bluetooth-btrtl-Firmware-format-v3-support/20250529-205020
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link: https://lore.kernel.org/r/20250529124816.4186320-2-hildawu%40realtek.com
patch subject: [PATCH 1/2] Bluetooth: btrtl: Firmware format v3 support
config: arm-randconfig-004-20250530 (https://download.01.org/0day-ci/archive/20250530/202505300705.KsxzVLt6-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250530/202505300705.KsxzVLt6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505300705.KsxzVLt6-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/bluetooth/btusb.c:2707:10: error: call to undeclared function 'btrtl_recv_event'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
2707 | return btrtl_recv_event(hdev, skb);
| ^
1 error generated.
vim +/btrtl_recv_event +2707 drivers/bluetooth/btusb.c
2689
2690 static int btusb_recv_event_realtek(struct hci_dev *hdev, struct sk_buff *skb)
2691 {
2692 if (skb->data[0] == HCI_VENDOR_PKT && skb->data[2] == RTK_SUB_EVENT_CODE_COREDUMP) {
2693 struct rtk_dev_coredump_hdr hdr = {
2694 .code = RTK_DEVCOREDUMP_CODE_MEMDUMP,
2695 };
2696
2697 bt_dev_dbg(hdev, "RTL: received coredump vendor evt, len %u",
2698 skb->len);
2699
2700 btusb_rtl_alloc_devcoredump(hdev, &hdr, skb->data, skb->len);
2701 kfree_skb(skb);
2702
2703 return 0;
2704 }
2705
2706 if (skb->data[0] == HCI_VENDOR_PKT)
> 2707 return btrtl_recv_event(hdev, skb);
2708
2709 return hci_recv_frame(hdev, skb);
2710 }
2711
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] Bluetooth: btrtl: Add enhanced download support
2025-05-29 12:48 ` [PATCH 2/2] Bluetooth: btrtl: Add enhanced download support Hilda Wu
@ 2025-05-30 11:49 ` kernel test robot
0 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2025-05-30 11:49 UTC (permalink / raw)
To: Hilda Wu, marcel
Cc: llvm, oe-kbuild-all, luiz.dentz, linux-bluetooth, linux-kernel,
max.chou, alex_lu
Hi Hilda,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bluetooth/master]
[also build test WARNING on bluetooth-next/master linus/master v6.15 next-20250530]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Hilda-Wu/Bluetooth-btrtl-Firmware-format-v3-support/20250529-205020
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link: https://lore.kernel.org/r/20250529124816.4186320-3-hildawu%40realtek.com
patch subject: [PATCH 2/2] Bluetooth: btrtl: Add enhanced download support
config: i386-buildonly-randconfig-004-20250530 (https://download.01.org/0day-ci/archive/20250530/202505301910.8q5W0vf5-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250530/202505301910.8q5W0vf5-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505301910.8q5W0vf5-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/bluetooth/btrtl.c:1339:7: warning: format specifies type 'unsigned long' but the argument has type 'unsigned int' [-Wformat]
1338 | bt_dev_err(hdev, "got invalid cmd complete, %u %lu", skb->len,
| ~~~
| %u
1339 | sizeof(*ev));
| ^~~~~~~~~~~
include/net/bluetooth/bluetooth.h:280:42: note: expanded from macro 'bt_dev_err'
280 | BT_ERR("%s: " fmt, bt_dev_name(hdev), ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/net/bluetooth/bluetooth.h:265:45: note: expanded from macro 'BT_ERR'
265 | #define BT_ERR(fmt, ...) bt_err(fmt "\n", ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
drivers/bluetooth/btrtl.c:2071:1: error: function definition is not allowed here
2071 | {
| ^
drivers/bluetooth/btrtl.c:2113:1: error: function definition is not allowed here
2113 | {
| ^
drivers/bluetooth/btrtl.c:2172:1: error: function definition is not allowed here
2172 | {
| ^
drivers/bluetooth/btrtl.c:2199:1: error: function definition is not allowed here
2199 | {
| ^
drivers/bluetooth/btrtl.c:2219:1: error: function definition is not allowed here
2219 | {
| ^
drivers/bluetooth/btrtl.c:2246:1: error: function definition is not allowed here
2246 | {
| ^
drivers/bluetooth/btrtl.c:2286:1: error: function definition is not allowed here
2286 | {
| ^
drivers/bluetooth/btrtl.c:2404:48: error: expected '}'
2404 | MODULE_FIRMWARE("rtl_bt/rtl8922au_config.bin");
| ^
drivers/bluetooth/btrtl.c:1878:1: note: to match this '{'
1878 | {
| ^
1 warning and 8 errors generated.
vim +1339 drivers/bluetooth/btrtl.c
1322
1323 static int btrtl_enhanced_download_mode_enable(struct hci_dev *hdev,
1324 struct btrtl_device_info *btrtl_dev)
1325 {
1326 struct hci_rp_enhanced_download_mode *ev;
1327 struct sk_buff *skb;
1328 u16 opcode = 0xfc1f;
1329 u8 val = 1;
1330 int ret = -EINVAL;
1331
1332 skb = __hci_cmd_sync(hdev, opcode, 1, &val, HCI_CMD_TIMEOUT);
1333 if (IS_ERR(skb)) {
1334 bt_dev_err(hdev, "send %04x error (%lu)", opcode, PTR_ERR(skb));
1335 return -EIO;
1336 }
1337 if (skb->len != sizeof(*ev)) {
1338 bt_dev_err(hdev, "got invalid cmd complete, %u %lu", skb->len,
> 1339 sizeof(*ev));
1340 goto err;
1341 }
1342 ev = (struct hci_rp_enhanced_download_mode *)skb->data;
1343 if (ev->status) {
1344 bt_dev_err(hdev, "got invalid status 0x%02x", ev->status);
1345 goto err;
1346 }
1347 btrtl_dev->handle = le16_to_cpu(ev->handle);
1348 btrtl_dev->acldata_pkt_len = le16_to_cpu(ev->acldata_pkt_len);
1349 kfree_skb(skb);
1350
1351 bt_dev_info(hdev, "enhanced download mode enabled, handle %04x, acl %u",
1352 btrtl_dev->handle, btrtl_dev->acldata_pkt_len);
1353
1354 return 0;
1355 err:
1356 kfree_skb(skb);
1357 return ret;
1358 }
1359
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: Bluetooth: Add support for RTK firmware version 3 and enhanced ACL-based download acceleration
2025-06-06 9:05 [PATCH v2 1/2] Bluetooth: btrtl: Firmware format v3 support Hilda Wu
@ 2025-06-06 9:35 ` bluez.test.bot
0 siblings, 0 replies; 7+ messages in thread
From: bluez.test.bot @ 2025-06-06 9:35 UTC (permalink / raw)
To: linux-bluetooth, hildawu
[-- Attachment #1: Type: text/plain, Size: 1682 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=969182
---Test result---
Test Summary:
CheckPatch PENDING 0.31 seconds
GitLint PENDING 0.24 seconds
SubjectPrefix PASS 0.18 seconds
BuildKernel PASS 24.86 seconds
CheckAllWarning PASS 27.82 seconds
CheckSparse PASS 31.89 seconds
BuildKernel32 PASS 24.75 seconds
TestRunnerSetup PASS 467.42 seconds
TestRunner_l2cap-tester PASS 25.36 seconds
TestRunner_iso-tester PASS 42.36 seconds
TestRunner_bnep-tester PASS 5.93 seconds
TestRunner_mgmt-tester PASS 133.73 seconds
TestRunner_rfcomm-tester PASS 9.40 seconds
TestRunner_sco-tester PASS 15.11 seconds
TestRunner_ioctl-tester PASS 10.12 seconds
TestRunner_mesh-tester PASS 7.30 seconds
TestRunner_smp-tester PASS 8.60 seconds
TestRunner_userchan-tester PASS 6.29 seconds
IncrementalBuild PENDING 0.81 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-06-06 9:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-29 12:48 [PATCH 0/2] Bluetooth: Add support for RTK firmware version 3 and enhanced ACL-based download acceleration Hilda Wu
2025-05-29 12:48 ` [PATCH 1/2] Bluetooth: btrtl: Firmware format v3 support Hilda Wu
2025-05-29 13:26 ` Bluetooth: Add support for RTK firmware version 3 and enhanced ACL-based download acceleration bluez.test.bot
2025-05-29 23:49 ` [PATCH 1/2] Bluetooth: btrtl: Firmware format v3 support kernel test robot
2025-05-29 12:48 ` [PATCH 2/2] Bluetooth: btrtl: Add enhanced download support Hilda Wu
2025-05-30 11:49 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2025-06-06 9:05 [PATCH v2 1/2] Bluetooth: btrtl: Firmware format v3 support Hilda Wu
2025-06-06 9:35 ` Bluetooth: Add support for RTK firmware version 3 and enhanced ACL-based download acceleration bluez.test.bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox