[PATCH BlueZ v1] bass: Fix not using SID from BT_BASS_ADD_SRC

[PATCH BlueZ v1] bass: Fix not using SID from BT_BASS_ADD_SRC

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

BT_BASS_ADD_SRC command does actually have the SID of the broadcast
source which must be set otherwise the kernel would assume it to be
0x00 which may not always be the case.

Fixes: https://github.com/bluez/bluez/issues/1282
---
 profiles/audio/bass.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/profiles/audio/bass.c b/profiles/audio/bass.c
index 017a5aa75c85..417b7b72ff9b 100644
--- a/profiles/audio/bass.c
+++ b/profiles/audio/bass.c
@@ -106,6 +106,7 @@ struct bass_delegator {
 	struct bt_bap *bap;
 	unsigned int state_id;
 	unsigned int bcode_id;
+	uint8_t sid;
 	uint8_t *bcode;
 	unsigned int timeout;
 	struct queue *bcode_reqs;
@@ -646,6 +647,7 @@ static void bap_attached(struct bt_bap *bap, void *user_data)
 		btd_device_get_bdaddr_type(device),
 		BT_IO_OPT_MODE, BT_IO_MODE_ISO,
 		BT_IO_OPT_QOS, &bap_sink_pa_qos,
+		BT_IO_OPT_ISO_BC_SID, dg->sid,
 		BT_IO_OPT_INVALID);
 	if (!dg->io) {
 		error("%s", err->message);
@@ -1320,6 +1322,7 @@ probe:
 
 	dg->device = device;
 	dg->src = bcast_src;
+	dg->sid = params->sid;
 	dg->bcode_reqs = queue_new();
 	dg->setups = queue_new();
 
@@ -1460,6 +1463,7 @@ static int handle_mod_src_req(struct bt_bcast_src *bcast_src,
 				btd_device_get_bdaddr_type(dg->device),
 				BT_IO_OPT_MODE, BT_IO_MODE_ISO,
 				BT_IO_OPT_QOS, &bap_sink_pa_qos,
+				BT_IO_OPT_ISO_BC_SID, dg->sid,
 				BT_IO_OPT_INVALID);
 			if (!dg->io) {
 				error("%s", err->message);
-- 
2.49.0

RE: [BlueZ,v1] bass: Fix not using SID from BT_BASS_ADD_SRC

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=967384

---Test result---

Test Summary:
CheckPatch                    PENDING   0.25 seconds
GitLint                       PENDING   0.27 seconds
BuildEll                      PASS      20.03 seconds
BluezMake                     PASS      2749.32 seconds
MakeCheck                     PASS      19.91 seconds
MakeDistcheck                 PASS      197.87 seconds
CheckValgrind                 PASS      275.66 seconds
CheckSmatch                   PASS      300.76 seconds
bluezmakeextell               PASS      127.93 seconds
IncrementalBuild              PENDING   0.25 seconds
ScanBuild                     PASS      906.97 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] bass: Fix not using SID from BT_BASS_ADD_SRC

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 29 May 2025 12:42:56 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> BT_BASS_ADD_SRC command does actually have the SID of the broadcast
> source which must be set otherwise the kernel would assume it to be
> 0x00 which may not always be the case.
> 
> Fixes: https://github.com/bluez/bluez/issues/1282
> 
> [...]

Here is the summary with links:
  - [BlueZ,v1] bass: Fix not using SID from BT_BASS_ADD_SRC
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5ad6ec151c61

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html