* [PATCH BlueZ 0/3] pbap: use the public DBus connection
@ 2025-06-03 15:13 Andrew Sayers
2025-06-03 15:13 ` [PATCH BlueZ 1/3] obexd: Pass at_(un)register value to logind callbacks Andrew Sayers
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Andrew Sayers @ 2025-06-03 15:13 UTC (permalink / raw)
To: linux-bluetooth; +Cc: luiz.dentz, pav, frederic.danis, Andrew Sayers
DBus requests are received by the public DBus connection, because it
registers the relevant bus name. My previous patches told PBAP to
listen on a private connection, but DBus doesn't let connections share
bus names, so it needs to listen on the public connection instead.
This adds a little more complexity to the logind callbacks, to avoid
unregistering profiles during shutdown. It also removes an API I
previously added, which is no longer used and would only encourage the
next person to make the same mistake.
Reported-by: Frédéric Danis <frederic.danis@collabora.com>
Closes: https://lore.kernel.org/linux-bluetooth/333ad76e-0aba-4f93-b141-8e69fb47535f@collabora.com/
Suggested-by: Pauli Virtanen <pav@iki.fi>
Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>
---
Andrew Sayers (3):
obexd: Pass at_(un)register value to logind callbacks
pbap: use the public DBus connection
Revert "obexd: Support creating private system/session bus connections"
obexd/client/pbap.c | 28 ++++++++++++++++++++++++----
obexd/plugins/bluetooth.c | 6 ++++--
obexd/src/logind.c | 14 +++++++-------
obexd/src/logind.h | 8 ++++----
obexd/src/main.c | 8 --------
obexd/src/obexd.h | 2 --
6 files changed, 39 insertions(+), 27 deletions(-)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH BlueZ 1/3] obexd: Pass at_(un)register value to logind callbacks
2025-06-03 15:13 [PATCH BlueZ 0/3] pbap: use the public DBus connection Andrew Sayers
@ 2025-06-03 15:13 ` Andrew Sayers
2025-06-03 16:01 ` Luiz Augusto von Dentz
` (2 more replies)
2025-06-03 15:13 ` [PATCH BlueZ 2/3] pbap: use the public DBus connection Andrew Sayers
` (2 subsequent siblings)
3 siblings, 3 replies; 10+ messages in thread
From: Andrew Sayers @ 2025-06-03 15:13 UTC (permalink / raw)
To: linux-bluetooth; +Cc: luiz.dentz, pav, frederic.danis, Andrew Sayers
Logind (un)registers callbacks that it calls when the user's state changes.
Callbacks may also be called during (un)registration.
Clients may need to handle those initial/final calls specially.
Pass an argument indicating whether this is being called during
(un)registration, and modify existing callbacks to ignore that argument.
Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>
---
obexd/client/pbap.c | 6 ++++--
obexd/plugins/bluetooth.c | 6 ++++--
obexd/src/logind.c | 14 +++++++-------
obexd/src/logind.h | 8 ++++----
4 files changed, 19 insertions(+), 15 deletions(-)
diff --git a/obexd/client/pbap.c b/obexd/client/pbap.c
index 51b523592..64bb8ff72 100644
--- a/obexd/client/pbap.c
+++ b/obexd/client/pbap.c
@@ -1455,8 +1455,9 @@ static struct obc_driver pbap = {
.remove = pbap_remove
};
-static int pbap_init_cb(void)
+static int pbap_init_cb(gboolean at_register)
{
+ (void)at_register;
int err;
DBG("");
@@ -1482,8 +1483,9 @@ static int pbap_init_cb(void)
return 0;
}
-static void pbap_exit_cb(void)
+static void pbap_exit_cb(gboolean at_unregister)
{
+ (void)at_unregister;
DBG("");
g_dbus_remove_watch(system_conn, listener_id);
diff --git a/obexd/plugins/bluetooth.c b/obexd/plugins/bluetooth.c
index 7ff27a8a8..ad37e636d 100644
--- a/obexd/plugins/bluetooth.c
+++ b/obexd/plugins/bluetooth.c
@@ -427,8 +427,9 @@ static const struct obex_transport_driver driver = {
static unsigned int listener_id = 0;
-static int bluetooth_init_cb(void)
+static int bluetooth_init_cb(gboolean at_register)
{
+ (void)at_register;
connection = g_dbus_setup_private(DBUS_BUS_SYSTEM, NULL, NULL);
if (connection == NULL)
return -EPERM;
@@ -439,8 +440,9 @@ static int bluetooth_init_cb(void)
return obex_transport_driver_register(&driver);
}
-static void bluetooth_exit_cb(void)
+static void bluetooth_exit_cb(gboolean at_unregister)
{
+ (void)at_unregister;
GSList *l;
g_dbus_remove_watch(connection, listener_id);
diff --git a/obexd/src/logind.c b/obexd/src/logind.c
index a0eb62b1e..b4279b209 100644
--- a/obexd/src/logind.c
+++ b/obexd/src/logind.c
@@ -43,13 +43,13 @@ static void call_init_cb(gpointer data, gpointer user_data)
{
int res;
- res = ((struct callback_pair *)data)->init_cb();
+ res = ((struct callback_pair *)data)->init_cb(FALSE);
if (res)
*(int *)user_data = res;
}
static void call_exit_cb(gpointer data, gpointer user_data)
{
- ((struct callback_pair *)data)->exit_cb();
+ ((struct callback_pair *)data)->exit_cb(FALSE);
}
static int update(void)
@@ -229,7 +229,7 @@ int logind_register(logind_init_cb init_cb, logind_exit_cb exit_cb)
struct callback_pair *cbs;
if (!monitoring_enabled)
- return init_cb();
+ return init_cb(TRUE);
if (callbacks == NULL) {
int res;
@@ -237,23 +237,23 @@ int logind_register(logind_init_cb init_cb, logind_exit_cb exit_cb)
if (res) {
error("logind_init(): %s - login detection disabled",
strerror(-res));
- return init_cb();
+ return init_cb(TRUE);
}
}
cbs = g_new(struct callback_pair, 1);
cbs->init_cb = init_cb;
cbs->exit_cb = exit_cb;
callbacks = g_slist_prepend(callbacks, cbs);
- return active ? init_cb() : 0;
+ return active ? init_cb(TRUE) : 0;
}
void logind_unregister(logind_init_cb init_cb, logind_exit_cb exit_cb)
{
GSList *cb_node;
if (!monitoring_enabled)
- return exit_cb();
+ return exit_cb(TRUE);
if (active)
- exit_cb();
+ exit_cb(TRUE);
cb_node = g_slist_find_custom(callbacks, init_cb, find_cb);
if (cb_node != NULL)
callbacks = g_slist_delete_link(callbacks, cb_node);
diff --git a/obexd/src/logind.h b/obexd/src/logind.h
index eb3ff8d7b..3cdb03338 100644
--- a/obexd/src/logind.h
+++ b/obexd/src/logind.h
@@ -8,8 +8,8 @@
*
*/
-typedef int (*logind_init_cb)(void);
-typedef void (*logind_exit_cb)(void);
+typedef int (*logind_init_cb)(gboolean at_register);
+typedef void (*logind_exit_cb)(gboolean at_unregister);
#ifdef SYSTEMD
@@ -22,12 +22,12 @@ int logind_set(gboolean enabled);
static inline int logind_register(logind_init_cb init_cb,
logind_exit_cb exit_cb)
{
- return init_cb();
+ return init_cb(TRUE);
}
static inline void logind_unregister(logind_init_cb init_cb,
logind_exit_cb exit_cb)
{
- return exit_cb();
+ return exit_cb(TRUE);
}
static inline int logind_set(gboolean enabled)
{
--
2.49.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH BlueZ 2/3] pbap: use the public DBus connection
2025-06-03 15:13 [PATCH BlueZ 0/3] pbap: use the public DBus connection Andrew Sayers
2025-06-03 15:13 ` [PATCH BlueZ 1/3] obexd: Pass at_(un)register value to logind callbacks Andrew Sayers
@ 2025-06-03 15:13 ` Andrew Sayers
2025-06-03 15:13 ` [PATCH BlueZ 3/3] Revert "obexd: Support creating private system/session bus connections" Andrew Sayers
2025-06-06 16:58 ` [PATCH BlueZ 0/3] pbap: use the public DBus connection Frédéric Danis
3 siblings, 0 replies; 10+ messages in thread
From: Andrew Sayers @ 2025-06-03 15:13 UTC (permalink / raw)
To: linux-bluetooth; +Cc: luiz.dentz, pav, frederic.danis, Andrew Sayers
PBAP must not use its own private DBus connection, as it needs to
receive messages sent to the bus name of the public connection.
PBAP must not unregister itself when the program is exiting, as it might
cause a long delay. Unregistering at exit is redundant anyway, as the
service will be implicitly unregistered when the connection is closed.
But PBAP must unregister itself when the user becomes inactive mid-session,
so systems with multiple users logged in at once can share bluetooth.
Use the public DBus connection instead of a private one,
and explicitly unregister the profile if appropriate.
Thanks Pauli Virtanen for pointing out the exit issue:
https://lore.kernel.org/linux-bluetooth/ae15a9fa4bf0bd509dd3d44f1f364e241e50956c.camel@iki.fi/
Reported-by: Frédéric Danis <frederic.danis@collabora.com>
Closes: https://lore.kernel.org/linux-bluetooth/333ad76e-0aba-4f93-b141-8e69fb47535f@collabora.com/
Suggested-by: Pauli Virtanen <pav@iki.fi>
Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>
---
obexd/client/pbap.c | 24 +++++++++++++++++++++---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/obexd/client/pbap.c b/obexd/client/pbap.c
index 64bb8ff72..0bd4e10df 100644
--- a/obexd/client/pbap.c
+++ b/obexd/client/pbap.c
@@ -1462,7 +1462,7 @@ static int pbap_init_cb(gboolean at_register)
DBG("");
- conn = obex_setup_dbus_connection_private(NULL, NULL);
+ conn = obex_get_dbus_connection();
if (!conn)
return -EIO;
@@ -1485,9 +1485,28 @@ static int pbap_init_cb(gboolean at_register)
static void pbap_exit_cb(gboolean at_unregister)
{
- (void)at_unregister;
+ DBusMessage *msg;
+ DBusMessageIter iter;
+ char *uuid = PBAP_CLIENT_UUID;
+
DBG("");
+ if (!at_unregister) {
+ client_path = g_strconcat("/org/bluez/obex/", uuid, NULL);
+ g_strdelimit(client_path, "-", '_');
+
+ msg = dbus_message_new_method_call("org.bluez", "/org/bluez",
+ "org.bluez.ProfileManager1",
+ "UnregisterProfile");
+
+ dbus_message_iter_init_append(msg, &iter);
+
+ dbus_message_iter_append_basic(&iter, DBUS_TYPE_OBJECT_PATH,
+ &client_path);
+
+ g_dbus_send_message(system_conn, msg);
+ }
+
g_dbus_remove_watch(system_conn, listener_id);
unregister_profile();
@@ -1499,7 +1518,6 @@ static void pbap_exit_cb(gboolean at_unregister)
}
if (conn) {
- dbus_connection_close(conn);
dbus_connection_unref(conn);
conn = NULL;
}
--
2.49.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH BlueZ 3/3] Revert "obexd: Support creating private system/session bus connections"
2025-06-03 15:13 [PATCH BlueZ 0/3] pbap: use the public DBus connection Andrew Sayers
2025-06-03 15:13 ` [PATCH BlueZ 1/3] obexd: Pass at_(un)register value to logind callbacks Andrew Sayers
2025-06-03 15:13 ` [PATCH BlueZ 2/3] pbap: use the public DBus connection Andrew Sayers
@ 2025-06-03 15:13 ` Andrew Sayers
2025-06-06 16:58 ` [PATCH BlueZ 0/3] pbap: use the public DBus connection Frédéric Danis
3 siblings, 0 replies; 10+ messages in thread
From: Andrew Sayers @ 2025-06-03 15:13 UTC (permalink / raw)
To: linux-bluetooth; +Cc: luiz.dentz, pav, frederic.danis, Andrew Sayers
This reverts commit 237d818ef294e22be87fba69b3cdd79c75c201e7,
which encouraged the use of private DBus connections.
Doing so caused a bug, so it's better to remove the temptation for now
and re-add it if a legitimate use case is ever found.
Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>
---
obexd/src/main.c | 8 --------
obexd/src/obexd.h | 2 --
2 files changed, 10 deletions(-)
diff --git a/obexd/src/main.c b/obexd/src/main.c
index df150973e..6837f0d73 100644
--- a/obexd/src/main.c
+++ b/obexd/src/main.c
@@ -254,14 +254,6 @@ DBusConnection *obex_setup_dbus_connection(const char *name,
return connection;
}
-DBusConnection *obex_setup_dbus_connection_private(const char *name,
- DBusError *error)
-{
- return g_dbus_setup_private(option_system_bus ?
- DBUS_BUS_SYSTEM : DBUS_BUS_SESSION,
- name, error);
-}
-
int main(int argc, char *argv[])
{
GOptionContext *context;
diff --git a/obexd/src/obexd.h b/obexd/src/obexd.h
index 560db29ce..5e5edc4de 100644
--- a/obexd/src/obexd.h
+++ b/obexd/src/obexd.h
@@ -33,5 +33,3 @@ const char *obex_option_capability(void);
DBusConnection *obex_get_dbus_connection(void);
DBusConnection *obex_setup_dbus_connection(const char *name,
DBusError *error);
-DBusConnection *obex_setup_dbus_connection_private(const char *name,
- DBusError *error);
--
2.49.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH BlueZ 1/3] obexd: Pass at_(un)register value to logind callbacks
2025-06-03 15:13 ` [PATCH BlueZ 1/3] obexd: Pass at_(un)register value to logind callbacks Andrew Sayers
@ 2025-06-03 16:01 ` Luiz Augusto von Dentz
2025-06-04 9:03 ` Andrew Sayers
2025-06-03 16:43 ` pbap: use the public DBus connection bluez.test.bot
2025-06-06 16:55 ` [PATCH BlueZ 1/3] obexd: Pass at_(un)register value to logind callbacks Frédéric Danis
2 siblings, 1 reply; 10+ messages in thread
From: Luiz Augusto von Dentz @ 2025-06-03 16:01 UTC (permalink / raw)
To: Andrew Sayers; +Cc: linux-bluetooth, pav, frederic.danis
Hi Andrew,
On Tue, Jun 3, 2025 at 11:17 AM Andrew Sayers
<kernel.org@pileofstuff.org> wrote:
>
> Logind (un)registers callbacks that it calls when the user's state changes.
> Callbacks may also be called during (un)registration.
> Clients may need to handle those initial/final calls specially.
>
> Pass an argument indicating whether this is being called during
> (un)registration, and modify existing callbacks to ignore that argument.
>
> Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>
> ---
> obexd/client/pbap.c | 6 ++++--
> obexd/plugins/bluetooth.c | 6 ++++--
> obexd/src/logind.c | 14 +++++++-------
> obexd/src/logind.h | 8 ++++----
> 4 files changed, 19 insertions(+), 15 deletions(-)
>
> diff --git a/obexd/client/pbap.c b/obexd/client/pbap.c
> index 51b523592..64bb8ff72 100644
> --- a/obexd/client/pbap.c
> +++ b/obexd/client/pbap.c
> @@ -1455,8 +1455,9 @@ static struct obc_driver pbap = {
> .remove = pbap_remove
> };
>
> -static int pbap_init_cb(void)
> +static int pbap_init_cb(gboolean at_register)
> {
> + (void)at_register;
> int err;
>
> DBG("");
> @@ -1482,8 +1483,9 @@ static int pbap_init_cb(void)
> return 0;
> }
>
> -static void pbap_exit_cb(void)
> +static void pbap_exit_cb(gboolean at_unregister)
> {
> + (void)at_unregister;
> DBG("");
>
> g_dbus_remove_watch(system_conn, listener_id);
> diff --git a/obexd/plugins/bluetooth.c b/obexd/plugins/bluetooth.c
> index 7ff27a8a8..ad37e636d 100644
> --- a/obexd/plugins/bluetooth.c
> +++ b/obexd/plugins/bluetooth.c
> @@ -427,8 +427,9 @@ static const struct obex_transport_driver driver = {
>
> static unsigned int listener_id = 0;
>
> -static int bluetooth_init_cb(void)
> +static int bluetooth_init_cb(gboolean at_register)
> {
> + (void)at_register;
> connection = g_dbus_setup_private(DBUS_BUS_SYSTEM, NULL, NULL);
> if (connection == NULL)
> return -EPERM;
> @@ -439,8 +440,9 @@ static int bluetooth_init_cb(void)
> return obex_transport_driver_register(&driver);
> }
>
> -static void bluetooth_exit_cb(void)
> +static void bluetooth_exit_cb(gboolean at_unregister)
> {
> + (void)at_unregister;
> GSList *l;
>
> g_dbus_remove_watch(connection, listener_id);
> diff --git a/obexd/src/logind.c b/obexd/src/logind.c
> index a0eb62b1e..b4279b209 100644
> --- a/obexd/src/logind.c
> +++ b/obexd/src/logind.c
> @@ -43,13 +43,13 @@ static void call_init_cb(gpointer data, gpointer user_data)
> {
> int res;
>
> - res = ((struct callback_pair *)data)->init_cb();
> + res = ((struct callback_pair *)data)->init_cb(FALSE);
> if (res)
> *(int *)user_data = res;
> }
> static void call_exit_cb(gpointer data, gpointer user_data)
> {
> - ((struct callback_pair *)data)->exit_cb();
> + ((struct callback_pair *)data)->exit_cb(FALSE);
> }
>
> static int update(void)
> @@ -229,7 +229,7 @@ int logind_register(logind_init_cb init_cb, logind_exit_cb exit_cb)
> struct callback_pair *cbs;
>
> if (!monitoring_enabled)
> - return init_cb();
> + return init_cb(TRUE);
> if (callbacks == NULL) {
> int res;
>
> @@ -237,23 +237,23 @@ int logind_register(logind_init_cb init_cb, logind_exit_cb exit_cb)
> if (res) {
> error("logind_init(): %s - login detection disabled",
> strerror(-res));
> - return init_cb();
> + return init_cb(TRUE);
> }
> }
> cbs = g_new(struct callback_pair, 1);
> cbs->init_cb = init_cb;
> cbs->exit_cb = exit_cb;
> callbacks = g_slist_prepend(callbacks, cbs);
> - return active ? init_cb() : 0;
> + return active ? init_cb(TRUE) : 0;
> }
> void logind_unregister(logind_init_cb init_cb, logind_exit_cb exit_cb)
> {
> GSList *cb_node;
>
> if (!monitoring_enabled)
> - return exit_cb();
> + return exit_cb(TRUE);
> if (active)
> - exit_cb();
> + exit_cb(TRUE);
> cb_node = g_slist_find_custom(callbacks, init_cb, find_cb);
> if (cb_node != NULL)
> callbacks = g_slist_delete_link(callbacks, cb_node);
> diff --git a/obexd/src/logind.h b/obexd/src/logind.h
> index eb3ff8d7b..3cdb03338 100644
> --- a/obexd/src/logind.h
> +++ b/obexd/src/logind.h
> @@ -8,8 +8,8 @@
> *
> */
>
> -typedef int (*logind_init_cb)(void);
> -typedef void (*logind_exit_cb)(void);
> +typedef int (*logind_init_cb)(gboolean at_register);
> +typedef void (*logind_exit_cb)(gboolean at_unregister);
>
> #ifdef SYSTEMD
>
> @@ -22,12 +22,12 @@ int logind_set(gboolean enabled);
> static inline int logind_register(logind_init_cb init_cb,
> logind_exit_cb exit_cb)
> {
> - return init_cb();
> + return init_cb(TRUE);
> }
> static inline void logind_unregister(logind_init_cb init_cb,
> logind_exit_cb exit_cb)
> {
> - return exit_cb();
> + return exit_cb(TRUE);
> }
> static inline int logind_set(gboolean enabled)
> {
> --
> 2.49.0
This is not going very well in my opinion, it looks like we missed the
opportunity to integrate the logind directly into obc_driver so we
don't have to duplicate code for each coded, so we keep just doing
plugin_init->obc_driver_register/plugin_exit->obc_driver_unregister
and that internally can detect when it shall be registered with the
Bluetoothd, etc, plugin_exit->obc_driver_unregister can actually be
assumed to be exit rather than just D-Bus unregister which happens
when seat is not longer active.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: pbap: use the public DBus connection
2025-06-03 15:13 ` [PATCH BlueZ 1/3] obexd: Pass at_(un)register value to logind callbacks Andrew Sayers
2025-06-03 16:01 ` Luiz Augusto von Dentz
@ 2025-06-03 16:43 ` bluez.test.bot
2025-06-06 16:55 ` [PATCH BlueZ 1/3] obexd: Pass at_(un)register value to logind callbacks Frédéric Danis
2 siblings, 0 replies; 10+ messages in thread
From: bluez.test.bot @ 2025-06-03 16:43 UTC (permalink / raw)
To: linux-bluetooth, kernel.org
[-- Attachment #1: Type: text/plain, Size: 34311 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=968319
---Test result---
Test Summary:
CheckPatch PENDING 0.25 seconds
GitLint PENDING 0.30 seconds
BuildEll PASS 20.16 seconds
BluezMake FAIL 88.17 seconds
MakeCheck FAIL 3132.99 seconds
MakeDistcheck PASS 201.05 seconds
CheckValgrind FAIL 64.86 seconds
CheckSmatch FAIL 196.13 seconds
bluezmakeextell FAIL 103.70 seconds
IncrementalBuild PENDING 0.25 seconds
ScanBuild FAIL 239.25 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: BluezMake - FAIL
Desc: Build BlueZ
Output:
tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12907:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12907 | int main(int argc, char *argv[])
| ^~~~
obexd/client/pbap.c: In function ‘pbap_init_cb’:
obexd/client/pbap.c:1461:2: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
1461 | int err;
| ^~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:9930: obexd/client/obexd-pbap.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4690: all] Error 2
##############################
Test: MakeCheck - FAIL
Desc: Run Bluez Make Check
Output:
unit/test-avdtp.c: In function ‘main’:
unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
766 | int main(int argc, char *argv[])
| ^~~~
unit/test-avrcp.c: In function ‘main’:
unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
989 | int main(int argc, char *argv[])
| ^~~~
obexd/plugins/bluetooth.c: In function ‘bluetooth_exit_cb’:
obexd/plugins/bluetooth.c:446:2: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
446 | GSList *l;
| ^~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:9580: obexd/plugins/obexd-bluetooth.o] Error 1
make: *** [Makefile:12345: check] Error 2
##############################
Test: CheckValgrind - FAIL
Desc: Run Bluez Make Check with Valgrind
Output:
tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12907:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12907 | int main(int argc, char *argv[])
| ^~~~
obexd/client/pbap.c: In function ‘pbap_init_cb’:
obexd/client/pbap.c:1461:2: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
1461 | int err;
| ^~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:9930: obexd/client/obexd-pbap.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:12345: check] Error 2
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:
src/shared/crypto.c:271:21: warning: Variable length array is used.
src/shared/crypto.c:272:23: warning: Variable length array is used.
src/shared/gatt-helpers.c:768:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:830:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used.
src/shared/gatt-server.c:278:25: warning: Variable length array is used.
src/shared/gatt-server.c:618:25: warning: Variable length array is used.
src/shared/gatt-server.c:716:25: warning: Variable length array is used.
src/shared/bap.c:315:25: warning: array of flexible structures
src/shared/bap.c: note: in included file:
./src/shared/ascs.h:88:25: warning: array of flexible structures
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
src/shared/crypto.c:271:21: warning: Variable length array is used.
src/shared/crypto.c:272:23: warning: Variable length array is used.
src/shared/gatt-helpers.c:768:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:830:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used.
src/shared/gatt-server.c:278:25: warning: Variable length array is used.
src/shared/gatt-server.c:618:25: warning: Variable length array is used.
src/shared/gatt-server.c:716:25: warning: Variable length array is used.
src/shared/bap.c:315:25: warning: array of flexible structures
src/shared/bap.c: note: in included file:
./src/shared/ascs.h:88:25: warning: array of flexible structures
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
tools/mesh-cfgtest.c:1453:17: warning: unknown escape sequence: '\%'
tools/sco-tester.c: note: in included file:
./lib/bluetooth.h:232:15: warning: array of flexible structures
./lib/bluetooth.h:237:31: warning: array of flexible structures
tools/bneptest.c:634:39: warning: unknown escape sequence: '\%'
tools/seq2bseq.c:57:26: warning: Variable length array is used.
tools/obex-client-tool.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
android/avctp.c:505:34: warning: Variable length array is used.
android/avctp.c:556:34: warning: Variable length array is used.
unit/test-avrcp.c:373:26: warning: Variable length array is used.
unit/test-avrcp.c:398:26: warning: Variable length array is used.
unit/test-avrcp.c:414:24: warning: Variable length array is used.
android/avrcp-lib.c:1085:34: warning: Variable length array is used.
android/avrcp-lib.c:1583:34: warning: Variable length array is used.
android/avrcp-lib.c:1612:34: warning: Variable length array is used.
android/avrcp-lib.c:1638:34: warning: Variable length array is used.
obexd/client/pbap.c:1461:9: warning: mixing declarations and code
obexd/client/pbap.c: In function ‘pbap_init_cb’:
obexd/client/pbap.c:1461:2: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
1461 | int err;
| ^~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:9930: obexd/client/obexd-pbap.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4690: all] Error 2
##############################
Test: bluezmakeextell - FAIL
Desc: Build Bluez with External ELL
Output:
obexd/client/pbap.c: In function ‘pbap_init_cb’:
obexd/client/pbap.c:1461:2: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
1461 | int err;
| ^~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:9930: obexd/client/obexd-pbap.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4690: all] Error 2
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
##############################
Test: ScanBuild - FAIL
Desc: Run Scan Build
Output:
src/shared/gatt-client.c:451:21: warning: Use of memory after it is freed
gatt_db_unregister(op->client->db, op->db_id);
^~~~~~~~~~
src/shared/gatt-client.c:696:2: warning: Use of memory after it is freed
discovery_op_complete(op, false, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:996:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1102:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1296:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1361:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1636:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1641:2: warning: Use of memory after it is freed
discover_all(op);
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2147:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2155:8: warning: Use of memory after it is freed
discovery_op_ref(op),
^~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3244:2: warning: Use of memory after it is freed
complete_write_long_op(req, success, 0, false);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3266:2: warning: Use of memory after it is freed
request_unref(req);
^~~~~~~~~~~~~~~~~~
12 warnings generated.
src/shared/bap.c:1522:8: warning: Use of memory after it is freed
bap = bt_bap_ref_safe(bap);
^~~~~~~~~~~~~~~~~~~~
src/shared/bap.c:2273:20: warning: Use of memory after it is freed
return queue_find(stream->bap->streams, NULL, stream);
^~~~~~~~~~~~~~~~~~~~
2 warnings generated.
src/shared/gatt-client.c:451:21: warning: Use of memory after it is freed
gatt_db_unregister(op->client->db, op->db_id);
^~~~~~~~~~
src/shared/gatt-client.c:696:2: warning: Use of memory after it is freed
discovery_op_complete(op, false, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:996:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1102:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1296:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1361:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1636:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1641:2: warning: Use of memory after it is freed
discover_all(op);
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2147:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2155:8: warning: Use of memory after it is freed
discovery_op_ref(op),
^~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3244:2: warning: Use of memory after it is freed
complete_write_long_op(req, success, 0, false);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3266:2: warning: Use of memory after it is freed
request_unref(req);
^~~~~~~~~~~~~~~~~~
12 warnings generated.
tools/hciattach.c:817:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 10)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:865:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 4)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:887:8: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 10)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:909:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 4)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:930:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 4)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:974:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 6)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
6 warnings generated.
src/shared/bap.c:1522:8: warning: Use of memory after it is freed
bap = bt_bap_ref_safe(bap);
^~~~~~~~~~~~~~~~~~~~
src/shared/bap.c:2273:20: warning: Use of memory after it is freed
return queue_find(stream->bap->streams, NULL, stream);
^~~~~~~~~~~~~~~~~~~~
2 warnings generated.
src/oui.c:50:2: warning: Value stored to 'hwdb' is never read
hwdb = udev_hwdb_unref(hwdb);
^ ~~~~~~~~~~~~~~~~~~~~~
src/oui.c:53:2: warning: Value stored to 'udev' is never read
udev = udev_unref(udev);
^ ~~~~~~~~~~~~~~~~
2 warnings generated.
tools/rfcomm.c:234:3: warning: Value stored to 'i' is never read
i = execvp(cmdargv[0], cmdargv);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/rfcomm.c:234:7: warning: Null pointer passed to 1st parameter expecting 'nonnull'
i = execvp(cmdargv[0], cmdargv);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/rfcomm.c:354:8: warning: Although the value stored to 'fd' is used in the enclosing expression, the value is never actually read from 'fd'
if ((fd = open(devname, O_RDONLY | O_NOCTTY)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/rfcomm.c:497:14: warning: Assigned value is garbage or undefined
req.channel = raddr.rc_channel;
^ ~~~~~~~~~~~~~~~~
tools/rfcomm.c:515:8: warning: Although the value stored to 'fd' is used in the enclosing expression, the value is never actually read from 'fd'
if ((fd = open(devname, O_RDONLY | O_NOCTTY)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 warnings generated.
tools/hcidump.c:180:9: warning: Potential leak of memory pointed to by 'dp'
if (fds[i].fd == sock)
^~~
tools/hcidump.c:248:17: warning: Assigned value is garbage or undefined
dh->ts_sec = htobl(frm.ts.tv_sec);
^ ~~~~~~~~~~~~~~~~~~~~
tools/hcidump.c:326:9: warning: 1st function call argument is an uninitialized value
if (be32toh(dp.flags) & 0x02) {
^~~~~~~~~~~~~~~~~
/usr/include/endian.h:46:22: note: expanded from macro 'be32toh'
# define be32toh(x) __bswap_32 (x)
^~~~~~~~~~~~~~
tools/hcidump.c:341:20: warning: 1st function call argument is an uninitialized value
frm.data_len = be32toh(dp.len);
^~~~~~~~~~~~~~~
/usr/include/endian.h:46:22: note: expanded from macro 'be32toh'
# define be32toh(x) __bswap_32 (x)
^~~~~~~~~~~~~~
tools/hcidump.c:346:14: warning: 1st function call argument is an uninitialized value
opcode = be32toh(dp.flags) & 0xffff;
^~~~~~~~~~~~~~~~~
/usr/include/endian.h:46:22: note: expanded from macro 'be32toh'
# define be32toh(x) __bswap_32 (x)
^~~~~~~~~~~~~~
tools/hcidump.c:384:17: warning: Assigned value is garbage or undefined
frm.data_len = btohs(dh.len);
^ ~~~~~~~~~~~~~
tools/hcidump.c:394:11: warning: Assigned value is garbage or undefined
frm.len = frm.data_len;
^ ~~~~~~~~~~~~
tools/hcidump.c:398:9: warning: 1st function call argument is an uninitialized value
ts = be64toh(ph.ts);
^~~~~~~~~~~~~~
/usr/include/endian.h:51:22: note: expanded from macro 'be64toh'
# define be64toh(x) __bswap_64 (x)
^~~~~~~~~~~~~~
tools/hcidump.c:403:13: warning: 1st function call argument is an uninitialized value
frm.in = be32toh(dp.flags) & 0x01;
^~~~~~~~~~~~~~~~~
/usr/include/endian.h:46:22: note: expanded from macro 'be32toh'
# define be32toh(x) __bswap_32 (x)
^~~~~~~~~~~~~~
tools/hcidump.c:408:11: warning: Assigned value is garbage or undefined
frm.in = dh.in;
^ ~~~~~
tools/hcidump.c:437:7: warning: Null pointer passed to 1st parameter expecting 'nonnull'
fd = open(file, open_flags, 0644);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
11 warnings generated.
tools/ciptool.c:350:7: warning: 5th function call argument is an uninitialized value
sk = do_connect(ctl, dev_id, &src, &dst, psm, (1 << CMTP_LOOPBACK));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
src/sdp-xml.c:126:10: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
src/sdp-xml.c:300:11: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
src/sdp-xml.c:338:11: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
3 warnings generated.
tools/sdptool.c:941:26: warning: Result of 'malloc' is converted to a pointer of type 'uint32_t', which is incompatible with sizeof operand type 'int'
uint32_t *value_int = malloc(sizeof(int));
~~~~~~~~~~ ^~~~~~ ~~~~~~~~~~~
tools/sdptool.c:980:4: warning: 1st function call argument is an uninitialized value
free(allocArray[i]);
^~~~~~~~~~~~~~~~~~~
tools/sdptool.c:3777:2: warning: Potential leak of memory pointed to by 'si.name'
return add_service(0, &si);
^~~~~~~~~~~~~~~~~~~~~~~~~~
tools/sdptool.c:4112:4: warning: Potential leak of memory pointed to by 'context.svc'
return -1;
^~~~~~~~~
4 warnings generated.
tools/avtest.c:243:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:253:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 4);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:262:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:276:5: warning: Value stored to 'len' is never read
len = write(sk, buf,
^ ~~~~~~~~~~~~~~
tools/avtest.c:283:5: warning: Value stored to 'len' is never read
len = write(sk, buf,
^ ~~~~~~~~~~~~~~
tools/avtest.c:290:5: warning: Value stored to 'len' is never read
len = write(sk, buf,
^ ~~~~~~~~~~~~~~
tools/avtest.c:297:5: warning: Value stored to 'len' is never read
len = write(sk, buf,
^ ~~~~~~~~~~~~~~
tools/avtest.c:309:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 4);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:313:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:322:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:326:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:335:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:342:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:364:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 4);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:368:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:377:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:381:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:394:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 4);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:398:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:405:4: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:415:4: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:580:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:588:3: warning: Value stored to 'len' is never read
len = write(sk, buf, invalid ? 2 : 3);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/avtest.c:602:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 4 + media_transport_size);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/avtest.c:615:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:625:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:637:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:652:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:664:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:673:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:680:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:716:2: warning: Value stored to 'len' is never read
len = write(sk, buf, AVCTP_HEADER_LENGTH + sizeof(play_pressed));
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
32 warnings generated.
tools/btproxy.c:836:15: warning: Null pointer passed to 1st parameter expecting 'nonnull'
tcp_port = atoi(optarg);
^~~~~~~~~~~~
tools/btproxy.c:839:8: warning: Null pointer passed to 1st parameter expecting 'nonnull'
if (strlen(optarg) > 3 && !strncmp(optarg, "hci", 3))
^~~~~~~~~~~~~~
2 warnings generated.
tools/create-image.c:76:3: warning: Value stored to 'fd' is never read
fd = -1;
^ ~~
tools/create-image.c:84:3: warning: Value stored to 'fd' is never read
fd = -1;
^ ~~
tools/create-image.c:92:3: warning: Value stored to 'fd' is never read
fd = -1;
^ ~~
tools/create-image.c:105:2: warning: Value stored to 'fd' is never read
fd = -1;
^ ~~
4 warnings generated.
tools/check-selftest.c:42:3: warning: Value stored to 'ptr' is never read
ptr = fgets(result, sizeof(result), fp);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
tools/gatt-service.c:294:2: warning: 2nd function call argument is an uninitialized value
chr_write(chr, value, len);
^~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
tools/btgatt-server.c:1212:2: warning: Value stored to 'argv' is never read
argv -= optind;
^ ~~~~~~
1 warning generated.
tools/btgatt-client.c:1824:2: warning: Value stored to 'argv' is never read
argv += optind;
^ ~~~~~~
1 warning generated.
tools/obex-server-tool.c:133:13: warning: Null pointer passed to 1st parameter expecting 'nonnull'
data->fd = open(name, O_WRONLY | O_CREAT | O_NOCTTY, 0600);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/obex-server-tool.c:192:13: warning: Null pointer passed to 1st parameter expecting 'nonnull'
data->fd = open(name, O_RDONLY | O_NOCTTY, 0);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
tools/btpclientctl.c:402:3: warning: Value stored to 'bit' is never read
bit = 0;
^ ~
tools/btpclientctl.c:1655:2: warning: Null pointer passed to 2nd parameter expecting 'nonnull'
memcpy(cp->data, ad_data, ad_len);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
src/sdpd-request.c:211:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint16_t'
pElem = malloc(sizeof(uint16_t));
^~~~~~ ~~~~~~~~~~~~~~~~
src/sdpd-request.c:239:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint32_t'
pElem = malloc(sizeof(uint32_t));
^~~~~~ ~~~~~~~~~~~~~~~~
2 warnings generated.
android/avrcp-lib.c:1968:3: warning: 1st function call argument is an uninitialized value
g_free(text[i]);
^~~~~~~~~~~~~~~
1 warning generated.
profiles/audio/avdtp.c:893:25: warning: Use of memory after it is freed
session->prio_queue = g_slist_remove(session->prio_queue, req);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/avdtp.c:900:24: warning: Use of memory after it is freed
session->req_queue = g_slist_remove(session->req_queue, req);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
profiles/audio/a2dp.c:375:8: warning: Use of memory after it is freed
if (!cb->resume_cb)
^~~~~~~~~~~~~
profiles/audio/a2dp.c:3269:20: warning: Access to field 'starting' results in a dereference of a null pointer (loaded from variable 'stream')
stream->starting = TRUE;
~~~~~~ ^
profiles/audio/a2dp.c:3272:8: warning: Access to field 'suspending' results in a dereference of a null pointer (loaded from variable 'stream')
if (!stream->suspending && stream->suspend_timer) {
^~~~~~~~~~~~~~~~~~
profiles/audio/a2dp.c:3332:22: warning: Access to field 'suspending' results in a dereference of a null pointer (loaded from variable 'stream')
stream->suspending = TRUE;
~~~~~~ ^
4 warnings generated.
profiles/audio/avrcp.c:1961:2: warning: Value stored to 'operands' is never read
operands += sizeof(*pdu);
^ ~~~~~~~~~~~~
1 warning generated.
profiles/health/hdp.c:644:3: warning: Use of memory after it is freed
hdp_tmp_dc_data_unref(dc_data);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
profiles/health/hdp.c:800:19: warning: Use of memory after it is freed
path = g_strdup(chan->path);
^~~~~~~~~~
profiles/health/hdp.c:1779:6: warning: Use of memory after it is freed
hdp_tmp_dc_data_ref(hdp_conn),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
profiles/health/hdp.c:1836:30: warning: Use of memory after it is freed
reply = g_dbus_create_error(data->msg, ERROR_INTERFACE ".HealthError",
^~~~~~~~~
4 warnings generated.
profiles/health/hdp_util.c:1052:2: warning: Use of memory after it is freed
conn_data->func(conn_data->data, gerr);
^~~~~~~~~~~~~~~
1 warning generated.
attrib/gatt.c:970:2: warning: Potential leak of memory pointed to by 'long_write'
return prepare_write(long_write);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
src/sdpd-request.c:211:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint16_t'
pElem = malloc(sizeof(uint16_t));
^~~~~~ ~~~~~~~~~~~~~~~~
src/sdpd-request.c:239:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint32_t'
pElem = malloc(sizeof(uint32_t));
^~~~~~ ~~~~~~~~~~~~~~~~
2 warnings generated.
src/sdp-client.c:353:14: warning: Access to field 'cb' results in a dereference of a null pointer
(*ctxt)->cb = cb;
~~~~~~~~~~~~^~~~
1 warning generated.
src/sdp-xml.c:126:10: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
src/sdp-xml.c:300:11: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
src/sdp-xml.c:338:11: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
3 warnings generated.
src/gatt-database.c:1173:10: warning: Value stored to 'bits' during its initialization is never read
uint8_t bits[] = { BT_GATT_CHRC_CLI_FEAT_ROBUST_CACHING,
^~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
gobex/gobex-header.c:95:2: warning: Null pointer passed to 2nd parameter expecting 'nonnull'
memcpy(to, from, count);
^~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
gobex/gobex-transfer.c:423:7: warning: Use of memory after it is freed
if (!g_slist_find(transfers, transfer))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
obexd/client/pbap.c: In function ‘pbap_init_cb’:
obexd/client/pbap.c:1461:2: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
1461 | int err;
| ^~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:9930: obexd/client/obexd-pbap.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4690: all] Error 2
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH BlueZ 1/3] obexd: Pass at_(un)register value to logind callbacks
2025-06-03 16:01 ` Luiz Augusto von Dentz
@ 2025-06-04 9:03 ` Andrew Sayers
0 siblings, 0 replies; 10+ messages in thread
From: Andrew Sayers @ 2025-06-04 9:03 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: linux-bluetooth, pav, frederic.danis
On Tue, Jun 03, 2025 at 12:01:08PM -0400, Luiz Augusto von Dentz wrote:
> Hi Andrew,
>
> On Tue, Jun 3, 2025 at 11:17 AM Andrew Sayers
> <kernel.org@pileofstuff.org> wrote:
> >
> > Logind (un)registers callbacks that it calls when the user's state changes.
> > Callbacks may also be called during (un)registration.
> > Clients may need to handle those initial/final calls specially.
> >
> > Pass an argument indicating whether this is being called during
> > (un)registration, and modify existing callbacks to ignore that argument.
> >
> > Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>
> > ---
> > obexd/client/pbap.c | 6 ++++--
> > obexd/plugins/bluetooth.c | 6 ++++--
> > obexd/src/logind.c | 14 +++++++-------
> > obexd/src/logind.h | 8 ++++----
> > 4 files changed, 19 insertions(+), 15 deletions(-)
> >
> > diff --git a/obexd/client/pbap.c b/obexd/client/pbap.c
> > index 51b523592..64bb8ff72 100644
> > --- a/obexd/client/pbap.c
> > +++ b/obexd/client/pbap.c
> > @@ -1455,8 +1455,9 @@ static struct obc_driver pbap = {
> > .remove = pbap_remove
> > };
> >
> > -static int pbap_init_cb(void)
> > +static int pbap_init_cb(gboolean at_register)
> > {
> > + (void)at_register;
> > int err;
> >
> > DBG("");
> > @@ -1482,8 +1483,9 @@ static int pbap_init_cb(void)
> > return 0;
> > }
> >
> > -static void pbap_exit_cb(void)
> > +static void pbap_exit_cb(gboolean at_unregister)
> > {
> > + (void)at_unregister;
> > DBG("");
> >
> > g_dbus_remove_watch(system_conn, listener_id);
> > diff --git a/obexd/plugins/bluetooth.c b/obexd/plugins/bluetooth.c
> > index 7ff27a8a8..ad37e636d 100644
> > --- a/obexd/plugins/bluetooth.c
> > +++ b/obexd/plugins/bluetooth.c
> > @@ -427,8 +427,9 @@ static const struct obex_transport_driver driver = {
> >
> > static unsigned int listener_id = 0;
> >
> > -static int bluetooth_init_cb(void)
> > +static int bluetooth_init_cb(gboolean at_register)
> > {
> > + (void)at_register;
> > connection = g_dbus_setup_private(DBUS_BUS_SYSTEM, NULL, NULL);
> > if (connection == NULL)
> > return -EPERM;
> > @@ -439,8 +440,9 @@ static int bluetooth_init_cb(void)
> > return obex_transport_driver_register(&driver);
> > }
> >
> > -static void bluetooth_exit_cb(void)
> > +static void bluetooth_exit_cb(gboolean at_unregister)
> > {
> > + (void)at_unregister;
> > GSList *l;
> >
> > g_dbus_remove_watch(connection, listener_id);
> > diff --git a/obexd/src/logind.c b/obexd/src/logind.c
> > index a0eb62b1e..b4279b209 100644
> > --- a/obexd/src/logind.c
> > +++ b/obexd/src/logind.c
> > @@ -43,13 +43,13 @@ static void call_init_cb(gpointer data, gpointer user_data)
> > {
> > int res;
> >
> > - res = ((struct callback_pair *)data)->init_cb();
> > + res = ((struct callback_pair *)data)->init_cb(FALSE);
> > if (res)
> > *(int *)user_data = res;
> > }
> > static void call_exit_cb(gpointer data, gpointer user_data)
> > {
> > - ((struct callback_pair *)data)->exit_cb();
> > + ((struct callback_pair *)data)->exit_cb(FALSE);
> > }
> >
> > static int update(void)
> > @@ -229,7 +229,7 @@ int logind_register(logind_init_cb init_cb, logind_exit_cb exit_cb)
> > struct callback_pair *cbs;
> >
> > if (!monitoring_enabled)
> > - return init_cb();
> > + return init_cb(TRUE);
> > if (callbacks == NULL) {
> > int res;
> >
> > @@ -237,23 +237,23 @@ int logind_register(logind_init_cb init_cb, logind_exit_cb exit_cb)
> > if (res) {
> > error("logind_init(): %s - login detection disabled",
> > strerror(-res));
> > - return init_cb();
> > + return init_cb(TRUE);
> > }
> > }
> > cbs = g_new(struct callback_pair, 1);
> > cbs->init_cb = init_cb;
> > cbs->exit_cb = exit_cb;
> > callbacks = g_slist_prepend(callbacks, cbs);
> > - return active ? init_cb() : 0;
> > + return active ? init_cb(TRUE) : 0;
> > }
> > void logind_unregister(logind_init_cb init_cb, logind_exit_cb exit_cb)
> > {
> > GSList *cb_node;
> >
> > if (!monitoring_enabled)
> > - return exit_cb();
> > + return exit_cb(TRUE);
> > if (active)
> > - exit_cb();
> > + exit_cb(TRUE);
> > cb_node = g_slist_find_custom(callbacks, init_cb, find_cb);
> > if (cb_node != NULL)
> > callbacks = g_slist_delete_link(callbacks, cb_node);
> > diff --git a/obexd/src/logind.h b/obexd/src/logind.h
> > index eb3ff8d7b..3cdb03338 100644
> > --- a/obexd/src/logind.h
> > +++ b/obexd/src/logind.h
> > @@ -8,8 +8,8 @@
> > *
> > */
> >
> > -typedef int (*logind_init_cb)(void);
> > -typedef void (*logind_exit_cb)(void);
> > +typedef int (*logind_init_cb)(gboolean at_register);
> > +typedef void (*logind_exit_cb)(gboolean at_unregister);
> >
> > #ifdef SYSTEMD
> >
> > @@ -22,12 +22,12 @@ int logind_set(gboolean enabled);
> > static inline int logind_register(logind_init_cb init_cb,
> > logind_exit_cb exit_cb)
> > {
> > - return init_cb();
> > + return init_cb(TRUE);
> > }
> > static inline void logind_unregister(logind_init_cb init_cb,
> > logind_exit_cb exit_cb)
> > {
> > - return exit_cb();
> > + return exit_cb(TRUE);
> > }
> > static inline int logind_set(gboolean enabled)
> > {
> > --
> > 2.49.0
>
> This is not going very well in my opinion, it looks like we missed the
> opportunity to integrate the logind directly into obc_driver so we
> don't have to duplicate code for each coded, so we keep just doing
> plugin_init->obc_driver_register/plugin_exit->obc_driver_unregister
> and that internally can detect when it shall be registered with the
> Bluetoothd, etc, plugin_exit->obc_driver_unregister can actually be
> assumed to be exit rather than just D-Bus unregister which happens
> when seat is not longer active.
>
> --
> Luiz Augusto von Dentz
>
If I understand correctly, you want something like this:
static struct obc_driver pbap = {
.service = "PBAP",
.uuid = PBAP_UUID,
.target = OBEX_PBAP_UUID,
.target_len = OBEX_PBAP_UUID_LEN,
.supported_features = pbap_supported_features,
.probe = pbap_probe,
.remove = pbap_remove,
+ .seated = pbap_seated,
+ .unseated = pbap_unseated
};
That's fine, but it sounds like version 2. Would it be better to get this
bugfix ready to commit first, then talk about architecture in another thread?
I only see a couple of mistakes from bluez test bot (both "mixed declarations
and code"), but the new architecture will take a lot of work and may not be
right first time. Having a commit with no known bugs will make bisecting
easier, and having a fix out sooner will help users.
As an example of the problems to discuss in version 2 - bluetooth.c uses
obex_transport_driver instead of obc_driver, so the changes would need to go there too.
Getting that right will take more time and discussion, and could lead to some knock-on
change that adds more again.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH BlueZ 1/3] obexd: Pass at_(un)register value to logind callbacks
2025-06-03 15:13 ` [PATCH BlueZ 1/3] obexd: Pass at_(un)register value to logind callbacks Andrew Sayers
2025-06-03 16:01 ` Luiz Augusto von Dentz
2025-06-03 16:43 ` pbap: use the public DBus connection bluez.test.bot
@ 2025-06-06 16:55 ` Frédéric Danis
2 siblings, 0 replies; 10+ messages in thread
From: Frédéric Danis @ 2025-06-06 16:55 UTC (permalink / raw)
To: Andrew Sayers, linux-bluetooth; +Cc: luiz.dentz, pav
Hi Andrew,
On 03/06/2025 17:13, Andrew Sayers wrote:
> Logind (un)registers callbacks that it calls when the user's state changes.
> Callbacks may also be called during (un)registration.
> Clients may need to handle those initial/final calls specially.
>
> Pass an argument indicating whether this is being called during
> (un)registration, and modify existing callbacks to ignore that argument.
>
> Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>
> ---
> obexd/client/pbap.c | 6 ++++--
> obexd/plugins/bluetooth.c | 6 ++++--
> obexd/src/logind.c | 14 +++++++-------
> obexd/src/logind.h | 8 ++++----
> 4 files changed, 19 insertions(+), 15 deletions(-)
>
> diff --git a/obexd/client/pbap.c b/obexd/client/pbap.c
> index 51b523592..64bb8ff72 100644
> --- a/obexd/client/pbap.c
> +++ b/obexd/client/pbap.c
> @@ -1455,8 +1455,9 @@ static struct obc_driver pbap = {
> .remove = pbap_remove
> };
>
> -static int pbap_init_cb(void)
> +static int pbap_init_cb(gboolean at_register)
> {
> + (void)at_register;
> int err;
Building on Ubuntu 24.04 I got the following error:
obexd/client/pbap.c:1461:9: error: ISO C90 forbids mixed declarations
and code [-Werror=declaration-after-statement]
1461 | int err;
| ^~~
>
> DBG("");
> @@ -1482,8 +1483,9 @@ static int pbap_init_cb(void)
> return 0;
> }
>
> -static void pbap_exit_cb(void)
> +static void pbap_exit_cb(gboolean at_unregister)
> {
> + (void)at_unregister;
> DBG("");
>
> g_dbus_remove_watch(system_conn, listener_id);
> diff --git a/obexd/plugins/bluetooth.c b/obexd/plugins/bluetooth.c
> index 7ff27a8a8..ad37e636d 100644
> --- a/obexd/plugins/bluetooth.c
> +++ b/obexd/plugins/bluetooth.c
> @@ -427,8 +427,9 @@ static const struct obex_transport_driver driver = {
>
> static unsigned int listener_id = 0;
>
> -static int bluetooth_init_cb(void)
> +static int bluetooth_init_cb(gboolean at_register)
> {
> + (void)at_register;
> connection = g_dbus_setup_private(DBUS_BUS_SYSTEM, NULL, NULL);
> if (connection == NULL)
> return -EPERM;
> @@ -439,8 +440,9 @@ static int bluetooth_init_cb(void)
> return obex_transport_driver_register(&driver);
> }
>
> -static void bluetooth_exit_cb(void)
> +static void bluetooth_exit_cb(gboolean at_unregister)
> {
> + (void)at_unregister;
> GSList *l;
And:
obexd/plugins/bluetooth.c: In function ‘bluetooth_exit_cb’:
obexd/plugins/bluetooth.c:446:9: error: ISO C90 forbids mixed
declarations and code [-Werror=declaration-after-statement]
446 | GSList *l;
| ^~~~~~
>
> g_dbus_remove_watch(connection, listener_id);
> diff --git a/obexd/src/logind.c b/obexd/src/logind.c
> index a0eb62b1e..b4279b209 100644
> --- a/obexd/src/logind.c
> +++ b/obexd/src/logind.c
> @@ -43,13 +43,13 @@ static void call_init_cb(gpointer data, gpointer user_data)
> {
> int res;
>
> - res = ((struct callback_pair *)data)->init_cb();
> + res = ((struct callback_pair *)data)->init_cb(FALSE);
> if (res)
> *(int *)user_data = res;
> }
> static void call_exit_cb(gpointer data, gpointer user_data)
> {
> - ((struct callback_pair *)data)->exit_cb();
> + ((struct callback_pair *)data)->exit_cb(FALSE);
> }
>
> static int update(void)
> @@ -229,7 +229,7 @@ int logind_register(logind_init_cb init_cb, logind_exit_cb exit_cb)
> struct callback_pair *cbs;
>
> if (!monitoring_enabled)
> - return init_cb();
> + return init_cb(TRUE);
> if (callbacks == NULL) {
> int res;
>
> @@ -237,23 +237,23 @@ int logind_register(logind_init_cb init_cb, logind_exit_cb exit_cb)
> if (res) {
> error("logind_init(): %s - login detection disabled",
> strerror(-res));
> - return init_cb();
> + return init_cb(TRUE);
> }
> }
> cbs = g_new(struct callback_pair, 1);
> cbs->init_cb = init_cb;
> cbs->exit_cb = exit_cb;
> callbacks = g_slist_prepend(callbacks, cbs);
> - return active ? init_cb() : 0;
> + return active ? init_cb(TRUE) : 0;
> }
> void logind_unregister(logind_init_cb init_cb, logind_exit_cb exit_cb)
> {
> GSList *cb_node;
>
> if (!monitoring_enabled)
> - return exit_cb();
> + return exit_cb(TRUE);
> if (active)
> - exit_cb();
> + exit_cb(TRUE);
> cb_node = g_slist_find_custom(callbacks, init_cb, find_cb);
> if (cb_node != NULL)
> callbacks = g_slist_delete_link(callbacks, cb_node);
> diff --git a/obexd/src/logind.h b/obexd/src/logind.h
> index eb3ff8d7b..3cdb03338 100644
> --- a/obexd/src/logind.h
> +++ b/obexd/src/logind.h
> @@ -8,8 +8,8 @@
> *
> */
>
> -typedef int (*logind_init_cb)(void);
> -typedef void (*logind_exit_cb)(void);
> +typedef int (*logind_init_cb)(gboolean at_register);
> +typedef void (*logind_exit_cb)(gboolean at_unregister);
>
> #ifdef SYSTEMD
>
> @@ -22,12 +22,12 @@ int logind_set(gboolean enabled);
> static inline int logind_register(logind_init_cb init_cb,
> logind_exit_cb exit_cb)
> {
> - return init_cb();
> + return init_cb(TRUE);
> }
> static inline void logind_unregister(logind_init_cb init_cb,
> logind_exit_cb exit_cb)
> {
> - return exit_cb();
> + return exit_cb(TRUE);
> }
> static inline int logind_set(gboolean enabled)
> {
--
Frédéric Danis
Senior Software Engineer
Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, United Kingdom
Registered in England & Wales, no. 5513718
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH BlueZ 0/3] pbap: use the public DBus connection
2025-06-03 15:13 [PATCH BlueZ 0/3] pbap: use the public DBus connection Andrew Sayers
` (2 preceding siblings ...)
2025-06-03 15:13 ` [PATCH BlueZ 3/3] Revert "obexd: Support creating private system/session bus connections" Andrew Sayers
@ 2025-06-06 16:58 ` Frédéric Danis
3 siblings, 0 replies; 10+ messages in thread
From: Frédéric Danis @ 2025-06-06 16:58 UTC (permalink / raw)
To: Andrew Sayers, linux-bluetooth; +Cc: luiz.dentz, pav
Hi Andrew,
On 03/06/2025 17:13, Andrew Sayers wrote:
> DBus requests are received by the public DBus connection, because it
> registers the relevant bus name. My previous patches told PBAP to
> listen on a private connection, but DBus doesn't let connections share
> bus names, so it needs to listen on the public connection instead.
>
> This adds a little more complexity to the logind callbacks, to avoid
> unregistering profiles during shutdown. It also removes an API I
> previously added, which is no longer used and would only encourage the
> next person to make the same mistake.
>
> Reported-by: Frédéric Danis <frederic.danis@collabora.com>
> Closes: https://lore.kernel.org/linux-bluetooth/333ad76e-0aba-4f93-b141-8e69fb47535f@collabora.com/
> Suggested-by: Pauli Virtanen <pav@iki.fi>
> Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>
> ---
>
> Andrew Sayers (3):
> obexd: Pass at_(un)register value to logind callbacks
> pbap: use the public DBus connection
> Revert "obexd: Support creating private system/session bus connections"
>
> obexd/client/pbap.c | 28 ++++++++++++++++++++++++----
> obexd/plugins/bluetooth.c | 6 ++++--
> obexd/src/logind.c | 14 +++++++-------
> obexd/src/logind.h | 8 ++++----
> obexd/src/main.c | 8 --------
> obexd/src/obexd.h | 2 --
> 6 files changed, 39 insertions(+), 27 deletions(-)
>
Except 2 simple build errors, this allows me to connect the pbap profile.
Thanks
--
Frédéric Danis
Senior Software Engineer
Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, United Kingdom
Registered in England & Wales, no. 5513718
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: pbap: use the public DBus connection
2025-06-11 13:06 [PATCH BlueZ v2 1/3] obexd: Pass at_(un)register value to logind callbacks Andrew Sayers
@ 2025-06-11 14:35 ` bluez.test.bot
0 siblings, 0 replies; 10+ messages in thread
From: bluez.test.bot @ 2025-06-11 14:35 UTC (permalink / raw)
To: linux-bluetooth, kernel.org
[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=970848
---Test result---
Test Summary:
CheckPatch PENDING 0.34 seconds
GitLint PENDING 0.35 seconds
BuildEll PASS 19.98 seconds
BluezMake PASS 2634.06 seconds
MakeCheck PASS 20.60 seconds
MakeDistcheck PASS 198.09 seconds
CheckValgrind PASS 275.31 seconds
CheckSmatch PASS 306.04 seconds
bluezmakeextell PASS 129.10 seconds
IncrementalBuild PENDING 0.37 seconds
ScanBuild PASS 905.63 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2025-06-11 14:35 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-03 15:13 [PATCH BlueZ 0/3] pbap: use the public DBus connection Andrew Sayers
2025-06-03 15:13 ` [PATCH BlueZ 1/3] obexd: Pass at_(un)register value to logind callbacks Andrew Sayers
2025-06-03 16:01 ` Luiz Augusto von Dentz
2025-06-04 9:03 ` Andrew Sayers
2025-06-03 16:43 ` pbap: use the public DBus connection bluez.test.bot
2025-06-06 16:55 ` [PATCH BlueZ 1/3] obexd: Pass at_(un)register value to logind callbacks Frédéric Danis
2025-06-03 15:13 ` [PATCH BlueZ 2/3] pbap: use the public DBus connection Andrew Sayers
2025-06-03 15:13 ` [PATCH BlueZ 3/3] Revert "obexd: Support creating private system/session bus connections" Andrew Sayers
2025-06-06 16:58 ` [PATCH BlueZ 0/3] pbap: use the public DBus connection Frédéric Danis
-- strict thread matches above, loose matches on Subject: below --
2025-06-11 13:06 [PATCH BlueZ v2 1/3] obexd: Pass at_(un)register value to logind callbacks Andrew Sayers
2025-06-11 14:35 ` pbap: use the public DBus connection bluez.test.bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox