public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH BlueZ 1/2] advertising: client_remove: use concrete type
@ 2025-07-01 14:17 Christian Eggers
  2025-07-01 14:17 ` [PATCH BlueZ 2/2] mesh: node: remove dead function declaration Christian Eggers
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Christian Eggers @ 2025-07-01 14:17 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Christian Eggers

No need for using a void pointer here.
---
 src/advertising.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/advertising.c b/src/advertising.c
index 4476d7cd53a5..cc30c1c85ef6 100644
--- a/src/advertising.c
+++ b/src/advertising.c
@@ -195,9 +195,8 @@ static void remove_advertising(struct btd_adv_manager *manager,
 			manager->mgmt_index, sizeof(cp), &cp, NULL, NULL, NULL);
 }
 
-static void client_remove(void *data)
+static void client_remove(struct btd_adv_client *client)
 {
-	struct btd_adv_client *client = data;
 	struct mgmt_cp_remove_advertising cp;
 
 	g_dbus_client_set_proxy_handlers(client->client, NULL, NULL, NULL,
@@ -225,9 +224,11 @@ static void client_remove(void *data)
 
 static void client_disconnect_cb(DBusConnection *conn, void *user_data)
 {
+	struct btd_adv_client *client = user_data;
+
 	DBG("Client disconnected");
 
-	client_remove(user_data);
+	client_remove(client);
 }
 
 static bool parse_type(DBusMessageIter *iter, struct btd_adv_client *client)
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH BlueZ 2/2] mesh: node: remove dead function declaration
  2025-07-01 14:17 [PATCH BlueZ 1/2] advertising: client_remove: use concrete type Christian Eggers
@ 2025-07-01 14:17 ` Christian Eggers
  2025-07-01 15:56 ` [BlueZ,1/2] advertising: client_remove: use concrete type bluez.test.bot
  2025-07-02 17:30 ` [PATCH BlueZ 1/2] " patchwork-bot+bluetooth
  2 siblings, 0 replies; 4+ messages in thread
From: Christian Eggers @ 2025-07-01 14:17 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Christian Eggers

node_attach_io() has been removed in 7cdc215ff5a1 ("mesh: Add
finalization of a newly created node")
---
 mesh/node.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mesh/node.h b/mesh/node.h
index cba51cb93bbb..136173c8cee1 100644
--- a/mesh/node.h
+++ b/mesh/node.h
@@ -75,7 +75,6 @@ const char *node_get_app_path(struct mesh_node *node);
 bool node_add_pending_local(struct mesh_node *node,
 					const struct mesh_prov_node_info *info);
 void node_attach_io_all(struct mesh_io *io);
-void node_attach_io(struct mesh_node *node, struct mesh_io *io);
 void node_attach(const char *app_root, const char *sender, uint64_t token,
 					node_ready_func_t cb, void *user_data);
 void node_build_attach_reply(struct mesh_node *node,
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [BlueZ,1/2] advertising: client_remove: use concrete type
  2025-07-01 14:17 [PATCH BlueZ 1/2] advertising: client_remove: use concrete type Christian Eggers
  2025-07-01 14:17 ` [PATCH BlueZ 2/2] mesh: node: remove dead function declaration Christian Eggers
@ 2025-07-01 15:56 ` bluez.test.bot
  2025-07-02 17:30 ` [PATCH BlueZ 1/2] " patchwork-bot+bluetooth
  2 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2025-07-01 15:56 UTC (permalink / raw)
  To: linux-bluetooth, ceggers

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=977745

---Test result---

Test Summary:
CheckPatch                    PENDING   0.32 seconds
GitLint                       PENDING   0.29 seconds
BuildEll                      PASS      20.16 seconds
BluezMake                     PASS      2753.14 seconds
MakeCheck                     PASS      20.91 seconds
MakeDistcheck                 PASS      203.79 seconds
CheckValgrind                 PASS      278.65 seconds
CheckSmatch                   PASS      308.29 seconds
bluezmakeextell               PASS      128.35 seconds
IncrementalBuild              PENDING   0.24 seconds
ScanBuild                     PASS      919.87 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH BlueZ 1/2] advertising: client_remove: use concrete type
  2025-07-01 14:17 [PATCH BlueZ 1/2] advertising: client_remove: use concrete type Christian Eggers
  2025-07-01 14:17 ` [PATCH BlueZ 2/2] mesh: node: remove dead function declaration Christian Eggers
  2025-07-01 15:56 ` [BlueZ,1/2] advertising: client_remove: use concrete type bluez.test.bot
@ 2025-07-02 17:30 ` patchwork-bot+bluetooth
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+bluetooth @ 2025-07-02 17:30 UTC (permalink / raw)
  To: Christian Eggers; +Cc: linux-bluetooth

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 1 Jul 2025 16:17:38 +0200 you wrote:
> No need for using a void pointer here.
> ---
>  src/advertising.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Here is the summary with links:
  - [BlueZ,1/2] advertising: client_remove: use concrete type
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=90e2296ee459
  - [BlueZ,2/2] mesh: node: remove dead function declaration
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=50fb9042e1ad

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-07-02 17:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-01 14:17 [PATCH BlueZ 1/2] advertising: client_remove: use concrete type Christian Eggers
2025-07-01 14:17 ` [PATCH BlueZ 2/2] mesh: node: remove dead function declaration Christian Eggers
2025-07-01 15:56 ` [BlueZ,1/2] advertising: client_remove: use concrete type bluez.test.bot
2025-07-02 17:30 ` [PATCH BlueZ 1/2] " patchwork-bot+bluetooth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox