* [PATCH v1] Bluetooth: hci_ll: Fix compilation issue
@ 2025-07-15 3:03 Kiran K
2025-07-15 3:35 ` [v1] " bluez.test.bot
2025-07-15 4:11 ` [PATCH v1] " Ivan Pravdin
0 siblings, 2 replies; 4+ messages in thread
From: Kiran K @ 2025-07-15 3:03 UTC (permalink / raw)
To: linux-bluetooth; +Cc: ceggers, Kiran K
hci_ll.c: In function ‘ll_setup’:
hci_ll.c:656:68: error: ‘struct hci_dev’ has no member
named ‘quirks’
set_bit(HCI_QUIRK_INVALID_BDADDR, &hu->hdev->quirks);
Fixes: be736f5f89d5 ("Bluetooth: hci_dev: replace 'quirks' integer by 'quirk_flags' bitmap")
Signed-off-by: Kiran K <kiran.k@intel.com>
---
drivers/bluetooth/hci_ll.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
index e19e9bd49555..7044c86325ce 100644
--- a/drivers/bluetooth/hci_ll.c
+++ b/drivers/bluetooth/hci_ll.c
@@ -649,11 +649,11 @@ static int ll_setup(struct hci_uart *hu)
/* This means that there was an error getting the BD address
* during probe, so mark the device as having a bad address.
*/
- set_bit(HCI_QUIRK_INVALID_BDADDR, &hu->hdev->quirks);
+ hci_set_quirk(hu->hdev, HCI_QUIRK_INVALID_BDADDR);
} else if (bacmp(&lldev->bdaddr, BDADDR_ANY)) {
err = ll_set_bdaddr(hu->hdev, &lldev->bdaddr);
if (err)
- set_bit(HCI_QUIRK_INVALID_BDADDR, &hu->hdev->quirks);
+ hci_set_quirk(hu->hdev, HCI_QUIRK_INVALID_BDADDR);
}
/* Operational speed if any */
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [v1] Bluetooth: hci_ll: Fix compilation issue
2025-07-15 3:03 [PATCH v1] Bluetooth: hci_ll: Fix compilation issue Kiran K
@ 2025-07-15 3:35 ` bluez.test.bot
2025-07-15 4:11 ` [PATCH v1] " Ivan Pravdin
1 sibling, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2025-07-15 3:35 UTC (permalink / raw)
To: linux-bluetooth, kiran.k
[-- Attachment #1: Type: text/plain, Size: 2295 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=982292
---Test result---
Test Summary:
CheckPatch PENDING 0.35 seconds
GitLint PENDING 0.24 seconds
SubjectPrefix PASS 0.08 seconds
BuildKernel PASS 24.55 seconds
CheckAllWarning PASS 26.92 seconds
CheckSparse PASS 30.52 seconds
BuildKernel32 PASS 24.55 seconds
TestRunnerSetup PASS 468.24 seconds
TestRunner_l2cap-tester PASS 25.06 seconds
TestRunner_iso-tester PASS 38.01 seconds
TestRunner_bnep-tester PASS 5.95 seconds
TestRunner_mgmt-tester FAIL 135.29 seconds
TestRunner_rfcomm-tester PASS 9.32 seconds
TestRunner_sco-tester PASS 14.64 seconds
TestRunner_ioctl-tester PASS 9.91 seconds
TestRunner_mesh-tester FAIL 11.41 seconds
TestRunner_smp-tester PASS 8.45 seconds
TestRunner_userchan-tester PASS 6.14 seconds
IncrementalBuild PENDING 0.88 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 490, Passed: 485 (99.0%), Failed: 1, Not Run: 4
Failed Test Cases
LL Privacy - Set Flags 1 (Add to RL) Failed 0.168 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 2.233 seconds
Mesh - Send cancel - 2 Timed out 2.005 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] Bluetooth: hci_ll: Fix compilation issue
2025-07-15 3:03 [PATCH v1] Bluetooth: hci_ll: Fix compilation issue Kiran K
2025-07-15 3:35 ` [v1] " bluez.test.bot
@ 2025-07-15 4:11 ` Ivan Pravdin
2025-07-15 13:04 ` Luiz Augusto von Dentz
1 sibling, 1 reply; 4+ messages in thread
From: Ivan Pravdin @ 2025-07-15 4:11 UTC (permalink / raw)
To: Kiran K, linux-bluetooth; +Cc: ceggers
On Tue, Jul 15, 2025 at 08:33:18AM GMT, Kiran K wrote:
> hci_ll.c: In function ‘ll_setup’:
> hci_ll.c:656:68: error: ‘struct hci_dev’ has no member
> named ‘quirks’
> set_bit(HCI_QUIRK_INVALID_BDADDR, &hu->hdev->quirks);
>
> Fixes: be736f5f89d5 ("Bluetooth: hci_dev: replace 'quirks' integer by 'quirk_flags' bitmap")
> Signed-off-by: Kiran K <kiran.k@intel.com>
> ---
> drivers/bluetooth/hci_ll.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
> index e19e9bd49555..7044c86325ce 100644
> --- a/drivers/bluetooth/hci_ll.c
> +++ b/drivers/bluetooth/hci_ll.c
> @@ -649,11 +649,11 @@ static int ll_setup(struct hci_uart *hu)
> /* This means that there was an error getting the BD address
> * during probe, so mark the device as having a bad address.
> */
> - set_bit(HCI_QUIRK_INVALID_BDADDR, &hu->hdev->quirks);
> + hci_set_quirk(hu->hdev, HCI_QUIRK_INVALID_BDADDR);
> } else if (bacmp(&lldev->bdaddr, BDADDR_ANY)) {
> err = ll_set_bdaddr(hu->hdev, &lldev->bdaddr);
> if (err)
> - set_bit(HCI_QUIRK_INVALID_BDADDR, &hu->hdev->quirks);
> + hci_set_quirk(hu->hdev, HCI_QUIRK_INVALID_BDADDR);
> }
>
> /* Operational speed if any */
> --
> 2.43.0
>
Tested-by: Ivan Pravdin <ipravdin.official@gmail.com>
Ivan Pravdin
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] Bluetooth: hci_ll: Fix compilation issue
2025-07-15 4:11 ` [PATCH v1] " Ivan Pravdin
@ 2025-07-15 13:04 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2025-07-15 13:04 UTC (permalink / raw)
To: Ivan Pravdin; +Cc: Kiran K, linux-bluetooth, ceggers
Hi Kiran, Ivan,
On Tue, Jul 15, 2025 at 12:31 AM Ivan Pravdin
<ipravdin.official@gmail.com> wrote:
>
> On Tue, Jul 15, 2025 at 08:33:18AM GMT, Kiran K wrote:
> > hci_ll.c: In function ‘ll_setup’:
> > hci_ll.c:656:68: error: ‘struct hci_dev’ has no member
> > named ‘quirks’
> > set_bit(HCI_QUIRK_INVALID_BDADDR, &hu->hdev->quirks);
> >
> > Fixes: be736f5f89d5 ("Bluetooth: hci_dev: replace 'quirks' integer by 'quirk_flags' bitmap")
> > Signed-off-by: Kiran K <kiran.k@intel.com>
I went ahead and amend the original change adding your signed-off and tested-by.
> > ---
> > drivers/bluetooth/hci_ll.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
> > index e19e9bd49555..7044c86325ce 100644
> > --- a/drivers/bluetooth/hci_ll.c
> > +++ b/drivers/bluetooth/hci_ll.c
> > @@ -649,11 +649,11 @@ static int ll_setup(struct hci_uart *hu)
> > /* This means that there was an error getting the BD address
> > * during probe, so mark the device as having a bad address.
> > */
> > - set_bit(HCI_QUIRK_INVALID_BDADDR, &hu->hdev->quirks);
> > + hci_set_quirk(hu->hdev, HCI_QUIRK_INVALID_BDADDR);
> > } else if (bacmp(&lldev->bdaddr, BDADDR_ANY)) {
> > err = ll_set_bdaddr(hu->hdev, &lldev->bdaddr);
> > if (err)
> > - set_bit(HCI_QUIRK_INVALID_BDADDR, &hu->hdev->quirks);
> > + hci_set_quirk(hu->hdev, HCI_QUIRK_INVALID_BDADDR);
> > }
> >
> > /* Operational speed if any */
> > --
> > 2.43.0
> >
>
> Tested-by: Ivan Pravdin <ipravdin.official@gmail.com>
>
> Ivan Pravdin
>
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-15 13:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-15 3:03 [PATCH v1] Bluetooth: hci_ll: Fix compilation issue Kiran K
2025-07-15 3:35 ` [v1] " bluez.test.bot
2025-07-15 4:11 ` [PATCH v1] " Ivan Pravdin
2025-07-15 13:04 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox