[PATCH] Bluetooth: btintel_pcie: Drop pci_set_drvdata(pdev, NULL)

[PATCH] Bluetooth: btintel_pcie: Drop pci_set_drvdata(pdev, NULL)

[Salah Triki]

Drop pci_set_drvdata(pdev, NULL) in the remove function of the pci
driver since it is useless, the data is not accessible when the driver
is removed.

Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
 drivers/bluetooth/btintel_pcie.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
index e1c688dd2d45..28fa4ca3199a 100644
--- a/drivers/bluetooth/btintel_pcie.c
+++ b/drivers/bluetooth/btintel_pcie.c
@@ -2339,8 +2339,6 @@ static void btintel_pcie_remove(struct pci_dev *pdev)
 	btintel_pcie_free(data);
 
 	pci_clear_master(pdev);
-
-	pci_set_drvdata(pdev, NULL);
 }
 
 #ifdef CONFIG_DEV_COREDUMP
-- 
2.43.0

RE: Bluetooth: btintel_pcie: Drop pci_set_drvdata(pdev, NULL)

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2027 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=983173

---Test result---

Test Summary:
CheckPatch                    PENDING   0.40 seconds
GitLint                       PENDING   0.35 seconds
SubjectPrefix                 PASS      0.07 seconds
BuildKernel                   PASS      23.84 seconds
CheckAllWarning               PASS      26.62 seconds
CheckSparse                   PASS      30.36 seconds
BuildKernel32                 PASS      23.83 seconds
TestRunnerSetup               PASS      471.64 seconds
TestRunner_l2cap-tester       PASS      25.18 seconds
TestRunner_iso-tester         PASS      42.60 seconds
TestRunner_bnep-tester        PASS      5.92 seconds
TestRunner_mgmt-tester        PASS      132.54 seconds
TestRunner_rfcomm-tester      PASS      9.34 seconds
TestRunner_sco-tester         PASS      14.70 seconds
TestRunner_ioctl-tester       PASS      9.97 seconds
TestRunner_mesh-tester        FAIL      11.37 seconds
TestRunner_smp-tester         PASS      8.51 seconds
TestRunner_userchan-tester    PASS      6.17 seconds
IncrementalBuild              PENDING   0.61 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    2.068 seconds
Mesh - Send cancel - 2                               Timed out    1.999 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH] Bluetooth: btintel_pcie: Drop pci_set_drvdata(pdev, NULL)

[Salah Triki]

Hi Marcel, Luiz, and linux-bluetooth community,

Thank you for the CI test results on my patch [PATCH] Bluetooth: btintel: Drop
pci_set_drvdata(pdev, NULL).

I've reviewed the automated test results and noted the failure of `TestRunner_mesh-tester`,
specifically the "Mesh - Send cancel - 1" and "Mesh - Send cancel - 2" cases which timed out.

I'm currently investigating why this seemingly unrelated change might be impacting the mesh
tester functionality. I will work to understand the root cause and will submit a revised
patch if necessary.

Could you send some information about the two test cases ?

Thank you for your time and review.

Best regards,
Salah Triki

RE: [PATCH] Bluetooth: btintel_pcie: Drop pci_set_drvdata(pdev, NULL)

[K, Kiran]

Hi Luiz,

>-----Original Message-----
>From: Salah Triki <salah.triki@gmail.com>
>Sent: Thursday, July 17, 2025 8:55 AM
>To: Marcel Holtmann <marcel@holtmann.org>; Luiz Augusto von Dentz
><luiz.dentz@gmail.com>; linux-bluetooth@vger.kernel.org; linux-
>kernel@vger.kernel.org
>Cc: salah.triki@gmail.com
>Subject: [PATCH] Bluetooth: btintel_pcie: Drop pci_set_drvdata(pdev, NULL)
>
>Drop pci_set_drvdata(pdev, NULL) in the remove function of the pci driver
>since it is useless, the data is not accessible when the driver is removed.
>
>Signed-off-by: Salah Triki <salah.triki@gmail.com>

Tested-by: Kiran K <kiran.k@intel.com>
>---
> drivers/bluetooth/btintel_pcie.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
>index e1c688dd2d45..28fa4ca3199a 100644
>--- a/drivers/bluetooth/btintel_pcie.c
>+++ b/drivers/bluetooth/btintel_pcie.c
>@@ -2339,8 +2339,6 @@ static void btintel_pcie_remove(struct pci_dev
>*pdev)
> 	btintel_pcie_free(data);
>
> 	pci_clear_master(pdev);
>-
>-	pci_set_drvdata(pdev, NULL);
> }
>
> #ifdef CONFIG_DEV_COREDUMP
>--
>2.43.0
>
Thanks,
Kiran