Re: [PATCH v1] Bluetooth: btintel: Add support for BlazarIW core

Re: [PATCH v1] Bluetooth: btintel: Add support for BlazarIW core

[Paul Menzel]

Dear Kiran,


Am 23.07.25 um 08:26 schrieb Kiran K:
> Need to add support for BlazarIW Bluetooth core used in Wildcat Lake
> platform.

Need to … sounds strange for a commit message.

Where is the id from? It’d be great if you added the datasheet name and 
revision.

Also, how did you test this?

> Signed-off-by: Vijay Satija <vijay.satija@intel.com>
> Signed-off-by: Kiran K <kiran.k@intel.com>
> ---
>   drivers/bluetooth/btintel.c      | 3 +++
>   drivers/bluetooth/btintel_pcie.c | 1 +
>   2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index be69d21c9aa7..ea1521c6b2d3 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -484,6 +484,7 @@ int btintel_version_info_tlv(struct hci_dev *hdev,
>   	case 0x1d:	/* BlazarU (BzrU) */
>   	case 0x1e:	/* BlazarI (Bzr) */
>   	case 0x1f:      /* Scorpious Peak */
> +	case 0x22:	/* BlazarIW (BzrIW */

Missing closing ).

>   		break;
>   	default:
>   		bt_dev_err(hdev, "Unsupported Intel hardware variant (0x%x)",
> @@ -3253,6 +3254,7 @@ void btintel_set_msft_opcode(struct hci_dev *hdev, u8 hw_variant)
>   	case 0x1d:
>   	case 0x1e:
>   	case 0x1f:
> +	case 0x22:
>   		hci_set_msft_opcode(hdev, 0xFC1E);
>   		break;
>   	default:
> @@ -3593,6 +3595,7 @@ static int btintel_setup_combined(struct hci_dev *hdev)
>   	case 0x1d:
>   	case 0x1e:
>   	case 0x1f:
> +	case 0x22:
>   		/* Display version information of TLV type */
>   		btintel_version_info_tlv(hdev, &ver_tlv);
>   
> diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
> index 6e7bbbd35279..d08f59ae7720 100644
> --- a/drivers/bluetooth/btintel_pcie.c
> +++ b/drivers/bluetooth/btintel_pcie.c
> @@ -2149,6 +2149,7 @@ static int btintel_pcie_setup_internal(struct hci_dev *hdev)
>   	switch (INTEL_HW_VARIANT(ver_tlv.cnvi_bt)) {
>   	case 0x1e:	/* BzrI */
>   	case 0x1f:	/* ScP  */
> +	case 0x22:	/* BzrIW */
>   		/* Display version information of TLV type */
>   		btintel_version_info_tlv(hdev, &ver_tlv);
>   

The rest looks good.


Kind regards,

Paul

[PATCH v1] Bluetooth: btintel: Add support for BlazarIW core

[Kiran K]

Need to add support for BlazarIW Bluetooth core used in Wildcat Lake
platform.

Signed-off-by: Vijay Satija <vijay.satija@intel.com>
Signed-off-by: Kiran K <kiran.k@intel.com>
---
 drivers/bluetooth/btintel.c      | 3 +++
 drivers/bluetooth/btintel_pcie.c | 1 +
 2 files changed, 4 insertions(+)

diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index be69d21c9aa7..ea1521c6b2d3 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -484,6 +484,7 @@ int btintel_version_info_tlv(struct hci_dev *hdev,
 	case 0x1d:	/* BlazarU (BzrU) */
 	case 0x1e:	/* BlazarI (Bzr) */
 	case 0x1f:      /* Scorpious Peak */
+	case 0x22:	/* BlazarIW (BzrIW */
 		break;
 	default:
 		bt_dev_err(hdev, "Unsupported Intel hardware variant (0x%x)",
@@ -3253,6 +3254,7 @@ void btintel_set_msft_opcode(struct hci_dev *hdev, u8 hw_variant)
 	case 0x1d:
 	case 0x1e:
 	case 0x1f:
+	case 0x22:
 		hci_set_msft_opcode(hdev, 0xFC1E);
 		break;
 	default:
@@ -3593,6 +3595,7 @@ static int btintel_setup_combined(struct hci_dev *hdev)
 	case 0x1d:
 	case 0x1e:
 	case 0x1f:
+	case 0x22:
 		/* Display version information of TLV type */
 		btintel_version_info_tlv(hdev, &ver_tlv);
 
diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
index 6e7bbbd35279..d08f59ae7720 100644
--- a/drivers/bluetooth/btintel_pcie.c
+++ b/drivers/bluetooth/btintel_pcie.c
@@ -2149,6 +2149,7 @@ static int btintel_pcie_setup_internal(struct hci_dev *hdev)
 	switch (INTEL_HW_VARIANT(ver_tlv.cnvi_bt)) {
 	case 0x1e:	/* BzrI */
 	case 0x1f:	/* ScP  */
+	case 0x22:	/* BzrIW */
 		/* Display version information of TLV type */
 		btintel_version_info_tlv(hdev, &ver_tlv);
 
-- 
2.43.0

RE: [v1] Bluetooth: btintel: Add support for BlazarIW core

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2296 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=984974

---Test result---

Test Summary:
CheckPatch                    PENDING   0.29 seconds
GitLint                       PENDING   0.21 seconds
SubjectPrefix                 PASS      0.13 seconds
BuildKernel                   PASS      24.06 seconds
CheckAllWarning               PASS      26.65 seconds
CheckSparse                   PASS      30.00 seconds
BuildKernel32                 PASS      24.11 seconds
TestRunnerSetup               PASS      471.66 seconds
TestRunner_l2cap-tester       PASS      25.25 seconds
TestRunner_iso-tester         PASS      40.21 seconds
TestRunner_bnep-tester        PASS      6.16 seconds
TestRunner_mgmt-tester        FAIL      133.14 seconds
TestRunner_rfcomm-tester      PASS      9.54 seconds
TestRunner_sco-tester         PASS      14.99 seconds
TestRunner_ioctl-tester       PASS      10.14 seconds
TestRunner_mesh-tester        FAIL      11.69 seconds
TestRunner_smp-tester         PASS      8.65 seconds
TestRunner_userchan-tester    PASS      6.42 seconds
IncrementalBuild              PENDING   0.95 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 490, Passed: 485 (99.0%), Failed: 1, Not Run: 4

Failed Test Cases
LL Privacy - Set Device Flag 1 (Device Privacy)      Failed       0.156 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    2.160 seconds
Mesh - Send cancel - 2                               Timed out    1.989 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH v1] Bluetooth: btintel: Add support for BlazarIW core

[Bastien Nocera]

On Wed, 2025-07-23 at 11:56 +0530, Kiran K wrote:
> Need to add support for BlazarIW Bluetooth core used in Wildcat Lake
> platform.
> 
> Signed-off-by: Vijay Satija <vijay.satija@intel.com>
> Signed-off-by: Kiran K <kiran.k@intel.com>

Do you have a "tested-by" too?

Is there an "lspci" or similar output that could be added to the commit
message that would help identify this device?

Typo mentioned in the comments below.

Cheers

> ---
>  drivers/bluetooth/btintel.c      | 3 +++
>  drivers/bluetooth/btintel_pcie.c | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/bluetooth/btintel.c
> b/drivers/bluetooth/btintel.c
> index be69d21c9aa7..ea1521c6b2d3 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -484,6 +484,7 @@ int btintel_version_info_tlv(struct hci_dev
> *hdev,
>  	case 0x1d:	/* BlazarU (BzrU) */
>  	case 0x1e:	/* BlazarI (Bzr) */
>  	case 0x1f:      /* Scorpious Peak */
> +	case 0x22:	/* BlazarIW (BzrIW */

Missing closing paren

<snip>

Re: [PATCH v1] Bluetooth: btintel: Add support for BlazarIW core

[Bastien Nocera]

On Wed, 2025-07-23 at 10:42 +0200, Bastien Nocera wrote:
> On Wed, 2025-07-23 at 11:56 +0530, Kiran K wrote:
> > Need to add support for BlazarIW Bluetooth core used in Wildcat
> > Lake
> > platform.
> > 
> > Signed-off-by: Vijay Satija <vijay.satija@intel.com>
> > Signed-off-by: Kiran K <kiran.k@intel.com>
> 
> Do you have a "tested-by" too?
> 
> Is there an "lspci" or similar output that could be added to the
> commit
> message that would help identify this device?

FWIW, Vijay's address doesn't work. Would be good to have a working
one, otherwise please remove his name from the commit message.

> 
> Typo mentioned in the comments below.
> 
> Cheers
> 
> > ---
> >  drivers/bluetooth/btintel.c      | 3 +++
> >  drivers/bluetooth/btintel_pcie.c | 1 +
> >  2 files changed, 4 insertions(+)
> > 
> > diff --git a/drivers/bluetooth/btintel.c
> > b/drivers/bluetooth/btintel.c
> > index be69d21c9aa7..ea1521c6b2d3 100644
> > --- a/drivers/bluetooth/btintel.c
> > +++ b/drivers/bluetooth/btintel.c
> > @@ -484,6 +484,7 @@ int btintel_version_info_tlv(struct hci_dev
> > *hdev,
> >  	case 0x1d:	/* BlazarU (BzrU) */
> >  	case 0x1e:	/* BlazarI (Bzr) */
> >  	case 0x1f:      /* Scorpious Peak */
> > +	case 0x22:	/* BlazarIW (BzrIW */
> 
> Missing closing paren
> 
> <snip>

RE: [PATCH v1] Bluetooth: btintel: Add support for BlazarIW core

[K, Kiran]

Hi Paul,

Thanks for the comments.

>-----Original Message-----
>From: Paul Menzel <pmenzel@molgen.mpg.de>
>Sent: Wednesday, July 23, 2025 11:51 AM
>To: K, Kiran <kiran.k@intel.com>
>Cc: linux-bluetooth@vger.kernel.org; Srivatsa, Ravishankar
><ravishankar.srivatsa@intel.com>; Vijay Satija <vijay.satija@intel.com>
>Subject: Re: [PATCH v1] Bluetooth: btintel: Add support for BlazarIW core
>
>Dear Kiran,
>
>
>Am 23.07.25 um 08:26 schrieb Kiran K:
>> Need to add support for BlazarIW Bluetooth core used in Wildcat Lake
>> platform.
>
>Need to … sounds strange for a commit message.

Ack. I will modify the commit message.

>
>Where is the id from? It’d be great if you added the datasheet name and
>revision.
Id comes from hardware requirements which is maintained in JIRAs.
>
>Also, how did you test this?
It was tested on silicon.  May be I can add the firmware download messages from dmesg.
>
>> Signed-off-by: Vijay Satija <vijay.satija@intel.com>
>> Signed-off-by: Kiran K <kiran.k@intel.com>
>> ---
>>   drivers/bluetooth/btintel.c      | 3 +++
>>   drivers/bluetooth/btintel_pcie.c | 1 +
>>   2 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
>> index be69d21c9aa7..ea1521c6b2d3 100644
>> --- a/drivers/bluetooth/btintel.c
>> +++ b/drivers/bluetooth/btintel.c
>> @@ -484,6 +484,7 @@ int btintel_version_info_tlv(struct hci_dev *hdev,
>>   	case 0x1d:	/* BlazarU (BzrU) */
>>   	case 0x1e:	/* BlazarI (Bzr) */
>>   	case 0x1f:      /* Scorpious Peak */
>> +	case 0x22:	/* BlazarIW (BzrIW */
>
>Missing closing ).
Ack
>
>>   		break;
>>   	default:
>>   		bt_dev_err(hdev, "Unsupported Intel hardware variant
>(0x%x)", @@
>> -3253,6 +3254,7 @@ void btintel_set_msft_opcode(struct hci_dev *hdev, u8
>hw_variant)
>>   	case 0x1d:
>>   	case 0x1e:
>>   	case 0x1f:
>> +	case 0x22:
>>   		hci_set_msft_opcode(hdev, 0xFC1E);
>>   		break;
>>   	default:
>> @@ -3593,6 +3595,7 @@ static int btintel_setup_combined(struct hci_dev
>*hdev)
>>   	case 0x1d:
>>   	case 0x1e:
>>   	case 0x1f:
>> +	case 0x22:
>>   		/* Display version information of TLV type */
>>   		btintel_version_info_tlv(hdev, &ver_tlv);
>>
>> diff --git a/drivers/bluetooth/btintel_pcie.c
>> b/drivers/bluetooth/btintel_pcie.c
>> index 6e7bbbd35279..d08f59ae7720 100644
>> --- a/drivers/bluetooth/btintel_pcie.c
>> +++ b/drivers/bluetooth/btintel_pcie.c
>> @@ -2149,6 +2149,7 @@ static int btintel_pcie_setup_internal(struct
>hci_dev *hdev)
>>   	switch (INTEL_HW_VARIANT(ver_tlv.cnvi_bt)) {
>>   	case 0x1e:	/* BzrI */
>>   	case 0x1f:	/* ScP  */
>> +	case 0x22:	/* BzrIW */
>>   		/* Display version information of TLV type */
>>   		btintel_version_info_tlv(hdev, &ver_tlv);
>>
>
>The rest looks good.
>
>
>Kind regards,
>
>Paul

Thanks,
Kiran

RE: [v1] Bluetooth: btintel: Add support for BlazarIW core

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2296 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=985135

---Test result---

Test Summary:
CheckPatch                    PENDING   0.31 seconds
GitLint                       PENDING   0.30 seconds
SubjectPrefix                 PASS      0.12 seconds
BuildKernel                   PASS      24.18 seconds
CheckAllWarning               PASS      29.81 seconds
CheckSparse                   PASS      29.90 seconds
BuildKernel32                 PASS      24.30 seconds
TestRunnerSetup               PASS      473.54 seconds
TestRunner_l2cap-tester       PASS      25.30 seconds
TestRunner_iso-tester         PASS      42.63 seconds
TestRunner_bnep-tester        PASS      6.19 seconds
TestRunner_mgmt-tester        FAIL      135.30 seconds
TestRunner_rfcomm-tester      PASS      9.46 seconds
TestRunner_sco-tester         PASS      14.88 seconds
TestRunner_ioctl-tester       PASS      10.33 seconds
TestRunner_mesh-tester        FAIL      11.63 seconds
TestRunner_smp-tester         PASS      8.84 seconds
TestRunner_userchan-tester    PASS      6.45 seconds
IncrementalBuild              PENDING   0.64 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 490, Passed: 485 (99.0%), Failed: 1, Not Run: 4

Failed Test Cases
LL Privacy - Start Discovery 1 (Disable RL)          Failed       0.186 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    2.072 seconds
Mesh - Send cancel - 2                               Timed out    1.996 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth