[PATCH v1 1/2] Bluetooth: btintel_pcie: Add Bluetooth core and platform details

[PATCH v1 1/2] Bluetooth: btintel_pcie: Add Bluetooth core and platform details

[Kiran K]

Add Bluetooth CNVi core and platform details to the PCI device table
for each device ID.

Signed-off-by: Kiran K <kiran.k@intel.com>
---
 drivers/bluetooth/btintel_pcie.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
index 9792a49886ff..14d59d1353cd 100644
--- a/drivers/bluetooth/btintel_pcie.c
+++ b/drivers/bluetooth/btintel_pcie.c
@@ -35,9 +35,9 @@
 
 /* Intel Bluetooth PCIe device id table */
 static const struct pci_device_id btintel_pcie_table[] = {
-	{ BTINTEL_PCI_DEVICE(0x4D76, PCI_ANY_ID) },
-	{ BTINTEL_PCI_DEVICE(0xA876, PCI_ANY_ID) },
-	{ BTINTEL_PCI_DEVICE(0xE476, PCI_ANY_ID) },
+	{ BTINTEL_PCI_DEVICE(0x4D76, PCI_ANY_ID) }, /* BlazarI, Wildcat Lake */
+	{ BTINTEL_PCI_DEVICE(0xA876, PCI_ANY_ID) }, /* BlazarI, Lunar Lake */
+	{ BTINTEL_PCI_DEVICE(0xE476, PCI_ANY_ID) }, /* Scorpious, Panther Lake-H */
 	{ 0 }
 };
 MODULE_DEVICE_TABLE(pci, btintel_pcie_table);
-- 
2.43.0

[PATCH v1 2/2] Bluetooth: btintel_pcie: Add support for device

[Kiran K]

sudo lspci -v -k -d 8086:e376
00:14.7 Bluetooth: Intel Corporation Device e376
        Subsystem: Intel Corporation Device 0011
        Flags: bus master, fast devsel, latency 0, IRQ 16, IOMMU group 14
        Memory at 14815368000 (64-bit, non-prefetchable) [size=16K]
        Capabilities: [c8] Power Management version 3
        Capabilities: [d0] MSI: Enable- Count=1/1 Maskable- 64bit+
        Capabilities: [40] Express Root Complex Integrated Endpoint, MSI 00
        Capabilities: [80] MSI-X: Enable+ Count=32 Masked-
        Capabilities: [100] Latency Tolerance Reporting
        Kernel driver in use: btintel_pcie
        Kernel modules: btintel_pcie

Signed-off-by: Kiran K <kiran.k@intel.com>
---
 drivers/bluetooth/btintel_pcie.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
index 14d59d1353cd..cf0b77ba378e 100644
--- a/drivers/bluetooth/btintel_pcie.c
+++ b/drivers/bluetooth/btintel_pcie.c
@@ -37,7 +37,8 @@
 static const struct pci_device_id btintel_pcie_table[] = {
 	{ BTINTEL_PCI_DEVICE(0x4D76, PCI_ANY_ID) }, /* BlazarI, Wildcat Lake */
 	{ BTINTEL_PCI_DEVICE(0xA876, PCI_ANY_ID) }, /* BlazarI, Lunar Lake */
-	{ BTINTEL_PCI_DEVICE(0xE476, PCI_ANY_ID) }, /* Scorpious, Panther Lake-H */
+	{ BTINTEL_PCI_DEVICE(0xE376, PCI_ANY_ID) }, /* Scorpious, Panther Lake-H484 */
+	{ BTINTEL_PCI_DEVICE(0xE476, PCI_ANY_ID) }, /* Scorpious, Panther Lake-H404 */
 	{ 0 }
 };
 MODULE_DEVICE_TABLE(pci, btintel_pcie_table);
-- 
2.43.0

RE: [v1,1/2] Bluetooth: btintel_pcie: Add Bluetooth core and platform details

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2028 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=985792

---Test result---

Test Summary:
CheckPatch                    PENDING   0.35 seconds
GitLint                       PENDING   0.26 seconds
SubjectPrefix                 PASS      0.18 seconds
BuildKernel                   PASS      24.07 seconds
CheckAllWarning               PASS      26.46 seconds
CheckSparse                   PASS      30.81 seconds
BuildKernel32                 PASS      24.47 seconds
TestRunnerSetup               PASS      487.14 seconds
TestRunner_l2cap-tester       PASS      25.63 seconds
TestRunner_iso-tester         PASS      39.38 seconds
TestRunner_bnep-tester        PASS      6.02 seconds
TestRunner_mgmt-tester        PASS      129.10 seconds
TestRunner_rfcomm-tester      PASS      9.57 seconds
TestRunner_sco-tester         PASS      15.17 seconds
TestRunner_ioctl-tester       PASS      10.44 seconds
TestRunner_mesh-tester        FAIL      12.35 seconds
TestRunner_smp-tester         PASS      8.97 seconds
TestRunner_userchan-tester    PASS      6.25 seconds
IncrementalBuild              PENDING   0.94 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    2.677 seconds
Mesh - Send cancel - 2                               Timed out    1.997 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH v1 1/2] Bluetooth: btintel_pcie: Add Bluetooth core and platform details

[Paul Menzel]

Dear Kiran,


Thank you for your patch.

Am 25.07.25 um 05:31 schrieb Kiran K:
> Add Bluetooth CNVi core and platform details to the PCI device table
> for each device ID.

It’d be great if you made it more clear that comments are added. Maybe:

Bluetooth: btintel_pcie: Add core/platform names as comments

Add Bluetooth CNVi core and platform names to the PCI device table
for each device ID as a comment.

> Signed-off-by: Kiran K <kiran.k@intel.com>
> ---
>   drivers/bluetooth/btintel_pcie.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
> index 9792a49886ff..14d59d1353cd 100644
> --- a/drivers/bluetooth/btintel_pcie.c
> +++ b/drivers/bluetooth/btintel_pcie.c
> @@ -35,9 +35,9 @@
>   
>   /* Intel Bluetooth PCIe device id table */
>   static const struct pci_device_id btintel_pcie_table[] = {
> -	{ BTINTEL_PCI_DEVICE(0x4D76, PCI_ANY_ID) },
> -	{ BTINTEL_PCI_DEVICE(0xA876, PCI_ANY_ID) },
> -	{ BTINTEL_PCI_DEVICE(0xE476, PCI_ANY_ID) },
> +	{ BTINTEL_PCI_DEVICE(0x4D76, PCI_ANY_ID) }, /* BlazarI, Wildcat Lake */
> +	{ BTINTEL_PCI_DEVICE(0xA876, PCI_ANY_ID) }, /* BlazarI, Lunar Lake */
> +	{ BTINTEL_PCI_DEVICE(0xE476, PCI_ANY_ID) }, /* Scorpious, Panther Lake-H */

Why not add H484 at the end right away from the patch 2/2?

>   	{ 0 }
>   };
>   MODULE_DEVICE_TABLE(pci, btintel_pcie_table);

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul

RE: [PATCH v1 1/2] Bluetooth: btintel_pcie: Add Bluetooth core and platform details

[K, Kiran]

Hi Paul,

Thanks for your comments.

>-----Original Message-----
>From: Paul Menzel <pmenzel@molgen.mpg.de>
>Sent: Friday, July 25, 2025 7:04 PM
>To: K, Kiran <kiran.k@intel.com>
>Cc: linux-bluetooth@vger.kernel.org; Srivatsa, Ravishankar
><ravishankar.srivatsa@intel.com>; Devegowda, Chandrashekar
><chandrashekar.devegowda@intel.com>
>Subject: Re: [PATCH v1 1/2] Bluetooth: btintel_pcie: Add Bluetooth core and
>platform details
>
>Dear Kiran,
>
>
>Thank you for your patch.
>
>Am 25.07.25 um 05:31 schrieb Kiran K:
>> Add Bluetooth CNVi core and platform details to the PCI device table
>> for each device ID.
>
>It’d be great if you made it more clear that comments are added. Maybe:
>
>Bluetooth: btintel_pcie: Add core/platform names as comments
>
>Add Bluetooth CNVi core and platform names to the PCI device table for each
>device ID as a comment.

Ack. I will amend the commit message.

>
>> Signed-off-by: Kiran K <kiran.k@intel.com>
>> ---
>>   drivers/bluetooth/btintel_pcie.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/bluetooth/btintel_pcie.c
>> b/drivers/bluetooth/btintel_pcie.c
>> index 9792a49886ff..14d59d1353cd 100644
>> --- a/drivers/bluetooth/btintel_pcie.c
>> +++ b/drivers/bluetooth/btintel_pcie.c
>> @@ -35,9 +35,9 @@
>>
>>   /* Intel Bluetooth PCIe device id table */
>>   static const struct pci_device_id btintel_pcie_table[] = {
>> -	{ BTINTEL_PCI_DEVICE(0x4D76, PCI_ANY_ID) },
>> -	{ BTINTEL_PCI_DEVICE(0xA876, PCI_ANY_ID) },
>> -	{ BTINTEL_PCI_DEVICE(0xE476, PCI_ANY_ID) },
>> +	{ BTINTEL_PCI_DEVICE(0x4D76, PCI_ANY_ID) }, /* BlazarI, Wildcat Lake
>*/
>> +	{ BTINTEL_PCI_DEVICE(0xA876, PCI_ANY_ID) }, /* BlazarI, Lunar Lake */
>> +	{ BTINTEL_PCI_DEVICE(0xE476, PCI_ANY_ID) }, /* Scorpious, Panther
>> +Lake-H */
>
>Why not add H484 at the end right away from the patch 2/2?
Ack.

>
>>   	{ 0 }
>>   };
>>   MODULE_DEVICE_TABLE(pci, btintel_pcie_table);
>
>Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
>
Ack.

>
>Kind regards,
>
>Paul