[PATCH] lib/uuid: Do not use mixed-case letters in UUIDs

[PATCH] lib/uuid: Do not use mixed-case letters in UUIDs

[Arkadiusz Bokowy]

---
 lib/uuid.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/uuid.h b/lib/uuid.h
index 479986f06..67cb1b92b 100644
--- a/lib/uuid.h
+++ b/lib/uuid.h
@@ -50,7 +50,7 @@ extern "C" {
 #define BATTERY_UUID		"0000180f-0000-1000-8000-00805f9b34fb"
 #define SCAN_PARAMETERS_UUID	"00001813-0000-1000-8000-00805f9b34fb"
 
-#define SAP_UUID		"0000112D-0000-1000-8000-00805f9b34fb"
+#define SAP_UUID		"0000112d-0000-1000-8000-00805f9b34fb"
 
 #define HEART_RATE_UUID			"0000180d-0000-1000-8000-00805f9b34fb"
 #define HEART_RATE_MEASUREMENT_UUID	"00002a37-0000-1000-8000-00805f9b34fb"
@@ -164,7 +164,7 @@ extern "C" {
 #define BAA_SERVICE_UUID	"00001851-0000-1000-8000-00805f9b34fb"
 
 #define ASHA_SERVICE					0xFDF0
-#define ASHA_PROFILE_UUID	"0000FDF0-0000-1000-8000-00805f9b34fb"
+#define ASHA_PROFILE_UUID	"0000fdf0-0000-1000-8000-00805f9b34fb"
 
 #define PAC_CONTEXT					0x2bcd
 #define PAC_SUPPORTED_CONTEXT				0x2bce
-- 
2.43.0

RE: lib/uuid: Do not use mixed-case letters in UUIDs

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=989478

---Test result---

Test Summary:
CheckPatch                    PENDING   0.30 seconds
GitLint                       PENDING   0.26 seconds
BuildEll                      PASS      19.92 seconds
BluezMake                     PASS      2632.49 seconds
MakeCheck                     PASS      20.07 seconds
MakeDistcheck                 PASS      188.20 seconds
CheckValgrind                 PASS      238.35 seconds
CheckSmatch                   PASS      306.96 seconds
bluezmakeextell               PASS      129.55 seconds
IncrementalBuild              PENDING   0.35 seconds
ScanBuild                     PASS      924.13 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH] lib/uuid: Do not use mixed-case letters in UUIDs

[Paul Menzel]

Dear Arkadiusz,


Thank you for your patch.

Am 08.08.25 um 19:06 schrieb Arkadiusz Bokowy:

Maybe mention, that you settled on lower case, or make the summary more 
specific: lib/uuid: Make mixed-case letter UUIDs lowercase.

Also, your Signed-off-by: line is missing.

> ---
>   lib/uuid.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/uuid.h b/lib/uuid.h
> index 479986f06..67cb1b92b 100644
> --- a/lib/uuid.h
> +++ b/lib/uuid.h
> @@ -50,7 +50,7 @@ extern "C" {
>   #define BATTERY_UUID		"0000180f-0000-1000-8000-00805f9b34fb"
>   #define SCAN_PARAMETERS_UUID	"00001813-0000-1000-8000-00805f9b34fb"
>   
> -#define SAP_UUID		"0000112D-0000-1000-8000-00805f9b34fb"
> +#define SAP_UUID		"0000112d-0000-1000-8000-00805f9b34fb"
>   
>   #define HEART_RATE_UUID			"0000180d-0000-1000-8000-00805f9b34fb"
>   #define HEART_RATE_MEASUREMENT_UUID	"00002a37-0000-1000-8000-00805f9b34fb"
> @@ -164,7 +164,7 @@ extern "C" {
>   #define BAA_SERVICE_UUID	"00001851-0000-1000-8000-00805f9b34fb"
>   
>   #define ASHA_SERVICE					0xFDF0
> -#define ASHA_PROFILE_UUID	"0000FDF0-0000-1000-8000-00805f9b34fb"
> +#define ASHA_PROFILE_UUID	"0000fdf0-0000-1000-8000-00805f9b34fb"
>   
>   #define PAC_CONTEXT					0x2bcd
>   #define PAC_SUPPORTED_CONTEXT				0x2bce

With the formalities fixed:

Reviewed-by: Paul Menzel


Kind regards,

Paul