[PATCH] Bluetooth: btintel_pcie: Remove duplicate BTINTEL_PCIE_MAGIC_NUM definition

[PATCH] Bluetooth: btintel_pcie: Remove duplicate BTINTEL_PCIE_MAGIC_NUM definition

[Wentao Guan]

Remove the duplicate definition of BTINTEL_PCIE_MAGIC_NUM macro.
The macro is defined twice with the same value (0xA5A5A5A5) which
is redundant and should be cleaned up.

Fixes: b9465e6670a2 ("Bluetooth: btintel_pcie: Read hardware exception data")
Signed-off-by: Jun Zhan <zhanjun@uniontech.com>
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

------
PS: I don`t know why not show a gcc redefined warning or error?
------
---
 drivers/bluetooth/btintel_pcie.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
index 6e7bbbd35279..758fbf3fb55a 100644
--- a/drivers/bluetooth/btintel_pcie.c
+++ b/drivers/bluetooth/btintel_pcie.c
@@ -65,8 +65,6 @@ struct btintel_pcie_dev_recovery {
 #define BTINTEL_PCIE_SCP_HWEXP_SIZE		4096
 #define BTINTEL_PCIE_SCP_HWEXP_DMP_ADDR		0xB030F800
 
-#define BTINTEL_PCIE_MAGIC_NUM	0xA5A5A5A5
-
 #define BTINTEL_PCIE_TRIGGER_REASON_USER_TRIGGER	0x17A2
 #define BTINTEL_PCIE_TRIGGER_REASON_FW_ASSERT		0x1E61
 
-- 
2.20.1

RE: Bluetooth: btintel_pcie: Remove duplicate BTINTEL_PCIE_MAGIC_NUM definition

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2536 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=990541

---Test result---

Test Summary:
CheckPatch                    PENDING   0.42 seconds
GitLint                       PENDING   0.35 seconds
SubjectPrefix                 PASS      0.09 seconds
BuildKernel                   PASS      24.24 seconds
CheckAllWarning               PASS      26.59 seconds
CheckSparse                   PASS      29.96 seconds
BuildKernel32                 PASS      23.97 seconds
TestRunnerSetup               PASS      488.91 seconds
TestRunner_l2cap-tester       PASS      25.24 seconds
TestRunner_iso-tester         PASS      37.59 seconds
TestRunner_bnep-tester        PASS      6.07 seconds
TestRunner_mgmt-tester        FAIL      130.58 seconds
TestRunner_rfcomm-tester      PASS      9.48 seconds
TestRunner_sco-tester         PASS      14.78 seconds
TestRunner_ioctl-tester       PASS      10.16 seconds
TestRunner_mesh-tester        FAIL      11.45 seconds
TestRunner_smp-tester         PASS      8.48 seconds
TestRunner_userchan-tester    PASS      6.26 seconds
IncrementalBuild              PENDING   0.82 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 490, Passed: 482 (98.4%), Failed: 4, Not Run: 4

Failed Test Cases
Add Ext Advertising - Success 22 (LE -> off, Remove) Failed       0.140 seconds
Set Device ID - Power off and Power on               Failed       0.120 seconds
Set Device ID - SSP off and Power on                 Failed       0.116 seconds
LL Privacy - Remove Device 3 (Disable RL)            Failed       0.248 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    2.089 seconds
Mesh - Send cancel - 2                               Timed out    1.999 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH] Bluetooth: btintel_pcie: Remove duplicate BTINTEL_PCIE_MAGIC_NUM definition

[Paul Menzel]

Dear Wentao,


Thank you for your patch.

Am 12.08.25 um 14:43 schrieb Wentao Guan:
> Remove the duplicate definition of BTINTEL_PCIE_MAGIC_NUM macro.
> The macro is defined twice with the same value (0xA5A5A5A5) which
> is redundant and should be cleaned up.
> 
> Fixes: b9465e6670a2 ("Bluetooth: btintel_pcie: Read hardware exception data")
> Signed-off-by: Jun Zhan <zhanjun@uniontech.com>
> Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
> 
> ------
> PS: I don`t know why not show a gcc redefined warning or error?

Macros are processed by the preprocessor, and are no variables. But 
maybe I am wrong.

> ------
> ---
>   drivers/bluetooth/btintel_pcie.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
> index 6e7bbbd35279..758fbf3fb55a 100644
> --- a/drivers/bluetooth/btintel_pcie.c
> +++ b/drivers/bluetooth/btintel_pcie.c
> @@ -65,8 +65,6 @@ struct btintel_pcie_dev_recovery {
>   #define BTINTEL_PCIE_SCP_HWEXP_SIZE		4096
>   #define BTINTEL_PCIE_SCP_HWEXP_DMP_ADDR		0xB030F800
>   
> -#define BTINTEL_PCIE_MAGIC_NUM	0xA5A5A5A5
> -
>   #define BTINTEL_PCIE_TRIGGER_REASON_USER_TRIGGER	0x17A2
>   #define BTINTEL_PCIE_TRIGGER_REASON_FW_ASSERT		0x1E61
>   

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul

Re: [PATCH] Bluetooth: btintel_pcie: Remove duplicate BTINTEL_PCIE_MAGIC_NUM definition

[Wentao Guan]

Dear Paul,

Thanks for you review,

> > PS: I don`t know why not show a gcc redefined warning or error?
> 
> Macros are processed by the preprocessor, and are no variables. But 
> maybe I am wrong.
Right, "If a macro is redefined with a definition that is not effectively 
the same as the old one, the preprocessor issues a warning and 
changes the macro to use the new definition. "
From GCC docs:
https://gcc.gnu.org/onlinedocs/cpp/Undefining-and-Redefining-Macros.html

Best Regards
Wentao Guan