[PATCH] Bluetooth: hci_ldisc: Remove redundant 0 value initialization

[PATCH] Bluetooth: hci_ldisc: Remove redundant 0 value initialization

[Liao Yuanhong]

The hci_uart struct is already zeroed by kzalloc(). It's redundant to
initialize hu->padding to 0.

Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
 drivers/bluetooth/hci_ldisc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
index d0adae3267b4..e7a55c2e63f1 100644
--- a/drivers/bluetooth/hci_ldisc.c
+++ b/drivers/bluetooth/hci_ldisc.c
@@ -508,7 +508,6 @@ static int hci_uart_tty_open(struct tty_struct *tty)
 
 	/* disable alignment support by default */
 	hu->alignment = 1;
-	hu->padding = 0;
 
 	/* Use serial port speed as oper_speed */
 	hu->oper_speed = tty->termios.c_ospeed;
-- 
2.34.1

Re: [PATCH] Bluetooth: hci_ldisc: Remove redundant 0 value initialization

[Paul Menzel]

Dear Liao,


Thank you for the patch.

Am 18.08.25 um 14:36 schrieb Liao Yuanhong:
> The hci_uart struct is already zeroed by kzalloc(). It's redundant to
> initialize hu->padding to 0.
> 
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> ---
>   drivers/bluetooth/hci_ldisc.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
> index d0adae3267b4..e7a55c2e63f1 100644
> --- a/drivers/bluetooth/hci_ldisc.c
> +++ b/drivers/bluetooth/hci_ldisc.c
> @@ -508,7 +508,6 @@ static int hci_uart_tty_open(struct tty_struct *tty)
>   
>   	/* disable alignment support by default */
>   	hu->alignment = 1;
> -	hu->padding = 0;
>   
>   	/* Use serial port speed as oper_speed */
>   	hu->oper_speed = tty->termios.c_ospeed;

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul

RE: Bluetooth: hci_ldisc: Remove redundant 0 value initialization

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2377 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=992533

---Test result---

Test Summary:
CheckPatch                    PENDING   0.33 seconds
GitLint                       PENDING   0.36 seconds
SubjectPrefix                 PASS      0.08 seconds
BuildKernel                   PASS      24.11 seconds
CheckAllWarning               PASS      26.58 seconds
CheckSparse                   PASS      30.04 seconds
BuildKernel32                 PASS      24.20 seconds
TestRunnerSetup               PASS      477.02 seconds
TestRunner_l2cap-tester       PASS      24.97 seconds
TestRunner_iso-tester         PASS      36.96 seconds
TestRunner_bnep-tester        PASS      5.98 seconds
TestRunner_mgmt-tester        FAIL      126.60 seconds
TestRunner_rfcomm-tester      PASS      9.36 seconds
TestRunner_sco-tester         PASS      14.80 seconds
TestRunner_ioctl-tester       PASS      10.03 seconds
TestRunner_mesh-tester        FAIL      11.45 seconds
TestRunner_smp-tester         PASS      11.64 seconds
TestRunner_userchan-tester    PASS      6.36 seconds
IncrementalBuild              PENDING   0.81 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 490, Passed: 484 (98.8%), Failed: 2, Not Run: 4

Failed Test Cases
LL Privacy - Add Device 3 (AL is full)               Failed       0.226 seconds
LL Privacy - Start Discovery 1 (Disable RL)          Failed       0.180 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    1.993 seconds
Mesh - Send cancel - 2                               Timed out    1.997 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH] Bluetooth: hci_ldisc: Remove redundant 0 value initialization

[Markus Elfring]

> The hci_uart struct is already zeroed by kzalloc(). It's redundant to
> initialize hu->padding to 0.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc2#n94

Regards,
Markus