[PATCH BlueZ 0/2] Fix DualShock 4 cable pairing

[PATCH BlueZ 0/2] Fix DualShock 4 cable pairing

[Bastien Nocera]

I wish we could have full cable pairing support, but this is better than
this whole plugin being unreachable code for DS4 controllers.

Bastien Nocera (2):
  sixaxis: Fix official DualShock 4 controllers not being handled
  sixaxis: Initiate pairing for all cable pairing devices

 plugins/sixaxis.c        | 6 +++---
 profiles/input/sixaxis.h | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.50.1

[PATCH BlueZ 1/2] sixaxis: Fix official DualShock 4 controllers not being handled

[Bastien Nocera]

The devices changed names, and those do not match the expected name in
our list. Ignore the "Vendor" portion of the device name before matching
it.

This is most likely the result of official DS4 controllers now being
handled by the hid-playstation driver rather than the
community-supported hid-sony.

This fixes DS4 controllers not initiating cable pairing when turned on.
---
 profiles/input/sixaxis.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/profiles/input/sixaxis.h b/profiles/input/sixaxis.h
index ab8831995e55..44e43b483bf6 100644
--- a/profiles/input/sixaxis.h
+++ b/profiles/input/sixaxis.h
@@ -81,7 +81,7 @@ get_pairing(uint16_t vid, uint16_t pid, const char *name)
 		if (devices[i].pid != pid)
 			continue;
 
-		if (name && strcmp(name, devices[i].name))
+		if (name && !g_str_has_suffix(name, devices[i].name))
 			continue;
 
 		return &devices[i];
-- 
2.50.1

[PATCH BlueZ 2/2] sixaxis: Initiate pairing for all cable pairing devices

[Bastien Nocera]

Fix the cable pairing not being triggered on DualShock 4 controllers.

Note that this still requires an authorisation when connecting through
Bluetooth the first time as we're not exchanging linkkeys. Sixaxis/PS3
controllers aren't paired, so don't have that problem.
---
 plugins/sixaxis.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/plugins/sixaxis.c b/plugins/sixaxis.c
index 22dc634da0f8..27bc09815b31 100644
--- a/plugins/sixaxis.c
+++ b/plugins/sixaxis.c
@@ -300,11 +300,11 @@ static void agent_auth_cb(DBusError *derr, void *user_data)
 	if (closure->type == CABLE_PAIRING_SIXAXIS) {
 		btd_device_set_record(closure->device, HID_UUID,
 						 SIXAXIS_HID_SDP_RECORD);
+	}
 
-		device_set_cable_pairing(closure->device, true);
+	device_set_cable_pairing(closure->device, true);
 
-		server_set_cable_pairing(adapter_bdaddr, true);
-	}
+	server_set_cable_pairing(adapter_bdaddr, true);
 
 	ba2str(&closure->bdaddr, device_addr);
 	ba2str(&central_bdaddr, central_addr);
-- 
2.50.1

RE: Fix DualShock 4 cable pairing

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=994029

---Test result---

Test Summary:
CheckPatch                    PENDING   0.29 seconds
GitLint                       PENDING   0.38 seconds
BuildEll                      PASS      20.26 seconds
BluezMake                     PASS      2874.11 seconds
MakeCheck                     PASS      20.02 seconds
MakeDistcheck                 PASS      189.25 seconds
CheckValgrind                 PASS      239.20 seconds
CheckSmatch                   PASS      309.51 seconds
bluezmakeextell               PASS      129.34 seconds
IncrementalBuild              PENDING   0.38 seconds
ScanBuild                     PASS      935.42 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ 0/2] Fix DualShock 4 cable pairing

[patchwork-bot+bluetooth]

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 21 Aug 2025 14:57:20 +0200 you wrote:
> I wish we could have full cable pairing support, but this is better than
> this whole plugin being unreachable code for DS4 controllers.
> 
> Bastien Nocera (2):
>   sixaxis: Fix official DualShock 4 controllers not being handled
>   sixaxis: Initiate pairing for all cable pairing devices
> 
> [...]

Here is the summary with links:
  - [BlueZ,1/2] sixaxis: Fix official DualShock 4 controllers not being handled
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=dbf96bb28a83
  - [BlueZ,2/2] sixaxis: Initiate pairing for all cable pairing devices
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3acfa2d50a9f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html