* [PATCH BlueZ 1/2] sixaxis: Fix official DualShock 4 controllers not being handled
2025-08-21 12:57 [PATCH BlueZ 0/2] Fix DualShock 4 cable pairing Bastien Nocera
@ 2025-08-21 12:57 ` Bastien Nocera
2025-08-21 14:23 ` Fix DualShock 4 cable pairing bluez.test.bot
2025-08-21 12:57 ` [PATCH BlueZ 2/2] sixaxis: Initiate pairing for all cable pairing devices Bastien Nocera
2025-08-22 14:00 ` [PATCH BlueZ 0/2] Fix DualShock 4 cable pairing patchwork-bot+bluetooth
2 siblings, 1 reply; 5+ messages in thread
From: Bastien Nocera @ 2025-08-21 12:57 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Egor Vorontsov
The devices changed names, and those do not match the expected name in
our list. Ignore the "Vendor" portion of the device name before matching
it.
This is most likely the result of official DS4 controllers now being
handled by the hid-playstation driver rather than the
community-supported hid-sony.
This fixes DS4 controllers not initiating cable pairing when turned on.
---
profiles/input/sixaxis.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/profiles/input/sixaxis.h b/profiles/input/sixaxis.h
index ab8831995e55..44e43b483bf6 100644
--- a/profiles/input/sixaxis.h
+++ b/profiles/input/sixaxis.h
@@ -81,7 +81,7 @@ get_pairing(uint16_t vid, uint16_t pid, const char *name)
if (devices[i].pid != pid)
continue;
- if (name && strcmp(name, devices[i].name))
+ if (name && !g_str_has_suffix(name, devices[i].name))
continue;
return &devices[i];
--
2.50.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH BlueZ 2/2] sixaxis: Initiate pairing for all cable pairing devices
2025-08-21 12:57 [PATCH BlueZ 0/2] Fix DualShock 4 cable pairing Bastien Nocera
2025-08-21 12:57 ` [PATCH BlueZ 1/2] sixaxis: Fix official DualShock 4 controllers not being handled Bastien Nocera
@ 2025-08-21 12:57 ` Bastien Nocera
2025-08-22 14:00 ` [PATCH BlueZ 0/2] Fix DualShock 4 cable pairing patchwork-bot+bluetooth
2 siblings, 0 replies; 5+ messages in thread
From: Bastien Nocera @ 2025-08-21 12:57 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Egor Vorontsov
Fix the cable pairing not being triggered on DualShock 4 controllers.
Note that this still requires an authorisation when connecting through
Bluetooth the first time as we're not exchanging linkkeys. Sixaxis/PS3
controllers aren't paired, so don't have that problem.
---
plugins/sixaxis.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/plugins/sixaxis.c b/plugins/sixaxis.c
index 22dc634da0f8..27bc09815b31 100644
--- a/plugins/sixaxis.c
+++ b/plugins/sixaxis.c
@@ -300,11 +300,11 @@ static void agent_auth_cb(DBusError *derr, void *user_data)
if (closure->type == CABLE_PAIRING_SIXAXIS) {
btd_device_set_record(closure->device, HID_UUID,
SIXAXIS_HID_SDP_RECORD);
+ }
- device_set_cable_pairing(closure->device, true);
+ device_set_cable_pairing(closure->device, true);
- server_set_cable_pairing(adapter_bdaddr, true);
- }
+ server_set_cable_pairing(adapter_bdaddr, true);
ba2str(&closure->bdaddr, device_addr);
ba2str(¢ral_bdaddr, central_addr);
--
2.50.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH BlueZ 0/2] Fix DualShock 4 cable pairing
2025-08-21 12:57 [PATCH BlueZ 0/2] Fix DualShock 4 cable pairing Bastien Nocera
2025-08-21 12:57 ` [PATCH BlueZ 1/2] sixaxis: Fix official DualShock 4 controllers not being handled Bastien Nocera
2025-08-21 12:57 ` [PATCH BlueZ 2/2] sixaxis: Initiate pairing for all cable pairing devices Bastien Nocera
@ 2025-08-22 14:00 ` patchwork-bot+bluetooth
2 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+bluetooth @ 2025-08-22 14:00 UTC (permalink / raw)
To: Bastien Nocera; +Cc: linux-bluetooth, sdoregor
Hello:
This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Thu, 21 Aug 2025 14:57:20 +0200 you wrote:
> I wish we could have full cable pairing support, but this is better than
> this whole plugin being unreachable code for DS4 controllers.
>
> Bastien Nocera (2):
> sixaxis: Fix official DualShock 4 controllers not being handled
> sixaxis: Initiate pairing for all cable pairing devices
>
> [...]
Here is the summary with links:
- [BlueZ,1/2] sixaxis: Fix official DualShock 4 controllers not being handled
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=dbf96bb28a83
- [BlueZ,2/2] sixaxis: Initiate pairing for all cable pairing devices
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3acfa2d50a9f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread