[PATCH BlueZ v1] client: Fix transport.acquire not doing anything

[PATCH BlueZ v1] client: Fix transport.acquire not doing anything

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

If transport.acquire is called for a transport that does not use a local
endpoint it won't call Transport.Acquire as the bluetoothd does not
allow controlling transports of other processes, but it doesn't print
anything either leaving the user blind to what is happening.

Fixes: https://github.com/bluez/bluez/issues/1532
---
 client/player.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/client/player.c b/client/player.c
index 8e68fbcc054a..598ad7f6dfd7 100644
--- a/client/player.c
+++ b/client/player.c
@@ -5017,8 +5017,15 @@ static void transport_acquire(GDBusProxy *proxy, bool prompt)
 	 * endpoint.
 	 */
 	ep = find_ep_by_transport(g_dbus_proxy_get_path(proxy));
-	if (!ep || queue_find(ep->acquiring, NULL, proxy))
+	if (!ep) {
+		bt_shell_printf("transport endpoint not found\n");
 		return;
+	}
+
+	if (queue_find(ep->acquiring, NULL, proxy)) {
+		bt_shell_printf("acquire already in progress\n");
+		return;
+	}
 
 	if (!ep->broadcast) {
 		link = find_link_by_proxy(proxy);
-- 
2.50.1

RE: [BlueZ,v1] client: Fix transport.acquire not doing anything

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=996079

---Test result---

Test Summary:
CheckPatch                    PENDING   0.39 seconds
GitLint                       PENDING   0.35 seconds
BuildEll                      PASS      20.01 seconds
BluezMake                     PASS      2657.70 seconds
MakeCheck                     PASS      20.46 seconds
MakeDistcheck                 PASS      185.78 seconds
CheckValgrind                 PASS      236.97 seconds
CheckSmatch                   PASS      306.68 seconds
bluezmakeextell               PASS      129.75 seconds
IncrementalBuild              PENDING   0.32 seconds
ScanBuild                     PASS      928.25 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] client: Fix transport.acquire not doing anything

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 27 Aug 2025 10:04:16 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> If transport.acquire is called for a transport that does not use a local
> endpoint it won't call Transport.Acquire as the bluetoothd does not
> allow controlling transports of other processes, but it doesn't print
> anything either leaving the user blind to what is happening.
> 
> [...]

Here is the summary with links:
  - [BlueZ,v1] client: Fix transport.acquire not doing anything
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5d4efe960fd9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html