[PATCH BlueZ] media: fix pac_config_cb() error code return

[PATCH BlueZ] media: fix pac_config_cb() error code return

[Pauli Virtanen]

Fixes: a887b1a1b91f ("audio: Add support for specific error codes for A2DP configuration")
---
 profiles/audio/media.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/profiles/audio/media.c b/profiles/audio/media.c
index 332f643bb..deb321e6c 100644
--- a/profiles/audio/media.c
+++ b/profiles/audio/media.c
@@ -1110,7 +1110,7 @@ static void pac_config_cb(struct media_endpoint *endpoint, void *ret, int size,
 	if (!transport)
 		return;
 
-	data->cb(data->stream, error_code == 0 ? 0 : -EINVAL);
+	data->cb(data->stream, (error_code && *error_code == 0) ? 0 : -EINVAL);
 }
 
 static struct media_transport *pac_ucast_config(struct bt_bap_stream *stream,
-- 
2.51.0

Re: [PATCH BlueZ] media: fix pac_config_cb() error code return

[Pauli Virtanen]

Hi,

Looks like BlueZ 5.84 was just tagged. Unfortunately BAP was in broken
state at commit da5daf532409812c41a237a6a6126868f6867079, see below.

to, 2025-09-18 kello 20:19 +0300, Pauli Virtanen kirjoitti:
> Fixes: a887b1a1b91f ("audio: Add support for specific error codes for A2DP configuration")
> ---
>  profiles/audio/media.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/profiles/audio/media.c b/profiles/audio/media.c
> index 332f643bb..deb321e6c 100644
> --- a/profiles/audio/media.c
> +++ b/profiles/audio/media.c
> @@ -1110,7 +1110,7 @@ static void pac_config_cb(struct media_endpoint *endpoint, void *ret, int size,
>  	if (!transport)
>  		return;
>  
> -	data->cb(data->stream, error_code == 0 ? 0 : -EINVAL);
> +	data->cb(data->stream, (error_code && *error_code == 0) ? 0 : -EINVAL);
>  }
>  
>  static struct media_transport *pac_ucast_config(struct bt_bap_stream *stream,

-- 
Pauli Virtanen

Re: [PATCH BlueZ] media: fix pac_config_cb() error code return

[Luiz Augusto von Dentz]

Hi Marcel,

On Thu, Sep 18, 2025 at 2:11 PM Pauli Virtanen <pav@iki.fi> wrote:
>
> Hi,
>
> Looks like BlueZ 5.84 was just tagged. Unfortunately BAP was in broken
> state at commit da5daf532409812c41a237a6a6126868f6867079, see below.

Looks like BAP/LE Audio is broken on 5.84, should we proceed with 5.85 then?

> to, 2025-09-18 kello 20:19 +0300, Pauli Virtanen kirjoitti:
> > Fixes: a887b1a1b91f ("audio: Add support for specific error codes for A2DP configuration")
> > ---
> >  profiles/audio/media.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/profiles/audio/media.c b/profiles/audio/media.c
> > index 332f643bb..deb321e6c 100644
> > --- a/profiles/audio/media.c
> > +++ b/profiles/audio/media.c
> > @@ -1110,7 +1110,7 @@ static void pac_config_cb(struct media_endpoint *endpoint, void *ret, int size,
> >       if (!transport)
> >               return;
> >
> > -     data->cb(data->stream, error_code == 0 ? 0 : -EINVAL);
> > +     data->cb(data->stream, (error_code && *error_code == 0) ? 0 : -EINVAL);
> >  }
> >
> >  static struct media_transport *pac_ucast_config(struct bt_bap_stream *stream,
>
> --
> Pauli Virtanen
>


-- 
Luiz Augusto von Dentz

RE: [BlueZ] media: fix pac_config_cb() error code return

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1003939

---Test result---

Test Summary:
CheckPatch                    PENDING   0.40 seconds
GitLint                       PENDING   0.40 seconds
BuildEll                      PASS      20.67 seconds
BluezMake                     PASS      2785.04 seconds
MakeCheck                     PASS      19.86 seconds
MakeDistcheck                 PASS      189.94 seconds
CheckValgrind                 PASS      244.07 seconds
CheckSmatch                   PASS      312.08 seconds
bluezmakeextell               PASS      130.50 seconds
IncrementalBuild              PENDING   0.46 seconds
ScanBuild                     PASS      933.84 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ] media: fix pac_config_cb() error code return

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 18 Sep 2025 20:19:35 +0300 you wrote:
> Fixes: a887b1a1b91f ("audio: Add support for specific error codes for A2DP configuration")
> ---
>  profiles/audio/media.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ] media: fix pac_config_cb() error code return
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6b0a08776ae4

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html