[PATCH BlueZ v1 1/2] shared/bass: Fix permissions not requiring encryption

[PATCH BlueZ v1 1/2] shared/bass: Fix permissions not requiring encryption

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

Both Broadcast Audio Scan Control Point and Broadcast Receive State do
require encryption:

https://www.bluetooth.com/wp-content/uploads/Files/Specification/HTML/24670-BASS-html5/out/en/index-en.html#UUID-dd95da9a-6ac0-3f45-7e34-13fa9e04d41c
---
 src/shared/bass.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/shared/bass.c b/src/shared/bass.c
index 4b4fe8adf762..19cc9531d617 100644
--- a/src/shared/bass.c
+++ b/src/shared/bass.c
@@ -1223,7 +1223,7 @@ static void bcast_recv_new(struct bt_bass_db *bdb, int i)
 	bt_uuid16_create(&uuid, BCAST_RECV_STATE_UUID);
 	bcast_recv_state->attr =
 		gatt_db_service_add_characteristic(bdb->service, &uuid,
-				BT_ATT_PERM_READ,
+				BT_ATT_PERM_READ | BT_ATT_PERM_READ_ENCRYPT,
 				BT_GATT_CHRC_PROP_READ |
 				BT_GATT_CHRC_PROP_NOTIFY,
 				bass_bcast_recv_state_read, NULL,
@@ -1252,7 +1252,7 @@ static void bass_new(struct bt_bass_db *bdb)
 	bdb->bcast_audio_scan_cp =
 		gatt_db_service_add_characteristic(bdb->service,
 				&uuid,
-				BT_ATT_PERM_WRITE,
+				BT_ATT_PERM_WRITE | BT_ATT_PERM_WRITE_ENCRYPT,
 				BT_GATT_CHRC_PROP_WRITE |
 				BT_GATT_CHRC_PROP_WRITE_WITHOUT_RESP,
 				NULL, bass_bcast_audio_scan_cp_write,
-- 
2.51.0

[PATCH BlueZ v1 2/2] client/player: Set QoS.Encryption if QoS.BCode is set

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

QoS.Encryption must be set in order for the daemon to interpret the
QoS.BCode as valid.
---
 client/player.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/client/player.c b/client/player.c
index 598ad7f6dfd7..bb193dafeba0 100644
--- a/client/player.c
+++ b/client/player.c
@@ -1870,6 +1870,10 @@ static void append_bcast_qos(DBusMessageIter *iter, struct endpoint_config *cfg)
 
 	if (cfg->ep->bcode->iov_len != 0) {
 		const char *key = "BCode";
+		uint8_t encryption = 0x01;
+
+		g_dbus_dict_append_entry(iter, "Encryption", DBUS_TYPE_BYTE,
+						&encryption);
 
 		bt_shell_printf("BCode:\n");
 		bt_shell_hexdump(cfg->ep->bcode->iov_base,
-- 
2.51.0

RE: [BlueZ,v1,1/2] shared/bass: Fix permissions not requiring encryption

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2882 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1007799

---Test result---

Test Summary:
CheckPatch                    PENDING   0.53 seconds
GitLint                       PENDING   0.35 seconds
BuildEll                      PASS      19.87 seconds
BluezMake                     PASS      2686.41 seconds
MakeCheck                     FAIL      20.82 seconds
MakeDistcheck                 FAIL      169.11 seconds
CheckValgrind                 FAIL      237.79 seconds
CheckSmatch                   PASS      305.16 seconds
bluezmakeextell               PASS      127.41 seconds
IncrementalBuild              PENDING   0.39 seconds
ScanBuild                     PASS      926.58 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: MakeCheck - FAIL
Desc: Run Bluez Make Check
Output:

./test-driver: line 107: 30638 Aborted                 (core dumped) "$@" > $log_file 2>&1
make[3]: *** [Makefile:9937: test-suite.log] Error 1
make[2]: *** [Makefile:10045: check-TESTS] Error 2
make[1]: *** [Makefile:10467: check-am] Error 2
make: *** [Makefile:10469: check] Error 2
##############################
Test: MakeDistcheck - FAIL
Desc: Run Bluez Make Distcheck
Output:

Package cups was not found in the pkg-config search path.
Perhaps you should add the directory containing `cups.pc'
to the PKG_CONFIG_PATH environment variable
No package 'cups' found
../../test-driver: line 107: 51088 Aborted                 (core dumped) "$@" > $log_file 2>&1
make[4]: *** [Makefile:9937: test-suite.log] Error 1
make[3]: *** [Makefile:10045: check-TESTS] Error 2
make[2]: *** [Makefile:10467: check-am] Error 2
make[1]: *** [Makefile:10469: check] Error 2
make: *** [Makefile:10390: distcheck] Error 1
##############################
Test: CheckValgrind - FAIL
Desc: Run Bluez Make Check with Valgrind
Output:

tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12904:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12904 | int main(int argc, char *argv[])
      |     ^~~~
./test-driver: line 107: 69516 Aborted                 (core dumped) "$@" > $log_file 2>&1
make[3]: *** [Makefile:9937: test-suite.log] Error 1
make[2]: *** [Makefile:10045: check-TESTS] Error 2
make[1]: *** [Makefile:10467: check-am] Error 2
make: *** [Makefile:10469: check] Error 2
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1 1/2] shared/bass: Fix permissions not requiring encryption

[patchwork-bot+bluetooth]

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed,  1 Oct 2025 15:13:51 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> Both Broadcast Audio Scan Control Point and Broadcast Receive State do
> require encryption:
> 
> https://www.bluetooth.com/wp-content/uploads/Files/Specification/HTML/24670-BASS-html5/out/en/index-en.html#UUID-dd95da9a-6ac0-3f45-7e34-13fa9e04d41c
> 
> [...]

Here is the summary with links:
  - [BlueZ,v1,1/2] shared/bass: Fix permissions not requiring encryption
    (no matching commit)
  - [BlueZ,v1,2/2] client/player: Set QoS.Encryption if QoS.BCode is set
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3e55476bf6c8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html