[PATCH v1] Bluetooth: hci_conn: Fix connection cleanup with BIG with 2 or more BIS

[PATCH v1] Bluetooth: hci_conn: Fix connection cleanup with BIG with 2 or more BIS

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This fixes bis_cleanup not considering connections in BT_OPEN state
before attempting to remove the BIG causing the following error:

btproxy[20110]: < HCI Command: LE Terminate Broadcast Isochronous Group (0x08|0x006a) plen 2
        BIG Handle: 0x01
        Reason: Connection Terminated By Local Host (0x16)
> HCI Event: Command Status (0x0f) plen 4
      LE Terminate Broadcast Isochronous Group (0x08|0x006a) ncmd 1
        Status: Unknown Advertising Identifier (0x42)

Fixes: fa224d0c094a ("Bluetooth: ISO: Reassociate a socket with an active BIS")
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
 net/bluetooth/hci_conn.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index d6162a95048e..0b86aaddfb02 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -843,6 +843,13 @@ static void bis_cleanup(struct hci_conn *conn)
 		if (bis)
 			return;
 
+		bis = hci_conn_hash_lookup_big_state(hdev,
+						     conn->iso_qos.bcast.big,
+						     BT_OPEN,
+						     HCI_ROLE_MASTER);
+		if (bis)
+			return;
+
 		hci_le_terminate_big(hdev, conn);
 	} else {
 		hci_le_big_terminate(hdev, conn->iso_qos.bcast.big,
-- 
2.51.0

Re: [PATCH v1] Bluetooth: hci_conn: Fix connection cleanup with BIG with 2 or more BIS

[Paul Menzel]

Dear Luiz,


Thank you for your patch.

Am 22.10.25 um 22:29 schrieb Luiz Augusto von Dentz:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This fixes bis_cleanup not considering connections in BT_OPEN state
> before attempting to remove the BIG causing the following error:
> 
> btproxy[20110]: < HCI Command: LE Terminate Broadcast Isochronous Group (0x08|0x006a) plen 2
>          BIG Handle: 0x01
>          Reason: Connection Terminated By Local Host (0x16)
>> HCI Event: Command Status (0x0f) plen 4
>        LE Terminate Broadcast Isochronous Group (0x08|0x006a) ncmd 1
>          Status: Unknown Advertising Identifier (0x42)
> 
> Fixes: fa224d0c094a ("Bluetooth: ISO: Reassociate a socket with an active BIS")
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> ---
>   net/bluetooth/hci_conn.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
> index d6162a95048e..0b86aaddfb02 100644
> --- a/net/bluetooth/hci_conn.c
> +++ b/net/bluetooth/hci_conn.c
> @@ -843,6 +843,13 @@ static void bis_cleanup(struct hci_conn *conn)
>   		if (bis)
>   			return;
>   
> +		bis = hci_conn_hash_lookup_big_state(hdev,
> +						     conn->iso_qos.bcast.big,
> +						     BT_OPEN,
> +						     HCI_ROLE_MASTER);
> +		if (bis)
> +			return;
> +
>   		hci_le_terminate_big(hdev, conn);
>   	} else {
>   		hci_le_big_terminate(hdev, conn->iso_qos.bcast.big,

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul

RE: [v1] Bluetooth: hci_conn: Fix connection cleanup with BIG with 2 or more BIS

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2377 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1014692

---Test result---

Test Summary:
CheckPatch                    PENDING   0.44 seconds
GitLint                       PENDING   0.38 seconds
SubjectPrefix                 PASS      0.07 seconds
BuildKernel                   PASS      25.32 seconds
CheckAllWarning               PASS      27.05 seconds
CheckSparse                   PASS      30.04 seconds
BuildKernel32                 PASS      24.40 seconds
TestRunnerSetup               PASS      489.89 seconds
TestRunner_l2cap-tester       PASS      23.74 seconds
TestRunner_iso-tester         PASS      82.67 seconds
TestRunner_bnep-tester        PASS      6.06 seconds
TestRunner_mgmt-tester        FAIL      114.28 seconds
TestRunner_rfcomm-tester      PASS      9.24 seconds
TestRunner_sco-tester         PASS      14.35 seconds
TestRunner_ioctl-tester       PASS      10.02 seconds
TestRunner_mesh-tester        FAIL      11.46 seconds
TestRunner_smp-tester         PASS      8.44 seconds
TestRunner_userchan-tester    PASS      6.36 seconds
IncrementalBuild              PENDING   1.04 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 490, Passed: 484 (98.8%), Failed: 2, Not Run: 4

Failed Test Cases
Read Exp Feature - Success                           Failed       0.103 seconds
LL Privacy - Set Device Flag 1 (Device Privacy)      Failed       0.162 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    1.883 seconds
Mesh - Send cancel - 2                               Timed out    1.997 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH v1] Bluetooth: hci_conn: Fix connection cleanup with BIG with 2 or more BIS

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 22 Oct 2025 16:29:41 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This fixes bis_cleanup not considering connections in BT_OPEN state
> before attempting to remove the BIG causing the following error:
> 
> btproxy[20110]: < HCI Command: LE Terminate Broadcast Isochronous Group (0x08|0x006a) plen 2
>         BIG Handle: 0x01
>         Reason: Connection Terminated By Local Host (0x16)
> > HCI Event: Command Status (0x0f) plen 4
>       LE Terminate Broadcast Isochronous Group (0x08|0x006a) ncmd 1
>         Status: Unknown Advertising Identifier (0x42)
> 
> [...]

Here is the summary with links:
  - [v1] Bluetooth: hci_conn: Fix connection cleanup with BIG with 2 or more BIS
    https://git.kernel.org/bluetooth/bluetooth-next/c/990c0549b5f1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html