From: Szymon Janc <szymon.janc@tieto.com>
To: Andrzej Kaczmarek <andrzej.kaczmarek@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] android: Include headers from libhardware as system headers
Date: Thu, 22 May 2014 09:32:25 +0200 [thread overview]
Message-ID: <6903600.aZEQEVyvJm@uw000953> (raw)
In-Reply-To: <1400689082-12662-1-git-send-email-andrzej.kaczmarek@tieto.com>
Hi Andrzej,
On Wednesday 21 of May 2014 18:18:02 Andrzej Kaczmarek wrote:
> Including hardware/audio.h in Android build produces sign-compare
> warning due to nested include of cutils/bitops.h. Since we cannot avoid
> this warning in sane way unless it's fixed in AOSP tree, we can make
> GCC think this is a system header and suppress warnings.
>
> This patch changes the way headers from libhardware are added to
> search path from LOCAL_C_INCLUDES to explicit "-isystem" option added
> to LOCAL_CFLAGS.
> ---
> android/Android.mk | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/android/Android.mk b/android/Android.mk
> index 4235a7c..d3d94ed 100644
> --- a/android/Android.mk
> +++ b/android/Android.mk
> @@ -121,12 +121,12 @@ LOCAL_SRC_FILES := \
I'd rather fix this in AOSP instead of hacking this in our build system.
--
Best regards,
Szymon Janc
next prev parent reply other threads:[~2014-05-22 7:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 16:18 [PATCH] android: Include headers from libhardware as system headers Andrzej Kaczmarek
2014-05-22 7:32 ` Szymon Janc [this message]
2014-05-22 7:59 ` Andrzej Kaczmarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6903600.aZEQEVyvJm@uw000953 \
--to=szymon.janc@tieto.com \
--cc=andrzej.kaczmarek@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox