public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] Bluetooth: btusb: add new custom firmwares
@ 2025-11-07  2:13 Shuai Zhang
  2025-11-07  3:13 ` Dmitry Baryshkov
  2025-11-07  3:13 ` [v1] " bluez.test.bot
  0 siblings, 2 replies; 4+ messages in thread
From: Shuai Zhang @ 2025-11-07  2:13 UTC (permalink / raw)
  To: Marcel Holtmann, Luiz Augusto von Dentz
  Cc: linux-bluetooth, linux-kernel, stable, linux-arm-msm,
	quic_chejiang, quic_jiaymao, quic_chezhou, Shuai Zhang

There are custom-made firmwares based on board ID for a given QCA BT
chip sometimes, and they are different with existing firmwares and put
in a separate subdirectory to avoid conflict, for example:
QCA2066, as a variant of WCN6855, has firmwares under 'qca/QCA2066/'
of linux-firmware repository.

Cc: stable@vger.kernel.org
Signed-off-by: Shuai Zhang <quic_shuaz@quicinc.com>
---
 drivers/bluetooth/btusb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index dcbff7641..7175e9b2d 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -3273,6 +3273,7 @@ static const struct qca_device_info qca_devices_table[] = {
 
 static const struct qca_custom_firmware qca_custom_btfws[] = {
 	{ 0x00130201, 0x030A, "QCA2066" },
+	{ 0x00130201, 0x030B, "QCA2066" },
 	{ },
 };
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] Bluetooth: btusb: add new custom firmwares
  2025-11-07  2:13 [PATCH v1] Bluetooth: btusb: add new custom firmwares Shuai Zhang
@ 2025-11-07  3:13 ` Dmitry Baryshkov
  2025-11-07 12:09   ` Shuai Zhang
  2025-11-07  3:13 ` [v1] " bluez.test.bot
  1 sibling, 1 reply; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-11-07  3:13 UTC (permalink / raw)
  To: Shuai Zhang
  Cc: Marcel Holtmann, Luiz Augusto von Dentz, linux-bluetooth,
	linux-kernel, stable, linux-arm-msm, quic_chejiang, quic_jiaymao,
	quic_chezhou

On Fri, Nov 07, 2025 at 10:13:45AM +0800, Shuai Zhang wrote:
> There are custom-made firmwares based on board ID for a given QCA BT
> chip sometimes, and they are different with existing firmwares and put
> in a separate subdirectory to avoid conflict, for example:
> QCA2066, as a variant of WCN6855, has firmwares under 'qca/QCA2066/'
> of linux-firmware repository.

These are generic phrases regarding QCA2066. Describe why and what is
done in the patch (e.g. why do you add new entry to that table).

> 
> Cc: stable@vger.kernel.org

There is little point for CC'ing stable if this is not a fix (and it's
not, it lacks a corresponding tag).

> Signed-off-by: Shuai Zhang <quic_shuaz@quicinc.com>

Please migrate to the @oss.qualcomm.com address.

> ---
>  drivers/bluetooth/btusb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index dcbff7641..7175e9b2d 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -3273,6 +3273,7 @@ static const struct qca_device_info qca_devices_table[] = {
>  
>  static const struct qca_custom_firmware qca_custom_btfws[] = {
>  	{ 0x00130201, 0x030A, "QCA2066" },
> +	{ 0x00130201, 0x030B, "QCA2066" },
>  	{ },
>  };
>  
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [v1] Bluetooth: btusb: add new custom firmwares
  2025-11-07  2:13 [PATCH v1] Bluetooth: btusb: add new custom firmwares Shuai Zhang
  2025-11-07  3:13 ` Dmitry Baryshkov
@ 2025-11-07  3:13 ` bluez.test.bot
  1 sibling, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2025-11-07  3:13 UTC (permalink / raw)
  To: linux-bluetooth, quic_shuaz

[-- Attachment #1: Type: text/plain, Size: 2457 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1020712

---Test result---

Test Summary:
CheckPatch                    PENDING   0.25 seconds
GitLint                       PENDING   0.26 seconds
SubjectPrefix                 PASS      0.12 seconds
BuildKernel                   PASS      25.18 seconds
CheckAllWarning               PASS      27.53 seconds
CheckSparse                   PASS      31.02 seconds
BuildKernel32                 PASS      24.83 seconds
TestRunnerSetup               PASS      497.26 seconds
TestRunner_l2cap-tester       PASS      27.35 seconds
TestRunner_iso-tester         PASS      72.46 seconds
TestRunner_bnep-tester        PASS      6.11 seconds
TestRunner_mgmt-tester        FAIL      114.70 seconds
TestRunner_rfcomm-tester      PASS      9.16 seconds
TestRunner_sco-tester         PASS      14.46 seconds
TestRunner_ioctl-tester       PASS      10.25 seconds
TestRunner_mesh-tester        FAIL      11.45 seconds
TestRunner_smp-tester         PASS      8.34 seconds
TestRunner_userchan-tester    PASS      6.47 seconds
IncrementalBuild              PENDING   0.90 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 492, Passed: 485 (98.6%), Failed: 3, Not Run: 4

Failed Test Cases
Read Exp Feature - Success                           Failed       0.100 seconds
LL Privacy - Set Flags 1 (Add to RL)                 Failed       0.154 seconds
LL Privacy - Set Flags 2 (Enable RL)                 Failed       0.164 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    2.030 seconds
Mesh - Send cancel - 2                               Timed out    1.996 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] Bluetooth: btusb: add new custom firmwares
  2025-11-07  3:13 ` Dmitry Baryshkov
@ 2025-11-07 12:09   ` Shuai Zhang
  0 siblings, 0 replies; 4+ messages in thread
From: Shuai Zhang @ 2025-11-07 12:09 UTC (permalink / raw)
  To: Dmitry Baryshkov
  Cc: Marcel Holtmann, Luiz Augusto von Dentz, linux-bluetooth,
	linux-kernel, stable, linux-arm-msm, quic_chejiang, quic_jiaymao,
	quic_chezhou

Hi Dmitry

On 11/7/2025 11:13 AM, Dmitry Baryshkov wrote:
> On Fri, Nov 07, 2025 at 10:13:45AM +0800, Shuai Zhang wrote:
>> There are custom-made firmwares based on board ID for a given QCA BT
>> chip sometimes, and they are different with existing firmwares and put
>> in a separate subdirectory to avoid conflict, for example:
>> QCA2066, as a variant of WCN6855, has firmwares under 'qca/QCA2066/'
>> of linux-firmware repository.
> 
> These are generic phrases regarding QCA2066. Describe why and what is
> done in the patch (e.g. why do you add new entry to that table).
> 
>>
>> Cc: stable@vger.kernel.org
> 
> There is little point for CC'ing stable if this is not a fix (and it's
> not, it lacks a corresponding tag).
> 

I tried not adding Cc: stable@vger.kernel.org, but this question occurred.

FYI: kernel test robot notices the stable kernel rule is not satisfied.

The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1

Rule: add the tag "Cc: stable@vger.kernel.org" in the sign-off area to have the patch automatically included in the stable tree."



>> Signed-off-by: Shuai Zhang <quic_shuaz@quicinc.com>
> 
> Please migrate to the @oss.qualcomm.com address.

I am currently submitting an application for an OSS account.

> 
>> ---
>>  drivers/bluetooth/btusb.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
>> index dcbff7641..7175e9b2d 100644
>> --- a/drivers/bluetooth/btusb.c
>> +++ b/drivers/bluetooth/btusb.c
>> @@ -3273,6 +3273,7 @@ static const struct qca_device_info qca_devices_table[] = {
>>  
>>  static const struct qca_custom_firmware qca_custom_btfws[] = {
>>  	{ 0x00130201, 0x030A, "QCA2066" },
>> +	{ 0x00130201, 0x030B, "QCA2066" },
>>  	{ },
>>  };
>>  
>> -- 
>> 2.34.1
>>
> 

Best,regard
Shuai


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-11-07 12:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-07  2:13 [PATCH v1] Bluetooth: btusb: add new custom firmwares Shuai Zhang
2025-11-07  3:13 ` Dmitry Baryshkov
2025-11-07 12:09   ` Shuai Zhang
2025-11-07  3:13 ` [v1] " bluez.test.bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox