[PATCH BlueZ v1] bass: Fix attempting to create multiple assistant for the same stream

[PATCH BlueZ v1] bass: Fix attempting to create multiple assistant for the same stream

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

bt_bap_stream may change from streaming -> streaming when updating its
metadata in which case bis_src_handler would be called multiple times
for the same stream causing it to fail at g_dbus_register_interface, to
fix this adds a check if the state is already streaming then it must
have been handle already so it safe to skip calling bt_bap_parse_base.
---
 profiles/audio/bass.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/profiles/audio/bass.c b/profiles/audio/bass.c
index 20c37323bb0e..031f527be9f5 100644
--- a/profiles/audio/bass.c
+++ b/profiles/audio/bass.c
@@ -1274,6 +1274,10 @@ static void bap_state_src_changed(struct bt_bap_stream *stream,
 		data->stream = NULL;
 		break;
 	case BT_BAP_STREAM_STATE_STREAMING:
+		/* If already streaming don't attempt to parse it again */
+		if (old_state == new_state)
+			break;
+
 		base = bt_bap_stream_get_base(stream);
 		if (!base) {
 			error("Unable to read BASE of stream %p", stream);
-- 
2.52.0

RE: [BlueZ,v1] bass: Fix attempting to create multiple assistant for the same stream

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1030870

---Test result---

Test Summary:
CheckPatch                    PENDING   0.28 seconds
GitLint                       PENDING   0.38 seconds
BuildEll                      PASS      19.91 seconds
BluezMake                     PASS      638.04 seconds
MakeCheck                     PASS      21.49 seconds
MakeDistcheck                 PASS      240.46 seconds
CheckValgrind                 PASS      300.94 seconds
CheckSmatch                   PASS      351.75 seconds
bluezmakeextell               PASS      182.01 seconds
IncrementalBuild              PENDING   0.41 seconds
ScanBuild                     PASS      1012.04 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] bass: Fix attempting to create multiple assistant for the same stream

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri,  5 Dec 2025 09:49:52 -0500 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> bt_bap_stream may change from streaming -> streaming when updating its
> metadata in which case bis_src_handler would be called multiple times
> for the same stream causing it to fail at g_dbus_register_interface, to
> fix this adds a check if the state is already streaming then it must
> have been handle already so it safe to skip calling bt_bap_parse_base.
> 
> [...]

Here is the summary with links:
  - [BlueZ,v1] bass: Fix attempting to create multiple assistant for the same stream
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=d83198c78ee1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html