[PATCH BlueZ 0/4] Decode system parameters and add BR/EDR idle timeout

[PATCH BlueZ 0/4] Decode system parameters and add BR/EDR idle timeout

[Stefan Sørensen]

This series adds support for setting the BR/EDR system default
connection idle timeout, documents some previously added default
system configuration parameters and adds decoding of read/set default
system parameters.

Stefan Sørensen (4):
  doc: Sync default system parameter list with kernel
  adapter: Do not send empty default system parameter list
  monitor: Decode MGMT read/set default system parameters
  main: Add BR.IdleTimeout option

 doc/mgmt.rst      |   4 ++
 monitor/packet.c  | 117 +++++++++++++++++++++++++++++++++++++++++++---
 src/adapter.c     |   9 ++++
 src/btd.h         |   1 +
 src/main.c        |  10 +++-
 src/main.conf     |   3 ++
 src/shared/mgmt.c |   5 ++
 src/shared/mgmt.h |   1 +
 8 files changed, 142 insertions(+), 8 deletions(-)

-- 
2.52.0

[PATCH BlueZ 1/4] doc: Sync default system parameter list with kernel

[Stefan Sørensen]

Add the LE interleave scan default system parameters that were never
added to the documentation.
---
 doc/mgmt.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/mgmt.rst b/doc/mgmt.rst
index 3fca69ed0..fec9ce5af 100644
--- a/doc/mgmt.rst
+++ b/doc/mgmt.rst
@@ -3444,6 +3444,9 @@ Currently defined Parameter_Type values are:
 	0x0019, LE Connection Latency
 	0x001a, LE Connection Supervision Timeout
 	0x001b, LE Autoconnect Timeout
+	0x001d, LE Allow List Scanning Duration for adv monitoring
+	0x001e, LE No Filter Scanning Duration for adv monitoring
+	0x001f, LE Enable Interleave Scan for adv monitoring
 
 This command can be used at any time and will return a list of supported default
 parameters as well as their current value.
-- 
2.52.0

[PATCH BlueZ 2/4] adapter: Do not send empty default system parameter list

[Stefan Sørensen]

If we have no default system parameters to set, bail out without
sending the empty list to the kernel just to get an error back.
---
 src/adapter.c     | 3 +++
 src/shared/mgmt.c | 5 +++++
 src/shared/mgmt.h | 1 +
 3 files changed, 9 insertions(+)

diff --git a/src/adapter.c b/src/adapter.c
index 445203463..924cddf3b 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -4957,6 +4957,9 @@ static void load_defaults(struct btd_adapter *adapter)
 	if (!load_le_defaults(adapter, list, &btd_opts.defaults.le))
 		goto done;
 
+	if (mgmt_tlv_list_size(list) == 0)
+		goto done;
+
 	err = mgmt_send_tlv(adapter->mgmt, MGMT_OP_SET_DEF_SYSTEM_CONFIG,
 			adapter->dev_id, list, NULL, NULL, NULL);
 
diff --git a/src/shared/mgmt.c b/src/shared/mgmt.c
index a5335b978..6a7eb5798 100644
--- a/src/shared/mgmt.c
+++ b/src/shared/mgmt.c
@@ -686,6 +686,11 @@ void mgmt_tlv_list_free(struct mgmt_tlv_list *tlv_list)
 	free(tlv_list);
 }
 
+uint16_t mgmt_tlv_list_size(struct mgmt_tlv_list *tlv_list)
+{
+	return tlv_list->size;
+}
+
 bool mgmt_tlv_add(struct mgmt_tlv_list *tlv_list, uint16_t type, uint8_t length,
 								void *value)
 {
diff --git a/src/shared/mgmt.h b/src/shared/mgmt.h
index b413cea78..2629fbd59 100644
--- a/src/shared/mgmt.h
+++ b/src/shared/mgmt.h
@@ -36,6 +36,7 @@ typedef void (*mgmt_request_func_t)(uint8_t status, uint16_t length,
 
 struct mgmt_tlv_list *mgmt_tlv_list_new(void);
 void mgmt_tlv_list_free(struct mgmt_tlv_list *tlv_list);
+uint16_t mgmt_tlv_list_size(struct mgmt_tlv_list *tlv_list);
 bool mgmt_tlv_add(struct mgmt_tlv_list *tlv_list, uint16_t type, uint8_t length,
 								void *value);
 #define mgmt_tlv_add_fixed(_list, _type, _value) \
-- 
2.52.0

[PATCH BlueZ 3/4] monitor: Decode MGMT read/set default system parameters

[Stefan Sørensen]

Add decoding of the payload of the Read Default System Configuration
and Set Default System Configuration MGMT commands and replies:

@ MGMT Command: Set Default System Configuration (0x004c) plen 15
        BR/EDR Page Timeout: 200
        BR/EDR Min Sniff Interval: 50
        BR/EDR Max Sniff Interval: 200
---
 monitor/packet.c | 116 ++++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 110 insertions(+), 6 deletions(-)

diff --git a/monitor/packet.c b/monitor/packet.c
index 254fe840d..bd316d842 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -32,11 +32,13 @@
 #include "bluetooth/uuid.h"
 #include "bluetooth/hci.h"
 #include "bluetooth/hci_lib.h"
+#include "bluetooth/mgmt.h"
 
 #include "src/shared/util.h"
 #include "src/shared/btsnoop.h"
 #include "src/shared/queue.h"
 #include "src/shared/bap-debug.h"
+#include "src/shared/mgmt.h"
 #include "display.h"
 #include "bt.h"
 #include "ll.h"
@@ -14683,10 +14685,6 @@ static const struct bitfield_data mgmt_adv_flags_table[] = {
 	{  16, "Contain Scan Response Data"		},
 	{ }
 };
-#define MGMT_ADV_PARAM_DURATION		(1 << 12)
-#define MGMT_ADV_PARAM_TIMEOUT		(1 << 13)
-#define MGMT_ADV_PARAM_INTERVALS	(1 << 14)
-#define MGMT_ADV_PARAM_TX_POWER		(1 << 15)
 
 static void mgmt_print_adv_flags(uint32_t flags)
 {
@@ -15994,6 +15992,108 @@ static void mgmt_set_exp_feature_rsp(const void *data, uint16_t size)
 	mgmt_print_exp_feature(data);
 }
 
+static const struct {
+	uint16_t val;
+	const char *str;
+} default_system_config_table[] = {
+	{0x0000, "BR/EDR Page Scan Type"                              },
+	{0x0001, "BR/EDR Page Scan Interval"                          },
+	{0x0002, "BR/EDR Page Scan Window"                            },
+	{0x0003, "BR/EDR Inquiry Scan Type"                           },
+	{0x0004, "BR/EDR Inquiry Scan Interval"                       },
+	{0x0005, "BR/EDR Inquiry Scan Window"                         },
+	{0x0006, "BR/EDR Link Supervision Timeout"                    },
+	{0x0007, "BR/EDR Page Timeout"                                },
+	{0x0008, "BR/EDR Min Sniff Interval"                          },
+	{0x0009, "BR/EDR Max Sniff Interval"                          },
+	{0x000a, "LE Advertisement Min Interval"                      },
+	{0x000b, "LE Advertisement Max Interval"                      },
+	{0x000c, "LE Multi Advertisement Rotation Interval"           },
+	{0x000d, "LE Scanning Interval for auto connect"              },
+	{0x000e, "LE Scanning Window for auto connect"                },
+	{0x000f, "LE Scanning Interval for wake scenarios"            },
+	{0x0010, "LE Scanning Window for wake scenarios"              },
+	{0x0011, "LE Scanning Interval for discovery"                 },
+	{0x0012, "LE Scanning Window for discovery"                   },
+	{0x0013, "LE Scanning Interval for adv monitoring"            },
+	{0x0014, "LE Scanning Window for adv monitoring"              },
+	{0x0015, "LE Scanning Interval for connect"                   },
+	{0x0016, "LE Scanning Window for connect"                     },
+	{0x0017, "LE Min Connection Interval"                         },
+	{0x0018, "LE Max Connection Interval"                         },
+	{0x0019, "LE Connection Latency"                              },
+	{0x001a, "LE Connection Supervision Timeout"                  },
+	{0x001b, "LE Autoconnect Timeout"                             },
+	{0x001d, "LE Allow List Scanning Duration for adv monitoring" },
+	{0x001e, "LE No Filter Scanning Duration for adv monitoring"  },
+	{0x001f, "LE Enable Interleave Scan for adv monitoring"       },
+	{ }
+};
+
+static const char *default_system_config(uint16_t val)
+{
+	int i;
+
+	for (i = 0; default_system_config_table[i].str; i++) {
+		if (default_system_config_table[i].val == val)
+			return default_system_config_table[i].str;
+	}
+
+	return NULL;
+}
+
+static void mgmt_print_system_config_tlv(void *data, void *user_data)
+{
+	const struct mgmt_tlv *entry = data;
+	uint16_t type = get_le16(&entry->type);
+	const char *desc = default_system_config(type);
+	uint32_t value;
+	char buf[8];
+
+	if (!desc) {
+		snprintf(buf, sizeof(buf), "0x%4.4x", entry->type);
+		desc = buf;
+	}
+
+	if (entry->length == 1 || entry->length == 2 || entry->length == 4) {
+		if (entry->length == 1)
+			value = get_u8(entry->value);
+		else if (entry->length == 2)
+			value = get_le16(entry->value);
+		else if (entry->length == 4)
+			value = get_le32(entry->value);
+		print_field("%s: %u", desc, value);
+	} else {
+		print_hex_field(desc, entry->value, entry->length);
+	}
+}
+
+static void mgmt_read_default_system_config_rsp(const void *data, uint16_t size)
+{
+	struct mgmt_tlv_list *tlv_list;
+
+	tlv_list = mgmt_tlv_list_load_from_buf(data, size);
+	if (!tlv_list) {
+		print_text(COLOR_ERROR, "  Unable to parse response of read system configuration");
+		return;
+	}
+	mgmt_tlv_list_foreach(tlv_list, mgmt_print_system_config_tlv, NULL);
+	mgmt_tlv_list_free(tlv_list);
+}
+
+static void mgmt_set_default_system_config_cmd(const void *data, uint16_t size)
+{
+	struct mgmt_tlv_list *tlv_list;
+
+	tlv_list = mgmt_tlv_list_load_from_buf(data, size);
+	if (!tlv_list) {
+		print_text(COLOR_ERROR, "  Unable to parse command of set system configuration");
+		return;
+	}
+	mgmt_tlv_list_foreach(tlv_list, mgmt_print_system_config_tlv, NULL);
+	mgmt_tlv_list_free(tlv_list);
+}
+
 static const struct bitfield_data mgmt_added_device_flags_table[] = {
 	{ 0, "Remote Wakeup"		},
 	{ 1, "Device Privacy Mode"	},
@@ -16574,8 +16674,12 @@ static const struct mgmt_data mgmt_command_table[] = {
 	{ 0x004a, "Set Experimental Feature",
 				mgmt_set_exp_feature_cmd, 17, true,
 				mgmt_set_exp_feature_rsp, 20, true },
-	{ 0x004b, "Read Default System Configuration" },
-	{ 0x004c, "Set Default System Configuration" },
+	{ 0x004b, "Read Default System Configuration",
+				mgmt_null_cmd, 0, true,
+				mgmt_read_default_system_config_rsp, 4, false},
+	{ 0x004c, "Set Default System Configuration",
+				mgmt_set_default_system_config_cmd, 4, false,
+				mgmt_null_rsp, 0, true},
 	{ 0x004d, "Read Default Runtime Configuration" },
 	{ 0x004e, "Set Default Runtime Configuration" },
 	{ 0x004f, "Get Device Flags",
-- 
2.52.0

[PATCH BlueZ 4/4] main: Add BR.IdleTimeout option

[Stefan Sørensen]

This option sets the idle timeout for BR/EDR connections, allowing
them to switch into SNIFF mode after a period with no data traffic.
---
 doc/mgmt.rst     |  1 +
 monitor/packet.c |  1 +
 src/adapter.c    |  6 ++++++
 src/btd.h        |  1 +
 src/main.c       | 10 ++++++++--
 src/main.conf    |  3 +++
 6 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/doc/mgmt.rst b/doc/mgmt.rst
index fec9ce5af..35446dd97 100644
--- a/doc/mgmt.rst
+++ b/doc/mgmt.rst
@@ -3447,6 +3447,7 @@ Currently defined Parameter_Type values are:
 	0x001d, LE Allow List Scanning Duration for adv monitoring
 	0x001e, LE No Filter Scanning Duration for adv monitoring
 	0x001f, LE Enable Interleave Scan for adv monitoring
+	0x0020, BR/EDR Connection Idle Timeout
 
 This command can be used at any time and will return a list of supported default
 parameters as well as their current value.
diff --git a/monitor/packet.c b/monitor/packet.c
index bd316d842..5e546ad95 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -16027,6 +16027,7 @@ static const struct {
 	{0x001d, "LE Allow List Scanning Duration for adv monitoring" },
 	{0x001e, "LE No Filter Scanning Duration for adv monitoring"  },
 	{0x001f, "LE Enable Interleave Scan for adv monitoring"       },
+	{0x0020, "BR/EDR Connection Idle Timeout"                     },
 	{ }
 };
 
diff --git a/src/adapter.c b/src/adapter.c
index 924cddf3b..a5de7cee1 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -4801,6 +4801,12 @@ static bool load_bredr_defaults(struct btd_adapter *adapter,
 			return false;
 	}
 
+	if (defaults->idle_timeout) {
+		if (!mgmt_tlv_add_fixed(list, 0x0020,
+					&defaults->idle_timeout))
+			return false;
+	}
+
 	return true;
 }
 
diff --git a/src/btd.h b/src/btd.h
index 5c952bf17..1b521706d 100644
--- a/src/btd.h
+++ b/src/btd.h
@@ -62,6 +62,7 @@ struct btd_br_defaults {
 
 	uint16_t	min_sniff_interval;
 	uint16_t	max_sniff_interval;
+	uint32_t	idle_timeout;
 };
 
 struct btd_le_defaults {
diff --git a/src/main.c b/src/main.c
index 61e5ef983..59df0ad4c 100644
--- a/src/main.c
+++ b/src/main.c
@@ -104,6 +104,7 @@ static const char *br_options[] = {
 	"InquiryScanWindow",
 	"LinkSupervisionTimeout",
 	"PageTimeout",
+	"IdleTimeout",
 	"MinSniffInterval",
 	"MaxSniffInterval",
 	NULL
@@ -494,8 +495,8 @@ struct config_param {
 	const char * const val_name;
 	void * const val;
 	const size_t size;
-	const uint16_t min;
-	const uint16_t max;
+	const uint32_t min;
+	const uint32_t max;
 };
 
 static void parse_mode_config(GKeyFile *config, const char *group,
@@ -573,6 +574,11 @@ static void parse_br_config(GKeyFile *config)
 		  sizeof(btd_opts.defaults.br.max_sniff_interval),
 		  0x0001,
 		  0xFFFE},
+		{ "IdleTimeout",
+		  &btd_opts.defaults.br.idle_timeout,
+		  sizeof(btd_opts.defaults.br.idle_timeout),
+		  500,
+		  3600000},
 	};
 
 	if (btd_opts.mode == BT_MODE_LE)
diff --git a/src/main.conf b/src/main.conf
index fa94cf97d..724c4b44f 100644
--- a/src/main.conf
+++ b/src/main.conf
@@ -182,6 +182,9 @@
 # BR/EDR Page Timeout
 #PageTimeout=
 
+# BR/EDR Connection Idle Timeout
+#IdleTimeout=
+
 # BR/EDR Sniff Intervals
 #MinSniffInterval=
 #MaxSniffInterval=
-- 
2.52.0

RE: [BlueZ,1/4] doc: Sync default system parameter list with kernel

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1034329

---Test result---

Test Summary:
CheckPatch                    PENDING   0.31 seconds
GitLint                       PENDING   0.41 seconds
BuildEll                      PASS      20.39 seconds
BluezMake                     PASS      647.22 seconds
MakeCheck                     PASS      22.03 seconds
MakeDistcheck                 PASS      246.23 seconds
CheckValgrind                 PASS      305.40 seconds
CheckSmatch                   PASS      354.38 seconds
bluezmakeextell               PASS      183.85 seconds
IncrementalBuild              PENDING   0.33 seconds
ScanBuild                     PASS      1052.98 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ 0/4] Decode system parameters and add BR/EDR idle timeout

[Luiz Augusto von Dentz]

Hi Stefan,

On Wed, Dec 17, 2025 at 3:38 PM Stefan Sørensen <ssorensen@roku.com> wrote:
>
> This series adds support for setting the BR/EDR system default
> connection idle timeout, documents some previously added default
> system configuration parameters and adds decoding of read/set default
> system parameters.
>
> Stefan Sørensen (4):
>   doc: Sync default system parameter list with kernel
>   adapter: Do not send empty default system parameter list
>   monitor: Decode MGMT read/set default system parameters
>   main: Add BR.IdleTimeout option

Looks like the last 2 were not sent to list, or they were blocked:

https://patchwork.kernel.org/project/bluetooth/list/?series=1034329

>  doc/mgmt.rst      |   4 ++
>  monitor/packet.c  | 117 +++++++++++++++++++++++++++++++++++++++++++---
>  src/adapter.c     |   9 ++++
>  src/btd.h         |   1 +
>  src/main.c        |  10 +++-
>  src/main.conf     |   3 ++
>  src/shared/mgmt.c |   5 ++
>  src/shared/mgmt.h |   1 +
>  8 files changed, 142 insertions(+), 8 deletions(-)
>
> --
> 2.52.0
>
>


-- 
Luiz Augusto von Dentz

Re: [PATCH BlueZ 0/4] Decode system parameters and add BR/EDR idle timeout

[Stefan Sørensen]

>>   doc: Sync default system parameter list with kernel
>>   adapter: Do not send empty default system parameter list
>>   monitor: Decode MGMT read/set default system parameters
>>   main: Add BR.IdleTimeout option
>
>Looks like the last 2 were not sent to list, or they were blocked:
>
>https://patchwork.kernel.org/project/bluetooth/list/?series=1034329

I looks like there is some delay on the mails that I send to the list - but they are in the Patchwork by now.

Regards,
Stefan

Re: [PATCH BlueZ 0/4] Decode system parameters and add BR/EDR idle timeout

[patchwork-bot+bluetooth]

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 17 Dec 2025 17:02:52 +0100 you wrote:
> This series adds support for setting the BR/EDR system default
> connection idle timeout, documents some previously added default
> system configuration parameters and adds decoding of read/set default
> system parameters.
> 
> Stefan Sørensen (4):
>   doc: Sync default system parameter list with kernel
>   adapter: Do not send empty default system parameter list
>   monitor: Decode MGMT read/set default system parameters
>   main: Add BR.IdleTimeout option
> 
> [...]

Here is the summary with links:
  - [BlueZ,1/4] doc: Sync default system parameter list with kernel
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=063db049ba29
  - [BlueZ,2/4] adapter: Do not send empty default system parameter list
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5e5b46c5c0cc
  - [BlueZ,3/4] monitor: Decode MGMT read/set default system parameters
    (no matching commit)
  - [BlueZ,4/4] main: Add BR.IdleTimeout option
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=2edcad4c4312

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html