* [PATCH 0/3] More CONFIG_PM* simplifications
@ 2026-01-16 12:50 Bastien Nocera
2026-01-16 12:50 ` [PATCH 1/3] Bluetooth: btmtksdio: Simplify dev_pm_ops usage Bastien Nocera
` (2 more replies)
0 siblings, 3 replies; 23+ messages in thread
From: Bastien Nocera @ 2026-01-16 12:50 UTC (permalink / raw)
To: linux-bluetooth
Follow-up from the earlier "Bluetooth: btusb: Use pm_ptr instead of
#ifdef CONFIG_PM" patch.
All 3 drivers were successfully compiled with CONFIG_PM disabled.
Bastien Nocera (3):
Bluetooth: btmtksdio: Simplify dev_pm_ops usage
Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef
Bluetooth: btintel: Remove unneeded CONFIG_PM* #ifdef's
drivers/bluetooth/btmtksdio.c | 12 +++---------
drivers/bluetooth/btnxpuart.c | 2 --
drivers/bluetooth/hci_intel.c | 6 ------
3 files changed, 3 insertions(+), 17 deletions(-)
--
2.52.0
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 1/3] Bluetooth: btmtksdio: Simplify dev_pm_ops usage
2026-01-16 12:50 [PATCH 0/3] More CONFIG_PM* simplifications Bastien Nocera
@ 2026-01-16 12:50 ` Bastien Nocera
2026-01-16 13:33 ` Paul Menzel
` (2 more replies)
2026-01-16 12:50 ` [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef Bastien Nocera
2026-01-16 12:50 ` [PATCH 3/3] Bluetooth: btintel: Remove unneeded CONFIG_PM* #ifdef's Bastien Nocera
2 siblings, 3 replies; 23+ messages in thread
From: Bastien Nocera @ 2026-01-16 12:50 UTC (permalink / raw)
To: linux-bluetooth
This increases build coverage and allows to drop a few #ifdef's.
Signed-off-by: Bastien Nocera <hadess@hadess.net>
---
drivers/bluetooth/btmtksdio.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
index fba3ab6d30a5..ec17521d5b9f 100644
--- a/drivers/bluetooth/btmtksdio.c
+++ b/drivers/bluetooth/btmtksdio.c
@@ -1472,7 +1472,6 @@ static void btmtksdio_remove(struct sdio_func *func)
hci_free_dev(hdev);
}
-#ifdef CONFIG_PM
static int btmtksdio_runtime_suspend(struct device *dev)
{
struct sdio_func *func = dev_to_sdio_func(dev);
@@ -1538,22 +1537,17 @@ static int btmtksdio_system_resume(struct device *dev)
}
static const struct dev_pm_ops btmtksdio_pm_ops = {
- SYSTEM_SLEEP_PM_OPS(btmtksdio_system_suspend, btmtksdio_system_resume)
- RUNTIME_PM_OPS(btmtksdio_runtime_suspend, btmtksdio_runtime_resume, NULL)
+ SET_SYSTEM_SLEEP_PM_OPS(btmtksdio_system_suspend, btmtksdio_system_resume)
+ SET_RUNTIME_PM_OPS(btmtksdio_runtime_suspend, btmtksdio_runtime_resume, NULL)
};
-#define BTMTKSDIO_PM_OPS (&btmtksdio_pm_ops)
-#else /* CONFIG_PM */
-#define BTMTKSDIO_PM_OPS NULL
-#endif /* CONFIG_PM */
-
static struct sdio_driver btmtksdio_driver = {
.name = "btmtksdio",
.probe = btmtksdio_probe,
.remove = btmtksdio_remove,
.id_table = btmtksdio_table,
.drv = {
- .pm = BTMTKSDIO_PM_OPS,
+ .pm = &btmtksdio_pm_ops,
}
};
--
2.52.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef
2026-01-16 12:50 [PATCH 0/3] More CONFIG_PM* simplifications Bastien Nocera
2026-01-16 12:50 ` [PATCH 1/3] Bluetooth: btmtksdio: Simplify dev_pm_ops usage Bastien Nocera
@ 2026-01-16 12:50 ` Bastien Nocera
2026-01-16 13:35 ` Paul Menzel
` (2 more replies)
2026-01-16 12:50 ` [PATCH 3/3] Bluetooth: btintel: Remove unneeded CONFIG_PM* #ifdef's Bastien Nocera
2 siblings, 3 replies; 23+ messages in thread
From: Bastien Nocera @ 2026-01-16 12:50 UTC (permalink / raw)
To: linux-bluetooth
The functions are already disabled through the use of pm_ptr() when
CONFIG_PM is disabled, and won't be included in the final code if not
needed.
This increases build coverage and allows to drop an #ifdef.
Signed-off-by: Bastien Nocera <hadess@hadess.net>
---
drivers/bluetooth/btnxpuart.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
index 3b1e9224e965..13daa174aaaa 100644
--- a/drivers/bluetooth/btnxpuart.c
+++ b/drivers/bluetooth/btnxpuart.c
@@ -1947,7 +1947,6 @@ static void nxp_serdev_remove(struct serdev_device *serdev)
hci_free_dev(hdev);
}
-#ifdef CONFIG_PM_SLEEP
static int nxp_serdev_suspend(struct device *dev)
{
struct btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
@@ -1975,7 +1974,6 @@ static int nxp_serdev_resume(struct device *dev)
ps_control(psdata->hdev, PS_STATE_AWAKE);
return 0;
}
-#endif
#ifdef CONFIG_DEV_COREDUMP
static void nxp_serdev_coredump(struct device *dev)
--
2.52.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 3/3] Bluetooth: btintel: Remove unneeded CONFIG_PM* #ifdef's
2026-01-16 12:50 [PATCH 0/3] More CONFIG_PM* simplifications Bastien Nocera
2026-01-16 12:50 ` [PATCH 1/3] Bluetooth: btmtksdio: Simplify dev_pm_ops usage Bastien Nocera
2026-01-16 12:50 ` [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef Bastien Nocera
@ 2026-01-16 12:50 ` Bastien Nocera
2026-01-16 13:36 ` Paul Menzel
2026-01-16 21:49 ` kernel test robot
2 siblings, 2 replies; 23+ messages in thread
From: Bastien Nocera @ 2026-01-16 12:50 UTC (permalink / raw)
To: linux-bluetooth
The functions are already disabled if CONFIG_PM or CONFIG_PM_SLEEP are
disabled through the use of SET_SYSTEM_SLEEP_PM_OPS() and
SET_RUNTIME_PM_OPS().
This increases build coverage and allows to drop a few #ifdef's.
Signed-off-by: Bastien Nocera <hadess@hadess.net>
---
drivers/bluetooth/hci_intel.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/bluetooth/hci_intel.c b/drivers/bluetooth/hci_intel.c
index 20baf2895dec..52dca7520fa0 100644
--- a/drivers/bluetooth/hci_intel.c
+++ b/drivers/bluetooth/hci_intel.c
@@ -126,7 +126,6 @@ static int intel_wait_booting(struct hci_uart *hu)
return err;
}
-#ifdef CONFIG_PM
static int intel_wait_lpm_transaction(struct hci_uart *hu)
{
struct intel_data *intel = hu->priv;
@@ -237,7 +236,6 @@ static int intel_lpm_resume(struct hci_uart *hu)
return 0;
}
-#endif /* CONFIG_PM */
static int intel_lpm_host_wake(struct hci_uart *hu)
{
@@ -1066,7 +1064,6 @@ static const struct acpi_device_id intel_acpi_match[] = {
MODULE_DEVICE_TABLE(acpi, intel_acpi_match);
#endif
-#ifdef CONFIG_PM
static int intel_suspend_device(struct device *dev)
{
struct intel_device *idev = dev_get_drvdata(dev);
@@ -1090,9 +1087,7 @@ static int intel_resume_device(struct device *dev)
return 0;
}
-#endif
-#ifdef CONFIG_PM_SLEEP
static int intel_suspend(struct device *dev)
{
struct intel_device *idev = dev_get_drvdata(dev);
@@ -1112,7 +1107,6 @@ static int intel_resume(struct device *dev)
return intel_resume_device(dev);
}
-#endif
static const struct dev_pm_ops intel_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(intel_suspend, intel_resume)
--
2.52.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH 1/3] Bluetooth: btmtksdio: Simplify dev_pm_ops usage
2026-01-16 12:50 ` [PATCH 1/3] Bluetooth: btmtksdio: Simplify dev_pm_ops usage Bastien Nocera
@ 2026-01-16 13:33 ` Paul Menzel
2026-01-16 13:42 ` Bastien Nocera
2026-01-16 13:36 ` More CONFIG_PM* simplifications bluez.test.bot
2026-01-16 19:29 ` [PATCH 1/3] Bluetooth: btmtksdio: Simplify dev_pm_ops usage kernel test robot
2 siblings, 1 reply; 23+ messages in thread
From: Paul Menzel @ 2026-01-16 13:33 UTC (permalink / raw)
To: Bastien Nocera; +Cc: linux-bluetooth
Dear Bastien,
Thank you for your patch.
Am 16.01.26 um 13:50 schrieb Bastien Nocera:
> This increases build coverage and allows to drop a few #ifdef's.
Should you resend, you could elaborate on the difference between
SYSTEM_SLEEP_PM_OPS and SET_SYSTEM_SLEEP_PM_OPS.
> Signed-off-by: Bastien Nocera <hadess@hadess.net>
> ---
> drivers/bluetooth/btmtksdio.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
> index fba3ab6d30a5..ec17521d5b9f 100644
> --- a/drivers/bluetooth/btmtksdio.c
> +++ b/drivers/bluetooth/btmtksdio.c
> @@ -1472,7 +1472,6 @@ static void btmtksdio_remove(struct sdio_func *func)
> hci_free_dev(hdev);
> }
>
> -#ifdef CONFIG_PM
> static int btmtksdio_runtime_suspend(struct device *dev)
> {
> struct sdio_func *func = dev_to_sdio_func(dev);
> @@ -1538,22 +1537,17 @@ static int btmtksdio_system_resume(struct device *dev)
> }
>
> static const struct dev_pm_ops btmtksdio_pm_ops = {
> - SYSTEM_SLEEP_PM_OPS(btmtksdio_system_suspend, btmtksdio_system_resume)
> - RUNTIME_PM_OPS(btmtksdio_runtime_suspend, btmtksdio_runtime_resume, NULL)
> + SET_SYSTEM_SLEEP_PM_OPS(btmtksdio_system_suspend, btmtksdio_system_resume)
> + SET_RUNTIME_PM_OPS(btmtksdio_runtime_suspend, btmtksdio_runtime_resume, NULL)
> };
>
> -#define BTMTKSDIO_PM_OPS (&btmtksdio_pm_ops)
> -#else /* CONFIG_PM */
> -#define BTMTKSDIO_PM_OPS NULL
> -#endif /* CONFIG_PM */
> -
> static struct sdio_driver btmtksdio_driver = {
> .name = "btmtksdio",
> .probe = btmtksdio_probe,
> .remove = btmtksdio_remove,
> .id_table = btmtksdio_table,
> .drv = {
> - .pm = BTMTKSDIO_PM_OPS,
> + .pm = &btmtksdio_pm_ops,
> }
> };
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef
2026-01-16 12:50 ` [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef Bastien Nocera
@ 2026-01-16 13:35 ` Paul Menzel
2026-01-16 14:35 ` Luiz Augusto von Dentz
2026-01-16 19:50 ` kernel test robot
2 siblings, 0 replies; 23+ messages in thread
From: Paul Menzel @ 2026-01-16 13:35 UTC (permalink / raw)
To: Bastien Nocera; +Cc: linux-bluetooth
Dear Bastien,
Thank you for your patch.
Am 16.01.26 um 13:50 schrieb Bastien Nocera:
> The functions are already disabled through the use of pm_ptr() when
> CONFIG_PM is disabled, and won't be included in the final code if not
> needed.
>
> This increases build coverage and allows to drop an #ifdef.
>
> Signed-off-by: Bastien Nocera <hadess@hadess.net>
> ---
> drivers/bluetooth/btnxpuart.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
> index 3b1e9224e965..13daa174aaaa 100644
> --- a/drivers/bluetooth/btnxpuart.c
> +++ b/drivers/bluetooth/btnxpuart.c
> @@ -1947,7 +1947,6 @@ static void nxp_serdev_remove(struct serdev_device *serdev)
> hci_free_dev(hdev);
> }
>
> -#ifdef CONFIG_PM_SLEEP
> static int nxp_serdev_suspend(struct device *dev)
> {
> struct btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
> @@ -1975,7 +1974,6 @@ static int nxp_serdev_resume(struct device *dev)
> ps_control(psdata->hdev, PS_STATE_AWAKE);
> return 0;
> }
> -#endif
>
> #ifdef CONFIG_DEV_COREDUMP
> static void nxp_serdev_coredump(struct device *dev)
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 3/3] Bluetooth: btintel: Remove unneeded CONFIG_PM* #ifdef's
2026-01-16 12:50 ` [PATCH 3/3] Bluetooth: btintel: Remove unneeded CONFIG_PM* #ifdef's Bastien Nocera
@ 2026-01-16 13:36 ` Paul Menzel
2026-01-16 21:49 ` kernel test robot
1 sibling, 0 replies; 23+ messages in thread
From: Paul Menzel @ 2026-01-16 13:36 UTC (permalink / raw)
To: Bastien Nocera; +Cc: linux-bluetooth
Dear Bastien,
Thank you for your patch.
Am 16.01.26 um 13:50 schrieb Bastien Nocera:
> The functions are already disabled if CONFIG_PM or CONFIG_PM_SLEEP are
> disabled through the use of SET_SYSTEM_SLEEP_PM_OPS() and
> SET_RUNTIME_PM_OPS().
>
> This increases build coverage and allows to drop a few #ifdef's.
>
> Signed-off-by: Bastien Nocera <hadess@hadess.net>
> ---
> drivers/bluetooth/hci_intel.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_intel.c b/drivers/bluetooth/hci_intel.c
> index 20baf2895dec..52dca7520fa0 100644
> --- a/drivers/bluetooth/hci_intel.c
> +++ b/drivers/bluetooth/hci_intel.c
> @@ -126,7 +126,6 @@ static int intel_wait_booting(struct hci_uart *hu)
> return err;
> }
>
> -#ifdef CONFIG_PM
> static int intel_wait_lpm_transaction(struct hci_uart *hu)
> {
> struct intel_data *intel = hu->priv;
> @@ -237,7 +236,6 @@ static int intel_lpm_resume(struct hci_uart *hu)
>
> return 0;
> }
> -#endif /* CONFIG_PM */
>
> static int intel_lpm_host_wake(struct hci_uart *hu)
> {
> @@ -1066,7 +1064,6 @@ static const struct acpi_device_id intel_acpi_match[] = {
> MODULE_DEVICE_TABLE(acpi, intel_acpi_match);
> #endif
>
> -#ifdef CONFIG_PM
> static int intel_suspend_device(struct device *dev)
> {
> struct intel_device *idev = dev_get_drvdata(dev);
> @@ -1090,9 +1087,7 @@ static int intel_resume_device(struct device *dev)
>
> return 0;
> }
> -#endif
>
> -#ifdef CONFIG_PM_SLEEP
> static int intel_suspend(struct device *dev)
> {
> struct intel_device *idev = dev_get_drvdata(dev);
> @@ -1112,7 +1107,6 @@ static int intel_resume(struct device *dev)
>
> return intel_resume_device(dev);
> }
> -#endif
>
> static const struct dev_pm_ops intel_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(intel_suspend, intel_resume)
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
^ permalink raw reply [flat|nested] 23+ messages in thread
* RE: More CONFIG_PM* simplifications
2026-01-16 12:50 ` [PATCH 1/3] Bluetooth: btmtksdio: Simplify dev_pm_ops usage Bastien Nocera
2026-01-16 13:33 ` Paul Menzel
@ 2026-01-16 13:36 ` bluez.test.bot
2026-01-16 19:29 ` [PATCH 1/3] Bluetooth: btmtksdio: Simplify dev_pm_ops usage kernel test robot
2 siblings, 0 replies; 23+ messages in thread
From: bluez.test.bot @ 2026-01-16 13:36 UTC (permalink / raw)
To: linux-bluetooth, hadess
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
This is an automated email and please do not reply to this email.
Dear Submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.
----- Output -----
error: patch failed: drivers/bluetooth/btmtksdio.c:1472
error: drivers/bluetooth/btmtksdio.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch
Please resolve the issue and submit the patches again.
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/3] Bluetooth: btmtksdio: Simplify dev_pm_ops usage
2026-01-16 13:33 ` Paul Menzel
@ 2026-01-16 13:42 ` Bastien Nocera
0 siblings, 0 replies; 23+ messages in thread
From: Bastien Nocera @ 2026-01-16 13:42 UTC (permalink / raw)
To: Paul Menzel; +Cc: linux-bluetooth
On Fri, 2026-01-16 at 14:33 +0100, Paul Menzel wrote:
> Dear Bastien,
>
>
> Thank you for your patch.
>
> Am 16.01.26 um 13:50 schrieb Bastien Nocera:
> > This increases build coverage and allows to drop a few #ifdef's.
>
> Should you resend, you could elaborate on the difference between
> SYSTEM_SLEEP_PM_OPS and SET_SYSTEM_SLEEP_PM_OPS.
Noted.
For the record, those become no-ops when the associated CONFIG_PM* is
disabled:
#ifdef CONFIG_PM_SLEEP
#define SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \
SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn)
#else
#define SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn)
#endif
#ifdef CONFIG_PM
#define SET_RUNTIME_PM_OPS(suspend_fn, resume_fn, idle_fn) \
RUNTIME_PM_OPS(suspend_fn, resume_fn, idle_fn)
#else
#define SET_RUNTIME_PM_OPS(suspend_fn, resume_fn, idle_fn)
#endif
>
> > Signed-off-by: Bastien Nocera <hadess@hadess.net>
> > ---
> > drivers/bluetooth/btmtksdio.c | 12 +++---------
> > 1 file changed, 3 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/bluetooth/btmtksdio.c
> > b/drivers/bluetooth/btmtksdio.c
> > index fba3ab6d30a5..ec17521d5b9f 100644
> > --- a/drivers/bluetooth/btmtksdio.c
> > +++ b/drivers/bluetooth/btmtksdio.c
> > @@ -1472,7 +1472,6 @@ static void btmtksdio_remove(struct sdio_func
> > *func)
> > hci_free_dev(hdev);
> > }
> >
> > -#ifdef CONFIG_PM
> > static int btmtksdio_runtime_suspend(struct device *dev)
> > {
> > struct sdio_func *func = dev_to_sdio_func(dev);
> > @@ -1538,22 +1537,17 @@ static int btmtksdio_system_resume(struct
> > device *dev)
> > }
> >
> > static const struct dev_pm_ops btmtksdio_pm_ops = {
> > - SYSTEM_SLEEP_PM_OPS(btmtksdio_system_suspend,
> > btmtksdio_system_resume)
> > - RUNTIME_PM_OPS(btmtksdio_runtime_suspend,
> > btmtksdio_runtime_resume, NULL)
> > + SET_SYSTEM_SLEEP_PM_OPS(btmtksdio_system_suspend,
> > btmtksdio_system_resume)
> > + SET_RUNTIME_PM_OPS(btmtksdio_runtime_suspend,
> > btmtksdio_runtime_resume, NULL)
> > };
> >
> > -#define BTMTKSDIO_PM_OPS (&btmtksdio_pm_ops)
> > -#else /* CONFIG_PM */
> > -#define BTMTKSDIO_PM_OPS NULL
> > -#endif /* CONFIG_PM */
> > -
> > static struct sdio_driver btmtksdio_driver = {
> > .name = "btmtksdio",
> > .probe = btmtksdio_probe,
> > .remove = btmtksdio_remove,
> > .id_table = btmtksdio_table,
> > .drv = {
> > - .pm = BTMTKSDIO_PM_OPS,
> > + .pm = &btmtksdio_pm_ops,
> > }
> > };
>
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
>
>
> Kind regards,
>
> Paul
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef
2026-01-16 12:50 ` [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef Bastien Nocera
2026-01-16 13:35 ` Paul Menzel
@ 2026-01-16 14:35 ` Luiz Augusto von Dentz
2026-01-16 14:41 ` Bastien Nocera
2026-01-16 19:50 ` kernel test robot
2 siblings, 1 reply; 23+ messages in thread
From: Luiz Augusto von Dentz @ 2026-01-16 14:35 UTC (permalink / raw)
To: Bastien Nocera; +Cc: linux-bluetooth
Hi Bastien,
On Fri, Jan 16, 2026 at 7:58 AM Bastien Nocera <hadess@hadess.net> wrote:
>
> The functions are already disabled through the use of pm_ptr() when
> CONFIG_PM is disabled, and won't be included in the final code if not
> needed.
I guess it would be more correct to say that compilers will detect
that these functions are not in use (aka. dead code) and just remove
them.
> This increases build coverage and allows to drop an #ifdef.
>
> Signed-off-by: Bastien Nocera <hadess@hadess.net>
> ---
> drivers/bluetooth/btnxpuart.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
> index 3b1e9224e965..13daa174aaaa 100644
> --- a/drivers/bluetooth/btnxpuart.c
> +++ b/drivers/bluetooth/btnxpuart.c
> @@ -1947,7 +1947,6 @@ static void nxp_serdev_remove(struct serdev_device *serdev)
> hci_free_dev(hdev);
> }
>
> -#ifdef CONFIG_PM_SLEEP
> static int nxp_serdev_suspend(struct device *dev)
> {
> struct btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
> @@ -1975,7 +1974,6 @@ static int nxp_serdev_resume(struct device *dev)
> ps_control(psdata->hdev, PS_STATE_AWAKE);
> return 0;
> }
> -#endif
>
> #ifdef CONFIG_DEV_COREDUMP
> static void nxp_serdev_coredump(struct device *dev)
> --
> 2.52.0
>
>
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef
2026-01-16 14:35 ` Luiz Augusto von Dentz
@ 2026-01-16 14:41 ` Bastien Nocera
0 siblings, 0 replies; 23+ messages in thread
From: Bastien Nocera @ 2026-01-16 14:41 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: linux-bluetooth
On Fri, 2026-01-16 at 09:35 -0500, Luiz Augusto von Dentz wrote:
> Hi Bastien,
>
> On Fri, Jan 16, 2026 at 7:58 AM Bastien Nocera <hadess@hadess.net>
> wrote:
> >
> > The functions are already disabled through the use of pm_ptr() when
> > CONFIG_PM is disabled, and won't be included in the final code if
> > not
> > needed.
>
> I guess it would be more correct to say that compilers will detect
> that these functions are not in use (aka. dead code) and just remove
> them.
I don't know whether it's the linker or the compiler that will remove
them. Do you want me to send a v2 or will you amend the commit message?
>
> > This increases build coverage and allows to drop an #ifdef.
> >
> > Signed-off-by: Bastien Nocera <hadess@hadess.net>
> > ---
> > drivers/bluetooth/btnxpuart.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/bluetooth/btnxpuart.c
> > b/drivers/bluetooth/btnxpuart.c
> > index 3b1e9224e965..13daa174aaaa 100644
> > --- a/drivers/bluetooth/btnxpuart.c
> > +++ b/drivers/bluetooth/btnxpuart.c
> > @@ -1947,7 +1947,6 @@ static void nxp_serdev_remove(struct
> > serdev_device *serdev)
> > hci_free_dev(hdev);
> > }
> >
> > -#ifdef CONFIG_PM_SLEEP
> > static int nxp_serdev_suspend(struct device *dev)
> > {
> > struct btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
> > @@ -1975,7 +1974,6 @@ static int nxp_serdev_resume(struct device
> > *dev)
> > ps_control(psdata->hdev, PS_STATE_AWAKE);
> > return 0;
> > }
> > -#endif
> >
> > #ifdef CONFIG_DEV_COREDUMP
> > static void nxp_serdev_coredump(struct device *dev)
> > --
> > 2.52.0
> >
> >
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/3] Bluetooth: btmtksdio: Simplify dev_pm_ops usage
2026-01-16 12:50 ` [PATCH 1/3] Bluetooth: btmtksdio: Simplify dev_pm_ops usage Bastien Nocera
2026-01-16 13:33 ` Paul Menzel
2026-01-16 13:36 ` More CONFIG_PM* simplifications bluez.test.bot
@ 2026-01-16 19:29 ` kernel test robot
2 siblings, 0 replies; 23+ messages in thread
From: kernel test robot @ 2026-01-16 19:29 UTC (permalink / raw)
To: Bastien Nocera, linux-bluetooth; +Cc: oe-kbuild-all
Hi Bastien,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bluetooth/master]
[also build test WARNING on linus/master v6.19-rc5]
[cannot apply to bluetooth-next/master next-20260116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bastien-Nocera/Bluetooth-btmtksdio-Simplify-dev_pm_ops-usage/20260116-210400
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link: https://lore.kernel.org/r/20260116125803.598552-2-hadess%40hadess.net
patch subject: [PATCH 1/3] Bluetooth: btmtksdio: Simplify dev_pm_ops usage
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20260117/202601170415.QZeIgHEM-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260117/202601170415.QZeIgHEM-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601170415.QZeIgHEM-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/bluetooth/btmtksdio.c:1534:12: warning: 'btmtksdio_system_resume' defined but not used [-Wunused-function]
1534 | static int btmtksdio_system_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/bluetooth/btmtksdio.c:1497:12: warning: 'btmtksdio_system_suspend' defined but not used [-Wunused-function]
1497 | static int btmtksdio_system_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/btmtksdio_system_resume +1534 drivers/bluetooth/btmtksdio.c
7f3c563c575e73 Sean Wang 2019-04-18 1496
4ed924fc122f75 Zhengping Jiang 2023-10-13 @1497 static int btmtksdio_system_suspend(struct device *dev)
4ed924fc122f75 Zhengping Jiang 2023-10-13 1498 {
4ed924fc122f75 Zhengping Jiang 2023-10-13 1499 struct sdio_func *func = dev_to_sdio_func(dev);
4ed924fc122f75 Zhengping Jiang 2023-10-13 1500 struct btmtksdio_dev *bdev;
4ed924fc122f75 Zhengping Jiang 2023-10-13 1501
4ed924fc122f75 Zhengping Jiang 2023-10-13 1502 bdev = sdio_get_drvdata(func);
4ed924fc122f75 Zhengping Jiang 2023-10-13 1503 if (!bdev)
4ed924fc122f75 Zhengping Jiang 2023-10-13 1504 return 0;
4ed924fc122f75 Zhengping Jiang 2023-10-13 1505
4ed924fc122f75 Zhengping Jiang 2023-10-13 1506 if (!test_bit(BTMTKSDIO_FUNC_ENABLED, &bdev->tx_state))
4ed924fc122f75 Zhengping Jiang 2023-10-13 1507 return 0;
4ed924fc122f75 Zhengping Jiang 2023-10-13 1508
4ed924fc122f75 Zhengping Jiang 2023-10-13 1509 set_bit(BTMTKSDIO_BT_WAKE_ENABLED, &bdev->tx_state);
4ed924fc122f75 Zhengping Jiang 2023-10-13 1510
4ed924fc122f75 Zhengping Jiang 2023-10-13 1511 return btmtksdio_runtime_suspend(dev);
4ed924fc122f75 Zhengping Jiang 2023-10-13 1512 }
4ed924fc122f75 Zhengping Jiang 2023-10-13 1513
7f3c563c575e73 Sean Wang 2019-04-18 1514 static int btmtksdio_runtime_resume(struct device *dev)
7f3c563c575e73 Sean Wang 2019-04-18 1515 {
7f3c563c575e73 Sean Wang 2019-04-18 1516 struct sdio_func *func = dev_to_sdio_func(dev);
7f3c563c575e73 Sean Wang 2019-04-18 1517 struct btmtksdio_dev *bdev;
7f3c563c575e73 Sean Wang 2019-04-18 1518 int err;
7f3c563c575e73 Sean Wang 2019-04-18 1519
7f3c563c575e73 Sean Wang 2019-04-18 1520 bdev = sdio_get_drvdata(func);
7f3c563c575e73 Sean Wang 2019-04-18 1521 if (!bdev)
7f3c563c575e73 Sean Wang 2019-04-18 1522 return 0;
7f3c563c575e73 Sean Wang 2019-04-18 1523
4b4b2228f521c3 Sean Wang 2021-12-02 1524 if (!test_bit(BTMTKSDIO_FUNC_ENABLED, &bdev->tx_state))
4b4b2228f521c3 Sean Wang 2021-12-02 1525 return 0;
4b4b2228f521c3 Sean Wang 2021-12-02 1526
c7e301d7c85544 Mark Chen 2022-01-12 1527 err = btmtksdio_drv_pmctrl(bdev);
7f3c563c575e73 Sean Wang 2019-04-18 1528
095519de2debef Sean Wang 2022-01-12 1529 bt_dev_dbg(bdev->hdev, "status (%d) get ownership from device", err);
7f3c563c575e73 Sean Wang 2019-04-18 1530
7f3c563c575e73 Sean Wang 2019-04-18 1531 return err;
7f3c563c575e73 Sean Wang 2019-04-18 1532 }
7f3c563c575e73 Sean Wang 2019-04-18 1533
4ed924fc122f75 Zhengping Jiang 2023-10-13 @1534 static int btmtksdio_system_resume(struct device *dev)
4ed924fc122f75 Zhengping Jiang 2023-10-13 1535 {
4ed924fc122f75 Zhengping Jiang 2023-10-13 1536 return btmtksdio_runtime_resume(dev);
4ed924fc122f75 Zhengping Jiang 2023-10-13 1537 }
4ed924fc122f75 Zhengping Jiang 2023-10-13 1538
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef
2026-01-16 12:50 ` [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef Bastien Nocera
2026-01-16 13:35 ` Paul Menzel
2026-01-16 14:35 ` Luiz Augusto von Dentz
@ 2026-01-16 19:50 ` kernel test robot
2026-01-19 7:53 ` Neeraj Sanjay Kale
2 siblings, 1 reply; 23+ messages in thread
From: kernel test robot @ 2026-01-16 19:50 UTC (permalink / raw)
To: Bastien Nocera, linux-bluetooth; +Cc: oe-kbuild-all
Hi Bastien,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bluetooth/master]
[also build test WARNING on linus/master v6.19-rc5]
[cannot apply to bluetooth-next/master next-20260116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bastien-Nocera/Bluetooth-btmtksdio-Simplify-dev_pm_ops-usage/20260116-210400
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link: https://lore.kernel.org/r/20260116125803.598552-3-hadess%40hadess.net
patch subject: [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef
config: x86_64-randconfig-002-20260116 (https://download.01.org/0day-ci/archive/20260117/202601170322.MZrwlt6M-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260117/202601170322.MZrwlt6M-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601170322.MZrwlt6M-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/bluetooth/btnxpuart.c:1964:12: warning: 'nxp_serdev_resume' defined but not used [-Wunused-function]
1964 | static int nxp_serdev_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~
>> drivers/bluetooth/btnxpuart.c:1950:12: warning: 'nxp_serdev_suspend' defined but not used [-Wunused-function]
1950 | static int nxp_serdev_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~
vim +/nxp_serdev_resume +1964 drivers/bluetooth/btnxpuart.c
689ca16e5232784 Neeraj Sanjay Kale 2023-03-16 1949
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 @1950 static int nxp_serdev_suspend(struct device *dev)
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1951 {
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1952 struct btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1953 struct ps_data *psdata = &nxpdev->psdata;
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1954
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1955 ps_control(psdata->hdev, PS_STATE_SLEEP);
c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1956
c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1957 if (psdata->wakeup_source) {
c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1958 enable_irq_wake(psdata->irq_handler);
c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1959 enable_irq(psdata->irq_handler);
c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1960 }
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1961 return 0;
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1962 }
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1963
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 @1964 static int nxp_serdev_resume(struct device *dev)
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1965 {
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1966 struct btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1967 struct ps_data *psdata = &nxpdev->psdata;
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1968
c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1969 if (psdata->wakeup_source) {
c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1970 disable_irq(psdata->irq_handler);
c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1971 disable_irq_wake(psdata->irq_handler);
c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1972 }
c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1973
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1974 ps_control(psdata->hdev, PS_STATE_AWAKE);
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1975 return 0;
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1976 }
658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1977
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 3/3] Bluetooth: btintel: Remove unneeded CONFIG_PM* #ifdef's
2026-01-16 12:50 ` [PATCH 3/3] Bluetooth: btintel: Remove unneeded CONFIG_PM* #ifdef's Bastien Nocera
2026-01-16 13:36 ` Paul Menzel
@ 2026-01-16 21:49 ` kernel test robot
1 sibling, 0 replies; 23+ messages in thread
From: kernel test robot @ 2026-01-16 21:49 UTC (permalink / raw)
To: Bastien Nocera, linux-bluetooth; +Cc: oe-kbuild-all
Hi Bastien,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bluetooth/master]
[also build test WARNING on linus/master v6.19-rc5]
[cannot apply to bluetooth-next/master next-20260116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bastien-Nocera/Bluetooth-btmtksdio-Simplify-dev_pm_ops-usage/20260116-210400
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link: https://lore.kernel.org/r/20260116125803.598552-4-hadess%40hadess.net
patch subject: [PATCH 3/3] Bluetooth: btintel: Remove unneeded CONFIG_PM* #ifdef's
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20260117/202601170613.lx6wk4st-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260117/202601170613.lx6wk4st-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601170613.lx6wk4st-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/bluetooth/hci_intel.c:1101:12: warning: 'intel_resume' defined but not used [-Wunused-function]
1101 | static int intel_resume(struct device *dev)
| ^~~~~~~~~~~~
>> drivers/bluetooth/hci_intel.c:1091:12: warning: 'intel_suspend' defined but not used [-Wunused-function]
1091 | static int intel_suspend(struct device *dev)
| ^~~~~~~~~~~~~
vim +/intel_resume +1101 drivers/bluetooth/hci_intel.c
aa6802df09fe32 Loic Poulain 2015-09-02 1090
f755247379912f Loic Poulain 2015-09-09 @1091 static int intel_suspend(struct device *dev)
f755247379912f Loic Poulain 2015-09-09 1092 {
f755247379912f Loic Poulain 2015-09-09 1093 struct intel_device *idev = dev_get_drvdata(dev);
f755247379912f Loic Poulain 2015-09-09 1094
f755247379912f Loic Poulain 2015-09-09 1095 if (device_may_wakeup(dev))
f755247379912f Loic Poulain 2015-09-09 1096 enable_irq_wake(idev->irq);
f755247379912f Loic Poulain 2015-09-09 1097
f755247379912f Loic Poulain 2015-09-09 1098 return intel_suspend_device(dev);
f755247379912f Loic Poulain 2015-09-09 1099 }
f755247379912f Loic Poulain 2015-09-09 1100
f755247379912f Loic Poulain 2015-09-09 @1101 static int intel_resume(struct device *dev)
f755247379912f Loic Poulain 2015-09-09 1102 {
f755247379912f Loic Poulain 2015-09-09 1103 struct intel_device *idev = dev_get_drvdata(dev);
f755247379912f Loic Poulain 2015-09-09 1104
f755247379912f Loic Poulain 2015-09-09 1105 if (device_may_wakeup(dev))
f755247379912f Loic Poulain 2015-09-09 1106 disable_irq_wake(idev->irq);
f755247379912f Loic Poulain 2015-09-09 1107
f755247379912f Loic Poulain 2015-09-09 1108 return intel_resume_device(dev);
f755247379912f Loic Poulain 2015-09-09 1109 }
f755247379912f Loic Poulain 2015-09-09 1110
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef
2026-01-16 19:50 ` kernel test robot
@ 2026-01-19 7:53 ` Neeraj Sanjay Kale
2026-01-19 9:10 ` Bastien Nocera
0 siblings, 1 reply; 23+ messages in thread
From: Neeraj Sanjay Kale @ 2026-01-19 7:53 UTC (permalink / raw)
To: kernel test robot, Bastien Nocera,
linux-bluetooth@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev
Hi Bastien,
Thank you for your patch.
Just an FYI, the " #ifdef CONFIG_PM_SLEEP" was added on purpose to resolve such build warning reported by kernel test bot:
https://lore.kernel.org/all/20240710123426.935122-1-neeraj.sanjaykale@nxp.com/
Thanks,
Neeraj
> Hi Bastien,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on bluetooth/master] [also build test WARNING on
> linus/master v6.19-rc5] [cannot apply to bluetooth-next/master next-
> 20260116] [If your patch is applied to the wrong git tree, kindly drop us a
> note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-/
> scm.com%2Fdocs%2Fgit-format-
> patch%23_base_tree_information&data=05%7C02%7Cneeraj.sanjaykale%40n
> xp.com%7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92
> cd99c5c301635%7C0%7C0%7C639041898935601715%7CUnknown%7CTWFp
> bGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4z
> MiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=W4jhk2S
> VUr77jirvKdK%2FrKuKAVyXSbY9iO2pQ1%2BL7Fs%3D&reserved=0]
>
> url:
> https://github/.
> com%2Fintel-lab-lkp%2Flinux%2Fcommits%2FBastien-Nocera%2FBluetooth-
> btmtksdio-Simplify-dev_pm_ops-usage%2F20260116-
> 210400&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f3219146a754
> 0774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C639041898935632879%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcG
> kiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIj
> oyfQ%3D%3D%7C0%7C%7C%7C&sdata=l2nEr61x%2F00NrtEqmvX2qhJ%2F0d
> %2Fc6T%2BI6e5YRiz1TAM%3D&reserved=0
> base:
> https://git.kern/
> el.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fbluetooth%2Fbluetooth.gi
> t&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f3219146a7540774e
> da08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
> 9041898935651605%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRy
> dWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3
> D%3D%7C0%7C%7C%7C&sdata=%2BKZxHj6EXqJXKC8%2FsiYrPOJczts%2BMEX
> ycXixKcxUcf8%3D&reserved=0 master
> patch link:
> https://lore.ke/
> rnel.org%2Fr%2F20260116125803.598552-3-
> hadess%2540hadess.net&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%
> 7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c3
> 01635%7C0%7C0%7C639041898935668808%7CUnknown%7CTWFpbGZsb3d8
> eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIj
> oiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=a3gomBec5GENv5B
> RsBv%2Butzd11I3QunXE2yAaDg5f4Q%3D&reserved=0
> patch subject: [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded
> CONFIG_PM ifdef
> config: x86_64-randconfig-002-20260116
> (https://downl/
> oad.01.org%2F0day-ci%2Farchive%2F20260117%2F202601170322.MZrwlt6M-
> lkp%40intel.com%2Fconfig&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com
> %7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c
> 301635%7C0%7C0%7C639041898935685518%7CUnknown%7CTWFpbGZsb3d
> 8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOI
> joiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=hR230cwqc4FucDn
> 9TPmv79VLdAd8kHHwc2Q8SdPtHtk%3D&reserved=0)
> compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 reproduce (this is a W=1 build):
> (https://downl/
> oad.01.org%2F0day-ci%2Farchive%2F20260117%2F202601170322.MZrwlt6M-
> lkp%40intel.com%2Freproduce&data=05%7C02%7Cneeraj.sanjaykale%40nxp.
> com%7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd9
> 9c5c301635%7C0%7C0%7C639041898935702245%7CUnknown%7CTWFpbGZ
> sb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIs
> IkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=dsZA9O8KQy
> QZJK2Fn%2FYtexA8zdrw%2FCcpwnEb7AwhiqU%3D&reserved=0)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes:
> | https://lore/
> | .kernel.org%2Foe-kbuild-all%2F202601170322.MZrwlt6M-
> lkp%40intel.com%2F
> |
> &data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f3219146a7540774e
> da08de
> |
> 5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63904189
> 89357202
> |
> 33%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjA
> uMDAwMCI
> |
> sIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sd
> ata=2
> | s046Nm4SrgCfY%2BqPyoYr8tf5xqoBw%2BqDiJ0YQ%2BiAt8%3D&reserved=0
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/bluetooth/btnxpuart.c:1964:12: warning: 'nxp_serdev_resume'
> >> defined but not used [-Wunused-function]
> 1964 | static int nxp_serdev_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~
> >> drivers/bluetooth/btnxpuart.c:1950:12: warning: 'nxp_serdev_suspend'
> >> defined but not used [-Wunused-function]
> 1950 | static int nxp_serdev_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~
>
>
> vim +/nxp_serdev_resume +1964 drivers/bluetooth/btnxpuart.c
>
> 689ca16e5232784 Neeraj Sanjay Kale 2023-03-16 1949
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 @1950 static int
> nxp_serdev_suspend(struct device *dev)
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1951 {
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1952 struct
> btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1953 struct ps_data
> *psdata = &nxpdev->psdata;
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1954
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1955 ps_control(psdata-
> >hdev, PS_STATE_SLEEP);
> c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1956
> c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1957 if (psdata-
> >wakeup_source) {
> c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1958
> enable_irq_wake(psdata->irq_handler);
> c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1959
> enable_irq(psdata->irq_handler);
> c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1960 }
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1961 return 0;
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1962 }
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1963
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 @1964 static int
> nxp_serdev_resume(struct device *dev)
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1965 {
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1966 struct
> btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1967 struct ps_data
> *psdata = &nxpdev->psdata;
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1968
> c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1969 if (psdata-
> >wakeup_source) {
> c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1970
> disable_irq(psdata->irq_handler);
> c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1971
> disable_irq_wake(psdata->irq_handler);
> c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1972 }
> c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1973
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1974 ps_control(psdata-
> >hdev, PS_STATE_AWAKE);
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1975 return 0;
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1976 }
> 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1977
>
> --
> 0-DAY CI Kernel Test Service
> https://github/.
> com%2Fintel%2Flkp-
> tests%2Fwiki&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f321914
> 6a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0
> %7C0%7C639041898935740752%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0e
> U1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCI
> sIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=IqE%2B%2BS2ZXcZb5PFvsvemp
> dQffNOiktBLNpxdDx5JJJg%3D&reserved=0
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef
2026-01-19 7:53 ` Neeraj Sanjay Kale
@ 2026-01-19 9:10 ` Bastien Nocera
2026-01-20 16:42 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 23+ messages in thread
From: Bastien Nocera @ 2026-01-19 9:10 UTC (permalink / raw)
To: Neeraj Sanjay Kale, kernel test robot,
linux-bluetooth@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev
On Mon, 2026-01-19 at 07:53 +0000, Neeraj Sanjay Kale wrote:
> Hi Bastien,
>
> Thank you for your patch.
>
> Just an FYI, the " #ifdef CONFIG_PM_SLEEP" was added on purpose to
> resolve such build warning reported by kernel test bot:
> https://lore.kernel.org/all/20240710123426.935122-1-neeraj.sanjaykale@nxp.com/
I didn't see those warnings locally. They should be fixed by using
__maybe_unused instead otherwise the "it extends the code coverage"
justification wouldn't really apply anymore.
Cheers
>
> Thanks,
> Neeraj
>
> > Hi Bastien,
> >
> > kernel test robot noticed the following build warnings:
> >
> > [auto build test WARNING on bluetooth/master] [also build test
> > WARNING on
> > linus/master v6.19-rc5] [cannot apply to bluetooth-next/master
> > next-
> > 20260116] [If your patch is applied to the wrong git tree, kindly
> > drop us a
> > note.
> > And when submitting patch, we suggest to use '--base' as documented
> > in
> > https://git-/
> > scm.com%2Fdocs%2Fgit-format-
> > patch%23_base_tree_information&data=05%7C02%7Cneeraj.sanjaykale%40n
> > xp.com%7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92
> > cd99c5c301635%7C0%7C0%7C639041898935601715%7CUnknown%7CTWFp
> > bGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4z
> > MiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=W4jhk2S
> > VUr77jirvKdK%2FrKuKAVyXSbY9iO2pQ1%2BL7Fs%3D&reserved=0]
> >
> > url:
> > https://github/.
> > com%2Fintel-lab-lkp%2Flinux%2Fcommits%2FBastien-Nocera%2FBluetooth-
> > btmtksdio-Simplify-dev_pm_ops-usage%2F20260116-
> > 210400&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f3219146a754
> > 0774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> > %7C639041898935632879%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcG
> > kiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUI
> > j
> > oyfQ%3D%3D%7C0%7C%7C%7C&sdata=l2nEr61x%2F00NrtEqmvX2qhJ%2F0d
> > %2Fc6T%2BI6e5YRiz1TAM%3D&reserved=0
> > base:
> > https://git.kern/
> > el.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fbluetooth%2Fbluetooth.g
> > i
> > t&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f3219146a7540774e
> > da08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
> > 9041898935651605%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRy
> > dWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%
> > 3
> > D%3D%7C0%7C%7C%7C&sdata=%2BKZxHj6EXqJXKC8%2FsiYrPOJczts%2BMEX
> > ycXixKcxUcf8%3D&reserved=0 master
> > patch link:
> > https://lore.ke/
> > rnel.org%2Fr%2F20260116125803.598552-3-
> > hadess%2540hadess.net&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%
> > 7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c3
> > 01635%7C0%7C0%7C639041898935668808%7CUnknown%7CTWFpbGZsb3d8
> > eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIj
> > oiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=a3gomBec5GENv5B
> > RsBv%2Butzd11I3QunXE2yAaDg5f4Q%3D&reserved=0
> > patch subject: [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded
> > CONFIG_PM ifdef
> > config: x86_64-randconfig-002-20260116
> > (https://downl/
> > oad.01.org%2F0day-ci%2Farchive%2F20260117%2F202601170322.MZrwlt6M-
> > lkp%40intel.com%2Fconfig&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com
> > %7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c
> > 301635%7C0%7C0%7C639041898935685518%7CUnknown%7CTWFpbGZsb3d
> > 8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOI
> > joiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=hR230cwqc4FucDn
> > 9TPmv79VLdAd8kHHwc2Q8SdPtHtk%3D&reserved=0)
> > compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 reproduce (this is a W=1
> > build):
> > (https://downl/
> > oad.01.org%2F0day-ci%2Farchive%2F20260117%2F202601170322.MZrwlt6M-
> > lkp%40intel.com%2Freproduce&data=05%7C02%7Cneeraj.sanjaykale%40nxp.
> > com%7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd9
> > 9c5c301635%7C0%7C0%7C639041898935702245%7CUnknown%7CTWFpbGZ
> > sb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIs
> > IkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=dsZA9O8KQy
> > QZJK2Fn%2FYtexA8zdrw%2FCcpwnEb7AwhiqU%3D&reserved=0)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a
> > new version of
> > the same patch/commit), kindly add following tags
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Closes:
> > > https://lore/
> > > .kernel.org%2Foe-kbuild-all%2F202601170322.MZrwlt6M-
> > lkp%40intel.com%2F
> > >
> > &data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f3219146a7540774e
> > da08de
> > >
> > 5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63904189
> > 89357202
> > >
> > 33%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjA
> > uMDAwMCI
> > >
> > sIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sd
> > ata=2
> > > s046Nm4SrgCfY%2BqPyoYr8tf5xqoBw%2BqDiJ0YQ%2BiAt8%3D&reserved=0
> >
> > All warnings (new ones prefixed by >>):
> >
> > > > drivers/bluetooth/btnxpuart.c:1964:12: warning:
> > > > 'nxp_serdev_resume'
> > > > defined but not used [-Wunused-function]
> > 1964 | static int nxp_serdev_resume(struct device *dev)
> > | ^~~~~~~~~~~~~~~~~
> > > > drivers/bluetooth/btnxpuart.c:1950:12: warning:
> > > > 'nxp_serdev_suspend'
> > > > defined but not used [-Wunused-function]
> > 1950 | static int nxp_serdev_suspend(struct device *dev)
> > | ^~~~~~~~~~~~~~~~~~
> >
> >
> > vim +/nxp_serdev_resume +1964 drivers/bluetooth/btnxpuart.c
> >
> > 689ca16e5232784 Neeraj Sanjay Kale 2023-03-16 1949
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 @1950 static int
> > nxp_serdev_suspend(struct device *dev)
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1951 {
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1952 struct
> > btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1953 struct
> > ps_data
> > *psdata = &nxpdev->psdata;
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1954
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1955
> > ps_control(psdata-
> > > hdev, PS_STATE_SLEEP);
> > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1956
> > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1957 if (psdata-
> > > wakeup_source) {
> > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1958
> > enable_irq_wake(psdata->irq_handler);
> > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1959
> > enable_irq(psdata->irq_handler);
> > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1960 }
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1961 return 0;
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1962 }
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1963
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 @1964 static int
> > nxp_serdev_resume(struct device *dev)
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1965 {
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1966 struct
> > btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1967 struct
> > ps_data
> > *psdata = &nxpdev->psdata;
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1968
> > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1969 if (psdata-
> > > wakeup_source) {
> > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1970
> > disable_irq(psdata->irq_handler);
> > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1971
> > disable_irq_wake(psdata->irq_handler);
> > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1972 }
> > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1973
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1974
> > ps_control(psdata-
> > > hdev, PS_STATE_AWAKE);
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1975 return 0;
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1976 }
> > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1977
> >
> > --
> > 0-DAY CI Kernel Test Service
> > https://github/.
> > com%2Fintel%2Flkp-
> > tests%2Fwiki&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f321914
> > 6a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0
> > %7C0%7C639041898935740752%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0e
> > U1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCI
> > sIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=IqE%2B%2BS2ZXcZb5PFvsvemp
> > dQffNOiktBLNpxdDx5JJJg%3D&reserved=0
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* RE: More CONFIG_PM* simplifications
2026-01-19 10:27 [PATCH v2 1/3] Bluetooth: btmtksdio: Simplify dev_pm_ops usage Bastien Nocera
@ 2026-01-19 10:56 ` bluez.test.bot
2026-01-19 11:47 ` Bastien Nocera
0 siblings, 1 reply; 23+ messages in thread
From: bluez.test.bot @ 2026-01-19 10:56 UTC (permalink / raw)
To: linux-bluetooth, hadess
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
This is an automated email and please do not reply to this email.
Dear Submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.
----- Output -----
error: patch failed: drivers/bluetooth/btmtksdio.c:1472
error: drivers/bluetooth/btmtksdio.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch
Please resolve the issue and submit the patches again.
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: More CONFIG_PM* simplifications
2026-01-19 10:56 ` More CONFIG_PM* simplifications bluez.test.bot
@ 2026-01-19 11:47 ` Bastien Nocera
0 siblings, 0 replies; 23+ messages in thread
From: Bastien Nocera @ 2026-01-19 11:47 UTC (permalink / raw)
To: linux-bluetooth
A similar patch is already in bluetooth-next:
https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=fd52b1d0ad7de69b1266c2efa7065e1d2f8acb49
So this patch can be dropped.
On Mon, 2026-01-19 at 02:56 -0800, bluez.test.bot@gmail.com wrote:
> This is an automated email and please do not reply to this email.
>
> Dear Submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing
> list.
> While preparing the CI tests, the patches you submitted couldn't be
> applied to the current HEAD of the repository.
>
> ----- Output -----
>
> error: patch failed: drivers/bluetooth/btmtksdio.c:1472
> error: drivers/bluetooth/btmtksdio.c: patch does not apply
> hint: Use 'git am --show-current-patch' to see the failed patch
>
> Please resolve the issue and submit the patches again.
>
>
> ---
> Regards,
> Linux Bluetooth
^ permalink raw reply [flat|nested] 23+ messages in thread
* RE: More CONFIG_PM* simplifications
2026-01-19 12:34 [PATCH v3 1/2] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef Bastien Nocera
@ 2026-01-19 14:02 ` bluez.test.bot
0 siblings, 0 replies; 23+ messages in thread
From: bluez.test.bot @ 2026-01-19 14:02 UTC (permalink / raw)
To: linux-bluetooth, hadess
[-- Attachment #1: Type: text/plain, Size: 2913 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1044140
---Test result---
Test Summary:
CheckPatch PENDING 0.48 seconds
GitLint PENDING 0.35 seconds
SubjectPrefix PASS 0.15 seconds
BuildKernel PASS 23.61 seconds
CheckAllWarning PASS 26.42 seconds
CheckSparse PASS 28.89 seconds
BuildKernel32 PASS 23.45 seconds
TestRunnerSetup PASS 515.78 seconds
TestRunner_l2cap-tester PASS 28.67 seconds
TestRunner_iso-tester FAIL 58.89 seconds
TestRunner_bnep-tester PASS 6.37 seconds
TestRunner_mgmt-tester FAIL 124.26 seconds
TestRunner_rfcomm-tester PASS 9.53 seconds
TestRunner_sco-tester FAIL 14.63 seconds
TestRunner_ioctl-tester PASS 10.34 seconds
TestRunner_mesh-tester FAIL 12.49 seconds
TestRunner_smp-tester PASS 8.81 seconds
TestRunner_userchan-tester PASS 6.83 seconds
IncrementalBuild PENDING 0.71 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
BUG: KASAN: slab-use-after-free in le_read_features_complete+0x7e/0x2b0
Total: 141, Passed: 141 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 494, Passed: 488 (98.8%), Failed: 2, Not Run: 4
Failed Test Cases
Read Exp Feature - Success Failed 0.108 seconds
LL Privacy - Remove Device 3 (Disable RL) Failed 0.204 seconds
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
BUG: sleeping function called from invalid context at net/core/sock.c:3782
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 2.711 seconds
Mesh - Send cancel - 2 Timed out 1.999 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef
2026-01-19 9:10 ` Bastien Nocera
@ 2026-01-20 16:42 ` Luiz Augusto von Dentz
2026-01-20 17:17 ` Bastien Nocera
0 siblings, 1 reply; 23+ messages in thread
From: Luiz Augusto von Dentz @ 2026-01-20 16:42 UTC (permalink / raw)
To: Bastien Nocera
Cc: Neeraj Sanjay Kale, kernel test robot,
linux-bluetooth@vger.kernel.org, oe-kbuild-all@lists.linux.dev
Hi Bastien,
On Mon, Jan 19, 2026 at 4:13 AM Bastien Nocera <hadess@hadess.net> wrote:
>
> On Mon, 2026-01-19 at 07:53 +0000, Neeraj Sanjay Kale wrote:
> > Hi Bastien,
> >
> > Thank you for your patch.
> >
> > Just an FYI, the " #ifdef CONFIG_PM_SLEEP" was added on purpose to
> > resolve such build warning reported by kernel test bot:
> > https://lore.kernel.org/all/20240710123426.935122-1-neeraj.sanjaykale@nxp.com/
>
> I didn't see those warnings locally. They should be fixed by using
> __maybe_unused instead otherwise the "it extends the code coverage"
> justification wouldn't really apply anymore.
Yes, I think we should mark the functions that are conditional with
__maybe_unused, actually this might be the case with
btusb_resume/btusb_suspend as well, right?
>
> Cheers
>
> >
> > Thanks,
> > Neeraj
> >
> > > Hi Bastien,
> > >
> > > kernel test robot noticed the following build warnings:
> > >
> > > [auto build test WARNING on bluetooth/master] [also build test
> > > WARNING on
> > > linus/master v6.19-rc5] [cannot apply to bluetooth-next/master
> > > next-
> > > 20260116] [If your patch is applied to the wrong git tree, kindly
> > > drop us a
> > > note.
> > > And when submitting patch, we suggest to use '--base' as documented
> > > in
> > > https://git-/
> > > scm.com%2Fdocs%2Fgit-format-
> > > patch%23_base_tree_information&data=05%7C02%7Cneeraj.sanjaykale%40n
> > > xp.com%7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92
> > > cd99c5c301635%7C0%7C0%7C639041898935601715%7CUnknown%7CTWFp
> > > bGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4z
> > > MiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=W4jhk2S
> > > VUr77jirvKdK%2FrKuKAVyXSbY9iO2pQ1%2BL7Fs%3D&reserved=0]
> > >
> > > url:
> > > https://github/.
> > > com%2Fintel-lab-lkp%2Flinux%2Fcommits%2FBastien-Nocera%2FBluetooth-
> > > btmtksdio-Simplify-dev_pm_ops-usage%2F20260116-
> > > 210400&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f3219146a754
> > > 0774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> > > %7C639041898935632879%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcG
> > > kiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUI
> > > j
> > > oyfQ%3D%3D%7C0%7C%7C%7C&sdata=l2nEr61x%2F00NrtEqmvX2qhJ%2F0d
> > > %2Fc6T%2BI6e5YRiz1TAM%3D&reserved=0
> > > base:
> > > https://git.kern/
> > > el.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fbluetooth%2Fbluetooth.g
> > > i
> > > t&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f3219146a7540774e
> > > da08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
> > > 9041898935651605%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRy
> > > dWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%
> > > 3
> > > D%3D%7C0%7C%7C%7C&sdata=%2BKZxHj6EXqJXKC8%2FsiYrPOJczts%2BMEX
> > > ycXixKcxUcf8%3D&reserved=0 master
> > > patch link:
> > > https://lore.ke/
> > > rnel.org%2Fr%2F20260116125803.598552-3-
> > > hadess%2540hadess.net&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%
> > > 7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c3
> > > 01635%7C0%7C0%7C639041898935668808%7CUnknown%7CTWFpbGZsb3d8
> > > eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIj
> > > oiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=a3gomBec5GENv5B
> > > RsBv%2Butzd11I3QunXE2yAaDg5f4Q%3D&reserved=0
> > > patch subject: [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded
> > > CONFIG_PM ifdef
> > > config: x86_64-randconfig-002-20260116
> > > (https://downl/
> > > oad.01.org%2F0day-ci%2Farchive%2F20260117%2F202601170322.MZrwlt6M-
> > > lkp%40intel.com%2Fconfig&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com
> > > %7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c
> > > 301635%7C0%7C0%7C639041898935685518%7CUnknown%7CTWFpbGZsb3d
> > > 8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOI
> > > joiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=hR230cwqc4FucDn
> > > 9TPmv79VLdAd8kHHwc2Q8SdPtHtk%3D&reserved=0)
> > > compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 reproduce (this is a W=1
> > > build):
> > > (https://downl/
> > > oad.01.org%2F0day-ci%2Farchive%2F20260117%2F202601170322.MZrwlt6M-
> > > lkp%40intel.com%2Freproduce&data=05%7C02%7Cneeraj.sanjaykale%40nxp.
> > > com%7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd9
> > > 9c5c301635%7C0%7C0%7C639041898935702245%7CUnknown%7CTWFpbGZ
> > > sb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIs
> > > IkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=dsZA9O8KQy
> > > QZJK2Fn%2FYtexA8zdrw%2FCcpwnEb7AwhiqU%3D&reserved=0)
> > >
> > > If you fix the issue in a separate patch/commit (i.e. not just a
> > > new version of
> > > the same patch/commit), kindly add following tags
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > Closes:
> > > > https://lore/
> > > > .kernel.org%2Foe-kbuild-all%2F202601170322.MZrwlt6M-
> > > lkp%40intel.com%2F
> > > >
> > > &data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f3219146a7540774e
> > > da08de
> > > >
> > > 5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63904189
> > > 89357202
> > > >
> > > 33%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjA
> > > uMDAwMCI
> > > >
> > > sIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sd
> > > ata=2
> > > > s046Nm4SrgCfY%2BqPyoYr8tf5xqoBw%2BqDiJ0YQ%2BiAt8%3D&reserved=0
> > >
> > > All warnings (new ones prefixed by >>):
> > >
> > > > > drivers/bluetooth/btnxpuart.c:1964:12: warning:
> > > > > 'nxp_serdev_resume'
> > > > > defined but not used [-Wunused-function]
> > > 1964 | static int nxp_serdev_resume(struct device *dev)
> > > | ^~~~~~~~~~~~~~~~~
> > > > > drivers/bluetooth/btnxpuart.c:1950:12: warning:
> > > > > 'nxp_serdev_suspend'
> > > > > defined but not used [-Wunused-function]
> > > 1950 | static int nxp_serdev_suspend(struct device *dev)
> > > | ^~~~~~~~~~~~~~~~~~
> > >
> > >
> > > vim +/nxp_serdev_resume +1964 drivers/bluetooth/btnxpuart.c
> > >
> > > 689ca16e5232784 Neeraj Sanjay Kale 2023-03-16 1949
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 @1950 static int
> > > nxp_serdev_suspend(struct device *dev)
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1951 {
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1952 struct
> > > btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1953 struct
> > > ps_data
> > > *psdata = &nxpdev->psdata;
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1954
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1955
> > > ps_control(psdata-
> > > > hdev, PS_STATE_SLEEP);
> > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1956
> > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1957 if (psdata-
> > > > wakeup_source) {
> > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1958
> > > enable_irq_wake(psdata->irq_handler);
> > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1959
> > > enable_irq(psdata->irq_handler);
> > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1960 }
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1961 return 0;
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1962 }
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1963
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 @1964 static int
> > > nxp_serdev_resume(struct device *dev)
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1965 {
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1966 struct
> > > btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1967 struct
> > > ps_data
> > > *psdata = &nxpdev->psdata;
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1968
> > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1969 if (psdata-
> > > > wakeup_source) {
> > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1970
> > > disable_irq(psdata->irq_handler);
> > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1971
> > > disable_irq_wake(psdata->irq_handler);
> > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1972 }
> > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1973
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1974
> > > ps_control(psdata-
> > > > hdev, PS_STATE_AWAKE);
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1975 return 0;
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1976 }
> > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1977
> > >
> > > --
> > > 0-DAY CI Kernel Test Service
> > > https://github/.
> > > com%2Fintel%2Flkp-
> > > tests%2Fwiki&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f321914
> > > 6a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0
> > > %7C0%7C639041898935740752%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0e
> > > U1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCI
> > > sIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=IqE%2B%2BS2ZXcZb5PFvsvemp
> > > dQffNOiktBLNpxdDx5JJJg%3D&reserved=0
> >
>
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef
2026-01-20 16:42 ` Luiz Augusto von Dentz
@ 2026-01-20 17:17 ` Bastien Nocera
2026-01-20 18:05 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 23+ messages in thread
From: Bastien Nocera @ 2026-01-20 17:17 UTC (permalink / raw)
To: Luiz Augusto von Dentz
Cc: Neeraj Sanjay Kale, kernel test robot,
linux-bluetooth@vger.kernel.org, oe-kbuild-all@lists.linux.dev
On Tue, 2026-01-20 at 11:42 -0500, Luiz Augusto von Dentz wrote:
> Hi Bastien,
>
> On Mon, Jan 19, 2026 at 4:13 AM Bastien Nocera <hadess@hadess.net>
> wrote:
> >
> > On Mon, 2026-01-19 at 07:53 +0000, Neeraj Sanjay Kale wrote:
> > > Hi Bastien,
> > >
> > > Thank you for your patch.
> > >
> > > Just an FYI, the " #ifdef CONFIG_PM_SLEEP" was added on purpose
> > > to
> > > resolve such build warning reported by kernel test bot:
> > > https://lore.kernel.org/all/20240710123426.935122-1-neeraj.sanjaykale@nxp.com/
> >
> > I didn't see those warnings locally. They should be fixed by using
> > __maybe_unused instead otherwise the "it extends the code coverage"
> > justification wouldn't really apply anymore.
>
> Yes, I think we should mark the functions that are conditional with
> __maybe_unused, actually this might be the case with
> btusb_resume/btusb_suspend as well, right?
I believe that's what I've done that in v3. Let me know if there are
any problems with that version still.
Cheers
>
> >
> > Cheers
> >
> > >
> > > Thanks,
> > > Neeraj
> > >
> > > > Hi Bastien,
> > > >
> > > > kernel test robot noticed the following build warnings:
> > > >
> > > > [auto build test WARNING on bluetooth/master] [also build test
> > > > WARNING on
> > > > linus/master v6.19-rc5] [cannot apply to bluetooth-next/master
> > > > next-
> > > > 20260116] [If your patch is applied to the wrong git tree,
> > > > kindly
> > > > drop us a
> > > > note.
> > > > And when submitting patch, we suggest to use '--base' as
> > > > documented
> > > > in
> > > > https://git-/
> > > > scm.com%2Fdocs%2Fgit-format-
> > > > patch%23_base_tree_information&data=05%7C02%7Cneeraj.sanjaykale
> > > > %40n
> > > > xp.com%7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92
> > > > cd99c5c301635%7C0%7C0%7C639041898935601715%7CUnknown%7CTWFp
> > > > bGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4
> > > > z
> > > > MiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=W4jhk2S
> > > > VUr77jirvKdK%2FrKuKAVyXSbY9iO2pQ1%2BL7Fs%3D&reserved=0]
> > > >
> > > > url:
> > > > https://github/.
> > > > com%2Fintel-lab-lkp%2Flinux%2Fcommits%2FBastien-
> > > > Nocera%2FBluetooth-
> > > > btmtksdio-Simplify-dev_pm_ops-usage%2F20260116-
> > > > 210400&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f3219146a7
> > > > 54
> > > > 0774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> > > > %7C639041898935632879%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcG
> > > > kiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsI
> > > > ldUI
> > > > j
> > > > oyfQ%3D%3D%7C0%7C%7C%7C&sdata=l2nEr61x%2F00NrtEqmvX2qhJ%2F0d
> > > > %2Fc6T%2BI6e5YRiz1TAM%3D&reserved=0
> > > > base:
> > > > https://git.kern/
> > > > el.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fbluetooth%2Fbluetoo
> > > > th.g
> > > > i
> > > > t&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f3219146a754077
> > > > 4e
> > > > da08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
> > > > 9041898935651605%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRy
> > > > dWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjo
> > > > yfQ%
> > > > 3
> > > > D%3D%7C0%7C%7C%7C&sdata=%2BKZxHj6EXqJXKC8%2FsiYrPOJczts%2BMEX
> > > > ycXixKcxUcf8%3D&reserved=0 master
> > > > patch link:
> > > > https://lore.ke/
> > > > rnel.org%2Fr%2F20260116125803.598552-3-
> > > > hadess%2540hadess.net&data=05%7C02%7Cneeraj.sanjaykale%40nxp.co
> > > > m%
> > > > 7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c
> > > > 3
> > > > 01635%7C0%7C0%7C639041898935668808%7CUnknown%7CTWFpbGZsb3d8
> > > > eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkF
> > > > OIj
> > > > oiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=a3gomBec5GENv5B
> > > > RsBv%2Butzd11I3QunXE2yAaDg5f4Q%3D&reserved=0
> > > > patch subject: [PATCH 2/3] Bluetooth: btnxpuart: Remove
> > > > unneeded
> > > > CONFIG_PM ifdef
> > > > config: x86_64-randconfig-002-20260116
> > > > (https://downl/
> > > > oad.01.org%2F0day-
> > > > ci%2Farchive%2F20260117%2F202601170322.MZrwlt6M-
> > > > lkp%40intel.com%2Fconfig&data=05%7C02%7Cneeraj.sanjaykale%40nxp
> > > > .com
> > > > %7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5
> > > > c
> > > > 301635%7C0%7C0%7C639041898935685518%7CUnknown%7CTWFpbGZsb3d
> > > > 8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIk
> > > > FOI
> > > > joiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=hR230cwqc4FucDn
> > > > 9TPmv79VLdAd8kHHwc2Q8SdPtHtk%3D&reserved=0)
> > > > compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 reproduce (this is a
> > > > W=1
> > > > build):
> > > > (https://downl/
> > > > oad.01.org%2F0day-
> > > > ci%2Farchive%2F20260117%2F202601170322.MZrwlt6M-
> > > > lkp%40intel.com%2Freproduce&data=05%7C02%7Cneeraj.sanjaykale%40
> > > > nxp.
> > > > com%7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd9
> > > > 9c5c301635%7C0%7C0%7C639041898935702245%7CUnknown%7CTWFpbGZ
> > > > sb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMi
> > > > Is
> > > > IkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=dsZA9O8KQy
> > > > QZJK2Fn%2FYtexA8zdrw%2FCcpwnEb7AwhiqU%3D&reserved=0)
> > > >
> > > > If you fix the issue in a separate patch/commit (i.e. not just
> > > > a
> > > > new version of
> > > > the same patch/commit), kindly add following tags
> > > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > > Closes:
> > > > > https://lore/
> > > > > .kernel.org%2Foe-kbuild-all%2F202601170322.MZrwlt6M-
> > > > lkp%40intel.com%2F
> > > > >
> > > > &data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f3219146a7540774
> > > > e
> > > > da08de
> > > > >
> > > > 5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63904189
> > > > 89357202
> > > > >
> > > > 33%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjA
> > > > uMDAwMCI
> > > > >
> > > > sIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&
> > > > sd
> > > > ata=2
> > > > > s046Nm4SrgCfY%2BqPyoYr8tf5xqoBw%2BqDiJ0YQ%2BiAt8%3D&reserved=
> > > > > 0
> > > >
> > > > All warnings (new ones prefixed by >>):
> > > >
> > > > > > drivers/bluetooth/btnxpuart.c:1964:12: warning:
> > > > > > 'nxp_serdev_resume'
> > > > > > defined but not used [-Wunused-function]
> > > > 1964 | static int nxp_serdev_resume(struct device *dev)
> > > > | ^~~~~~~~~~~~~~~~~
> > > > > > drivers/bluetooth/btnxpuart.c:1950:12: warning:
> > > > > > 'nxp_serdev_suspend'
> > > > > > defined but not used [-Wunused-function]
> > > > 1950 | static int nxp_serdev_suspend(struct device *dev)
> > > > | ^~~~~~~~~~~~~~~~~~
> > > >
> > > >
> > > > vim +/nxp_serdev_resume +1964 drivers/bluetooth/btnxpuart.c
> > > >
> > > > 689ca16e5232784 Neeraj Sanjay Kale 2023-03-16 1949
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 @1950 static int
> > > > nxp_serdev_suspend(struct device *dev)
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1951 {
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1952 struct
> > > > btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1953 struct
> > > > ps_data
> > > > *psdata = &nxpdev->psdata;
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1954
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1955
> > > > ps_control(psdata-
> > > > > hdev, PS_STATE_SLEEP);
> > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1956
> > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1957 if
> > > > (psdata-
> > > > > wakeup_source) {
> > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1958
> > > > enable_irq_wake(psdata->irq_handler);
> > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1959
> > > > enable_irq(psdata->irq_handler);
> > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1960 }
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1961 return
> > > > 0;
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1962 }
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1963
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 @1964 static int
> > > > nxp_serdev_resume(struct device *dev)
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1965 {
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1966 struct
> > > > btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1967 struct
> > > > ps_data
> > > > *psdata = &nxpdev->psdata;
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1968
> > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1969 if
> > > > (psdata-
> > > > > wakeup_source) {
> > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1970
> > > > disable_irq(psdata->irq_handler);
> > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1971
> > > > disable_irq_wake(psdata->irq_handler);
> > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1972 }
> > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1973
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1974
> > > > ps_control(psdata-
> > > > > hdev, PS_STATE_AWAKE);
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1975 return
> > > > 0;
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1976 }
> > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1977
> > > >
> > > > --
> > > > 0-DAY CI Kernel Test Service
> > > > https://github/.
> > > > com%2Fintel%2Flkp-
> > > > tests%2Fwiki&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f321
> > > > 914
> > > > 6a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0
> > > > %7C0%7C639041898935740752%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0e
> > > > U1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFp
> > > > bCI
> > > > sIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=IqE%2B%2BS2ZXcZb5PFvsvemp
> > > > dQffNOiktBLNpxdDx5JJJg%3D&reserved=0
> > >
> >
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef
2026-01-20 17:17 ` Bastien Nocera
@ 2026-01-20 18:05 ` Luiz Augusto von Dentz
2026-01-20 21:38 ` Bastien Nocera
0 siblings, 1 reply; 23+ messages in thread
From: Luiz Augusto von Dentz @ 2026-01-20 18:05 UTC (permalink / raw)
To: Bastien Nocera
Cc: Neeraj Sanjay Kale, kernel test robot,
linux-bluetooth@vger.kernel.org, oe-kbuild-all@lists.linux.dev
Hi Bastien,
On Tue, Jan 20, 2026 at 12:17 PM Bastien Nocera <hadess@hadess.net> wrote:
>
> On Tue, 2026-01-20 at 11:42 -0500, Luiz Augusto von Dentz wrote:
> > Hi Bastien,
> >
> > On Mon, Jan 19, 2026 at 4:13 AM Bastien Nocera <hadess@hadess.net>
> > wrote:
> > >
> > > On Mon, 2026-01-19 at 07:53 +0000, Neeraj Sanjay Kale wrote:
> > > > Hi Bastien,
> > > >
> > > > Thank you for your patch.
> > > >
> > > > Just an FYI, the " #ifdef CONFIG_PM_SLEEP" was added on purpose
> > > > to
> > > > resolve such build warning reported by kernel test bot:
> > > > https://lore.kernel.org/all/20240710123426.935122-1-neeraj.sanjaykale@nxp.com/
> > >
> > > I didn't see those warnings locally. They should be fixed by using
> > > __maybe_unused instead otherwise the "it extends the code coverage"
> > > justification wouldn't really apply anymore.
> >
> > Yes, I think we should mark the functions that are conditional with
> > __maybe_unused, actually this might be the case with
> > btusb_resume/btusb_suspend as well, right?
>
> I believe that's what I've done that in v3. Let me know if there are
> any problems with that version still.
You mean https://patchwork.kernel.org/project/bluetooth/list/?series=1044140?
That doesn't contain any changes to btusb though, anyway I can fixup
the existing change just in case.
>
> Cheers
>
> >
> > >
> > > Cheers
> > >
> > > >
> > > > Thanks,
> > > > Neeraj
> > > >
> > > > > Hi Bastien,
> > > > >
> > > > > kernel test robot noticed the following build warnings:
> > > > >
> > > > > [auto build test WARNING on bluetooth/master] [also build test
> > > > > WARNING on
> > > > > linus/master v6.19-rc5] [cannot apply to bluetooth-next/master
> > > > > next-
> > > > > 20260116] [If your patch is applied to the wrong git tree,
> > > > > kindly
> > > > > drop us a
> > > > > note.
> > > > > And when submitting patch, we suggest to use '--base' as
> > > > > documented
> > > > > in
> > > > > https://git-/
> > > > > scm.com%2Fdocs%2Fgit-format-
> > > > > patch%23_base_tree_information&data=05%7C02%7Cneeraj.sanjaykale
> > > > > %40n
> > > > > xp.com%7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92
> > > > > cd99c5c301635%7C0%7C0%7C639041898935601715%7CUnknown%7CTWFp
> > > > > bGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4
> > > > > z
> > > > > MiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=W4jhk2S
> > > > > VUr77jirvKdK%2FrKuKAVyXSbY9iO2pQ1%2BL7Fs%3D&reserved=0]
> > > > >
> > > > > url:
> > > > > https://github/.
> > > > > com%2Fintel-lab-lkp%2Flinux%2Fcommits%2FBastien-
> > > > > Nocera%2FBluetooth-
> > > > > btmtksdio-Simplify-dev_pm_ops-usage%2F20260116-
> > > > > 210400&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f3219146a7
> > > > > 54
> > > > > 0774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> > > > > %7C639041898935632879%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcG
> > > > > kiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsI
> > > > > ldUI
> > > > > j
> > > > > oyfQ%3D%3D%7C0%7C%7C%7C&sdata=l2nEr61x%2F00NrtEqmvX2qhJ%2F0d
> > > > > %2Fc6T%2BI6e5YRiz1TAM%3D&reserved=0
> > > > > base:
> > > > > https://git.kern/
> > > > > el.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fbluetooth%2Fbluetoo
> > > > > th.g
> > > > > i
> > > > > t&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f3219146a754077
> > > > > 4e
> > > > > da08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
> > > > > 9041898935651605%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRy
> > > > > dWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjo
> > > > > yfQ%
> > > > > 3
> > > > > D%3D%7C0%7C%7C%7C&sdata=%2BKZxHj6EXqJXKC8%2FsiYrPOJczts%2BMEX
> > > > > ycXixKcxUcf8%3D&reserved=0 master
> > > > > patch link:
> > > > > https://lore.ke/
> > > > > rnel.org%2Fr%2F20260116125803.598552-3-
> > > > > hadess%2540hadess.net&data=05%7C02%7Cneeraj.sanjaykale%40nxp.co
> > > > > m%
> > > > > 7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c
> > > > > 3
> > > > > 01635%7C0%7C0%7C639041898935668808%7CUnknown%7CTWFpbGZsb3d8
> > > > > eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkF
> > > > > OIj
> > > > > oiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=a3gomBec5GENv5B
> > > > > RsBv%2Butzd11I3QunXE2yAaDg5f4Q%3D&reserved=0
> > > > > patch subject: [PATCH 2/3] Bluetooth: btnxpuart: Remove
> > > > > unneeded
> > > > > CONFIG_PM ifdef
> > > > > config: x86_64-randconfig-002-20260116
> > > > > (https://downl/
> > > > > oad.01.org%2F0day-
> > > > > ci%2Farchive%2F20260117%2F202601170322.MZrwlt6M-
> > > > > lkp%40intel.com%2Fconfig&data=05%7C02%7Cneeraj.sanjaykale%40nxp
> > > > > .com
> > > > > %7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5
> > > > > c
> > > > > 301635%7C0%7C0%7C639041898935685518%7CUnknown%7CTWFpbGZsb3d
> > > > > 8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIk
> > > > > FOI
> > > > > joiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=hR230cwqc4FucDn
> > > > > 9TPmv79VLdAd8kHHwc2Q8SdPtHtk%3D&reserved=0)
> > > > > compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 reproduce (this is a
> > > > > W=1
> > > > > build):
> > > > > (https://downl/
> > > > > oad.01.org%2F0day-
> > > > > ci%2Farchive%2F20260117%2F202601170322.MZrwlt6M-
> > > > > lkp%40intel.com%2Freproduce&data=05%7C02%7Cneeraj.sanjaykale%40
> > > > > nxp.
> > > > > com%7C6f3219146a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd9
> > > > > 9c5c301635%7C0%7C0%7C639041898935702245%7CUnknown%7CTWFpbGZ
> > > > > sb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMi
> > > > > Is
> > > > > IkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=dsZA9O8KQy
> > > > > QZJK2Fn%2FYtexA8zdrw%2FCcpwnEb7AwhiqU%3D&reserved=0)
> > > > >
> > > > > If you fix the issue in a separate patch/commit (i.e. not just
> > > > > a
> > > > > new version of
> > > > > the same patch/commit), kindly add following tags
> > > > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > > > Closes:
> > > > > > https://lore/
> > > > > > .kernel.org%2Foe-kbuild-all%2F202601170322.MZrwlt6M-
> > > > > lkp%40intel.com%2F
> > > > > >
> > > > > &data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f3219146a7540774
> > > > > e
> > > > > da08de
> > > > > >
> > > > > 5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63904189
> > > > > 89357202
> > > > > >
> > > > > 33%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjA
> > > > > uMDAwMCI
> > > > > >
> > > > > sIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&
> > > > > sd
> > > > > ata=2
> > > > > > s046Nm4SrgCfY%2BqPyoYr8tf5xqoBw%2BqDiJ0YQ%2BiAt8%3D&reserved=
> > > > > > 0
> > > > >
> > > > > All warnings (new ones prefixed by >>):
> > > > >
> > > > > > > drivers/bluetooth/btnxpuart.c:1964:12: warning:
> > > > > > > 'nxp_serdev_resume'
> > > > > > > defined but not used [-Wunused-function]
> > > > > 1964 | static int nxp_serdev_resume(struct device *dev)
> > > > > | ^~~~~~~~~~~~~~~~~
> > > > > > > drivers/bluetooth/btnxpuart.c:1950:12: warning:
> > > > > > > 'nxp_serdev_suspend'
> > > > > > > defined but not used [-Wunused-function]
> > > > > 1950 | static int nxp_serdev_suspend(struct device *dev)
> > > > > | ^~~~~~~~~~~~~~~~~~
> > > > >
> > > > >
> > > > > vim +/nxp_serdev_resume +1964 drivers/bluetooth/btnxpuart.c
> > > > >
> > > > > 689ca16e5232784 Neeraj Sanjay Kale 2023-03-16 1949
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 @1950 static int
> > > > > nxp_serdev_suspend(struct device *dev)
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1951 {
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1952 struct
> > > > > btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1953 struct
> > > > > ps_data
> > > > > *psdata = &nxpdev->psdata;
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1954
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1955
> > > > > ps_control(psdata-
> > > > > > hdev, PS_STATE_SLEEP);
> > > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1956
> > > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1957 if
> > > > > (psdata-
> > > > > > wakeup_source) {
> > > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1958
> > > > > enable_irq_wake(psdata->irq_handler);
> > > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1959
> > > > > enable_irq(psdata->irq_handler);
> > > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1960 }
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1961 return
> > > > > 0;
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1962 }
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1963
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 @1964 static int
> > > > > nxp_serdev_resume(struct device *dev)
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1965 {
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1966 struct
> > > > > btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1967 struct
> > > > > ps_data
> > > > > *psdata = &nxpdev->psdata;
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1968
> > > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1969 if
> > > > > (psdata-
> > > > > > wakeup_source) {
> > > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1970
> > > > > disable_irq(psdata->irq_handler);
> > > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1971
> > > > > disable_irq_wake(psdata->irq_handler);
> > > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1972 }
> > > > > c50b56664e48b66 Neeraj Sanjay Kale 2025-04-14 1973
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1974
> > > > > ps_control(psdata-
> > > > > > hdev, PS_STATE_AWAKE);
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1975 return
> > > > > 0;
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1976 }
> > > > > 658c56d5b3b3a41 Neeraj Sanjay Kale 2024-07-05 1977
> > > > >
> > > > > --
> > > > > 0-DAY CI Kernel Test Service
> > > > > https://github/.
> > > > > com%2Fintel%2Flkp-
> > > > > tests%2Fwiki&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7C6f321
> > > > > 914
> > > > > 6a7540774eda08de5538a471%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0
> > > > > %7C0%7C639041898935740752%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0e
> > > > > U1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFp
> > > > > bCI
> > > > > sIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=IqE%2B%2BS2ZXcZb5PFvsvemp
> > > > > dQffNOiktBLNpxdDx5JJJg%3D&reserved=0
> > > >
> > >
> >
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef
2026-01-20 18:05 ` Luiz Augusto von Dentz
@ 2026-01-20 21:38 ` Bastien Nocera
0 siblings, 0 replies; 23+ messages in thread
From: Bastien Nocera @ 2026-01-20 21:38 UTC (permalink / raw)
To: Luiz Augusto von Dentz
Cc: Neeraj Sanjay Kale, kernel test robot,
linux-bluetooth@vger.kernel.org, oe-kbuild-all@lists.linux.dev
On Tue, 2026-01-20 at 13:05 -0500, Luiz Augusto von Dentz wrote:
> Hi Bastien,
>
> On Tue, Jan 20, 2026 at 12:17 PM Bastien Nocera <hadess@hadess.net>
> wrote:
> >
> > On Tue, 2026-01-20 at 11:42 -0500, Luiz Augusto von Dentz wrote:
> > > Hi Bastien,
> > >
> > > On Mon, Jan 19, 2026 at 4:13 AM Bastien Nocera
> > > <hadess@hadess.net>
> > > wrote:
> > > >
> > > > On Mon, 2026-01-19 at 07:53 +0000, Neeraj Sanjay Kale wrote:
> > > > > Hi Bastien,
> > > > >
> > > > > Thank you for your patch.
> > > > >
> > > > > Just an FYI, the " #ifdef CONFIG_PM_SLEEP" was added on
> > > > > purpose
> > > > > to
> > > > > resolve such build warning reported by kernel test bot:
> > > > > https://lore.kernel.org/all/20240710123426.935122-1-neeraj.sanjaykale@nxp.com/
> > > >
> > > > I didn't see those warnings locally. They should be fixed by
> > > > using
> > > > __maybe_unused instead otherwise the "it extends the code
> > > > coverage"
> > > > justification wouldn't really apply anymore.
> > >
> > > Yes, I think we should mark the functions that are conditional
> > > with
> > > __maybe_unused, actually this might be the case with
> > > btusb_resume/btusb_suspend as well, right?
> >
> > I believe that's what I've done that in v3. Let me know if there
> > are
> > any problems with that version still.
>
> You mean
> https://patchwork.kernel.org/project/bluetooth/list/?series=1044140?
> That doesn't contain any changes to btusb though, anyway I can fixup
> the existing change just in case.
Sorry, I read that a bit quickly, you're right.
I made a bit of a mess of this patchset because I had real trouble
trying to first disabling CONFIG_PM altogether (had success with this
yesterday), and then trying to make the current btusb code throw a
warning, but couldn't.
And that's the case because pm_ptr() is based on PTR_IF() and its docs
explain why __maybe_unused isn't necessary when using pm_ptr():
https://kernel.org/doc/html//next/driver-api/basics.html#c.PTR_IF
The other patches I sent used SET_SYSTEM_SLEEP_PM_OPS() and
SET_RUNTIME_PM_OPS() which use #ifdef's.
In short, the code in btusb.c was correct, no need for fixups.
Cheers
^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2026-01-20 21:38 UTC | newest]
Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-16 12:50 [PATCH 0/3] More CONFIG_PM* simplifications Bastien Nocera
2026-01-16 12:50 ` [PATCH 1/3] Bluetooth: btmtksdio: Simplify dev_pm_ops usage Bastien Nocera
2026-01-16 13:33 ` Paul Menzel
2026-01-16 13:42 ` Bastien Nocera
2026-01-16 13:36 ` More CONFIG_PM* simplifications bluez.test.bot
2026-01-16 19:29 ` [PATCH 1/3] Bluetooth: btmtksdio: Simplify dev_pm_ops usage kernel test robot
2026-01-16 12:50 ` [PATCH 2/3] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef Bastien Nocera
2026-01-16 13:35 ` Paul Menzel
2026-01-16 14:35 ` Luiz Augusto von Dentz
2026-01-16 14:41 ` Bastien Nocera
2026-01-16 19:50 ` kernel test robot
2026-01-19 7:53 ` Neeraj Sanjay Kale
2026-01-19 9:10 ` Bastien Nocera
2026-01-20 16:42 ` Luiz Augusto von Dentz
2026-01-20 17:17 ` Bastien Nocera
2026-01-20 18:05 ` Luiz Augusto von Dentz
2026-01-20 21:38 ` Bastien Nocera
2026-01-16 12:50 ` [PATCH 3/3] Bluetooth: btintel: Remove unneeded CONFIG_PM* #ifdef's Bastien Nocera
2026-01-16 13:36 ` Paul Menzel
2026-01-16 21:49 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2026-01-19 10:27 [PATCH v2 1/3] Bluetooth: btmtksdio: Simplify dev_pm_ops usage Bastien Nocera
2026-01-19 10:56 ` More CONFIG_PM* simplifications bluez.test.bot
2026-01-19 11:47 ` Bastien Nocera
2026-01-19 12:34 [PATCH v3 1/2] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef Bastien Nocera
2026-01-19 14:02 ` More CONFIG_PM* simplifications bluez.test.bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox