[PATCH BlueZ v1] shared/tmap: Fix TMAP/SR/SGGIT/CHA/BV-01-C on big endian

[PATCH BlueZ v1] shared/tmap: Fix TMAP/SR/SGGIT/CHA/BV-01-C on big endian

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This fix the following error cause by not converting the role value to
little endian:

TMAP/SR/SGGIT/CHA/BV-01-C [Characteristic GGIT - TMAP Role] - run
**
ERROR:src/shared/tester.c:992:test_io_recv: assertion failed: (memcmp(buf, iov->iov_base, len) == 0)
Bail out! ERROR:src/shared/tester.c:992:test_io_recv: assertion failed: (memcmp(buf, iov->iov_base, len) == 0)
---
 src/shared/tmap.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/shared/tmap.c b/src/shared/tmap.c
index 27e08d74a0d4..685c15fba2df 100644
--- a/src/shared/tmap.c
+++ b/src/shared/tmap.c
@@ -239,13 +239,12 @@ static void tmas_role_read(struct gatt_db_attribute *attrib,
 					void *user_data)
 {
 	struct bt_tmas_db *db = user_data;
-	struct iovec iov = {
-		.iov_base = &db->role_value,
-		.iov_len = sizeof(db->role_value)
-	};
+	uint16_t role;
 
-	gatt_db_attribute_read_result(attrib, id, 0, iov.iov_base,
-							iov.iov_len);
+	role = cpu_to_le16(db->role_value);
+
+	gatt_db_attribute_read_result(attrib, id, 0, (void *)&role,
+					sizeof(role));
 }
 
 static bool match_db(const void *data, const void *match_data)
-- 
2.52.0

RE: [BlueZ,v1] shared/tmap: Fix TMAP/SR/SGGIT/CHA/BV-01-C on big endian

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1047158

---Test result---

Test Summary:
CheckPatch                    PENDING   0.47 seconds
GitLint                       PENDING   0.39 seconds
BuildEll                      PASS      19.97 seconds
BluezMake                     PASS      638.41 seconds
MakeCheck                     PASS      18.87 seconds
MakeDistcheck                 PASS      240.14 seconds
CheckValgrind                 PASS      292.76 seconds
CheckSmatch                   PASS      347.94 seconds
bluezmakeextell               PASS      181.41 seconds
IncrementalBuild              PENDING   0.65 seconds
ScanBuild                     PASS      1018.03 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth