public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] media: Fix G.722 @ 16 kHz codec ID value reported by transport
@ 2026-01-28 10:38 Arkadiusz Bokowy
  2026-01-28 11:34 ` bluez.test.bot
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Arkadiusz Bokowy @ 2026-01-28 10:38 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Arkadiusz Bokowy

The G.722 @ 16 kHz codec ID is 0x01, not 0x02. The 0x02 value comes from
the ASHA ReadOnlyProperties GATT characteristic which is a bitmask with
bits corresponding to codec IDs - setting bit 1 gives bitmask value 0x02.
---
 profiles/audio/media.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/profiles/audio/media.c b/profiles/audio/media.c
index b68290aed..772af1014 100644
--- a/profiles/audio/media.c
+++ b/profiles/audio/media.c
@@ -3752,7 +3752,7 @@ const struct media_endpoint *media_endpoint_get_asha(void)
 	 */
 	static struct media_endpoint asha_endpoint =  {
 		.uuid = ASHA_PROFILE_UUID,
-		.codec = 0x2, /* Currently on G.722 is defined by the spec */
+		.codec = 0x1, /* Currently on G.722 is defined by the spec */
 	};
 
 	return &asha_endpoint;
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* RE: media: Fix G.722 @ 16 kHz codec ID value reported by transport
  2026-01-28 10:38 [PATCH] media: Fix G.722 @ 16 kHz codec ID value reported by transport Arkadiusz Bokowy
@ 2026-01-28 11:34 ` bluez.test.bot
  2026-01-29 15:47 ` [PATCH] " Arun Raghavan
  2026-01-29 16:30 ` [PATCH] " patchwork-bot+bluetooth
  2 siblings, 0 replies; 7+ messages in thread
From: bluez.test.bot @ 2026-01-28 11:34 UTC (permalink / raw)
  To: linux-bluetooth, arkadiusz.bokowy

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1047987

---Test result---

Test Summary:
CheckPatch                    PENDING   0.46 seconds
GitLint                       PENDING   0.43 seconds
BuildEll                      PASS      17.85 seconds
BluezMake                     PASS      614.95 seconds
MakeCheck                     PASS      18.22 seconds
MakeDistcheck                 PASS      221.51 seconds
CheckValgrind                 PASS      280.21 seconds
CheckSmatch                   PASS      315.20 seconds
bluezmakeextell               PASS      169.43 seconds
IncrementalBuild              PENDING   0.40 seconds
ScanBuild                     PASS      940.29 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] media: Fix G.722 @ 16 kHz codec ID value reported by transport
  2026-01-28 10:38 [PATCH] media: Fix G.722 @ 16 kHz codec ID value reported by transport Arkadiusz Bokowy
  2026-01-28 11:34 ` bluez.test.bot
@ 2026-01-29 15:47 ` Arun Raghavan
  2026-01-29 15:53   ` Arun Raghavan
                     ` (2 more replies)
  2026-01-29 16:30 ` [PATCH] " patchwork-bot+bluetooth
  2 siblings, 3 replies; 7+ messages in thread
From: Arun Raghavan @ 2026-01-29 15:47 UTC (permalink / raw)
  To: arkadiusz.bokowy, linux-bluetooth; +Cc: Arun Raghavan

The G.722 @ 16 kHz codec ID is 0x01, not 0x02. The 0x02 value comes from
the ASHA ReadOnlyProperties GATT characteristic which is a bitmask with
bits corresponding to codec IDs - setting bit 1 gives bitmask value 0x02.

Reviewed-by: Arun Raghavan <arun@arunraghavan.net>
---
 profiles/audio/media.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/profiles/audio/media.c b/profiles/audio/media.c
index b68290aed..772af1014 100644
--- a/profiles/audio/media.c
+++ b/profiles/audio/media.c
@@ -3752,7 +3752,7 @@ const struct media_endpoint *media_endpoint_get_asha(void)
 	 */
 	static struct media_endpoint asha_endpoint =  {
 		.uuid = ASHA_PROFILE_UUID,
-		.codec = 0x2, /* Currently on G.722 is defined by the spec */
+		.codec = 0x1, /* Currently on G.722 is defined by the spec */
 	};
 
 	return &asha_endpoint;

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] media: Fix G.722 @ 16 kHz codec ID value reported by transport
  2026-01-29 15:47 ` [PATCH] " Arun Raghavan
@ 2026-01-29 15:53   ` Arun Raghavan
  2026-01-29 16:30   ` patchwork-bot+bluetooth
  2026-01-29 16:43   ` bluez.test.bot
  2 siblings, 0 replies; 7+ messages in thread
From: Arun Raghavan @ 2026-01-29 15:53 UTC (permalink / raw)
  To: arkadiusz.bokowy, linux-bluetooth

On Thu, 29 Jan 2026, at 7:47 AM, Arun Raghavan wrote:
> The G.722 @ 16 kHz codec ID is 0x01, not 0x02. The 0x02 value comes from
> the ASHA ReadOnlyProperties GATT characteristic which is a bitmask with
> bits corresponding to codec IDs - setting bit 1 gives bitmask value 0x02.
>
> Reviewed-by: Arun Raghavan <arun@arunraghavan.net>
> ---
>  profiles/audio/media.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks like I might have used git send-email wrong here, apologies if that's the case.

-- Arun

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] media: Fix G.722 @ 16 kHz codec ID value reported by transport
  2026-01-28 10:38 [PATCH] media: Fix G.722 @ 16 kHz codec ID value reported by transport Arkadiusz Bokowy
  2026-01-28 11:34 ` bluez.test.bot
  2026-01-29 15:47 ` [PATCH] " Arun Raghavan
@ 2026-01-29 16:30 ` patchwork-bot+bluetooth
  2 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+bluetooth @ 2026-01-29 16:30 UTC (permalink / raw)
  To: Arkadiusz Bokowy; +Cc: linux-bluetooth

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 28 Jan 2026 11:38:09 +0100 you wrote:
> The G.722 @ 16 kHz codec ID is 0x01, not 0x02. The 0x02 value comes from
> the ASHA ReadOnlyProperties GATT characteristic which is a bitmask with
> bits corresponding to codec IDs - setting bit 1 gives bitmask value 0x02.
> ---
>  profiles/audio/media.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - media: Fix G.722 @ 16 kHz codec ID value reported by transport
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=ebb33150ba76

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] media: Fix G.722 @ 16 kHz codec ID value reported by transport
  2026-01-29 15:47 ` [PATCH] " Arun Raghavan
  2026-01-29 15:53   ` Arun Raghavan
@ 2026-01-29 16:30   ` patchwork-bot+bluetooth
  2026-01-29 16:43   ` bluez.test.bot
  2 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+bluetooth @ 2026-01-29 16:30 UTC (permalink / raw)
  To: Arun Raghavan; +Cc: arkadiusz.bokowy, linux-bluetooth

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 29 Jan 2026 07:47:52 -0800 you wrote:
> The G.722 @ 16 kHz codec ID is 0x01, not 0x02. The 0x02 value comes from
> the ASHA ReadOnlyProperties GATT characteristic which is a bitmask with
> bits corresponding to codec IDs - setting bit 1 gives bitmask value 0x02.
> 
> Reviewed-by: Arun Raghavan <arun@arunraghavan.net>
> ---
>  profiles/audio/media.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - media: Fix G.722 @ 16 kHz codec ID value reported by transport
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=ebb33150ba76

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: media: Fix G.722 @ 16 kHz codec ID value reported by transport
  2026-01-29 15:47 ` [PATCH] " Arun Raghavan
  2026-01-29 15:53   ` Arun Raghavan
  2026-01-29 16:30   ` patchwork-bot+bluetooth
@ 2026-01-29 16:43   ` bluez.test.bot
  2 siblings, 0 replies; 7+ messages in thread
From: bluez.test.bot @ 2026-01-29 16:43 UTC (permalink / raw)
  To: linux-bluetooth, arun

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1048593

---Test result---

Test Summary:
CheckPatch                    PENDING   0.35 seconds
GitLint                       PENDING   0.32 seconds
BuildEll                      PASS      19.86 seconds
BluezMake                     PASS      629.82 seconds
MakeCheck                     PASS      18.69 seconds
MakeDistcheck                 PASS      238.36 seconds
CheckValgrind                 PASS      289.12 seconds
CheckSmatch                   PASS      348.82 seconds
bluezmakeextell               PASS      181.29 seconds
IncrementalBuild              PENDING   0.40 seconds
ScanBuild                     PASS      993.09 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-01-29 16:43 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-28 10:38 [PATCH] media: Fix G.722 @ 16 kHz codec ID value reported by transport Arkadiusz Bokowy
2026-01-28 11:34 ` bluez.test.bot
2026-01-29 15:47 ` [PATCH] " Arun Raghavan
2026-01-29 15:53   ` Arun Raghavan
2026-01-29 16:30   ` patchwork-bot+bluetooth
2026-01-29 16:43   ` bluez.test.bot
2026-01-29 16:30 ` [PATCH] " patchwork-bot+bluetooth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox