[PATCH] Bluetooth: hci_core: Rate limit the logging of invalid ISO handle

[PATCH] Bluetooth: hci_core: Rate limit the logging of invalid ISO handle

[Pauli Virtanen]

Some controller firmwares (eg for MT7925) continuously send invalid ISO
packet, which result to "ISO unknown handle" error spam in logs.  It's
not important to show all of them to the user.

Rate limit these ISO error messages, similarly as we do for SCO.

Signed-off-by: Pauli Virtanen <pav@iki.fi>
---
 net/bluetooth/hci_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index b069607b145b..eb32802f6296 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -3917,8 +3917,8 @@ static void hci_isodata_packet(struct hci_dev *hdev, struct sk_buff *skb)
 
 	err = iso_recv(hdev, handle, skb, flags);
 	if (err == -ENOENT)
-		bt_dev_err(hdev, "ISO packet for unknown connection handle %d",
-			   handle);
+		bt_dev_err_ratelimited(hdev, "ISO packet for unknown connection handle %d",
+				       handle);
 	else if (err)
 		bt_dev_dbg(hdev, "ISO packet recv for handle %d failed: %d",
 			   handle, err);
-- 
2.52.0

Re: [PATCH] Bluetooth: hci_core: Rate limit the logging of invalid ISO handle

[Pauli Virtanen]

3. helmikuuta 2026 19.57.21 UTC Pauli Virtanen <pav@iki.fi> kirjoitti:
>Some controller firmwares (eg for MT7925) continuously send invalid ISO
>packet, which result to "ISO unknown handle" error spam in logs.  It's
>not important to show all of them to the user.
>
>Rate limit these ISO error messages, similarly as we do for SCO.

Possibly, the mtk driver should classify these packets for the invalid Handle 0 as some debug packets, or drop them.

But probably it makes sense to rate limit these messages regardless of whether it's driver or firmware issue.


>
>Signed-off-by: Pauli Virtanen <pav@iki.fi>
>---
> net/bluetooth/hci_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
>index b069607b145b..eb32802f6296 100644
>--- a/net/bluetooth/hci_core.c
>+++ b/net/bluetooth/hci_core.c
>@@ -3917,8 +3917,8 @@ static void hci_isodata_packet(struct hci_dev *hdev, struct sk_buff *skb)
> 
> 	err = iso_recv(hdev, handle, skb, flags);
> 	if (err == -ENOENT)
>-		bt_dev_err(hdev, "ISO packet for unknown connection handle %d",
>-			   handle);
>+		bt_dev_err_ratelimited(hdev, "ISO packet for unknown connection handle %d",
>+				       handle);
> 	else if (err)
> 		bt_dev_dbg(hdev, "ISO packet recv for handle %d failed: %d",
> 			   handle, err);

RE: Bluetooth: hci_core: Rate limit the logging of invalid ISO handle

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 3037 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1050469

---Test result---

Test Summary:
CheckPatch                    PENDING   0.52 seconds
GitLint                       PENDING   0.28 seconds
SubjectPrefix                 PASS      0.09 seconds
BuildKernel                   PASS      25.01 seconds
CheckAllWarning               PASS      27.93 seconds
CheckSparse                   WARNING   31.37 seconds
BuildKernel32                 PASS      24.65 seconds
TestRunnerSetup               PASS      552.12 seconds
TestRunner_l2cap-tester       PASS      28.26 seconds
TestRunner_iso-tester         PASS      75.09 seconds
TestRunner_bnep-tester        PASS      6.27 seconds
TestRunner_mgmt-tester        FAIL      112.88 seconds
TestRunner_rfcomm-tester      PASS      9.47 seconds
TestRunner_sco-tester         FAIL      14.43 seconds
TestRunner_ioctl-tester       PASS      10.06 seconds
TestRunner_mesh-tester        FAIL      11.71 seconds
TestRunner_smp-tester         PASS      8.58 seconds
TestRunner_userchan-tester    PASS      6.53 seconds
IncrementalBuild              PENDING   0.69 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: CheckSparse - WARNING
Desc: Run sparse tool with linux kernel
Output:
net/bluetooth/hci_core.c:85:9: warning: context imbalance in '__hci_dev_get' - different lock contexts for basic blocknet/bluetooth/hci_core.c: note: in included file (through include/linux/notifier.h, include/linux/memory_hotplug.h, include/linux/mmzone.h, include/linux/gfp.h, include/linux/xarray.h, include/linux/radix-tree.h, ...):
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4

Failed Test Cases
Read Exp Feature - Success                           Failed       0.107 seconds
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
BUG: sleeping function called from invalid context at net/core/sock.c:3782
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    1.857 seconds
Mesh - Send cancel - 2                               Timed out    1.994 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH] Bluetooth: hci_core: Rate limit the logging of invalid ISO handle

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue,  3 Feb 2026 21:57:21 +0200 you wrote:
> Some controller firmwares (eg for MT7925) continuously send invalid ISO
> packet, which result to "ISO unknown handle" error spam in logs.  It's
> not important to show all of them to the user.
> 
> Rate limit these ISO error messages, similarly as we do for SCO.
> 
> Signed-off-by: Pauli Virtanen <pav@iki.fi>
> 
> [...]

Here is the summary with links:
  - Bluetooth: hci_core: Rate limit the logging of invalid ISO handle
    https://git.kernel.org/bluetooth/bluetooth-next/c/294cf04ca959

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html