[PATCH] Bluetooth: Fix CIS host feature condition

[PATCH] Bluetooth: Fix CIS host feature condition

[Mariusz Skamra]

This fixes the condition for sending the LE Set Host Feature command.
The command is sent to indicate host support for Connected Isochronous
Streams in this case. It has been observed that the system could not
initialize BIS-only capable controllers because the controllers do not
support the command.

As per Core v6.2 | Vol 4, Part E, Table 3.1 the command shall be
supported if CIS Central or CIS Peripheral is supported; otherwise,
the command is optional.

Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
---
 net/bluetooth/hci_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index f04a90bce4a9..0b0dc0965f5a 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -4592,7 +4592,7 @@ static int hci_le_set_host_features_sync(struct hci_dev *hdev)
 {
 	int err;
 
-	if (iso_capable(hdev)) {
+	if (cis_capable(hdev)) {
 		/* Connected Isochronous Channels (Host Support) */
 		err = hci_le_set_host_feature_sync(hdev, 32,
 						   (iso_enabled(hdev) ? 0x01 :
-- 
2.53.0

Re: [PATCH] Bluetooth: Fix CIS host feature condition

[Greg KH]

On Thu, Feb 12, 2026 at 08:41:11AM +0100, Mariusz Skamra wrote:
> This fixes the condition for sending the LE Set Host Feature command.
> The command is sent to indicate host support for Connected Isochronous
> Streams in this case. It has been observed that the system could not
> initialize BIS-only capable controllers because the controllers do not
> support the command.
> 
> As per Core v6.2 | Vol 4, Part E, Table 3.1 the command shall be
> supported if CIS Central or CIS Peripheral is supported; otherwise,
> the command is optional.
> 
> Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
> ---
>  net/bluetooth/hci_sync.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
> index f04a90bce4a9..0b0dc0965f5a 100644
> --- a/net/bluetooth/hci_sync.c
> +++ b/net/bluetooth/hci_sync.c
> @@ -4592,7 +4592,7 @@ static int hci_le_set_host_features_sync(struct hci_dev *hdev)
>  {
>  	int err;
>  
> -	if (iso_capable(hdev)) {
> +	if (cis_capable(hdev)) {
>  		/* Connected Isochronous Channels (Host Support) */
>  		err = hci_le_set_host_feature_sync(hdev, 32,
>  						   (iso_enabled(hdev) ? 0x01 :
> -- 
> 2.53.0
> 
> 

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

RE: Bluetooth: Fix CIS host feature condition

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2593 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1053412

---Test result---

Test Summary:
CheckPatch                    PENDING   0.41 seconds
GitLint                       PENDING   0.25 seconds
SubjectPrefix                 PASS      0.13 seconds
BuildKernel                   PASS      26.22 seconds
CheckAllWarning               PASS      28.62 seconds
CheckSparse                   PASS      32.13 seconds
BuildKernel32                 PASS      25.73 seconds
TestRunnerSetup               PASS      564.50 seconds
TestRunner_l2cap-tester       PASS      28.93 seconds
TestRunner_iso-tester         PASS      98.53 seconds
TestRunner_bnep-tester        PASS      6.45 seconds
TestRunner_mgmt-tester        FAIL      114.30 seconds
TestRunner_rfcomm-tester      PASS      9.58 seconds
TestRunner_sco-tester         FAIL      14.71 seconds
TestRunner_ioctl-tester       PASS      10.25 seconds
TestRunner_mesh-tester        FAIL      12.55 seconds
TestRunner_smp-tester         PASS      8.68 seconds
TestRunner_userchan-tester    PASS      6.81 seconds
IncrementalBuild              PENDING   0.86 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4

Failed Test Cases
Read Exp Feature - Success                           Failed       0.101 seconds
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
BUG: sleeping function called from invalid context at net/core/sock.c:3782
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    2.737 seconds
Mesh - Send cancel - 2                               Timed out    1.995 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH] Bluetooth: Fix CIS host feature condition

[Paul Menzel]

[Cc: +Naga]

Dear Mariusz,


Thank you for your patch.

Am 12.02.26 um 08:41 schrieb Mariusz Skamra:
> This fixes the condition for sending the LE Set Host Feature command.
> The command is sent to indicate host support for Connected Isochronous
> Streams in this case. It has been observed that the system could not
> initialize BIS-only capable controllers because the controllers do not
> support the command.
> 
> As per Core v6.2 | Vol 4, Part E, Table 3.1 the command shall be
> supported if CIS Central or CIS Peripheral is supported; otherwise,
> the command is optional.

It’d be great if you documented the BIS-only controller you tested with.

Also to easier find your patch in the history, I’d find it useful to add 
the log messages of the failure.

I think you are missing the Fixes: tag.

Fixes: fe05e3c0593f ("Bluetooth: hci_sync: Add LE Channel Sounding HCI 
Command/event structures")

Though this was just merged in this 7.0 merge window.

(This seems to be a common mistake, and was fixed at another place in 
commit 5af69ab9bc62 (Bluetooth: ISO: Set CIS bit only for devices with 
CIS support).

> Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
> ---
>   net/bluetooth/hci_sync.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
> index f04a90bce4a9..0b0dc0965f5a 100644
> --- a/net/bluetooth/hci_sync.c
> +++ b/net/bluetooth/hci_sync.c
> @@ -4592,7 +4592,7 @@ static int hci_le_set_host_features_sync(struct hci_dev *hdev)
>   {
>   	int err;
>   
> -	if (iso_capable(hdev)) {
> +	if (cis_capable(hdev)) {
>   		/* Connected Isochronous Channels (Host Support) */
>   		err = hci_le_set_host_feature_sync(hdev, 32,
>   						   (iso_enabled(hdev) ? 0x01 :

Feel free to add

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul

Re: [PATCH] Bluetooth: Fix CIS host feature condition

[Mariusz Skamra]

[Cc: +Luiz]

Thank you for your advice.

czw., 12 lut 2026 o 09:16 Paul Menzel <pmenzel@molgen.mpg.de> napisał(a):
>
> [Cc: +Naga]
>
> Dear Mariusz,
>
>
> Thank you for your patch.
>
> Am 12.02.26 um 08:41 schrieb Mariusz Skamra:
> > This fixes the condition for sending the LE Set Host Feature command.
> > The command is sent to indicate host support for Connected Isochronous
> > Streams in this case. It has been observed that the system could not
> > initialize BIS-only capable controllers because the controllers do not
> > support the command.
> >
> > As per Core v6.2 | Vol 4, Part E, Table 3.1 the command shall be
> > supported if CIS Central or CIS Peripheral is supported; otherwise,
> > the command is optional.
>
> It’d be great if you documented the BIS-only controller you tested with.

The controller I am using is open-source Apache MyNewt Nimble.

>
> Also to easier find your patch in the history, I’d find it useful to add
> the log messages of the failure.
>
> I think you are missing the Fixes: tag.

Should it refer to mainline or bluetooth-next SHA?

>
> Fixes: fe05e3c0593f ("Bluetooth: hci_sync: Add LE Channel Sounding HCI
> Command/event structures")
>
> Though this was just merged in this 7.0 merge window.
>
> (This seems to be a common mistake, and was fixed at another place in
> commit 5af69ab9bc62 (Bluetooth: ISO: Set CIS bit only for devices with
> CIS support).
>
> > Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
> > ---
> >   net/bluetooth/hci_sync.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
> > index f04a90bce4a9..0b0dc0965f5a 100644
> > --- a/net/bluetooth/hci_sync.c
> > +++ b/net/bluetooth/hci_sync.c
> > @@ -4592,7 +4592,7 @@ static int hci_le_set_host_features_sync(struct hci_dev *hdev)
> >   {
> >       int err;
> >
> > -     if (iso_capable(hdev)) {
> > +     if (cis_capable(hdev)) {
> >               /* Connected Isochronous Channels (Host Support) */
> >               err = hci_le_set_host_feature_sync(hdev, 32,
> >                                                  (iso_enabled(hdev) ? 0x01 :
>

Looks like the regression was introduced in 709788b154ca
(Bluetooth: hci_core: Fix using {cis,bis}_capable for current settings),
while fe05e3c0593f ("Bluetooth: hci_sync: Add LE Channel Sounding HCI
Command/event structures") only moved the code.

Should I mention about 709788b154ca or fe05e3c0593f or maybe both?

> Feel free to add
>
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>

Sure

>
>
> Kind regards,
>
> Paul


-- 
Regards,
Mariusz


Mariusz Skamra
Senior Software Engineer

Codecoup Sp. z o. o.
Strzegomska 138
54-429 Wroclaw
POLAND
www.codecoup.pl