[RFC] Bluetooth: HIDP: Mark BT_HIDP as DEPRECATED

[RFC] Bluetooth: HIDP: Mark BT_HIDP as DEPRECATED

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This marks BT_HIDP as DEPRECATED as it is no longer needed on systems
with UHID which is preferred over BT_HIDP as that works both on BR/EDR
and LE beares.

Userspace already defaults to UHID since 9698870015b0
("input.conf: Make UserspaceHID defaults to true") which was released
with 5.73.

Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
 net/bluetooth/hidp/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/bluetooth/hidp/Kconfig b/net/bluetooth/hidp/Kconfig
index e08aae35351a..915035e23719 100644
--- a/net/bluetooth/hidp/Kconfig
+++ b/net/bluetooth/hidp/Kconfig
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config BT_HIDP
-	tristate "HIDP protocol support"
-	depends on BT_BREDR && HID
+	tristate "HIDP protocol support (DEPRECATED)"
+	depends on BT_BREDR && HID && DEPRECATED
 	help
 	  HIDP (Human Interface Device Protocol) is a transport layer
 	  for HID reports.  HIDP is required for the Bluetooth Human
-- 
2.53.0

RE: [RFC] Bluetooth: HIDP: Mark BT_HIDP as DEPRECATED

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2593 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1061551

---Test result---

Test Summary:
CheckPatch                    PENDING   0.31 seconds
GitLint                       PENDING   0.28 seconds
SubjectPrefix                 PASS      0.12 seconds
BuildKernel                   PASS      25.63 seconds
CheckAllWarning               PASS      28.08 seconds
CheckSparse                   PASS      31.83 seconds
BuildKernel32                 PASS      24.91 seconds
TestRunnerSetup               PASS      562.87 seconds
TestRunner_l2cap-tester       PASS      28.51 seconds
TestRunner_iso-tester         PASS      79.50 seconds
TestRunner_bnep-tester        PASS      6.33 seconds
TestRunner_mgmt-tester        FAIL      114.59 seconds
TestRunner_rfcomm-tester      PASS      9.49 seconds
TestRunner_sco-tester         FAIL      14.52 seconds
TestRunner_ioctl-tester       PASS      10.27 seconds
TestRunner_mesh-tester        FAIL      12.53 seconds
TestRunner_smp-tester         PASS      8.66 seconds
TestRunner_userchan-tester    PASS      6.86 seconds
IncrementalBuild              PENDING   0.72 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4

Failed Test Cases
Read Exp Feature - Success                           Failed       0.111 seconds
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
BUG: sleeping function called from invalid context at net/core/sock.c:3782
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    2.770 seconds
Mesh - Send cancel - 2                               Timed out    2.000 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [RFC] Bluetooth: HIDP: Mark BT_HIDP as DEPRECATED

[Paul Menzel]

Dear Luiz,


Thank you for this suggestion.

Am 04.03.26 um 21:06 schrieb Luiz Augusto von Dentz:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This marks BT_HIDP as DEPRECATED as it is no longer needed on systems
> with UHID which is preferred over BT_HIDP as that works both on BR/EDR
> and LE beares.
> 
> Userspace already defaults to UHID since 9698870015b0
> ("input.conf: Make UserspaceHID defaults to true") which was released
> with 5.73.
> 
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> ---
>   net/bluetooth/hidp/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/bluetooth/hidp/Kconfig b/net/bluetooth/hidp/Kconfig
> index e08aae35351a..915035e23719 100644
> --- a/net/bluetooth/hidp/Kconfig
> +++ b/net/bluetooth/hidp/Kconfig
> @@ -1,7 +1,7 @@
>   # SPDX-License-Identifier: GPL-2.0-only
>   config BT_HIDP
> -	tristate "HIDP protocol support"
> -	depends on BT_BREDR && HID
> +	tristate "HIDP protocol support (DEPRECATED)"
> +	depends on BT_BREDR && HID && DEPRECATED
>   	help
>   	  HIDP (Human Interface Device Protocol) is a transport layer
>   	  for HID reports.  HIDP is required for the Bluetooth Human

Could you also update the help text with the information from the commit 
message? I guess, this would help some users.


Kind regards,

Paul