public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH BlueZ 0/1] tools/btmgmt: Fix btmgmt --help hanging
@ 2026-03-11 11:14 Bastien Nocera
  2026-03-11 11:14 ` [PATCH BlueZ 1/1] " Bastien Nocera
  2026-03-17 19:50 ` [PATCH BlueZ 0/1] " patchwork-bot+bluetooth
  0 siblings, 2 replies; 4+ messages in thread
From: Bastien Nocera @ 2026-03-11 11:14 UTC (permalink / raw)
  To: linux-bluetooth

Another one of those. Wrote a test case again to avoid regressions :)

https://github.com/hadess/bluez/commit/81dcf1794b510a41c7b9b6ec53376cb5322b0bd2

Bastien Nocera (1):
  tools/btmgmt: Fix btmgmt --help hanging

 tools/btmgmt.c | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.53.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH BlueZ 1/1] tools/btmgmt: Fix btmgmt --help hanging
  2026-03-11 11:14 [PATCH BlueZ 0/1] tools/btmgmt: Fix btmgmt --help hanging Bastien Nocera
@ 2026-03-11 11:14 ` Bastien Nocera
  2026-03-11 12:34   ` bluez.test.bot
  2026-03-17 19:50 ` [PATCH BlueZ 0/1] " patchwork-bot+bluetooth
  1 sibling, 1 reply; 4+ messages in thread
From: Bastien Nocera @ 2026-03-11 11:14 UTC (permalink / raw)
  To: linux-bluetooth

btmgmt when run interactively would wait for commands on its prompt, but
that prompt is never setup when the help output is requested.

Handle --help through bt_shell_handle_non_interactive_help() so that the
application exits as soon as the help content has been printed, like
other interactive apps in bluez.
---
 tools/btmgmt.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/btmgmt.c b/tools/btmgmt.c
index 0f3de2880014..762a3a141c4a 100644
--- a/tools/btmgmt.c
+++ b/tools/btmgmt.c
@@ -47,6 +47,9 @@ int main(int argc, char *argv[])
 	bt_shell_init(argc, argv, &opt);
 
 	mgmt_add_submenu();
+
+	bt_shell_handle_non_interactive_help();
+
 	mgmt_set_index(index_option);
 	bt_shell_attach(fileno(stdin));
 	status = bt_shell_run();
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: tools/btmgmt: Fix btmgmt --help hanging
  2026-03-11 11:14 ` [PATCH BlueZ 1/1] " Bastien Nocera
@ 2026-03-11 12:34   ` bluez.test.bot
  0 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2026-03-11 12:34 UTC (permalink / raw)
  To: linux-bluetooth, hadess

[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1064985

---Test result---

Test Summary:
CheckPatch                    PENDING   0.32 seconds
GitLint                       PENDING   0.44 seconds
BuildEll                      PASS      18.09 seconds
BluezMake                     PASS      616.44 seconds
MakeCheck                     PASS      17.79 seconds
MakeDistcheck                 PASS      224.98 seconds
CheckValgrind                 PASS      279.97 seconds
CheckSmatch                   PASS      315.68 seconds
bluezmakeextell               PASS      168.03 seconds
IncrementalBuild              PENDING   0.39 seconds
ScanBuild                     PASS      932.64 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



https://github.com/bluez/bluez/pull/1955/checks

---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH BlueZ 0/1] tools/btmgmt: Fix btmgmt --help hanging
  2026-03-11 11:14 [PATCH BlueZ 0/1] tools/btmgmt: Fix btmgmt --help hanging Bastien Nocera
  2026-03-11 11:14 ` [PATCH BlueZ 1/1] " Bastien Nocera
@ 2026-03-17 19:50 ` patchwork-bot+bluetooth
  1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+bluetooth @ 2026-03-17 19:50 UTC (permalink / raw)
  To: Bastien Nocera; +Cc: linux-bluetooth

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 11 Mar 2026 12:14:12 +0100 you wrote:
> Another one of those. Wrote a test case again to avoid regressions :)
> 
> https://github.com/hadess/bluez/commit/81dcf1794b510a41c7b9b6ec53376cb5322b0bd2
> 
> Bastien Nocera (1):
>   tools/btmgmt: Fix btmgmt --help hanging
> 
> [...]

Here is the summary with links:
  - [BlueZ,1/1] tools/btmgmt: Fix btmgmt --help hanging
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=52c2b37d90c0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-03-17 19:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-11 11:14 [PATCH BlueZ 0/1] tools/btmgmt: Fix btmgmt --help hanging Bastien Nocera
2026-03-11 11:14 ` [PATCH BlueZ 1/1] " Bastien Nocera
2026-03-11 12:34   ` bluez.test.bot
2026-03-17 19:50 ` [PATCH BlueZ 0/1] " patchwork-bot+bluetooth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox