[PATCH BlueZ] iso-tester: fix missing clear of io_id in callbacks

[PATCH BlueZ] iso-tester: fix missing clear of io_id in callbacks

[Pauli Virtanen]

Fixes issues

GLib-CRITICAL **: Source ID 126 was not found when attempting to remove it
---
 tools/iso-tester.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/tools/iso-tester.c b/tools/iso-tester.c
index b851d2cd8..4c30e9951 100644
--- a/tools/iso-tester.c
+++ b/tools/iso-tester.c
@@ -3278,9 +3278,13 @@ fail:
 
 static gboolean test_listen_past(gpointer user_data)
 {
-	struct test_data *data = tester_get_data();
+	struct test_data *data = user_data;
 	struct bthost *host;
 
+	tester_print("Host initiates PAST");
+
+	data->io_id[3] = 0;
+
 	host = hciemu_client_get_host(data->hciemu);
 	bthost_past_set_info(host, data->acl_handle);
 
@@ -3343,7 +3347,8 @@ static void setup_listen_many(struct test_data *data, uint8_t n, uint8_t *num,
 		/* Wait for listen to take effect before initiating PAST
 		 * procedure.
 		 */
-		data->io_id[i] = g_timeout_add(250, test_listen_past, data);
+		g_assert(data->io_id[3] == 0);
+		data->io_id[3] = g_timeout_add(250, test_listen_past, data);
 	}
 }
 
@@ -3583,6 +3588,8 @@ static gboolean test_connect2_busy_done(gpointer user_data)
 {
 	struct test_data *data = tester_get_data();
 
+	data->io_id[1] = 0;
+
 	if (data->io_id[0] > 0) {
 		/* First connection still exists */
 		g_source_remove(data->io_id[0]);
-- 
2.53.0

RE: [BlueZ] iso-tester: fix missing clear of io_id in callbacks

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1311 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1074168

---Test result---

Test Summary:
CheckPatch                    PENDING   0.30 seconds
GitLint                       PENDING   0.28 seconds
BuildEll                      PASS      20.10 seconds
BluezMake                     PASS      629.26 seconds
MakeCheck                     PASS      18.79 seconds
MakeDistcheck                 PASS      244.71 seconds
CheckValgrind                 PASS      289.19 seconds
CheckSmatch                   PASS      344.77 seconds
bluezmakeextell               PASS      180.22 seconds
IncrementalBuild              PENDING   0.25 seconds
ScanBuild                     PASS      1003.77 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



https://github.com/bluez/bluez/pull/1993/checks

---
Regards,
Linux Bluetooth