RE: client: Add public broadcast advertising support

[bluez.test.bot@gmail.com]

[-- Attachment #1: Type: text/plain, Size: 12505 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1085227

---Test result---

Test Summary:
CheckPatch                    FAIL      1.30 seconds
GitLint                       PASS      0.67 seconds
BuildEll                      PASS      19.93 seconds
BluezMake                     PASS      604.72 seconds
CheckSmatch                   PASS      318.76 seconds
bluezmakeextell               PASS      162.72 seconds
IncrementalBuild              PASS      597.91 seconds
ScanBuild                     PASS      910.00 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[v2,1/2] client: add public-broadcast advertising command
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#106: FILE: client/advertising.c:1014:
+    return uuid && !bt_uuid_strcmp(uuid, AD_PUBLIC_BROADCAST_UUID);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#111: FILE: client/advertising.c:1019:
+    if (!ad_is_public_broadcast_uuid(ad.service[AD_TYPE_AD].uuid))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#112: FILE: client/advertising.c:1020:
+        return NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#112: FILE: client/advertising.c:1020:
+        return NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#114: FILE: client/advertising.c:1022:
+    if (ad.service[AD_TYPE_AD].data.len != 2)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#115: FILE: client/advertising.c:1023:
+        return NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#115: FILE: client/advertising.c:1023:
+        return NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: client/advertising.c:1025:
+    if (ad.service[AD_TYPE_AD].data.data[0] == 0x02 &&$

ERROR:CODE_INDENT: code indent should use tabs where possible
#118: FILE: client/advertising.c:1026:
+        ad.service[AD_TYPE_AD].data.data[1] == 0x00)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#118: FILE: client/advertising.c:1026:
+        ad.service[AD_TYPE_AD].data.data[1] == 0x00)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#119: FILE: client/advertising.c:1027:
+        return "sq";$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#119: FILE: client/advertising.c:1027:
+        return "sq";$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#121: FILE: client/advertising.c:1029:
+    if (ad.service[AD_TYPE_AD].data.data[0] == 0x04 &&$

ERROR:CODE_INDENT: code indent should use tabs where possible
#122: FILE: client/advertising.c:1030:
+        ad.service[AD_TYPE_AD].data.data[1] == 0x00)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#122: FILE: client/advertising.c:1030:
+        ad.service[AD_TYPE_AD].data.data[1] == 0x00)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#123: FILE: client/advertising.c:1031:
+        return "hq";$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#123: FILE: client/advertising.c:1031:
+        return "hq";$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#125: FILE: client/advertising.c:1033:
+    return NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#130: FILE: client/advertising.c:1038:
+    struct ad_data data = {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#131: FILE: client/advertising.c:1039:
+        .data = { 0x00, 0x00 },$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#131: FILE: client/advertising.c:1039:
+        .data = { 0x00, 0x00 },$

ERROR:CODE_INDENT: code indent should use tabs where possible
#132: FILE: client/advertising.c:1040:
+        .len = 2,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#132: FILE: client/advertising.c:1040:
+        .len = 2,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#133: FILE: client/advertising.c:1041:
+    };$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#134: FILE: client/advertising.c:1042:
+    const char *state;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#136: FILE: client/advertising.c:1044:
+    if (argc < 2) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#137: FILE: client/advertising.c:1045:
+        state = ad_public_broadcast_state();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#137: FILE: client/advertising.c:1045:
+        state = ad_public_broadcast_state();$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 12)
#138: FILE: client/advertising.c:1046:
+		if (state)
+            bt_shell_printf("Public Broadcast: %s\n", state);

ERROR:CODE_INDENT: code indent should use tabs where possible
#139: FILE: client/advertising.c:1047:
+            bt_shell_printf("Public Broadcast: %s\n", state);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#139: FILE: client/advertising.c:1047:
+            bt_shell_printf("Public Broadcast: %s\n", state);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#140: FILE: client/advertising.c:1048:
+        else$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#140: FILE: client/advertising.c:1048:
+        else$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#140: FILE: client/advertising.c:1048:
+        else
+            bt_shell_printf("Public Broadcast not set\n");

ERROR:CODE_INDENT: code indent should use tabs where possible
#141: FILE: client/advertising.c:1049:
+            bt_shell_printf("Public Broadcast not set\n");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#141: FILE: client/advertising.c:1049:
+            bt_shell_printf("Public Broadcast not set\n");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#144: FILE: client/advertising.c:1052:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#146: FILE: client/advertising.c:1054:
+    if (!strlen(argv[1])) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#147: FILE: client/advertising.c:1055:
+        bt_shell_printf("Public broadcast value cannot be empty\n");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#147: FILE: client/advertising.c:1055:
+        bt_shell_printf("Public broadcast value cannot be empty\n");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#148: FILE: client/advertising.c:1056:
+        return bt_shell_noninteractive_quit(EXIT_FAILURE);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#148: FILE: client/advertising.c:1056:
+        return bt_shell_noninteractive_quit(EXIT_FAILURE);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#149: FILE: client/advertising.c:1057:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#151: FILE: client/advertising.c:1059:
+    if (!strcasecmp(argv[1], "sq"))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#152: FILE: client/advertising.c:1060:
+        data.data[0] = 0x02;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#152: FILE: client/advertising.c:1060:
+        data.data[0] = 0x02;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#153: FILE: client/advertising.c:1061:
+    else if (!strcasecmp(argv[1], "hq"))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#154: FILE: client/advertising.c:1062:
+        data.data[0] = 0x04;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#154: FILE: client/advertising.c:1062:
+        data.data[0] = 0x04;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#155: FILE: client/advertising.c:1063:
+    else {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#156: FILE: client/advertising.c:1064:
+        bt_shell_printf("Invalid argument: accepted values are sq or hq\n");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#156: FILE: client/advertising.c:1064:
+        bt_shell_printf("Invalid argument: accepted values are sq or hq\n");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#157: FILE: client/advertising.c:1065:
+        return bt_shell_noninteractive_quit(EXIT_FAILURE);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#157: FILE: client/advertising.c:1065:
+        return bt_shell_noninteractive_quit(EXIT_FAILURE);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#158: FILE: client/advertising.c:1066:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#160: FILE: client/advertising.c:1068:
+    ad_clear_service(AD_TYPE_AD);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#162: FILE: client/advertising.c:1070:
+    ad.service[AD_TYPE_AD].uuid = g_strdup(AD_PUBLIC_BROADCAST_UUID);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#163: FILE: client/advertising.c:1071:
+    ad.service[AD_TYPE_AD].data = data;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#165: FILE: client/advertising.c:1073:
+    g_dbus_emit_property_changed(conn, AD_PATH, AD_IFACE,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#166: FILE: client/advertising.c:1074:
+        prop_names.service[AD_TYPE_AD]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#166: FILE: client/advertising.c:1074:
+        prop_names.service[AD_TYPE_AD]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#168: FILE: client/advertising.c:1076:
+    return bt_shell_noninteractive_quit(EXIT_SUCCESS);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#183: FILE: client/advertising.h:38:
+                                char *argv[]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#183: FILE: client/advertising.h:38:
+                                char *argv[]);$

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#195: FILE: client/main.c:2923:
+static const char *public_broadcast_arguments[] = {

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#196: FILE: client/main.c:2924:
+    "sq",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#197: FILE: client/main.c:2925:
+    "hq",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#198: FILE: client/main.c:2926:
+    NULL$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#203: FILE: client/main.c:2931:
+    return argument_generator(text, state, public_broadcast_arguments);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#215: FILE: client/main.c:2986:
+    ad_advertise_public_broadcast(dbus_conn, argc, argv);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#226: FILE: client/main.c:3673:
+            "Set/Get BLE Audio Public Broadcast Announcement",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#226: FILE: client/main.c:3673:
+            "Set/Get BLE Audio Public Broadcast Announcement",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#227: FILE: client/main.c:3674:
+            public_broadcast_generator },$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#227: FILE: client/main.c:3674:
+            public_broadcast_generator },$

/github/workspace/src/patch/14537907.patch total: 22 errors, 52 warnings, 134 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

/github/workspace/src/patch/14537907.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




https://github.com/bluez/bluez/pull/2069

---
Regards,
Linux Bluetooth