RE: Add RAS Packet format and Notification support

[bluez.test.bot@gmail.com]

[-- Attachment #1: Type: text/plain, Size: 16102 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1086088

---Test result---

Test Summary:
CheckPatch                    PASS      1.92 seconds
GitLint                       FAIL      0.64 seconds
BuildEll                      PASS      20.03 seconds
BluezMake                     FAIL      19.47 seconds
MakeCheck                     FAIL      42.81 seconds
MakeDistcheck                 PASS      242.09 seconds
CheckValgrind                 FAIL      16.07 seconds
CheckSmatch                   FAIL      24.06 seconds
bluezmakeextell               FAIL      13.17 seconds
IncrementalBuild              FAIL      20.14 seconds
ScanBuild                     FAIL      35.04 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,v3,1/3] Add RAS packet formatting and notification support for CS reflector

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (82>80): "[BlueZ,v3,1/3] Add RAS packet formatting and notification support for CS reflector"
##############################
Test: BluezMake - FAIL
Desc: Build BlueZ
Output:

src/shared/rap.c: In function ‘handle_local_subevent_result’:
src/shared/rap.c:1543:6: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 1543 |      uint32_t pct2 =
      |      ^~~~~~~~
src/shared/rap.c:1662:6: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 1662 |      uint32_t pct2 =
      |      ^~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7859: src/shared/libshared_mainloop_la-rap.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4172: all] Error 2
##############################
Test: MakeCheck - FAIL
Desc: Run Bluez Make Check
Output:

src/shared/rap.c: In function ‘handle_local_subevent_result’:
src/shared/rap.c:1543:6: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 1543 |      uint32_t pct2 =
      |      ^~~~~~~~
src/shared/rap.c:1662:6: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 1662 |      uint32_t pct2 =
      |      ^~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7579: src/shared/libshared_glib_la-rap.lo] Error 1
make: *** [Makefile:10820: check] Error 2
##############################
Test: CheckValgrind - FAIL
Desc: Run Bluez Make Check with Valgrind
Output:

src/shared/rap.c: In function ‘handle_local_subevent_result’:
src/shared/rap.c:1543:6: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 1543 |      uint32_t pct2 =
      |      ^~~~~~~~
src/shared/rap.c:1662:6: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 1662 |      uint32_t pct2 =
      |      ^~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7859: src/shared/libshared_mainloop_la-rap.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:10820: check] Error 2
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:

src/shared/crypto.c:271:21: warning: Variable length array is used.
src/shared/crypto.c:272:23: warning: Variable length array is used.
src/shared/gatt-helpers.c:764:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:842:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1335:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1366:23: warning: Variable length array is used.
src/shared/gatt-server.c:279:25: warning: Variable length array is used.
src/shared/gatt-server.c:622:25: warning: Variable length array is used.
src/shared/gatt-server.c:720:25: warning: Variable length array is used.
src/shared/bap.c:312:25: warning: array of flexible structures
src/shared/bap.c: note: in included file:
./src/shared/ascs.h:88:25: warning: array of flexible structures
src/shared/rap.c:1543:41: warning: mixing declarations and code
src/shared/rap.c:1662:41: warning: mixing declarations and code
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
src/shared/rap.c: In function ‘handle_local_subevent_result’:
src/shared/rap.c:1543:6: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 1543 |      uint32_t pct2 =
      |      ^~~~~~~~
src/shared/rap.c:1662:6: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 1662 |      uint32_t pct2 =
      |      ^~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7859: src/shared/libshared_mainloop_la-rap.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4172: all] Error 2
##############################
Test: bluezmakeextell - FAIL
Desc: Build Bluez with External ELL
Output:

src/shared/rap.c: In function ‘handle_local_subevent_result’:
src/shared/rap.c:1543:6: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 1543 |      uint32_t pct2 =
      |      ^~~~~~~~
src/shared/rap.c:1662:6: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 1662 |      uint32_t pct2 =
      |      ^~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7859: src/shared/libshared_mainloop_la-rap.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4172: all] Error 2
##############################
Test: IncrementalBuild - FAIL
Desc: Incremental build with the patches in the series
Output:

src/shared/rap.c: In function ‘register_ras_service’:
src/shared/rap.c:968:3: error: implicit declaration of function ‘gatt_db_service_add_ccc_custom’; did you mean ‘gatt_db_service_add_ccc’? [-Werror=implicit-function-declaration]
  968 |   gatt_db_service_add_ccc_custom(ras->svc,
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |   gatt_db_service_add_ccc
src/shared/rap.c:967:25: error: assignment to ‘struct gatt_db_attribute *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
  967 |  ras->realtime_chrc_ccc =
      |                         ^
src/shared/rap.c:983:20: error: assignment to ‘struct gatt_db_attribute *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
  983 |  ras->ondemand_ccc = gatt_db_service_add_ccc_custom(ras->svc,
      |                    ^
src/shared/rap.c:999:14: error: assignment to ‘struct gatt_db_attribute *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
  999 |  ras->cp_ccc = gatt_db_service_add_ccc_custom(ras->svc,
      |              ^
src/shared/rap.c:1015:17: error: assignment to ‘struct gatt_db_attribute *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
 1015 |  ras->ready_ccc = gatt_db_service_add_ccc_custom(ras->svc,
      |                 ^
src/shared/rap.c:1031:23: error: assignment to ‘struct gatt_db_attribute *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
 1031 |  ras->overwritten_ccc = gatt_db_service_add_ccc_custom(ras->svc,
      |                       ^
src/shared/rap.c: In function ‘handle_local_subevent_result’:
src/shared/rap.c:1543:6: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 1543 |      uint32_t pct2 =
      |      ^~~~~~~~
src/shared/rap.c:1662:6: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 1662 |      uint32_t pct2 =
      |      ^~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7859: src/shared/libshared_mainloop_la-rap.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4172: all] Error 2
[BlueZ,v3,1/3] Add RAS packet formatting and notification support for CS reflector

src/shared/rap.c: In function ‘register_ras_service’:
src/shared/rap.c:968:3: error: implicit declaration of function ‘gatt_db_service_add_ccc_custom’; did you mean ‘gatt_db_service_add_ccc’? [-Werror=implicit-function-declaration]
  968 |   gatt_db_service_add_ccc_custom(ras->svc,
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |   gatt_db_service_add_ccc
src/shared/rap.c:967:25: error: assignment to ‘struct gatt_db_attribute *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
  967 |  ras->realtime_chrc_ccc =
      |                         ^
src/shared/rap.c:983:20: error: assignment to ‘struct gatt_db_attribute *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
  983 |  ras->ondemand_ccc = gatt_db_service_add_ccc_custom(ras->svc,
      |                    ^
src/shared/rap.c:999:14: error: assignment to ‘struct gatt_db_attribute *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
  999 |  ras->cp_ccc = gatt_db_service_add_ccc_custom(ras->svc,
      |              ^
src/shared/rap.c:1015:17: error: assignment to ‘struct gatt_db_attribute *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
 1015 |  ras->ready_ccc = gatt_db_service_add_ccc_custom(ras->svc,
      |                 ^
src/shared/rap.c:1031:23: error: assignment to ‘struct gatt_db_attribute *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
 1031 |  ras->overwritten_ccc = gatt_db_service_add_ccc_custom(ras->svc,
      |                       ^
src/shared/rap.c: In function ‘handle_local_subevent_result’:
src/shared/rap.c:1543:6: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 1543 |      uint32_t pct2 =
      |      ^~~~~~~~
src/shared/rap.c:1662:6: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 1662 |      uint32_t pct2 =
      |      ^~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7859: src/shared/libshared_mainloop_la-rap.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4172: all] Error 2
##############################
Test: ScanBuild - FAIL
Desc: Run Scan Build
Output:

src/shared/gatt-client.c:447:21: warning: Use of memory after it is freed
        gatt_db_unregister(op->client->db, op->db_id);
                           ^~~~~~~~~~
src/shared/gatt-client.c:692:2: warning: Use of memory after it is freed
        discovery_op_complete(op, false, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:992:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1098:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1292:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1357:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1632:6: warning: Use of memory after it is freed
        if (read_db_hash(op)) {
            ^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1637:2: warning: Use of memory after it is freed
        discover_all(op);
        ^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1693:56: warning: Use of memory after it is freed
        notify_data->chrc->ccc_write_id = notify_data->att_id = att_id;
                                          ~~~~~~~~~~~~~~~~~~~ ^
src/shared/gatt-client.c:2146:6: warning: Use of memory after it is freed
        if (read_db_hash(op)) {
            ^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2154:8: warning: Use of memory after it is freed
                                                        discovery_op_ref(op),
                                                        ^~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3332:2: warning: Use of memory after it is freed
        complete_write_long_op(req, success, 0, false);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3354:2: warning: Use of memory after it is freed
        request_unref(req);
        ^~~~~~~~~~~~~~~~~~
13 warnings generated.
src/shared/rap.c: In function ‘register_ras_service’:
src/shared/rap.c:968:3: error: implicit declaration of function ‘gatt_db_service_add_ccc_custom’; did you mean ‘gatt_db_service_add_ccc’? [-Werror=implicit-function-declaration]
  968 |   gatt_db_service_add_ccc_custom(ras->svc,
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |   gatt_db_service_add_ccc
src/shared/rap.c:967:25: error: assignment to ‘struct gatt_db_attribute *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
  967 |  ras->realtime_chrc_ccc =
      |                         ^
src/shared/rap.c:983:20: error: assignment to ‘struct gatt_db_attribute *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
  983 |  ras->ondemand_ccc = gatt_db_service_add_ccc_custom(ras->svc,
      |                    ^
src/shared/rap.c:999:14: error: assignment to ‘struct gatt_db_attribute *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
  999 |  ras->cp_ccc = gatt_db_service_add_ccc_custom(ras->svc,
      |              ^
src/shared/rap.c:1015:17: error: assignment to ‘struct gatt_db_attribute *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
 1015 |  ras->ready_ccc = gatt_db_service_add_ccc_custom(ras->svc,
      |                 ^
src/shared/rap.c:1031:23: error: assignment to ‘struct gatt_db_attribute *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
 1031 |  ras->overwritten_ccc = gatt_db_service_add_ccc_custom(ras->svc,
      |                       ^
src/shared/rap.c: In function ‘handle_local_subevent_result’:
src/shared/rap.c:1543:6: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 1543 |      uint32_t pct2 =
      |      ^~~~~~~~
src/shared/rap.c:1662:6: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 1662 |      uint32_t pct2 =
      |      ^~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7859: src/shared/libshared_mainloop_la-rap.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
src/shared/bap.c:1529:8: warning: Use of memory after it is freed
        bap = bt_bap_ref_safe(bap);
              ^~~~~~~~~~~~~~~~~~~~
src/shared/bap.c:2340:20: warning: Use of memory after it is freed
        return queue_find(stream->bap->streams, NULL, stream);
                          ^~~~~~~~~~~~~~~~~~~~
2 warnings generated.
make: *** [Makefile:4172: all] Error 2


https://github.com/bluez/bluez/pull/2074

---
Regards,
Linux Bluetooth