RE: Add helper for "cleanup" variable attribute

[bluez.test.bot@gmail.com]

[-- Attachment #1: Type: text/plain, Size: 4626 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1090349

---Test result---

Test Summary:
CheckPatch                    FAIL      1.57 seconds
GitLint                       PASS      1.32 seconds
BuildEll                      PASS      20.73 seconds
BluezMake                     PASS      654.60 seconds
MakeCheck                     PASS      19.06 seconds
MakeDistcheck                 PASS      249.78 seconds
CheckValgrind                 PASS      296.64 seconds
CheckSmatch                   WARNING   355.15 seconds
bluezmakeextell               PASS      184.37 seconds
IncrementalBuild              PASS      1277.75 seconds
ScanBuild                     PASS      1024.24 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,2/5] shared/util: Add helper for "cleanup" variable attribute
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#74: FILE: src/shared/util.h:96:
+static inline void freep(void *p) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#75: FILE: src/shared/util.h:97:
+        free(*(void**) p);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#75: FILE: src/shared/util.h:97:
+        free(*(void**) p);$

ERROR:POINTER_LOCATION: "(foo**)" should be "(foo **)"
#75: FILE: src/shared/util.h:97:
+        free(*(void**) p);

/github/workspace/src/patch/14557019.patch total: 3 errors, 1 warnings, 13 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

/github/workspace/src/patch/14557019.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


[BlueZ,5/5] main: Use _cleanup_() to simplify GError-handling
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#66: FILE: src/main.c:208:
+static inline void free_error(void *err) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#67: FILE: src/main.c:209:
+        g_error_free(*(void**) err);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#67: FILE: src/main.c:209:
+        g_error_free(*(void**) err);$

ERROR:POINTER_LOCATION: "(foo**)" should be "(foo **)"
#67: FILE: src/main.c:209:
+        g_error_free(*(void**) err);

/github/workspace/src/patch/14557018.patch total: 3 errors, 1 warnings, 127 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

/github/workspace/src/patch/14557018.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/main.c: note: in included file (through src/device.h):src/shared/gatt-server.c:271:25: warning: Variable length array is used.src/shared/gatt-server.c:614:25: warning: Variable length array is used.src/shared/gatt-server.c:712:25: warning: Variable length array is used.src/shared/gatt-server.c:271:25: warning: Variable length array is used.src/shared/gatt-server.c:614:25: warning: Variable length array is used.src/shared/gatt-server.c:712:25: warning: Variable length array is used.src/shared/gatt-server.c:271:25: warning: Variable length array is used.src/shared/gatt-server.c:614:25: warning: Variable length array is used.src/shared/gatt-server.c:712:25: warning: Variable length array is used.src/main.c: note: in included file (through src/device.h):src/main.c: note: in included file (through src/device.h):


https://github.com/bluez/bluez/pull/2101

---
Regards,
Linux Bluetooth